Hardware Wallet Interface

This commit changes the build scripts for a Bitcoin hardware wallet interface tool. It makes sure graphical user interface (GUI) files are freshly generated before building installable packages, and adds a check that the generated package list stays consistent. There is no direct security bug being fixed here; it is a build-hygiene improvement meant to prevent packaging mistakes that could, in theory, lead to missing or inconsistent files in released software.

This commit adds a missing feature to the Blockstream Jade hardware wallet driver in HWI: the ability to register a Bitcoin output descriptor on the device. It is a small, straightforward implementation of an existing interface method. There is no direct evidence in the commit of a security vulnerability, bug, or malicious change. The change appears to be a normal feature addition.

This commit adds a new feature to the Coldcard hardware wallet driver in the HWI library: the ability to register a Bitcoin output descriptor on the device. The code sends the descriptor to the Coldcard in chunks, verifies the upload with a SHA-256 checksum, and then asks the device to enroll/register it. There is no obvious security bug in the diff itself; it is a straightforward implementation of a missing driver method. The main security-relevant observation is that the new code path involves device communication and a checksum check, but the diff does not show any vulnerability.

This commit adds a new feature to the BitBox02 hardware wallet driver in HWI that lets users register a Bitcoin output descriptor (a recipe for wallet addresses) on the device. The change itself is a straightforward feature implementation and does not appear to fix a security bug. There is no evidence in the commit or supplied references that this is a security patch or that it addresses any disclosed vulnerability.

This commit relaxes the version requirement for the 'protobuf' Python library in the project's dependency files. It changes the requirement from 'exactly 4.23.3 or compatible updates' to 'any version 4.23.3 or newer'. This is a routine dependency management change. There is no direct evidence in the commit that it fixes a specific security vulnerability, but keeping dependencies updated can help avoid known bugs or vulnerabilities in older versions.

This commit removes the 'plugdev' group assignment from Linux udev rules that grant user access to Bitcoin hardware wallets. The change is a compatibility fix for newer systemd versions (258+), which no longer allow non-system groups in udev rules. It is not a security vulnerability fix; if anything, removing group-based access slightly tightens access control by relying on the 'uaccess' tag instead.

This commit updates the Linux device rules for the Coldcard hardware wallet so that normal users can access the device on newer Linux systems that use systemd 258 or later. Without this change, the wallet might not be detected or usable by non-admin users after upgrading their operating system. It is a compatibility/usability fix, not a fix for an active security vulnerability.

This commit fixes a flaky automated test for Ledger hardware wallets. The test script was sometimes clicking the wrong on-screen button because a warning message appears twice on different screens. The fix narrows the click target so it only hits the first warning screen, not a later details screen. It does not change any wallet code that end users rely on for security.

This commit is a straightforward internal code refactor for Ledger hardware wallet support. It changes the data structure returned when signing a Bitcoin transaction from a simple tuple of raw bytes to a more descriptive object that can carry extra context for newer Taproot-style signatures. There is no indication this fixes a security bug or introduces a vulnerability; it is a compatibility and maintainability update taken from Ledger's own upstream code.

This commit updates the Ledger hardware wallet driver in HWI so it can correctly store Taproot script-path signatures in a PSBT, not just key-path signatures. Previously, the code had a placeholder that always treated any Taproot signature as a key-path signature. For users spending via a Taproot script path (for example, a multisig or timelock branch), the signature would have been placed in the wrong field, likely causing the PSBT to be invalid or incomplete. There is no direct evidence in the commit of an exploitable vulnerability; it appears to be a correctness/functional fix for an unimplemented feature.

This commit fixes a flaky automated test for Ledger hardware wallets. The test script was pressing an extra button because a randomly generated Bitcoin address happened to end in the letters 'To', which matched a screen-title rule. The fix narrows the rule so it only matches the word 'To' at the top of the screen, not inside wrapped address text. There is no security issue in the actual wallet software.

This commit fixes a bug in how the HWI library handles a newer Bitcoin transaction format called PSBTv2. Previously, when converting or setting up a PSBTv2 object, the code would accidentally overwrite the transaction's version number and locktime with default values. That could silently invalidate digital signatures that were already created for the transaction. The fix checks the PSBT version before touching those fields, and adds official BIP 370 test vectors to prevent the bug from returning.

This commit only adds more test data to a JSON file used by the project's test suite. It adds additional encoded PSBT (Partially Signed Bitcoin Transaction) examples from official BIP test vectors. The commit message explicitly says these new test cases already pass, meaning no code behavior was changed and no bug was fixed.

This commit only adds new test cases for an existing function that determines lock times in PSBTs (Partially Signed Bitcoin Transactions). It does not change any production code, fix a bug, or alter behavior. There is no security issue here.

This commit fixes a crash in the PSBT (Partially Signed Bitcoin Transaction) handling code. When a transaction input did not specify a sequence number, the software would crash with an assertion failure instead of assuming the standard default value (0xffffffff). The fix makes the code follow the BIP 370 specification correctly, allowing it to handle minimal PSBTv2 files without crashing.

This commit fixes a bug where a transaction's locktime (a time-based or block-height-based restriction on when a Bitcoin transaction can be mined) was being set on the wrong object. Instead of assigning it to the actual transaction, the code accidentally assigned it to the PSBT wrapper object, so the transaction kept a locktime of 0. This could cause transactions with intended time locks to become immediately spendable, potentially breaking security assumptions in wallets or contracts that rely on locktime.

This commit simply removes an unused Python 3.7 CI Docker file and cleans up a leftover dependency for Python 3.6. There is no security issue here—it's routine housekeeping.

This commit is a routine cleanup of leftover continuous-integration (CI) files. It removes an old Cirrus CI Dockerfile, updates two comment lines in other Dockerfiles, and swaps the build-status badge in README.md and setup.py from Cirrus CI to GitHub Actions. There is no change to the actual hardware-wallet software, its dependencies, or how it handles private keys or user data.

This commit simply updates web links and folder names in HWI's build scripts and documentation to match Ledger's renamed GitHub repositories. It does not change any wallet code, cryptography, or user-facing behavior. There is no security issue here.

This change makes the hardware-wallet interface library stricter when reading PSBT (Partially Signed Bitcoin Transaction) files. It now rejects locktime values that don't follow Bitcoin's rules: a time-based locktime must be at least 500,000,000, and a block-height-based locktime must be greater than 0 and less than 500,000,000. Without these checks, a malformed or malicious PSBT could confuse a hardware wallet about when a transaction is allowed to be mined, potentially leading to signing something the user didn't expect.

This commit fixes a parsing bug in the way the Hardware Wallet Interface (HWI) reads Bitcoin transaction files called PSBTs. PSBTs come in two versions, v0 and v2, and each version has its own allowed fields. The code was accidentally accepting some v2-only fields inside a v0 PSBT. That could let a specially crafted file change how the transaction is interpreted, potentially tricking a hardware wallet into signing something different from what the user sees. The fix makes the parser reject those v2 fields when the file says it is a v0 PSBT.

This change fixes a subtle parsing bug in how the wallet software reads PSBT (Partially Signed Bitcoin Transaction) files. Previously, the code could not tell the difference between a PSBT that genuinely contained an unsigned transaction with zero inputs and outputs, and a PSBT where the unsigned transaction was simply missing. This could allow a malformed or intentionally crafted PSBT to be treated as valid when it should have been rejected, potentially leading to incorrect transaction handling or confusion in hardware wallet workflows.

This commit fixes a bug in how the wallet interface reads the unsigned transaction embedded inside a PSBT (Partially Signed Bitcoin Transaction). Previously, the parser tried to auto-detect whether the transaction included witness data, which could misread certain valid transactions that had no inputs. Now it explicitly parses the transaction as a non-witness transaction and rejects any PSBT whose unsigned transaction is not serialized exactly that way. This is a correctness and standards-compliance fix that reduces the chance of a malformed or malicious PSBT being misinterpreted.

This change only adjusts a test setup script to pin a specific Rust compiler version when building the Trezor T hardware wallet emulator for automated tests. It is a build/test infrastructure fix, not a security patch, and does not change any wallet handling, cryptography, or user-facing code.

This commit simply adds a new identifier (0x80) for the upcoming Ledger Nano Gen5 hardware wallet to HWI's list of known Ledger devices. It is a routine device-support addition with no security-relevant behavior change.