test: increase stdin command timeout
What the developer wrote
Authored by Sjors Provoost
test: increase stdin command timeout
Ledger app 2.5.0 can take over 60 seconds to sign the large
transaction fixture. Allow stdin commands up to 120 seconds.
What changed, and why it matters
This commit only changes a test timeout from 60 seconds to 120 seconds so that automated tests can complete when a Ledger hardware wallet running newer firmware takes longer to sign a large test transaction. It does not change any production code, cryptographic logic, or user-facing behavior, and it does not fix or introduce a security vulnerability.
No security action needed. Treat as a routine test infrastructure change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies a single line in test/test_device.py inside a test helper that sends commands to the HWI CLI via stdin. The subprocess.communicate timeout is increased from 60 to 120 seconds because the Ledger app 2.5.0 requires more than 60 seconds to sign the existing large transaction fixture during automated device tests. No other code paths are affected.
Changed components
test/test_device.pyInspect captured patch +1 / −1
diff --git a/test/test_device.py b/test/test_device.py
index fb88ee7..33d3955 100644
--- a/test/test_device.py
+++ b/test/test_device.py
@@ -175,7 +175,7 @@ class DeviceTestCase(unittest.TestCase):
args = [f'"{arg}"' for arg in args]
input_str = '\n'.join(args) + '\n'
proc = subprocess.Popen(['hwi', '--stdin'], stdin=subprocess.PIPE, stdout=subprocess.PIPE)
- result = proc.communicate(input_str.encode(), timeout=60)
+ result = proc.communicate(input_str.encode(), timeout=120)
return json.loads(result[0].decode())
else:
return process_commands(args)
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.