Drop Ledger deny rule from tests
What the developer wrote
Authored by Sjors Provoost
Drop Ledger deny rule from tests
It's unused and occasionally trips up a test.
What changed, and why it matters
This commit removes an unused test automation rule that automatically pressed a button when a Ledger hardware wallet simulator showed 'Cancel' or 'Reject' on screen. It only affects test data, not the actual wallet interface code users rely on. There is no security issue here.
No security action needed. Treat as routine test maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change deletes a JSON entry in test/data/speculos-automation.json. Speculos is a Ledger Nano simulator used in HWI’s test suite. The removed ‘deny rule’ matched screens whose text began with ‘Cancel’ or ‘Reject’ and simulated button presses. The commit message states the rule was unused and caused occasional test flakiness. No production code, device communication logic, or cryptographic handling is modified.
Changed components
test/data/speculos-automation.jsonInspect captured patch +0 / −7
diff --git a/test/data/speculos-automation.json b/test/data/speculos-automation.json
index bc16699..a14eaab 100644
--- a/test/data/speculos-automation.json
+++ b/test/data/speculos-automation.json
@@ -114,13 +114,6 @@
[ "button", 2, false ],
[ "setbool", "seen_msg_hash", false ]
]
- },
- {
- "regexp": "^(Cancel|Reject).*",
- "actions": [
- [ "button", 1, true ],
- [ "button", 1, false ]
- ]
}
]
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.