AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 25 Bitcoin

Merge bitcoin-core/HWI#849: coldcard: bump firmware, add edge, display taproot address, restore test_signtx (ex. multisig)

Public commit record

What the developer wrote

Authored by Ava Chow

91/100 · Strong
Merge bitcoin-core/HWI#849: coldcard: bump firmware, add edge, display taproot address, restore test_signtx (ex. multisig)

aa3e73359c9d49140015f1e55ec61241ed39e313 ci: add finite APT connection timeouts/retries (Sjors Provoost)
90b7b0a6d498641704acefc920bbe1a772bdf799 ci: bump GitHub Actions versions (Sjors Provoost)
f8bd2942aae917f17c453308888bfe96aa7996e7 coldcard: preserve PSBTv2 when supported (Sjors Provoost)
e5aa9ccba5c93ad567a29f6e64b466dba202e8e5 coldcard: display singlesig taproot address on EDGE (Sjors Provoost)
534468cf1f79523d736dae1718116cb5933a8cdf ci: run Coldcard Edge simulator tests (Sjors Provoost)
454e36e3b32816c4bd0ad6269b03a2e3947d16f3 ci: parameterize device test matrix (Sjors Provoost)
2cda52a024e304be4b6db88c7d8bf946ffcd09c8 test: support Coldcard Edge in device tests (Sjors Provoost)
8dc9a6f796f58728a05c24b5c6218af700d386aa ci: build Coldcard Edge simulator (Sjors Provoost)
57b062ee12a5bdf3773a509a203d58aa95c287ae test: factor out Coldcard firmware setup (Sjors Provoost)
9b420ea7240bc11a720bdea0b2a20a842cea5899 test: limit Coldcard simulator checkout (Sjors Provoost)
893818a3f6421a2125260f0c81c68702b79e9ae0 test: bump Coldcard firmware to 5.6.0 (Sjors Provoost)
257e1ae1c8fb7aa099ce9a98e52a4c6606832398 test: reenable Coldcard singlesig transaction signing (Sjors Provoost)

Pull request description:

The Edge firmware supports displaying taproot single sig addresses, and more importantly MuSig2.

Rather than blowing up the CI matrix, this PR only adds it for Python 3.14. It can be easily be dropped again if all Edge features we care about land in their regular firmware.

The first commit re-enables `test_signtx`, which was already possible. It achieves this by dropping multisig for ColdCard in that these. This can be re-introduced by #792.

The multisig patch is adjusted or Edge. Alternatively after #847 it could be dropped entirely. It builds, but CI won't cover it until #792. I did test it locally.

- fixes #799
- fixes #703
- superseedes #833
- superseedes #725

ACKs for top commit:
achow101:
ACK aa3e73359c9d49140015f1e55ec61241ed39e313

Tree-SHA512: e67745bdea35c9d6d6515d83daecbb2f750bf925f403e03b102e4996b9a56194b4b7a4316d44565ab2a1768a2bb6b0a19068e7bfe2cedca829c6d39006329c66
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This is a routine feature-and-testing update for the Coldcard hardware wallet support in Bitcoin Core's HWI tool. It adds support for Coldcard's 'Edge' experimental firmware, lets users display single-signature Taproot addresses on Edge, and re-enables transaction-signing tests by dropping multisig cases for Coldcard. It also changes how PSBT version 2 is handled: newer Coldcard firmware keeps PSBTv2, while older firmware is downgraded to PSBTv0 before signing. There is no obvious security bug in the diff, but the PSBT version handling and new firmware support are worth a careful look because mistakes there could affect transaction validity or compatibility.

Recommended action

No immediate action required. Treat as a normal feature/test update. Reviewers should verify that the PSBTv2 downgrade path is only taken when the device genuinely does not support v2, and that the version parsing heuristic does not misclassify future firmware. Users of Coldcard Edge should confirm Taproot address display behavior matches expectations.

Security signals we found

01

PSBT version downgrade logic moved from per-pass to once-per-signing; intended to preserve v2 when supported and downgrade when not

02

New firmware version parsing heuristic treats Q/X suffixes and Edge/simulator as PSBTv2 capable

03

Taproot singlesig address display enabled only for Coldcard Edge firmware

04

Coldcard transaction signing tests re-enabled by removing multisig test cases

05

CI artifact action version bumps (upload-artifact v4→v7, download-artifact v4→v8, checkout v4→v7)

Risk score

Why this scored 25/100

Our methodology →
Potential impact 4/30
Exploitability 3/25
Stealth signal 3/15
Affected reach 5/15
Confidence 7/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.