What the developer wrote
Authored by FazleRabbbiferdaus172
[FIX] generate png for restart view
run_screen need to be executed by screenshot generator test to generate png for restart view. But we don't want to restart so the not starting the thread should be the way.
What changed, and why it matters
This commit fixes a screenshot-generation test issue. Previously, the RestartView skipped rendering entirely when used by the screenshot generator, so no PNG image was produced for the restart screen. The change now renders the reset screen but only starts the actual restart thread when not in screenshot mode. There is no security issue here.
No security action needed. This is a benign test/UX fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In RestartView.run(), the guard if self.is_screenshot_renderer: return was removed. The ResetScreen is now always rendered via run_screen(), while the DoResetThread is only started when not self.is_screenshot_renderer. This ensures the screenshot generator captures the restart view PNG without triggering a real device restart.
Changed components
src/seedsigner/views/view.pyRestartViewInspect captured patch +4 / −5
diff --git a/src/seedsigner/views/view.py b/src/seedsigner/views/view.py
index 462196d..98e1548 100644
--- a/src/seedsigner/views/view.py
+++ b/src/seedsigner/views/view.py
@@ -255,15 +255,14 @@ class RestartView(View):
self.thread = self.DoResetThread()
def run(self):
- if self.is_screenshot_renderer:
- # For the screenshot generator, we don't actually want to restart
- return
-
logger.info("Restarting SeedSigner")
from seedsigner.gui.screens.screen import ResetScreen
- self.thread.start()
+ if not self.is_screenshot_renderer:
+ # For the screenshot generator, we don't actually want to restart
+ self.thread.start()
+
self.run_screen(ResetScreen)
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.