What the developer wrote
Authored by PROWLERx15
added comment explaining changes
What changed, and why it matters
This commit only adds a clarifying comment to existing code. It does not change any program behavior, fix a bug, or alter security logic. The comment explains that pressing the back button during seed phrase entry can mean either aborting entirely (on the first word) or returning to the previous word (on later words), and that aborting requires discarding the partially entered mnemonic.
No action needed. This is a documentation-only change with no security or functional effect.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies a single comment block in src/seedsigner/views/seed_views.py within SeedMnemonicEntryView. The original one-line comment is replaced with a four-line comment that documents two distinct back-button behaviors and the need to call discard_pending_mnemonic() only when backing out from the first word. No executable code is changed.
Changed components
src/seedsigner/views/seed_views.pyInspect captured patch +4 / −1
diff --git a/src/seedsigner/views/seed_views.py b/src/seedsigner/views/seed_views.py
index a2761f9..53370f0 100644
--- a/src/seedsigner/views/seed_views.py
+++ b/src/seedsigner/views/seed_views.py
@@ -226,7 +226,10 @@ class SeedMnemonicEntryView(View):
)
if ret == RET_CODE__BACK_BUTTON:
- # Only need to discard when exiting from the very first word
+ # RET_CODE__BACK_BUTTON can happen in two ways here:
+ # 1. Backing out of the very first word completely aborts the mnemonic entry.
+ # 2. Backing out of a subsequent word just returns to the previous word.
+ # In both cases we return to BackStackView, but for case #1 we must also discard.
if self.cur_word_index == 0:
self.controller.storage.discard_pending_mnemonic()
return Destination(BackStackView)
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.