fix(l10n): update MicroSD toast timer terminology and add translator notes

SeedSigner/SeedSigner

aa4b8e06 View source ↗

Public commit record

What the developer wrote

Authored by okaybro

62/100 · Adequate

fix(l10n): update MicroSD toast timer terminology and add translator notes

✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body

The short version

What changed, and why it matters

This commit is a non-security change. It renames the user-facing label 'MicroSD toast timer' to 'MicroSD notification duration' and adds two translator comments to help people translate the terms into other languages. No code behavior changes.

Recommended action

No security action needed. Treat as a routine localization/user-interface improvement.

Security signals we found

No strong security signals were identified.

Technical analysis

Evidence from the diff

The diff only modifies display strings and translator notes in settings_definition.py. The setting’s internal values, identifiers, and behavior remain unchanged. There are no logic, input-handling, cryptographic, or access-control changes.

Changed components

src/seedsigner/models/settings_definition.py

Inspect captured patch +3 / −1

diff --git a/src/seedsigner/models/settings_definition.py b/src/seedsigner/models/settings_definition.py
index 974d2d5..25b07b8 100644
--- a/src/seedsigner/models/settings_definition.py
+++ b/src/seedsigner/models/settings_definition.py
@@ -299,7 +299,9 @@ class SettingsConstants:
     MICROSD_TOAST_TIMER_FOREVER = "inf"
     ALL_MICROSD_TOAST_TIMERS = [
         (MICROSD_TOAST_TIMER_DISABLED, _mft("Disabled")),
+        # TRANSLATOR_NOTE: MicroSD notification duration setting - Display notification for 5 seconds
         (MICROSD_TOAST_TIMER_FIVE_SECONDS, _mft("5 seconds")),
+        # TRANSLATOR_NOTE: MicroSD notification duration setting - Display notification until the SD card is removed
         (MICROSD_TOAST_TIMER_FOREVER, _mft("Until SD removed"))
     ]
 
@@ -670,7 +672,7 @@ class SettingsDefinition:
         
         SettingsEntry(category=SettingsConstants.CATEGORY__FEATURES,
                       attr_name=SettingsConstants.SETTING__MICROSD_TOAST_TIMER,
-                      display_name=_mft("MicroSD toast timer"),
+                      display_name=_mft("MicroSD notification duration"),
                       type=SettingsConstants.TYPE__SELECT_1,
                       visibility=SettingsConstants.VISIBILITY__ADVANCED,
                       selection_options=SettingsConstants.ALL_MICROSD_TOAST_TIMERS,

Risk score

Why this scored 15/100

Our methodology →

Potential impact 0/30

Exploitability 0/25

Stealth signal 0/15

Affected reach 0/15

Confidence 10/10

Evidence quality 5/5

Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

What the developer wrote

What changed, and why it matters

Security signals we found

Evidence from the diff

Changed components

Why this scored 15/100

Community notes

Related watches

fix: replace removed `get_seed` call in `PSBTSelectSeedView`

chore: update seedsigner-screenshots submodule to latest dev

refactor: use `Seed` instead of `seed_num`