What the developer wrote
Authored by kdmukai
Remove dead code
What changed, and why it matters
This commit removes unused code and fixes a minor variable-name inconsistency in the user interface code. There is no apparent security relevance: it deletes an unused screen class, removes an unused loading-screen flag, drops an unused selection-button setting, and renames a throwaway variable in a font-size calculation so the code is internally consistent. None of these changes affect how private keys, seeds, or transactions are handled.
No security action required. Treat as routine refactoring.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff is a small cleanup across four GUI screen modules. Changes: (1) removes self.show_loading_screen = True in PSBTOverviewScreen; (2) deletes the unused SeedBackupScreen dataclass from seed_screens.py; (3) removes self.use_checked_selection_buttons = True in SettingsEntryUpdateSelectionScreen; (4) renames the unused fourth return value of font.getbbox(...) from bit_font_height to bottom in ToolsCalcFinalWordScreen to match the subsequent call. No cryptographic, parsing, or authorization logic is modified.
Changed components
src/seedsigner/gui/screens/psbt_screens.pysrc/seedsigner/gui/screens/seed_screens.pysrc/seedsigner/gui/screens/settings_screens.pysrc/seedsigner/gui/screens/tools_screens.pyInspect captured patch +1 / −23
diff --git a/src/seedsigner/gui/screens/psbt_screens.py b/src/seedsigner/gui/screens/psbt_screens.py
index 4a65555..e0ec177 100644
--- a/src/seedsigner/gui/screens/psbt_screens.py
+++ b/src/seedsigner/gui/screens/psbt_screens.py
@@ -33,9 +33,6 @@ class PSBTOverviewScreen(ButtonListScreen):
self.is_bottom_list = True
self.button_data = [ButtonOption("Review details")]
- # This screen can take a while to load while parsing the PSBT
- self.show_loading_screen = True
-
super().__post_init__()
# Prep the headline amount being spent in large callout
diff --git a/src/seedsigner/gui/screens/seed_screens.py b/src/seedsigner/gui/screens/seed_screens.py
index ba684f9..3e15fd9 100644
--- a/src/seedsigner/gui/screens/seed_screens.py
+++ b/src/seedsigner/gui/screens/seed_screens.py
@@ -454,24 +454,6 @@ class SeedOptionsScreen(ButtonListScreen):
-@dataclass
-class SeedBackupScreen(ButtonListScreen):
- has_passphrase: bool = False
-
- def __post_init__(self):
- self.title = _("Backup Seed")
- self.is_bottom_list = True
- super().__post_init__()
-
- if self.has_passphrase:
- self.components.append(TextArea(
- # TRANSLATOR_NOTE: Additional explainer for the two seed backup options (mnemonic phrase and SeedQR).
- text=_("Backups do not include your passphrase."),
- screen_y=self.top_nav.height + GUIConstants.COMPONENT_PADDING,
- ))
-
-
-
@dataclass
class SeedWordsScreen(WarningEdgesMixin, ButtonListScreen):
words: List[str] = None
diff --git a/src/seedsigner/gui/screens/settings_screens.py b/src/seedsigner/gui/screens/settings_screens.py
index 10e8bd0..48cdc7d 100644
--- a/src/seedsigner/gui/screens/settings_screens.py
+++ b/src/seedsigner/gui/screens/settings_screens.py
@@ -25,7 +25,6 @@ class SettingsEntryUpdateSelectionScreen(ButtonListScreen):
def __post_init__(self):
self.title = _("Settings")
self.is_bottom_list = True
- self.use_checked_selection_buttons = True
if self.settings_entry_type == SettingsConstants.TYPE__MULTISELECT:
self.Button_cls = CheckboxButton
else:
diff --git a/src/seedsigner/gui/screens/tools_screens.py b/src/seedsigner/gui/screens/tools_screens.py
index 5701536..4264294 100644
--- a/src/seedsigner/gui/screens/tools_screens.py
+++ b/src/seedsigner/gui/screens/tools_screens.py
@@ -269,7 +269,7 @@ class ToolsCalcFinalWordScreen(ButtonListScreen):
# First what's the total bit display width and where do the checksum bits start?
bit_font_size = GUIConstants.get_button_font_size(locale="default") + 2 # bit font size should not vary by locale
font = Fonts.get_font(GUIConstants.FIXED_WIDTH_EMPHASIS_FONT_NAME, bit_font_size)
- (left, top, bit_display_width, bit_font_height) = font.getbbox("0" * 11, anchor="lt")
+ (left, top, bit_display_width, bottom) = font.getbbox("0" * 11, anchor="lt")
(left, top, checksum_x, bottom) = font.getbbox("0" * (11 - len(self.checksum_bits)), anchor="lt")
bit_display_x = int((self.canvas_width - bit_display_width)/2)
checksum_x += bit_display_x
Why this scored 12/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.