AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 47 Bitcoin

Hold milder psbt findings until the outputs are read

Public commit record

What the developer wrote

Authored by kdmukai

83/100 · Strong
Hold milder psbt findings until the outputs are read

A false input claim, entries in both derivation path maps, and surplus
output entries might each be an honest bug. They are now held in one
list instead of raised where found. parse() raises the first one after
_parse_outputs, so an output contradiction found later is still the one
reported. A held input is set aside (its verified list emptied). A held
output counts as a spend without its claims being evaluated.

Input claim verification moves into _parse_inputs. The wrong-seed check
moves after it and stands aside while a finding is held. Deletes
get_input_fingerprints, which had no callers.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
The short version

What changed, and why it matters

This commit changes how a Bitcoin signing helper (SeedSigner) handles suspicious but possibly innocent problems in a transaction file (PSBT). Instead of immediately stopping and warning about a minor issue on an input or output, it now 'holds' that concern, finishes reading the outputs, and only reports it if no more serious output-side attack is found. The goal is to make sure a fake-change attack on an output is never hidden behind a milder input problem. It also fixes a case where a malformed PSBT with missing UTXOs was wrongly reported as 'wrong seed'.

Recommended action

Review the new held-finding logic carefully to ensure no held input/output state leaks into later signing decisions, and verify that all held-finding branches are covered by tests. Consider whether any UI flow depends on the old immediate-error behavior.

Security signals we found

01

Change in error-reporting order to prioritize output-side attacks over input-side anomalies

02

Deferred raising of PSBTInputOwnershipClaimError, PSBTMixedDerivationPathTypesError, and PSBTSurplusDerivationPathsError

03

Held outputs explicitly counted as external spends, not change

04

Wrong-seed check repositioned and suppressed when a finding is held

05

New test coverage for held findings, ordering, and missing-UTXO diagnosis

Risk score

Why this scored 47/100

Our methodology →
Potential impact 12/30
Exploitability 8/25
Stealth signal 9/15
Affected reach 7/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.