What the developer wrote
Authored by kdmukai
bugfix
What changed, and why it matters
This is a one-line bugfix in a test helper script that generates screenshots. The change swaps a public method call for directly clearing an internal singleton variable. It only affects the screenshot generator's cleanup routine and does not appear to be a security fix for user-facing code.
No security action required. Treat as a normal development/test maintenance commit.
Security signals we found
No security-relevant signals in the diff
Change is confined to test/screenshot tooling
No input handling, cryptography, or privilege changes
Evidence from the diff
The commit modifies tests/screenshot_generator/generator.py. A callback that resets a Version singleton now assigns Version._instance = None directly instead of calling Version.reset_instance(). The added comment explains this is an atypical but intentional use case for the screenshot generator. The change is in test/development tooling, not in production firmware or wallet logic.
Changed components
tests/screenshot_generator/generator.pyInspect captured patch +3 / −1
diff --git a/tests/screenshot_generator/generator.py b/tests/screenshot_generator/generator.py
index 3bce441..2566a3a 100644
--- a/tests/screenshot_generator/generator.py
+++ b/tests/screenshot_generator/generator.py
@@ -313,7 +313,9 @@ def generate_screenshots(locale):
def reset_version_to_local_git_state_cb():
- Version.reset_instance()
+ # Normally, directly manipulating the singleton's internal instance is not
+ # allowed, but the screnshot generator is an atypical use case.
+ Version._instance = None
screenshot_sections = {
Why this scored 18/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.