Drop "scope" from the two ownership-claim summary lines
What the developer wrote
Authored by kdmukai
Drop "scope" from the two ownership-claim summary lines
"An output scope claims..." reads no better than "An output claims...".
The word is doing no work in a sentence about what the output says, and
the psbt-scope sense it borrows is not the one the reader needs there.
What changed, and why it matters
This commit only rewords two documentation comments inside the code, removing the word 'scope' from error-class descriptions. No program logic, behavior, or security checks were changed.
No action needed; this is a non-functional documentation/comment cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff changes two docstrings in src/seedsigner/models/psbt_parser.py for PSBTOutputOwnershipClaimError and PSBTInputOwnershipClaimError. The wording is simplified from ‘An output scope claims…’ to ‘An output claims…’ and from ‘An input scope claims…’ to ‘An input claims…’. No executable code, validation logic, exception handling, or data flow is modified.
Changed components
src/seedsigner/models/psbt_parser.py (docstrings only)Inspect captured patch +2 / −2
### src/seedsigner/models/psbt_parser.py
@@ -32,7 +32,7 @@ class PSBTVerificationError(Exception):
class PSBTOutputOwnershipClaimError(PSBTVerificationError):
"""
- An output scope claims this seed's fingerprint on a key the seed does not derive.
+ An output claims this seed's fingerprint on a key the seed does not derive.
This is asserting that an output belongs to this seed when it does not. We treat this
deception as an attack.
@@ -42,7 +42,7 @@ class PSBTOutputOwnershipClaimError(PSBTVerificationError):
class PSBTInputOwnershipClaimError(PSBTVerificationError):
"""
- An input scope claims this seed's fingerprint on a key the seed does not derive.
+ An input claims this seed's fingerprint on a key the seed does not derive.
The same type of false claim as the output case above, but a forged input claim simply
renders the psbt unsignable (embit re-derives the real key and will refuse to sign onWhy this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.