What the developer wrote
Authored by FazleRabbbiferdaus172
log moved to DoResetThread
Placing the log message inside the thread means it gets written at the exact moment the restart process actually begins. As in case of restart view this never gets executed. Better encapsulates the component responsible for rest.
What changed, and why it matters
This commit simply moves a log message that says 'Restarting SeedSigner' from one place in the code to another place inside the restart thread. It does not change what the program does, only when a status message is recorded. There is no security issue visible in this change.
No action required; this is a benign logging refactor.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff relocates a single logger.info() call from RestartView.run() into DoResetThread.run() just before the 0.25s sleep and process exit. The commit message explains this is for better encapsulation and timing accuracy of the log. No functional behavior, privilege boundary, input handling, or cryptographic logic is modified.
Changed components
src/seedsigner/views/view.py: RestartView, DoResetThreadInspect captured patch +1 / −2
diff --git a/src/seedsigner/views/view.py b/src/seedsigner/views/view.py
index 98e1548..940fe74 100644
--- a/src/seedsigner/views/view.py
+++ b/src/seedsigner/views/view.py
@@ -255,8 +255,6 @@ class RestartView(View):
self.thread = self.DoResetThread()
def run(self):
- logger.info("Restarting SeedSigner")
-
from seedsigner.gui.screens.screen import ResetScreen
if not self.is_screenshot_renderer:
@@ -274,6 +272,7 @@ class RestartView(View):
# Give the screen just enough time to display the reset message before
# exiting.
+ logger.info("Restarting SeedSigner")
time.sleep(0.25)
# Flush any buffered data.
Why this scored 13/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.