What changed, and why it matters
This commit simply renames a method from get_last_edit to get_last_edit_timestamp and updates the places that call it and test it. There is no security issue here—just a cleanup to fix a naming mismatch (the caller was already using a name that did not exist).
No security action needed. Treat as routine refactoring/test fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff renames Version.get_last_edit() to Version.get_last_edit_timestamp() and updates the single caller in settings_views.py and the corresponding test. The prior caller used Version.get_last_src_edit(), which appears to have been an already-broken reference; this change aligns names and fixes the call site. No functional behavior of the method changes.
Changed components
src/seedsigner/helpers/version.pysrc/seedsigner/views/settings_views.pytests/test_version.pyInspect captured patch +4 / −4
diff --git a/src/seedsigner/helpers/version.py b/src/seedsigner/helpers/version.py
index 5ae8f07..834dc07 100644
--- a/src/seedsigner/helpers/version.py
+++ b/src/seedsigner/helpers/version.py
@@ -140,7 +140,7 @@ class Version:
@classmethod
- def get_last_edit(cls) -> datetime:
+ def get_last_edit_timestamp(cls) -> datetime:
"""
Recursively scan the src/ directory for the most recent python file edit time.
"""
diff --git a/src/seedsigner/views/settings_views.py b/src/seedsigner/views/settings_views.py
index 85b446e..03b5f17 100644
--- a/src/seedsigner/views/settings_views.py
+++ b/src/seedsigner/views/settings_views.py
@@ -333,7 +333,7 @@ class VersionView(View):
self.run_screen(
settings_screens.VersionScreen,
version=Version.get_version(),
- last_edit=Version.get_last_src_edit(),
+ last_edit=Version.get_last_edit_timestamp(),
)
return Destination(SettingsMenuView)
\ No newline at end of file
diff --git a/tests/test_version.py b/tests/test_version.py
index 3819c6a..f398d2d 100644
--- a/tests/test_version.py
+++ b/tests/test_version.py
@@ -68,12 +68,12 @@ class TestVersion(BaseTest):
assert version == tag_name
- def test_get_last_src_edit(self):
+ def test_get_last_edit(self):
"""
Test that get_last_src_edit returns a sane datetime object. Assumes the system
running this test has a reasonably correct system time.
"""
- last_edit = Version.get_last_src_edit()
+ last_edit = Version.get_last_edit_timestamp()
assert isinstance(last_edit, datetime)
# Has to be more recent than the first SeedSigner v0.0.1 release
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.