AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 59 Bitcoin

Total verified_input_amount in _verify_input_amounts()

Public commit record

What the developer wrote

Authored by newtonick

40/100 · Thin
Total verified_input_amount in _verify_input_amounts()
✓ Specific, descriptive subject! No meaningful explanatory body
The short version

What changed, and why it matters

This commit renames and strengthens how SeedSigner totals the amount of bitcoin coming into a transaction. Previously, the wallet summed input amounts in a later step after a separate verification step. The change makes the verified total the only value used for display, so a malicious or buggy coordinator cannot trick the user into thinking a transaction has different inputs or fees than it really does. It is a defensive hardening patch, not a fix for a known active exploit.

Recommended action

Review as a security-hardening improvement. Ensure the removed 'continue' does not break legitimate PSBTs that previously parsed successfully. Consider whether the change warrants a changelog note for users relying on coordinator software that omits non_witness_utxo for non-segwit inputs.

Security signals we found

01

Defensive hardening against coordinator-supplied false input amounts (miner-fee attack)

02

Single source of truth for displayed input total now derived only after per-input verification

03

Removal of 'continue' in _verify_input_amounts() changes skip behavior to fail-closed for unverifiable non-segwit inputs

04

UI now consumes verified_input_amount instead of input_amount

05

No CVE, advisory, or vendor security disclosure referenced in commit

Risk score

Why this scored 59/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 8/15
Affected reach 10/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.