Updates test suite

SeedSigner/SeedSigner

21bf4e8e View source ↗

Public commit record

What the developer wrote

Authored by alvroble

38/100 · Opaque

Updates test suite

✓ Subject identifies a change✓ Mentions testing or verification! No meaningful explanatory body

The short version

What changed, and why it matters

This commit only updates the project's test suite. It adds a new screenshot configuration for a warning screen and adds one new assertion checking a default setting value. There are no changes to production code, no security fixes, and no behavior changes that affect users.

Recommended action

No security action needed. This is a routine test-maintenance commit.

Security signals we found

No strong security signals were identified.

Technical analysis

Evidence from the diff

The diff modifies two test files. In tests/screenshot_generator/generator.py, it imports RemoveMicroSDWarningView and adds a ScreenshotConfig entry for it. In tests/test_controller.py, it adds an assertion verifying that the default value of SETTING__MICROSD_TOAST_TIMER equals MICROSD_TOAST_TIMER_FIVE_SECONDS. No application source code is changed.

Changed components

tests/screenshot_generator/generator.pytests/test_controller.py

Inspect captured patch +3 / −1

diff --git a/tests/screenshot_generator/generator.py b/tests/screenshot_generator/generator.py
index be2b6ce..f94b93a 100644
--- a/tests/screenshot_generator/generator.py
+++ b/tests/screenshot_generator/generator.py
@@ -39,7 +39,7 @@ from seedsigner.models.qr_type import QRType
 from seedsigner.models.seed import Seed
 from seedsigner.models.settings import Settings
 from seedsigner.models.settings_definition import SettingsConstants, SettingsDefinition
-from seedsigner.views import (MainMenuView, PowerOptionsView, RestartView, NotYetImplementedView, UnhandledExceptionView, 
+from seedsigner.views import (MainMenuView, PowerOptionsView, RestartView, RemoveMicroSDWarningView, NotYetImplementedView, UnhandledExceptionView, 
     psbt_views, seed_views, settings_views, tools_views, scan_views)
 from seedsigner.views.screensaver import OpeningSplashView
 from seedsigner.views.view import NetworkMismatchErrorView, OptionDisabledView, PowerOffView
@@ -291,6 +291,7 @@ def generate_screenshots(locale):
                 ScreenshotConfig(MainMenuView, screenshot_name='MainMenuView_SDCardStateChangeToast_removed',  toast_thread=SDCardStateChangeToastManagerThread(action=MicroSD.ACTION__REMOVED, activation_delay=0, duration=0)),
                 ScreenshotConfig(MainMenuView, screenshot_name='MainMenuView_SDCardStateChangeToast_inserted', toast_thread=SDCardStateChangeToastManagerThread(action=MicroSD.ACTION__INSERTED, activation_delay=0, duration=0)),
                 ScreenshotConfig(MainMenuView, screenshot_name='MainMenuView_RemoveSDCardToast',               toast_thread=RemoveSDCardToastManagerThread(activation_delay=0, duration=0)),
+                ScreenshotConfig(RemoveMicroSDWarningView),
                 ScreenshotConfig(MainMenuView, screenshot_name='MainMenuView_DefaultToast',                    toast_thread=DefaultToast("This is a default text toast!", activation_delay=0, duration=0)),
                 ScreenshotConfig(MainMenuView, screenshot_name='MainMenuView_InfoToast',                       toast_thread=InfoToast("This is an info toast!", activation_delay=0, duration=0)),
                 ScreenshotConfig(MainMenuView, screenshot_name='MainMenuView_SuccessToast',                    toast_thread=SuccessToast("This is a success toast!", activation_delay=0, duration=0)),
diff --git a/tests/test_controller.py b/tests/test_controller.py
index d01a54c..0be99d0 100644
--- a/tests/test_controller.py
+++ b/tests/test_controller.py
@@ -110,6 +110,7 @@ class TestController(BaseTest):
         assert controller.settings.get_value(SettingsConstants.SETTING__DIRE_WARNINGS) == SettingsConstants.OPTION__ENABLED
         assert controller.settings.get_value(SettingsConstants.SETTING__QR_BRIGHTNESS_TIPS) == SettingsConstants.OPTION__ENABLED
         assert controller.settings.get_value(SettingsConstants.SETTING__PARTNER_LOGOS) == SettingsConstants.OPTION__ENABLED
+        assert controller.settings.get_value(SettingsConstants.SETTING__MICROSD_TOAST_TIMER) == SettingsConstants.MICROSD_TOAST_TIMER_FIVE_SECONDS
 
         # Hidden Settings defaults
         assert controller.settings.get_value(SettingsConstants.SETTING__QR_BRIGHTNESS) == 62

Risk score

Why this scored 15/100

Our methodology →

Potential impact 0/30

Exploitability 0/25

Stealth signal 0/15

Affected reach 0/15

Confidence 10/10

Evidence quality 5/5

Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

What the developer wrote

What changed, and why it matters

Security signals we found

Evidence from the diff

Changed components

Why this scored 15/100

Community notes

Related watches

Merge pull request #722 from Chaitanya-Keyal/psbt-huge-fee-warning

Settle is_high_fee once in parse()

Merge pull request #1032 from kdmukai/psbt_output_ownership