Use is_screenshot_generator for RestartView
What changed, and why it matters
This is a small internal cleanup change in a Bitcoin hardware wallet project. It replaces a manual flag used only during screenshot generation with an existing renderer property that already tells the code whether it is running in screenshot-generation mode. There is no user-facing or security-relevant change.
No security action needed. Treat as normal code-quality/test-maintenance change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
RestartView previously accepted an is_screenshot_renderer boolean dataclass field to decide whether to spawn the real device-restart thread. The patch removes that field and instead checks self.renderer.is_screenshot_generator, which the renderer already exposes. The screenshot generator no longer needs to pass a special constructor argument. This is a refactor that centralizes the screenshot-mode check and removes a redundant parameter.
Changed components
src/seedsigner/views/view.pytests/screenshot_generator/generator.pyInspect captured patch +2 / −3
diff --git a/src/seedsigner/views/view.py b/src/seedsigner/views/view.py
index 9e1bbea..2c0e3d1 100644
--- a/src/seedsigner/views/view.py
+++ b/src/seedsigner/views/view.py
@@ -248,12 +248,11 @@ class PowerOptionsView(View):
@dataclass
class RestartView(View):
- is_screenshot_renderer: bool = False
def run(self):
from seedsigner.gui.screens.screen import ResetScreen
- if not self.is_screenshot_renderer:
+ if not self.renderer.is_screenshot_generator:
# We don't want the screenshot generator to actually try to do the restart
RestartView.DoResetThread().start()
diff --git a/tests/screenshot_generator/generator.py b/tests/screenshot_generator/generator.py
index 196e25c..2a750b4 100644
--- a/tests/screenshot_generator/generator.py
+++ b/tests/screenshot_generator/generator.py
@@ -275,7 +275,7 @@ def generate_screenshots(locale):
ScreenshotConfig(MainMenuView, screenshot_name='MainMenuView_DireWarningToast', toast_thread=DireWarningToast("This is a dire warning toast!", activation_delay=0, duration=0)),
ScreenshotConfig(MainMenuView, screenshot_name='MainMenuView_ErrorToast', toast_thread=ErrorToast("This is an error toast!", activation_delay=0, duration=0)),
ScreenshotConfig(PowerOptionsView),
- ScreenshotConfig(RestartView, dict(is_screenshot_renderer=True)),
+ ScreenshotConfig(RestartView),
ScreenshotConfig(PowerOffView),
],
"Seed Views": [
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.