[REF] __post_init__ removed and RestartView initiates and start inside run method
What the developer wrote
Authored by FazleRabbbiferdaus172
[REF] __post_init__ removed and RestartView initiates and start inside run method
What changed, and why it matters
This is a small internal code cleanup in SeedSigner, a hardware wallet project. It moves the creation and starting of a background restart thread from a setup method into the main run method. There is no obvious security problem introduced by this change, and no security relevance is stated by the project.
No security action required. Review as normal refactoring if desired.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch removes RestartView.post_init(), which previously instantiated DoResetThread. Instead, RestartView.run() now creates and starts DoResetThread directly when not in screenshot-rendering mode. The functional behavior appears equivalent: the thread is still started once per run() invocation under the same guard condition. No input handling, cryptography, authentication, or network code is touched.
Changed components
src/seedsigner/views/view.pyRestartViewInspect captured patch +2 / −6
diff --git a/src/seedsigner/views/view.py b/src/seedsigner/views/view.py
index 940fe74..a4a077c 100644
--- a/src/seedsigner/views/view.py
+++ b/src/seedsigner/views/view.py
@@ -250,16 +250,12 @@ class PowerOptionsView(View):
class RestartView(View):
is_screenshot_renderer: bool = False
- def __post_init__(self):
- super().__post_init__()
- self.thread = self.DoResetThread()
-
def run(self):
from seedsigner.gui.screens.screen import ResetScreen
if not self.is_screenshot_renderer:
- # For the screenshot generator, we don't actually want to restart
- self.thread.start()
+ # We don't want the screenshot generator to actually try to do the restart
+ RestartView.DoResetThread().start()
self.run_screen(ResetScreen)
Why this scored 12/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.