What the developer wrote
Authored by kdmukai
Remove dead code
What changed, and why it matters
This commit simply deletes an unused helper method that could create a class instance without hardware initialization. There is no functional change to the running program because the method was not being called anywhere. It is a routine code cleanup, not a security fix.
No security action needed. Treat as normal refactoring/dead-code removal.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff removes HardwareButtons.get_instance_no_hardware(), a classmethod that instantiated the Singleton without invoking __init__. The remaining get_instance() path is unchanged and still enforces hardware initialization. No callers of the removed method are present in the diff or referenced materials, and no behavior is altered in the active code paths.
Changed components
src/seedsigner/hardware/buttons.pyInspect captured patch +0 / −7
diff --git a/src/seedsigner/hardware/buttons.py b/src/seedsigner/hardware/buttons.py
index 2f1a672..aee21c2 100644
--- a/src/seedsigner/hardware/buttons.py
+++ b/src/seedsigner/hardware/buttons.py
@@ -64,13 +64,6 @@ class HardwareButtons(Singleton):
return cls._instance
- @classmethod
- def get_instance_no_hardware(cls):
- # This is the only way to access the one and only instance
- if cls._instance is None:
- cls._instance = cls.__new__(cls)
-
-
def wait_for(self, keys=[]) -> int:
"""
Block execution until one of the target keys is pressed.
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.