Sparrow Wallet

This commit fixes a unit test that was failing on Windows. The test uses an embedded H2 database feature, and Windows file paths use backslashes. H2 interprets backslashes in its connection URL as escape characters, so the test path was being mangled. The fix converts the Windows path to forward slashes for the URL and adds a check that the test setup actually created the expected file before proceeding. There is no change to production wallet code or user-facing behavior.

This commit only changes the column headings in CSV export files so they include the name of the bitcoin unit being used (for example, 'Value (BTC)' or 'Value (sats)'). It is a user-experience improvement, not a security fix.

This commit changes how Sparrow Wallet displays bitcoin amounts in tables and charts. When a wallet using the 'auto' unit setting receives 1 BTC or more, the app now switches the display from satoshis to BTC. This is a user-interface convenience change, not a security fix.

This change fixes a bookkeeping issue between the Sparrow Wallet app and Bitcoin Core. When Bitcoin Core automatically expands the set of addresses it watches for a wallet, Sparrow could get out of sync and either try to re-import descriptors it already had, or refuse to extend the wallet's address range. The patch refreshes Sparrow's cached view of those ranges before deciding whether to import. The main risk is operational: users could see missing transactions, failed wallet loads, or address gaps, rather than a direct theft-of-funds bug.

This commit fixes how Sparrow Wallet calculates fees when you speed up or replace a Bitcoin transaction. Previously, if your wallet had unconfirmed follow-up transactions (like a CPFP child) that depended on the transaction being replaced, the wallet did not count their fees toward the replacement cost. That could cause the replacement to be rejected by the network for paying too little. The fix also improves the error message so users are told the correct minimum fee to use next time, and it allows a CPFP child that pays to a change address to be treated as a consolidation output when bumping fees.

This commit tightens how Sparrow's Cormorant integration decides when a Bitcoin Core wallet transaction has been replaced or dropped from the mempool. It now also considers new 'mempool conflicts' reported by Bitcoin Core 28+, waits until Core has finished loading its mempool before concluding a transaction is gone, and double-checks whether a transaction might have been confirmed in a block before purging it. The change is a defensive bug-fix that reduces the chance of Sparrow wrongly removing a transaction from its local view.

This small change fixes a UI bookkeeping bug in Sparrow Wallet. When you open a transaction in a tab, the wallet now properly stores the on-chain block information even if it could not fetch all of that transaction's input transactions. Previously, the block information may not have been saved in that case, so the confirmation count shown in the tab would not update as new blocks arrived. This is a correctness/fix for displayed state, not a vulnerability that lets someone steal funds or run code.

This commit fixes a UI display bug in Sparrow Wallet's transaction confirmation indicator. Previously, if a transaction tab opened when a transaction already had six or more confirmations, the little progress/tick icon would not draw correctly. It also now handles the rare case of a blockchain reorganization (reorg) reducing confirmations back below six, restoring the progress circle instead of leaving a tick. There is no indication this affects funds, private keys, or transaction signing.

This change fixes how Sparrow Wallet detects blockchain reorganizations when connected to Bitcoin Core. Previously, if Bitcoin Core's active chain briefly dropped below the last known block height (for example during a reorg), Sparrow would throw an error on every poll and keep failing until the user reconnected. Now it correctly recognizes this situation as a reorg and resets its last known block, allowing normal polling to continue.

This commit fixes a bug in Sparrow Wallet's Electrum server batching logic. When the wallet had experienced network timeouts, it tried to shrink its request batch size by half. If the configured page size was already 1, halving it produced 0, which then caused every future batched request to fail for the rest of the session. The fix ensures the page size never drops below 1. This is a reliability/denial-of-service bug rather than a way for an attacker to steal funds directly.

This commit hardens Sparrow Wallet's handling of block-chain tip announcements from Electrum servers. Previously, a server could announce a fake high block height and the wallet might keep retrying or accept the claim, affecting confirmation counts shown to the user. The change now refuses an announced tip if the wallet cannot verify it links into the known chain, falls back to the last verified store tip, and warns the user. It also prevents endless retries on the same bad tip.

This commit changes how Sparrow Wallet chooses between a regular Bitcoin address and a newer 'silent payment' address when paying someone via a DNS name or a Bitcoin URI. Previously, the wallet preferred the regular address. Now, if the sending wallet supports silent payments, it prefers the silent payment address and only falls back to the regular address when silent payments aren't possible. This is a feature/correctness improvement rather than a fix for an active security flaw, but it reduces the chance of silently using a weaker address type when a stronger one is available.

This commit tweaks the terminal (command-line) version of Sparrow Wallet. For a new type of wallet called a 'silent payments' wallet, it hides the 'gap limit' setting (which doesn't apply) and asks the user for the wallet's creation date when importing a watch-only silent-payments wallet. This is a user-interface improvement, not a security fix.

This commit simply hides the 'Discover' button when adding an account to a Silent Payments wallet. It is a UI change, not a fix for a vulnerability. There is no evidence of a security bug being patched.

This commit fixes a race condition in Sparrow Wallet's silent-payments scanning. When the wallet subscribes to a server to scan for silent payments, the server's first notification can arrive before the wallet has finished recording the subscription's official start height. Without the fix, that early notification could be ignored (potentially leaving the scan stuck waiting forever) or a notification from an old, replaced subscription could be wrongly applied (showing incorrect transaction history). The change holds early notifications in a small queue until the start height is known, then applies only the ones that belong to the current subscription, in the correct order.

This commit fixes how Sparrow Wallet calculates transaction size and fees for silent-payment transactions before they are fully signed. Previously, the wallet treated an unresolved silent-payment output as if it took up no space, which made the displayed transaction size, fee rate, and effective fee rate look smaller than they would be once broadcast. The fix sizes these outputs as the Taproot (P2TR) outputs they become after signing, so fee calculations and warnings match reality.

This commit adds support for a newer Bitcoin address format called 'silent payments' when Sparrow Wallet reads wallet labels from files or PDFs. Before this change, the wallet could fail to recognize silent-payment descriptors, so labels tied to those addresses might not be imported or matched correctly. There is no direct evidence this is a security vulnerability—no funds could be stolen—but it is a correctness fix that prevents silent-payment users from silently losing label metadata.

This commit fixes a bug in Sparrow Wallet's handling of silent payments after a blockchain reorganization (reorg). When the blockchain briefly rewinds and then re-adds a transaction at the same height, the wallet might not refresh all of its payment addresses, potentially leaving some balances or transaction statuses outdated. The fix forces a full refresh of all wallet nodes whenever any address was previously invalidated by a reorg, ensuring no stale data is missed.

This commit fixes a bookkeeping bug in Sparrow Wallet for silent-payments wallets. Previously, the wallet could record that it had scanned up to a certain block height before the scan actually finished. If the app then restarted, it might skip scanning that block range and miss payments sent to it. The change makes the wallet wait until a scan has actually covered a block before advancing its stored starting point for the next scan.

This commit only changes the text of an error message shown to users when importing a Bitcoin Secure Multisig Setup (BSMS) record. It makes the message clearer about why Sparrow treats a multi() quorum as a sortedmulti() equivalent and explains that addresses may differ from other signers if they don't sort keys the same way. There is no code behavior change, no vulnerability fix, and no security-relevant logic change.

This commit fixes a timing-related issue in Sparrow Wallet's terminal version. If a user asked to view their wallet seed and the wallet auto-locked before the password-derived key was ready, the app could still try to display the seed using a stale/untrusted state. The patch now checks whether the wallet locked during key derivation and refuses to show the seed if so, preventing possible exposure of the seed when the user no longer has an active unlocked session.

This commit changes how Sparrow Wallet calculates transaction fees. Previously, the wallet trusted the fee value reported by the Electrum server for each transaction. Now, when the wallet already knows the transactions that fund a given transaction's inputs, it calculates the fee directly from those input amounts minus the outputs. The server's reported fee is only used as a fallback when the wallet cannot derive the fee itself. This reduces the risk that a malicious or faulty server could trick the wallet into using an incorrect fee—particularly when the user later tries to bump a transaction's fee using RBF or CPFP.

This commit fixes a logic bug in Sparrow Wallet's Cormorant feature. Previously, when Cormorant was started only to test a connection to a Bitcoin server (not to actually manage wallets), it could still try to check or import wallet descriptors. The fix adds a guard so that wallet import checks are skipped when Cormorant is in 'test server connection' mode. This prevents unintended wallet operations and reduces the risk of exposing wallet information or causing errors during a simple connection test.

This commit adds a way to stop an ongoing background server connection attempt when the user tries to test or switch to a different server. Before the change, a retrying connection could keep running in the background while a new test connection started, causing the two attempts to share or fight over the same network resources. The fix cancels the old attempt first, then starts the new one. It is a reliability/resource-cleanup improvement rather than a clear-cut security vulnerability fix.

This commit changes how Sparrow Wallet tracks Electrum server notifications about Bitcoin address activity. Previously, the app remembered every status value it had ever seen for each address and ignored repeats of any earlier value. Now it only remembers the latest status and treats any change—even a return to an earlier value—as a real update. The old behavior could leave the wallet showing transactions that the server no longer has (for example, after a mempool replacement or a chain reorganization), which could mislead users about their balance or transaction history.