Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This is a documentation-only edit. It corrects a misleading comment in the code that wrongly claimed all fee estimates returned to LDK are forced to be at least 253 satoshis per 1000 weight units. The new comment clarifies that this minimu…
This change fixes a bug in Lightning Dev Kit's splicing logic. During a splice, one side can broadcast the new funding transaction as soon as it has the other side's signatures. Previously, if that transaction confirmed on-chain before the…
State-machine inconsistency in channel funding lifecycleMissing chain-source watch for in-flight splice funding transactionPotential failure to send splice_locked after splice confirms during signature exchange
This change fixes how Lightning nodes calculate the financial risk from tiny ('dust') HTLCs when the current on-chain fee rate is higher than the node's own local fee estimate. Previously, the code only considered a buffered fee rate when …
Incorrect fee exposure accounting for dust HTLCsPotential to accept HTLCs whose commitment/HTLC-success fees exceed their value under current feerateEconomic griefing / forced-channel-closure cost manipulation
This is a one-line code cleanup in a test file. It replaces a cloned array literal with a slice reference to silence a Rust compiler lint. There is no change to production code, no security fix, and no functional behavior change.
This is a one-line change in a test file to satisfy a Rust linter warning. It replaces a needless clone of a funding transaction with a reference-based slice construction. There is no functional change, no user-facing behavior change, and …
This commit is a test-only fix for a broken continuous integration (CI) build. It updates a test mock to match a new function signature and rewrites an existing test to use three nodes instead of two so the test scenario remains valid unde…
This change fixes a Lightning channel bug where a malicious peer could renegotiate the closing transaction fee while the local node was still waiting for its own signer to produce the final signature. If allowed, the local node might combi…
State-machine guard expansion to prevent fee renegotiation while a closing signature is pendingRisk of combining mismatched signatures across different closing feesRegression test demonstrates malicious peer renegotiation attempt and expected warning rejection
This change fixes a wallet bug in rust-lightning where a UTXO could be selected for a Lightning funding transaction, then rejected because its previous transaction was too large to fit in a Lightning peer message. Previously, that rejectio…
API change to CoinSelectionSource::select_confirmed_utxos adding max_input_prevtx_serialized_lenWalletSync filters UTXOs by prevtx serialized length before selectionFundingBuilder enforces Lightning tx_add_input message-size limit at selection time
This commit hardens LDK's BOLT 12 payment logic so it refuses to pay invoices containing very large unknown record types (4 billion and up). These records are legal under the Lightning spec, but LDK doesn't understand them, so the change t…
Defensive refusal to pay invoices with unknown high-numbered TLV recordsReuses existing UnknownRequiredFeatures failure path instead of adding a new oneAdds explicit checks before payment state insertion and route construction
This commit fixes a backward-compatibility bug in LDK's BOLT 12 invoice parser. A previous change had capped the range of 'experimental' TLV record types at 4 billion, but the Lightning spec imposes no upper bound. As a result, invoices cr…
Backward-compatibility regression in deserialization of persisted channel monitorsDenial-of-service via unreadable monitor blocking all channel monitoringSpec compliance fix: TLV record types have no upper bound
This change fixes a security issue where a signed text message could be crafted so that its prefixed form looks exactly like a Lightning 'node_announcement' gossip message. Because both use the same double-SHA256 hash and the same signing …
Signature replay / message confusion between signed messages and gossip announcementsForged `node_announcement` signatures via chosen-prefix message constructionNew validation rejects prefixed messages that deserialize as `UnsignedNodeAnnouncement`
This change fixes a corner case in how the Lightning node tries to claim multiple pending HTLCs (small Bitcoin payments locked in a channel) when the wallet cannot fund a single large batch transaction. Previously, if the multi-HTLC batch …
Funds-recovery robustness improvement: prevents premature abandonment of a single unbatched HTLCChange in error-handling arithmetic from checked_sub/saturating_sub with max(1)New unit tests covering both failed and successful singleton HTLC funding paths
This change prevents a Lightning node from accidentally overwriting an archived copy of a channel's security monitor with a brand-new one that happens to use the same identifier. In the old code, if a new channel reused the same identifier…
Data-loss prevention: stops archived ChannelMonitor from being overwritten by a later channel with the same keySafety guard added to both sync and async persistence pathsPersistence refusal surfaces as InProgress/UnrecoverableError rather than silent overwrite
This change fixes a place in the Lightning payment routing code where adding up fees could overflow the maximum number a computer can store in a 64-bit integer. Previously, the code assumed this could never happen and would crash (panic) i…
Integer overflow in fee computationPreviously unreachable!() panic path reachableMPP path merge could trigger overflow
This commit fixes a bug where a Lightning node could get stuck after restarting. If the node crashed or restarted while it was still saving the initial channel monitor to disk, and that save later finished in another process, the restarted…
Fixes a state-machine stall on node reload that could leave channels non-functionalRemoves an overstrict assertion that would panic on a legitimate post-reload stateAdds explicit detection of monitor persistence completed in a prior process
This change only updates documentation and code comments in the Lightning Dev Kit library. It clarifies that a particular key-derivation setting is fixed when a channel is first opened and is not changed by splicing. No code behavior was a…
This commit only changes documentation comments in two source files. It corrects the wording of how certain public keys are derived in the Lightning protocol and adds details about which witness script a signer must use when creating justi…
Documentation-only changeClarifies key derivation semantics for Lightning commitment transactionsClarifies justice transaction witness script requirements for signers
This change only adds documentation comments to a Rust struct. It does not modify any executable code, so it cannot by itself introduce or fix a security vulnerability. The new text warns developers that using TokioSpawner incorrectly can …
This commit hardens how Lightning Dev Kit handles custom signing modules. Previously, LDK relied on each custom signer to check that the other party's signatures on a holder commitment transaction were valid. The change adds a ready-made v…
New synchronous signature-verification helper for holder commitment transactionsTrait documentation now mandates verification before Ok(()) because LDK acts immediatelyInMemorySigner now validates that holder funding key belongs to signer before signature checks
This update fixes a corner case in the Lightning Dev Kit where a node could get confused if it received a 'channel_ready' message while still waiting for its own signer to produce the first commitment signature. The patch makes the node re…
State-machine confusion between funding_signed and channel_ready in async signer flowPremature channel_ready could advance counterparty_next_commitment_point before initial commitment is signedPatch closes channel rather than allowing inconsistent commitment state
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
Lower-prioritybolt12: deprecate manually_handle_bolt12_invoices as of 0.3by auto-pr-bot · 7a203d83 · Nov 16, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · auto-pr-bot
bolt12: deprecate manually_handle_bolt12_invoices as of 0.3
@matt asked:
> @auto-pr-bot please add a followup that changes this to 0.3 (same for > `send_payment_for_bolt12_invoice`).
The deprecation attributes added here were marked `since = "0.4.0"`, but `manually_handle_bolt12_invoices` and `ChannelManager::send_payment_for_bolt12_invoice` are being deprecated in the 0.3 release, so `since` should read `0.3` in both places. Clippy's `deprecated_semver` lint requires a semver-compliant version, so it is spelled `since = "0.3.0"`.
Allow monitor_pending_channel_ready on resumed outbound channels
Resuming a channel whose initial monitor persistence completed while the node was down can race with chain sync: if the funding transaction was broadcast before the node went down and confirmed to the required depth while it was down, syncing the chain marks the still-paused channel's channel_ready as pending. monitor_updating_restored then hit an assertion that an outbound, non-zero-conf channel can never have monitor_pending_channel_ready set, turning a stuck channel into a panic at every startup - nothing is persisted before the panic, so the node could never come back up.
After a reload from a ChannelManager serialized before the broadcast, LDK did broadcast the funding transaction (in the prior process), so the funding can legitimately have confirmed; drop the assertion and just send channel_ready. Adds a test which confirms the funding transaction to the required depth between the reload and the first background-event processing, matching the startup ordering that hits the removed assertion.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
boot or update path
AI analysis · Moderate 50/100
This commit fixes a bug where a Lightning node could crash in a loop every time it started up. The crash happened when a channel's funding transaction had already confirmed while the node was offline, but the node still had old saved state. The old code wrongly assumed this situation was impossible and panicked. The fix removes that incorrect assumption and lets the node resume the channel normally. It is a denial-of-service/availability bug, not a theft-of-funds bug, and it can only be triggered by the node's own saved state and normal blockchain activity.
Security candidateMerge PR 'Avoid overflow in closing fee limit calculation' (#5284)by Matt Corallo · dc3f8eda · Nov 16, 2026 · 1 fileMessage 86 · StrongModerate 59Details
Commit message · Matt Corallo
Merge PR 'Avoid overflow in closing fee limit calculation' (#5284)
from bot/5185-prevent-peer-triggered-overflow-081f9f into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5284 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
86/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
memory safetymerge-commit duplicate discount
AI analysis · Moderate 59/100
This patch fixes an integer overflow in the code that calculates the maximum acceptable fee when negotiating a Lightning channel closing transaction. A malicious or buggy peer could potentially supply values that cause the arithmetic to overflow, leading to an incorrect fee limit. The fix uses Rust's saturating addition so the result cannot wrap around. This is a defensive hardening change in a single calculation.
Lower-priorityMerge PR 'Log only first 16 unknown required feature bits from peer init' (#5605)by Matt Corallo · 1e8fab64 · Nov 16, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo
Merge PR 'Log only first 16 unknown required feature bits from peer init' (#5605)
from auto-pr-bot/bot/301-unknown-required-feature-bits-in-f6b4ca into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5605 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
from bot/5374-avoid-rescoring-replayed-payment-1ced3a into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5466 Reviewed-by: Val Wallace <val@noreply.git.rust-bitcoin.org>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Parallelize stale monitor update removal in batches of 50' (#5548)by Matt Corallo · 5cf77a92 · Nov 16, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo
Merge PR 'Parallelize stale monitor update removal in batches of 50' (#5548)
from bot/5542-cleanup_stale_updates_for_monito-b02e52 into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5548 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Rework async gossip UTXO validation around one lookup per SCID' (#5325)by Matt Corallo · 3e68df54 · Nov 16, 2026 · 3 filesMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo
Merge PR 'Rework async gossip UTXO validation around one lookup per SCID' (#5325)
from 2026-10-async-gossip-rework into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5325 Reviewed-by: Val Wallace <val@noreply.git.rust-bitcoin.org>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Document not swapping persisted static invoices for older ones' (#5350)by Val Wallace · 6e2c6db1 · Nov 16, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · Val Wallace
Merge PR 'Document not swapping persisted static invoices for older ones' (#5350)
from bot/5333-prevent-replayed-invoices-from-o-5a9315 into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5350 Reviewed-by: Val Wallace <val@noreply.git.rust-bitcoin.org>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateResume channels awaiting a completed monitor persistence on loadby auto-pr-bot · dc81ecb8 · Nov 16, 2026 · 3 filesMessage 81 · StrongModerate 53Details
Commit message · auto-pr-bot
Resume channels awaiting a completed monitor persistence on load
A channel serialized with MONITOR_UPDATE_IN_PROGRESS was only resumed on load through its tracked in-flight ChannelMonitorUpdates, but the initial ChannelMonitor write (from funding_created/funding_signed) is never tracked as one, and blocked updates the monitor already applied are dropped at load. A channel whose monitor persistence completed after the last ChannelManager write was therefore loaded with the flag set and nothing to ever clear it, leaving it stuck: as funder the funding transaction was never broadcast and channel_ready was never sent for confirmed funding, as acceptor channel_ready was never sent for the peer's confirmed funding. This state is reached with deferred monitor writes (where the background processor writes the ChannelManager before flushing the new monitor) or a Persist that returns InProgress for new channels, whenever the node goes down between the monitor write and the next ChannelManager write.
If a channel is still awaiting a monitor update on load, the monitor is present, and it has nothing in-flight or blocked, the persistence it was waiting on must have completed since we were last serialized, so queue a MonitorUpdatesComplete background event at the monitor's latest update_id, the same way completed in-flight updates are handled. Channels with blocked updates still go through AttemptUnblockMonitorUpdates and those with in-flight updates through the existing replay logic, so the new branch is exclusive with both.
Adds test_outbound_reload_with_completed_init_mon, mirroring the existing test_outbound_reload_without_init_mon but handing the monitor back on reload, and extends test_event_replay_causing_monitor_replay, which exercised the blocked-update variant of the same gap: the channel is now resumed on startup, so it expects the PaymentPathSuccessful produced by the resume and verifies a payment can be sent afterwards.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
boot or update path
AI analysis · Moderate 53/100
This commit fixes a bug in the Lightning Dev Kit where a newly-created channel could get permanently stuck after a restart. If the channel's first monitor save finished after the last ChannelManager save, the channel would reload believing it was still waiting for that save, but nothing would ever clear the wait. As a result, the funding transaction was never broadcast and the channel could never become usable. The fix detects this situation on load and resumes the channel automatically. It is a reliability/availability bug, not a direct theft-of-funds vulnerability, because the channel simply fails to open rather than funds being stolen.
AI review queuedMerge PR 'Drop ben and joost from the assign-reviewer pool' (#5498)by Matt Corallo · 6ac2db21 · Nov 16, 2026 · 1 fileMessage 81 · StrongInformational 15Details
Commit message · Matt Corallo
Merge PR 'Drop ben and joost from the assign-reviewer pool' (#5498)
from bot/5449-drop-stale-reviewers-from-the-as-5e7903 into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5498 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit simply updates an automated workflow that picks who gets asked to review new pull requests. It removes five people from the reviewer rotation and keeps four others. There is no code change to the actual Lightning software and no security relevance.
from bot/5549-0.1-additional-backports-bf75b6 into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5577 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Stop logging on every block once channel_ready is exchanged' (#5527)by Matt Corallo · 9282bb93 · Nov 16, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo
Merge PR 'Stop logging on every block once channel_ready is exchanged' (#5527)
from fix-channel-ready-log into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5527 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Update gossip fuzz test for new secp256k1 PublicKey Debug format' (#5598)by Matt Corallo · 249356c5 · Nov 16, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · Matt Corallo
Merge PR 'Update gossip fuzz test for new secp256k1 PublicKey Debug format' (#5598)
from bot/5593-fuzz_sanity-ci-failure-1e4459 into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5598 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencemerge-commit duplicate discount
Security candidateMerge PR 'Advise extract_tx_unchecked_fee_rate in sign_psbt docs' (#5599)by Matt Corallo · 75d8ba2c · Nov 16, 2026 · 1 fileMessage 81 · StrongInformational 18Details
Commit message · Matt Corallo
Merge PR 'Advise extract_tx_unchecked_fee_rate in sign_psbt docs' (#5599)
from bot/5594-sign_psbt-docs-advise-extract_tx-cd8cd5 into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5599 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 18/100
This change only updates documentation comments for the sign_psbt methods in wallet utilities. It advises developers to use extract_tx_unchecked_fee_rate() instead of extract_tx() when signing PSBTs outside the library, because extract_tx() can reject transactions with very high fee rates that are legitimate in Lightning child-pays-for-parent fee-bumping scenarios. It is a documentation-only fix with no code behavior change.
Security candidateAdvise extract_tx_unchecked_fee_rate in sign_psbt docsby auto-pr-bot · 7bdcb4f0 · Nov 16, 2026 · 1 fileMessage 81 · StrongModerate 60Details
Commit message · auto-pr-bot
Advise extract_tx_unchecked_fee_rate in sign_psbt docs
The sign_psbt() doc comments on CoinSelectionSource, WalletSource and their synchronous counterparts told wallet implementors to call psbt.extract_tx() to get the transaction to sign. Since the rust-bitcoin 0.31 upgrade (a8bd4c097f7a, first released in v0.0.124-beta) that method rejects transactions paying more than 25,000 sat/vB, and LDK's own callers were switched to extract_tx_unchecked_fee_rate() at the same time while the docs were left behind.
The transactions handed to sign_psbt() can legitimately carry a fee above that cap: the anchor CPFP child LDK builds for a ChannelClose event folds the commitment transaction's fee into its own input value, so its fee pays for the whole package and its own feerate exceeds 25,000 sat/vB once the commitment is large enough (e.g. ~146 sat/vB target with 483 pending HTLCs). A wallet written as documented then fails sign_psbt() and the force-close is never broadcast.
Point implementors at extract_tx_unchecked_fee_rate() instead, and warn against extract_tx() so they don't "fix" it back.
@matt asked:
> @auto-pr-bot can you change the docs to fix this?
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet path
AI analysis · Moderate 60/100
This commit only updates documentation comments in LDK's wallet utility code. It tells wallet developers not to use a standard Bitcoin library method (psbt.extract_tx()) when implementing the sign_psbt() function, because that method rejects transactions with very high fees. In certain legitimate Lightning scenarios—like a child transaction paying fees for both itself and its parent force-close transaction—the fee rate can exceed the library's cap. Using the wrong method would cause the wallet to refuse to sign, preventing a force-close transaction from being broadcast. The commit itself does not change any code behavior, only the guidance given to implementers.
Lower-priorityUpdate gossip fuzz test for new secp256k1 PublicKey Debug formatby auto-pr-bot · 9c33bdde · Nov 16, 2026 · 1 fileMessage 91 · StrongTriage 5Details
Commit message · auto-pr-bot
Update gossip fuzz test for new secp256k1 PublicKey Debug format
test_gossip_exchange_breakage asserts on exact log lines emitted by peer_handler when forwarding gossip, which embed the Debug output of the peer's PublicKey. secp256k1 0.29.100 changed that Debug impl from the derived form printing the 64-byte x||y coordinate hex wrapped in `PublicKey(...)` to the LowerHex of the compressed 33-byte serialization, so the expected strings no longer match and the fuzz_sanity CI job fails.
Update the three expected lines to the new format; the behaviour under test is unchanged.
@matt has asked:
> @auto-pr-bot looks like the fuzz_sanity CI job is failing with the > following error, fix it.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidence
Lower-priorityMerge PR 'Reject lower-work startup tips before disconnecting listeners' (#5311)by Matt Corallo · 0a5e41df · Nov 16, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo
Merge PR 'Reject lower-work startup tips before disconnecting listeners' (#5311)
from bot/5236-reject-lower-work-startup-tips-b-1a53d5 into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5311 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Filter remaining non-global IANA IPv4 ranges in init' (#5457)by Matt Corallo · 20b6df83 · Nov 16, 2026 · 1 fileMessage 81 · StrongTriage 0Details
from bot/5363-don-t-reflect-non-global-ipv4-sp-fc21f3 into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5457 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'gossip: Avoid wall-clock race in handling_channel_announcements' (#5579)by Matt Corallo · a141edea · Nov 15, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo
Merge PR 'gossip: Avoid wall-clock race in handling_channel_announcements' (#5579)
from channel-announcements-tracking-time into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5579 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Release the monitor-set lock before sync event callbacks' (#5590)by Matt Corallo · 7dda89c5 · Nov 15, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo
Merge PR 'Release the monitor-set lock before sync event callbacks' (#5590)
from bot/5589-release-the-monitor-set-lock-bef-410058 into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5590 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateRelease the monitor-set lock before sync event callbacksby auto-pr-bot · c587b847 · Nov 15, 2026 · 1 fileMessage 91 · StrongModerate 64Details
Commit message · auto-pr-bot
Release the monitor-set lock before sync event callbacks
@matt asked in #5589:
> @auto-pr-bot please fix this issue reported by project loupe > > ## Description > > The synchronous EventsProvider implementation holds > self.monitors.read() throughout each > ChannelMonitor::process_pending_events call, including the application > callback. Both its documentation and EventsProvider explicitly permit > callbacks to re-enter the provider. A callback that flushes a queued > new monitor acquires flush_lock and pending_ops, then > watch_channel_internal waits for self.monitors.write(). The same > thread still owns the outer read guard and cannot release it until the > callback returns, so production deadlocks. The blocked flush also > retains the global operation-queue lock, preventing subsequent > deferred monitor updates. > > [...] > > Exploitation is integration-dependent: an application must use > synchronous event handling and perform a checkpoint/flush from its > event callback (or another operation requiring the monitor-set write > lock). A channel counterparty can trigger that callback through an > on-chain close producing SpendableOutputs, while another registration > is queued. This stalls event processing and monitor-update flushing; > if processing remains stalled, time-sensitive claim handling can be > affected.
`process_pending_events_async` already re-acquires the monitors read lock around each monitor's event processing instead of holding it across the handler; this applies the same structure to the synchronous `EventsProvider` implementation, using the shared `process_events_body!` macro. A regression test queues a monitor registration and flushes it from the event handler, which the test lock checker detects as a deadlock on the previous code.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
explicit security languagefuzzing or regression evidence
AI analysis · Moderate 64/100
This commit fixes a deadlock bug in the rust-lightning library's ChainMonitor. When an application handled certain blockchain events synchronously, the library held a read lock while calling the application's handler. If that handler tried to flush a newly queued channel monitor, it needed a write lock on the same data structure, which the same thread still held as a read lock. This caused a self-deadlock, stalling event processing and time-sensitive on-chain claim handling. The fix releases the read lock before invoking the application callback and re-acquires it afterward, mirroring how the asynchronous event path already worked. A regression test confirms the previously deadlocking scenario now succeeds.