LDK
← All projectsLightning Dev Kit

rust-lightning

Composable Rust libraries for building Lightning wallets, nodes, and services.

BitcoinCryptographic librariesLightning NetworkNormal
Repository coverage

1924 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

300security candidates261second-pass queue1606AI analyses
175commits · 30 days
261commits · 60 days
636commits · 180 days
1314commits · 365 days
Backfill bands
Aug 5 → Feb 6819 seen18 candidatesComplete
Feb 6 → Jun 6468 seen16 candidatesComplete
Jun 6 → Jul 6128 seen8 candidatesComplete
Jul 6 → Aug 561 seen3 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

71/100 average clarity
704Strong · 80–100
856Adequate · 60–79
302Thin · 40–59
62Opaque · 0–39
3security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Matt Corallo58679418876
Elias Rohrer15415153667
auto-pr-bot571823287
Jeffrey Czyz19645182169
Wilmer Paulino15945155169
Valentine Wallace15715145169
Leo Nash11613116162
Vincenzo Palazzo11311183
Joost Jager16324162069
elnosh401434059
shaavan22622069
wpaulino2059082
Analysis record

Published AI watches

Last scanned 35 minutes ago

Informational 15 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Correct FeeEstimator docs on the 253 sat/kW lower bound

This is a documentation-only edit. It corrects a misleading comment in the code that wrongly claimed all fee estimates returned to LDK are forced to be at least 253 satoshis per 1000 weight units. The new comment clarifies that this minimu…

ea2051feby auto-pr-bot+9−31 file
No security note in commit
Moderate 54 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Track splice confirmation while awaiting tx_signatures' (#5570)

This change fixes a bug in Lightning Dev Kit's splicing logic. During a splice, one side can broadcast the new funding transaction as soon as it has the other side's signatures. Previously, if that transaction confirmed on-chain before the…

State-machine inconsistency in channel funding lifecycleMissing chain-source watch for in-flight splice funding transactionPotential failure to send splice_locked after splice confirms during signature exchange
ca778e61by Matt Corallo+245−32 files
No security note in commit
Moderate 63 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Account for current HTLC fees in dust exposure' (#5690)

This change fixes how Lightning nodes calculate the financial risk from tiny ('dust') HTLCs when the current on-chain fee rate is higher than the node's own local fee estimate. Previously, the code only considered a buffered fee rate when …

Incorrect fee exposure accounting for dust HTLCsPotential to accept HTLCs whose commitment/HTLC-success fees exceed their value under current feerateEconomic griefing / forced-channel-closure cost manipulation
cc798f60by Matt Corallo+108−382 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Replace cloned array literal with slice::from_ref in reload test' (#5689)

This is a one-line code cleanup in a test file. It replaces a cloned array literal with a slice reference to silence a Rust compiler lint. There is no change to production code, no security fix, and no functional behavior change.

03ca832fby Matt Corallo+1−11 file
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Replace cloned array literal with slice::from_ref in reload test

This is a one-line change in a test file to satisfy a Rust linter warning. It replaces a needless clone of a funding transaction with a reference-based slice construction. There is no functional change, no user-facing behavior change, and …

93e0129cby auto-pr-bot+1−11 file
No security note in commit
Informational 12 AI analysisMessage 91 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Fix CI: rebuild test coin-selection impl and rework reused-ID balance test' (#5684)

This commit is a test-only fix for a broken continuous integration (CI) build. It updates a test mock to match a new function signature and rewrites an existing test to use three nodes instead of two so the test scenario remains valid unde…

17bac68aby Matt Corallo+26−202 files
No security note in commit
Moderate 68 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Guard pending closing signatures before channel_ready' (#5681)

This change fixes a Lightning channel bug where a malicious peer could renegotiate the closing transaction fee while the local node was still waiting for its own signer to produce the final signature. If allowed, the local node might combi…

State-machine guard expansion to prevent fee renegotiation while a closing signature is pendingRisk of combining mismatched signatures across different closing feesRegression test demonstrates malicious peer renegotiation attempt and expected warning rejection
a01273a2by Matt Corallo+169−21 file
No security note in commit
Low 48 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Release wallet UTXOs when FundingBuilder rejects a coin selection' (#5634)

This change fixes a wallet bug in rust-lightning where a UTXO could be selected for a Lightning funding transaction, then rejected because its previous transaction was too large to fit in a Lightning peer message. Previously, that rejectio…

API change to CoinSelectionSource::select_confirmed_utxos adding max_input_prevtx_serialized_lenWalletSync filters UTXOs by prevtx serialized length before selectionFundingBuilder enforces Lightning tx_add_input message-size limit at selection time
56054190by Matt Corallo+148−155 files
No security note in commit
Low 48 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Refuse to pay BOLT 12 invoices with records above experimental range

This commit hardens LDK's BOLT 12 payment logic so it refuses to pay invoices containing very large unknown record types (4 billion and up). These records are legal under the Lightning spec, but LDK doesn't understand them, so the change t…

Defensive refusal to pay invoices with unknown high-numbered TLV recordsReuses existing UnknownRequiredFeatures failure path instead of adding a new oneAdds explicit checks before payment state insertion and route construction
2970372fby auto-pr-bot+106−177 files
No security note in commit
Moderate 64 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Read invoice TLV records above the experimental range

This commit fixes a backward-compatibility bug in LDK's BOLT 12 invoice parser. A previous change had capped the range of 'experimental' TLV record types at 4 billion, but the Lightning spec imposes no upper bound. As a result, invoices cr…

Backward-compatibility regression in deserialization of persisted channel monitorsDenial-of-service via unreadable monitor blocking all channel monitoringSpec compliance fix: TLV record types have no upper bound
9e28db58by auto-pr-bot+133−84 files
No security note in commit
High 74 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Refuse to sign messages that collide with gossip serializations' (#5677)

This change fixes a security issue where a signed text message could be crafted so that its prefixed form looks exactly like a Lightning 'node_announcement' gossip message. Because both use the same double-SHA256 hash and the same signing …

Signature replay / message confusion between signed messages and gossip announcementsForged `node_announcement` signatures via chosen-prefix message constructionNew validation rejects prefixed messages that deserialize as `UnsignedNodeAnnouncement`
ec40e097by Matt Corallo+74−148 files
Vendor flagged security relevance
Low 37 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Retry a single HTLC before abandoning an unfundable batch' (#5406)

This change fixes a corner case in how the Lightning node tries to claim multiple pending HTLCs (small Bitcoin payments locked in a channel) when the wallet cannot fund a single large batch transaction. Previously, if the multi-HTLC batch …

Funds-recovery robustness improvement: prevents premature abandonment of a single unbatched HTLCChange in error-handling arithmetic from checked_sub/saturating_sub with max(1)New unit tests covering both failed and successful singleton HTLC funding paths
643e8684by wpaulino+119−21 file
No security note in commit
Moderate 54 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Refuse to persist fresh monitors that alias archived monitors' (#5645)

This change prevents a Lightning node from accidentally overwriting an archived copy of a channel's security monitor with a brand-new one that happens to use the same identifier. In the old code, if a new channel reused the same identifier…

Data-loss prevention: stops archived ChannelMonitor from being overwritten by a later channel with the same keySafety guard added to both sync and async persistence pathsPersistence refusal surfaces as InProgress/UnrecoverableError rather than silent overwrite
3c606c11by Matt Corallo+298−332 files
No security note in commit
Moderate 52 AI analysisMessage 86 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Handle fee multiplication overflow when merging MPP paths' (#5288)

This change fixes a place in the Lightning payment routing code where adding up fees could overflow the maximum number a computer can store in a 64-bit integer. Previously, the code assumed this could never happen and would crash (panic) i…

Integer overflow in fee computationPreviously unreachable!() panic path reachableMPP path merge could trigger overflow
25f8a740by Matt Corallo+42−171 file
No security note in commit
Low 43 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Resume channels stuck awaiting a completed monitor persistence on reload' (#5610)

This commit fixes a bug where a Lightning node could get stuck after restarting. If the node crashed or restarted while it was still saving the initial channel monitor to disk, and that save later finished in another process, the restarted…

Fixes a state-machine stall on node reload that could leave channels non-functionalRemoves an overstrict assertion that would panic on a legitimate post-reload stateAdds explicit detection of monitor persistence completed in a prior process
11815ed1by Matt Corallo+334−74 files
No security note in commit
Informational 15 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Correct KeysManager docs on spliced channels' remote_key derivation' (#5609)

This change only updates documentation and code comments in the Lightning Dev Kit library. It clarifies that a particular key-derivation setting is fixed when a channel is first opened and is not changed by splicing. No code behavior was a…

83a4d243by Matt Corallo+17−91 file
No security note in commit
Informational 15 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Fix DelayedPaymentKey/HtlcKey from_basepoint docs and document justice tx witness script' (#5596)

This commit only changes documentation comments in two source files. It corrects the wording of how certain public keys are derived in the Lightning protocol and adds details about which witness script a signer must use when creating justi…

Documentation-only changeClarifies key derivation semantics for Lightning commitment transactionsClarifies justice transaction witness script requirements for signers
2f832195by Matt Corallo+44−62 files
No security note in commit
Informational 19 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Document that TokioSpawner requires all of LDK in a tokio context' (#5621)

This change only adds documentation comments to a Rust struct. It does not modify any executable code, so it cannot by itself introduce or fix a security vulnerability. The new text warns developers that using TokioSpawner incorrectly can …

Documentation-only changeNo code logic modifiedNo unsafe blocks added
6e555fa2by Matt Corallo+11−01 file
No security note in commit
High 70 AI analysisMessage 91 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Make custom signers verify holder commitment sigs synchronously' (#5616)

This commit hardens how Lightning Dev Kit handles custom signing modules. Previously, LDK relied on each custom signer to check that the other party's signatures on a holder commitment transaction were valid. The change adds a ready-made v…

New synchronous signature-verification helper for holder commitment transactionsTrait documentation now mandates verification before Ok(()) because LDK acts immediatelyInMemorySigner now validates that holder funding key belongs to signer before signature checks
0e3b6d33by Matt Corallo+324−954 files
Vendor flagged security relevance
Moderate 64 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Refuse channel_ready while the initial funding_signed is pending' (#5612)

This update fixes a corner case in the Lightning Dev Kit where a node could get confused if it received a 'channel_ready' message while still waiting for its own signer to produce the first commitment signature. The patch makes the node re…

State-machine confusion between funding_signed and channel_ready in async signer flowPremature channel_ready could advance counterparty_next_commitment_point before initial commitment is signedPatch closes channel rather than allowing inconsistent commitment state
d68d2235by Matt Corallo+101−12 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityMerge PR 'LSPS2: Release pruned pending requests from the total limit' (#5672)by Matt Corallo · 83c2cf8b · Nov 19, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'LSPS2: Release pruned pending requests from the total limit' (#5672)

from auto-pr-bot/bot/294-lsps2-total_pending_requests-not-fcf06e into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5672
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Ignore push_msat balances on closed unfunded inbound channels' (#5669)by Matt Corallo · 115a1362 · Nov 19, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Ignore push_msat balances on closed unfunded inbound channels' (#5669)

from auto-pr-bot/bot/258-unfunded-inbound-channels-with-p-b03cce into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5669
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Document when a `PaymentId` may be reused' (#5635)by Matt Corallo · 37589b57 · Nov 19, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Document when a `PaymentId` may be reused' (#5635)

from document-payment-id-reuse into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5635
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Release disconnected descriptors from blocked gossip queue' (#5653)by Matt Corallo · 3a3043de · Nov 19, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Release disconnected descriptors from blocked gossip queue' (#5653)

from bot/5626-release-disconnected-descriptors-233ea1 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5653
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityFix over-estimate of path max contribution with >= 100% feesby auto-pr-bot · b0b3ade6 · Nov 19, 2026 · 1 fileMessage 83 · StrongTriage 5Details
Commit message · auto-pr-bot

Fix over-estimate of path max contribution with >= 100% fees

@val wrote:

> The formula computing the maximum value a path can contribute to the
> final value received by the payee used to assume the aggregated
> proportional fee of the hops following a given hop was below 100%.
> Invoice hints (and blinded paths) may carry arbitrary fees, and with an
> aggregate proportional fee of 100% or more the computed maximum
> overshot the true one by 1 msat, building paths that exceed a hop's
> available liquidity (and panicking in debug builds). [...]

@val asked:

> @auto-pr-bot please open a PR to address this issue

209cb2aa2e0d67bf89a130b070f7116178e9ddb4 computed the maximum as
ceil(((max - agg_base) * 1_000_000) / (1_000_000 + agg_prop)) via the
(a + b - 1) / b idiom, and 7ebdf45b3 switched it to floor by dropping
only the `+ 1_000_000 - 1` term. That left `+ agg_prop` in the numerator,
computing floor((a + agg_prop) / (1_000_000 + agg_prop)) instead, which
overshoots the intended floor by 1 whenever a mod (1_000_000 + agg_prop)
is at least 1_000_000. Invoice route hints can carry proportional fees of
100% or more, which makes that remainder reachable and the resulting
1-msat overshoot builds paths exceeding a hop's available liquidity,
tripping the `used_liquidity_msat <= hop_max_msat` debug assertion.

Drop the stray term so we compute the floor the comment describes. A
floor cannot overshoot the true maximum even though hop fees are rounded
up with ceil: any f satisfying f * (1_000_000 + agg_prop)
<= (max - agg_base) * 1_000_000 also satisfies
f + ceil(f * agg_prop / 1_000_000) <= max - agg_base.

Add a regression test, contributed by @val in the issue, which panics in
debug builds without the fix.

Requested-by: @val
Authored-By: matt/GLM-5.3-Flash-GGUF:Q4_K_XL <goose@users.noreply.local>

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
fuzzing or regression evidence
Security candidateMerge PR 'Refuse to persist fresh monitors that alias archived monitors' (#5645)by Matt Corallo · 3c606c11 · Nov 18, 2026 · 2 filesMessage 81 · StrongModerate 54Details
Commit message · Matt Corallo

Merge PR 'Refuse to persist fresh monitors that alias archived monitors' (#5645)

from bot/5631-prevent-monitors-from-aliasing-w-ff2601 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5645
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
boot or update pathmerge-commit duplicate discount
AI analysis · Moderate 54/100

This change prevents a Lightning node from accidentally overwriting an archived copy of a channel's security monitor with a brand-new one that happens to use the same identifier. In the old code, if a new channel reused the same identifier as a previously closed and archived channel, the new monitor could be saved on top of the archived one. Later, when the new channel closed, its archived copy would overwrite the old archived copy, permanently destroying the historical record needed to detect cheating or recover funds. The fix makes the node refuse to save a new monitor when an archived one already exists under the same key, leaving the new channel 'stuck' instead of silently destroying data. This is a safety improvement rather than a remote-exploitable bug.

Security candidateMerge PR 'Handle fee multiplication overflow when merging MPP paths' (#5288)by Matt Corallo · 25f8a740 · Nov 18, 2026 · 1 fileMessage 86 · StrongModerate 52Details
Commit message · Matt Corallo

Merge PR 'Handle fee multiplication overflow when merging MPP paths' (#5288)

from bot/5191-handle-fee-multiplication-overfl-b098ce into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5288
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

86/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
memory safetymerge-commit duplicate discount
AI analysis · Moderate 52/100

This change fixes a place in the Lightning payment routing code where adding up fees could overflow the maximum number a computer can store in a 64-bit integer. Previously, the code assumed this could never happen and would crash (panic) if it did. The patch now detects the overflow, returns an error value, and safely skips or keeps the affected payment path instead of crashing. It also prevents a path from being left half-updated if the fee recalculation fails.

Lower-priorityMerge PR 'Cap onion message buffering for unconnected peers at half the total' (#5644)by Matt Corallo · d4649e73 · Nov 18, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Cap onion message buffering for unconnected peers at half the total' (#5644)

from bot/5639-onion-message-replies-to-made-up-0ec825 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5644
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Reject keysend payments carrying payment_metadata' (#5623)by Val Wallace · 584c1774 · Nov 18, 2026 · 4 filesMessage 81 · StrongTriage 0Details
Commit message · Val Wallace

Merge PR 'Reject keysend payments carrying payment_metadata' (#5623)

from bot/5615-keysends-surface-unauthenticated-9bc608 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5623
Reviewed-by: Val Wallace <val@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge PR 'Resume channels stuck awaiting a completed monitor persistence on reload' (#5610)by Matt Corallo · 11815ed1 · Nov 18, 2026 · 4 filesMessage 81 · StrongLow 43Details
Commit message · Matt Corallo

Merge PR 'Resume channels stuck awaiting a completed monitor persistence on reload' (#5610)

from bot/5603-initial-monitor-persist-completi-cc6c58 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5610
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
boot or update pathmerge-commit duplicate discount
AI analysis · Low 43/100

This commit fixes a bug where a Lightning node could get stuck after restarting. If the node crashed or restarted while it was still saving the initial channel monitor to disk, and that save later finished in another process, the restarted node would not realize the save was done. As a result, it would never broadcast the funding transaction or resume the channel, leaving funds temporarily inaccessible and the channel unusable. The fix makes the node check on reload whether the monitor persistence actually completed and, if so, resume the channel normally.

Lower-priorityCap buffering for unconnected onion message peers at half the totalby auto-pr-bot · 8e79625b · Nov 17, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · auto-pr-bot

Cap buffering for unconnected onion message peers at half the total

@matt asked:

> @auto-pr-bot please fix this issue. The suggested change looks good -
> let's just cut `MAX_TOTAL_BUFFER_SIZE` in two and only allow the first
> half for peers we aren't connected to.

The first hop of a reply is the introduction node of the reply path,
chosen by the sender of the message being replied to, and the per-peer
outbound buffer limit is keyed by that requester-chosen node id. A
requester that names a new, made-up introduction node in every reply
path is therefore limited only by `MAX_TOTAL_BUFFER_SIZE` (128 MiB),
which is shared with everything else the node sends or forwards: about
5.7 MB of invoice requests is enough to fill the buffer and block the
node's BOLT 12 invoices, its own outbound onion messages and all
forwards for 20-30 s per round.

Rather than a per-peer limit, which such a requester trivially spreads
across node ids, only allow peers we aren't connected to to consume the
first half of the total buffer. Messages the node initiates, forwards
and replies to connected peers are unaffected, and replies to an
unannounced peer that has just gone offline still wait for a
ConnectionNeeded wake-up while the budget allows.

Fixes #5639

Requested-by: @matt
Link: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/issues/5639
Authored-By: matt/GLM-5.3-Flash-GGUF:Q4_K_XL <goose@users.noreply.local>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Security candidateMerge PR 'Correct KeysManager docs on spliced channels' remote_key derivation' (#5609)by Matt Corallo · 83a4d243 · Nov 17, 2026 · 1 fileMessage 81 · StrongInformational 15Details
Commit message · Matt Corallo

Merge PR 'Correct KeysManager docs on spliced channels' remote_key derivation' (#5609)

from bot/5606-keysmanager-docs-still-say-splic-5df634 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5609
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
secret or key materialsigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This change only updates documentation and code comments in the Lightning Dev Kit library. It clarifies that a particular key-derivation setting is fixed when a channel is first opened and is not changed by splicing. No code behavior was altered, so there is no security vulnerability or fix here.

Security candidateMerge PR 'Fix DelayedPaymentKey/HtlcKey from_basepoint docs and document justice tx witness script' (#5596)by Matt Corallo · 2f832195 · Nov 17, 2026 · 2 filesMessage 81 · StrongInformational 15Details
Commit message · Matt Corallo

Merge PR 'Fix DelayedPaymentKey/HtlcKey from_basepoint docs and document justice tx witness script' (#5596)

from auto-pr-bot/bot/272-wrong-basepoint-in-delayedpaymen-236086 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5596
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathsigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only changes documentation comments in two source files. It corrects the wording of how certain public keys are derived in the Lightning protocol and adds details about which witness script a signer must use when creating justice (penalty) transactions. No code logic, function signatures, or behavior were modified.

Lower-priorityMerge PR 'Bump chacha20-poly1305 to 0.3.0' (#5625)by Matt Corallo · 39fe2ba4 · Nov 17, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Bump chacha20-poly1305 to 0.3.0' (#5625)

from bot/5620-bump-chacha20-poly1305-to-0.3.0-20190e into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5625
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Address review nits on archived monitor update cleanup' (#5550)by Matt Corallo · e13cb49b · Nov 17, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Address review nits on archived monitor update cleanup' (#5550)

from bot/5540-remove-stale-updates-when-archiv-63e222 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5550
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Keep payment retries within the original fee budget' (#5482)by Matt Corallo · 6950aeb0 · Nov 17, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Keep payment retries within the original fee budget' (#5482)

from bot/5388-keep-recipient-overpayments-insi-72185b into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5482
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge PR 'Document that TokioSpawner requires all of LDK in a tokio context' (#5621)by Matt Corallo · 6e555fa2 · Nov 17, 2026 · 1 fileMessage 81 · StrongInformational 19Details
Commit message · Matt Corallo

Merge PR 'Document that TokioSpawner requires all of LDK in a tokio context' (#5621)

from bot/5614-stashed-reads-let-any-peer-panic-d94a61 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5621
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Informational 19/100

This change only adds documentation comments to a Rust struct. It does not modify any executable code, so it cannot by itself introduce or fix a security vulnerability. The new text warns developers that using TokioSpawner incorrectly can cause their program to panic (crash) if LDK runs outside a Tokio runtime. It is a documentation-only clarification, not a code patch.

AI review queuedMerge PR 'Make custom signers verify holder commitment sigs synchronously' (#5616)by Matt Corallo · 0e3b6d33 · Nov 17, 2026 · 4 filesMessage 91 · StrongHigh 70Details
Commit message · Matt Corallo

Merge PR 'Make custom signers verify holder commitment sigs synchronously' (#5616)

from bot/5611-funding-tx-broadcast-on-invalid-c2b5de into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5616
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · High 70/100

This commit hardens how Lightning Dev Kit handles custom signing modules. Previously, LDK relied on each custom signer to check that the other party's signatures on a holder commitment transaction were valid. The change adds a ready-made verification helper and updates the documentation to make clear that signers must do this check synchronously before returning success, because LDK may immediately broadcast the funding transaction or use the commitment on force-close. It also makes LDK's built-in signer verify that the holder funding key in the channel parameters actually belongs to it before trusting signatures. The commit is defensive: it reduces the chance that a buggy or malicious custom signer accidentally accepts invalid signatures and lets LDK act on them.

Lower-priorityMerge PR 'Consolidate cancelled async event processing tests' (#5500)by Matt Corallo · 95df8916 · Nov 17, 2026 · 2 filesMessage 91 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Consolidate cancelled async event processing tests' (#5500)

from bot/5264-restore-channelmanager-event-pro-e0b16f into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5500
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Sort amount-less invoice hints by highest inbound capacity' (#5618)by Matt Corallo · e6f82b48 · Nov 17, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Sort amount-less invoice hints by highest inbound capacity' (#5618)

from bot/5607-amount-less-invoices-hint-the-3-b8d56d into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5618
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Reject legacy P2PKH/P2SH scripts in ShutdownScript::try_from' (#5619)by tnull · 018c59fd · Nov 17, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · tnull

Merge PR 'Reject legacy P2PKH/P2SH scripts in ShutdownScript::try_from' (#5619)

from bot/5608-shutdownscript-try_from-accepts-b271a7 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5619
Reviewed-by: tnull <tnull@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'bolt12: deprecate manually_handle_bolt12_invoices as of 0.3' (#5617)by Matt Corallo · ea61fb95 · Nov 17, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'bolt12: deprecate manually_handle_bolt12_invoices as of 0.3' (#5617)

from bot/4812-bolt12-partial-mpp-payment-ddcc31 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5617
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge PR 'Refuse channel_ready while the initial funding_signed is pending' (#5612)by Matt Corallo · d68d2235 · Nov 17, 2026 · 2 filesMessage 81 · StrongModerate 64Details
Commit message · Matt Corallo

Merge PR 'Refuse channel_ready while the initial funding_signed is pending' (#5612)

from auto-pr-bot/bot/268-channel_ready-before-async-fundi-11838c into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5612
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 64/100

This update fixes a corner case in the Lightning Dev Kit where a node could get confused if it received a 'channel_ready' message while still waiting for its own signer to produce the first commitment signature. The patch makes the node reject such premature messages and close the channel safely, preventing the counterparty's commitment point from advancing underneath an unsigned initial commitment.

Lower-priorityMerge PR 'Log cooperative channel closes at info rather than error' (#5544)by Matt Corallo · 03f8ed3c · Nov 16, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Log cooperative channel closes at info rather than error' (#5544)

from sovereigntechnology/log/noissue-coop-close-info into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5544
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge PR 'Reject overflowing legacy PaymentForwarded amounts' (#5316)by Matt Corallo · af91ac3f · Nov 16, 2026 · 1 fileMessage 81 · StrongLow 44Details
Commit message · Matt Corallo

Merge PR 'Reject overflowing legacy PaymentForwarded amounts' (#5316)

from bot/5244-reject-overflowing-legacy-paymen-748c1f into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5316
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
memory safetymerge-commit duplicate discount
AI analysis · Low 44/100

This change fixes a spot where two payment amounts could be added together without checking for integer overflow. In Rust, adding two large u64 numbers can wrap around to a tiny value, which could make a forwarded payment look incorrectly small. The patch now rejects the data if the addition overflows. This is a defensive fix in event deserialization/serialization logic.