Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
66/100 average clarity
496Strong · 80–100
1083Adequate · 60–79
567Thin · 40–59
151Opaque · 0–39
20security candidates with opaque commit messaging
This is a code-quality and performance improvement, not a security fix. It changes how the library adds up lists of Bitcoin amounts so that it stops early once an overflow is detected, rather than continuing to process the rest of the list…
No security-relevant signal in commit message or diffRefactor preserves overflow-checking behavior (short-circuits instead of continuing)New API method `NumOpResult::from_result` is a pure inverse of existing `into_result`
This update fixes a bug in how the library reads Bitcoin amount strings like '1.5 BTC'. Previously, certain malformed inputs such as '.', '._', '1_', '1_.0', and '1._0' were incorrectly accepted and treated as valid amounts (often zero), i…
Input validation bypass in amount parserMalformed strings silently parsed as zero or ordinary amountsUnderscore separator placement not enforced
This commit fixes a rounding bug in how the rust-bitcoin library calculates the minimum transaction weight needed to pay a given fee at a given fee rate. The old code rounded the fee rate up too early, which could produce a weight slightly…
Incorrect fee-weight calculation due to premature integer roundingPotential transaction fee shortfall when using div_by_fee_rate_ceilOverflow protection added for Amount::MAX * 4_000_000 intermediate value
This is a routine release-management commit that bumps the version number of the `bitcoin-consensus-encoding` crate from 1.2.0 to 1.3.0 and updates lock files accordingly. It contains no code changes that fix or introduce a security issue.…
This commit updates a GitHub Actions automation tool (actions/labeler) used to automatically tag pull requests with labels. It is a routine dependency version bump from 6.2.0 to 7.0.0, with no indication of a security fix or vulnerability.…
This commit is a routine update to the GitHub Actions checkout tool used by the project's automated workflows. It only changes version numbers in configuration files and does not alter the actual Bitcoin library code that users run. There …
This commit updates a GitHub Actions helper used to install a Python tool called uv, which runs the zizmor security scanner. The change only bumps the pinned version of the helper from 8.3.2 to 9.0.0. The new version's release notes mentio…
No security-relevant signals in commit or upstream release notesDependency bump in CI only, not in library codeNo CVE or advisory referenced
This is a routine Dependabot update that changes the pinned version of GitHub's official CodeQL upload-sarif action from 4.37.0 to 4.37.3 in a single CI workflow. The action only uploads static analysis results to GitHub; it does not touch…
This is a routine update to a GitHub Actions helper used to install Rust during automated testing. It only changes the pinned version of the dtolnay/rust-toolchain action in workflow files. There is no change to the actual rust-bitcoin lib…
This commit adds a way to ask, in advance, exactly how many bytes a Bitcoin block or transaction will take when serialized. It is a feature addition for the library's encoding system, not a fix for a vulnerability. There is no indication i…
No security-relevant signals in commit message or diffFeature addition: expose exact encoded sizeNo mention of vulnerability, CVE, bug bounty, or security report
This is a routine update by Dependabot that changes which version of a popular GitHub Action (dtolnay/rust-toolchain) is used to install Rust in automated CI workflows. The commit only updates pinned commit hashes in workflow files; it doe…
This is a routine patch-version update of a GitHub-maintained action used only to upload static-analysis results (SARIF files) from a scheduled CI job. The change does not touch any project source code, cryptographic logic, or user-facing …
This is a routine automated update by Dependabot that changes the pinned version of a GitHub Action used to install a Python tool called 'uv' in two workflow files. The new version is a major release of the setup-uv action itself, but the …
This commit removes the automatic `Copy` trait from several public error types in the rust-bitcoin library and updates the project's written policy to discourage `Copy` on error types. `Copy` is a Rust trait that lets values be duplicated …
API hardening: removes `Copy` from public error types to preserve future flexibilityPolicy update: docs/policy.md now explicitly discourages `Copy` on error typesNo vulnerability fix: change is defensive/preventive, not reactive to a disclosed issue
This change is a routine code cleanup, not a security fix. It moves a method that converts Bitcoin output scripts into human-readable addresses from a temporary 'extension trait' directly onto the main Address type. The actual conversion l…
This is a routine code-quality and API-expansion pull request for the rust-bitcoin library's 'units' crate. It widens some fee-rate constructors from 32-bit to 64-bit inputs, renames the old 32-bit versions, improves serde error messages, …
API surface change: new u64 fee-rate constructors return NumOpResult to prevent silent overflowRenaming of existing u32 constructors to *_u32 may break downstream callers at compile time (breaking API change)Removal of artificial restriction in from_per_vb allows larger valid inputs
This commit fixes a bug in how the library handles math errors. Previously, if you added or subtracted two values and one of them already had an error (for example, dividing by zero), the library would silently replace that original error …
Error-state information loss in arithmetic wrapper typeIncorrect error propagation could mask prior failures such as division by zeroDefensive correctness fix in numeric operation result handling
This is a routine dependency-maintenance merge that swaps out old, unmaintained helper libraries for newer, patched versions in the project's example embedded programs and benchmark harness. The changes are driven by automated security sca…
cargo audit advisory remediationdependency upgrade for known-vulnerable crate (rand 0.7 / jobserver)dependency upgrade for known-vulnerable crate (crossbeam-epoch)
This commit fixes a counting bug in a Rust Bitcoin library. The library has combined encoders that bundle multiple pieces of data together. A method called len() is supposed to report how many bytes are left to encode, but it was incorrect…
Violation of documented API contract (ExactSizeEncoder::len)Potential incorrect buffer-size or progress decisions by downstream callersComposite encoder state not fully isolated in size reporting before fix
This commit fixes a bookkeeping bug in a Rust Bitcoin library's composite encoder. The encoder is a tool that combines multiple pieces of data into a single byte stream, and it has a method that is supposed to report how many bytes are lef…
Incorrect implementation of a documented size/length contractPotential for callers to over-allocate buffers or miscompute transaction/witness sizesComposite encoder used in consensus-critical serialization paths
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
Security candidateprimitives: split TapScript and TapScriptBuf from scriptby Andrew Poelstra · 017d2c10 · Aug 22, 2025 · 16 filesMessage 65 · AdequateInformational 19Details
Commit message · Andrew Poelstra
primitives: split TapScript and TapScriptBuf from script
Last one :) next commit deletes ScriptBuf and Script.
65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Informational 19/100
This commit is a routine internal code reorganization in the rust-bitcoin library. It introduces separate type names, TapScript and TapScriptBuf, for scripts used in Taproot spending paths, replacing the more generic Script/ScriptBuf names in those places. There is no change to how Bitcoin data is parsed, validated, or serialized, and no security fix or vulnerability is described.
Security candidateprimitives: split WitnessScript and WitnessScriptBuf from scriptby Andrew Poelstra · 683d55ba · Aug 22, 2025 · 18 filesMessage 73 · AdequateInformational 19Details
Commit message · Andrew Poelstra
primitives: split WitnessScript and WitnessScriptBuf from script
Ok, after the previous huge/ugly commits, this one is pretty cathartic. I introduced the new type, used it for every field named `witness_script` and all the constructors for `WScriptHash`, chased through all the compiler bugs, and everything "just worked".
There is one oddity: in BIP143 there is a special-cased scriptcode construction used for P2SH-wrapped segwit. We have methods that compute this. To make the types line up (without introducing new traits and generics) I simply typed the special-case thing as a WitnessScript, since that's what it's pretending to be. I added a doccomment to all the methods that compute this.
This is a mild abuse of the `WitnessScript` type, since this special-case object really isn't a witness script (though you could use it as one, and trick wallets in mostly-harmless ways by doing so ... but this is a bug in Bitcoin, not in our library!). But only a mild one, and I think it does a *way* better job of guiding the user through the script-mangling weirdness around sighashes and p2sh/p2wsh wrapping.
The final tag is TapScript, which will be done in the next commit. Then I can throw away the Whatever tag, delete `Script`/`ScriptBuf`, and finally rename `GenericScript`/`GenericScriptBuf` to those names.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Informational 19/100
This commit is a large internal refactoring in the rust-bitcoin library. It introduces a new dedicated type, WitnessScript, for Segwit v0 witness scripts and uses it wherever the code previously used the generic Script type for that purpose. The change is primarily about making the type system guide users to the correct Bitcoin concepts. The commit message explicitly notes one deliberate design oddity: for BIP143 P2SH-wrapped-segwit sighash calculations, the returned object is typed as WitnessScript even though it is technically a special-case template, not a real witness script. The author calls this a 'mild abuse' and documents it. There is no bug fix for a runtime vulnerability in the diff; the security relevance is that stronger typing may help prevent future API misuse.
Security candidatebitcoin: make script::Builder genericby Andrew Poelstra · e51b5c30 · Aug 22, 2025 · 10 filesMessage 68 · AdequateInformational 18Details
Commit message · Andrew Poelstra
bitcoin: make script::Builder generic
Required updating the extension trait macro to add generics, and splitting out some methods on the Script/ScriptBuf extension traits into new GenericScript / GenericScriptBuf extension traits.
I did not do this in a principled way; I just moved the minimum set of functions I needed to make the generic script builder compile.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
cryptography-sensitive path
AI analysis · Informational 18/100
This commit is a routine internal refactoring of the Rust Bitcoin library. It makes the script-building code generic so it can work with different script type tags, but does not change what the code actually does. There is no indication this fixes a security bug or introduces a vulnerability.
Security candidatebitcoin: move hex and PSBT decoding from ScriptBufExt to GenericScriptBufExtby Andrew Poelstra · 865ca2cb · Aug 22, 2025 · 10 filesMessage 65 · AdequateInformational 15Details
Commit message · Andrew Poelstra
bitcoin: move hex and PSBT decoding from ScriptBufExt to GenericScriptBufExt
These things apply to all script buffer types and belong in the generic trait.
65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing boundarycryptography-sensitive pathsigning or wallet path
AI analysis · Informational 15/100
This is a routine internal code reorganization in the rust-bitcoin library. It moves hex decoding and PSBT serialization helpers from a trait that only applied to the standard script buffer into a more generic trait so the same helpers work with all script buffer types. There is no security fix or behavior change visible in the diff.
Security candidateprimitives: split ScriptSig and ScriptSigBuf from Script and ScriptBufby Andrew Poelstra · 3e55c526 · Aug 22, 2025 · 24 filesMessage 91 · StrongInformational 18Details
Commit message · Andrew Poelstra
primitives: split ScriptSig and ScriptSigBuf from Script and ScriptBuf
Adds an extension trait ScriptSigExt with a single method, redeem_script, which isn't used anywhere (or even tested) but seems useful enough so we'll keep it.
Regarding extension traits: annoyingly I need to add a new extension trait for every tagged script. In a sensible language I could just use the existing trait and stick `where Tag == ScriptSigTag` onto the methods that were specific to script sigs, but Rust is not sensible. It has a fractal surface area where there is no part of the syntax that you can ever understand all the rules of.
Anyway there is an 11-year-old tracking issue for this https://github.com/rust-lang/rust/issues/20041
91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Informational 18/100
This commit is a routine internal refactoring in the rust-bitcoin library. It introduces separate types for transaction input scripts (scriptSig) and other scripts, moving some helper methods between extension traits. There is no indication it fixes a security bug or changes behavior in a way that would create a vulnerability.
Security candidateprimitives: split ScriptPubKey and ScriptPubKeyBuf from generic scriptby Andrew Poelstra · c89e70e8 · Aug 22, 2025 · 32 filesMessage 85 · StrongInformational 19Details
Commit message · Andrew Poelstra
primitives: split ScriptPubKey and ScriptPubKeyBuf from generic script
There are a couple places where (in Bitcoin, not just this crate) there is confusion between scriptPubKeys and redeemScripts. Specifically, in P2SH-wrapped segwit, we put a segwit scriptpubkey into a redeemScript slot and then it must be treated as both.
The next commit will introduce the RedeemScript type and a trait that covers both RedeemScript and ScriptPubKey.
Meanwhile, there are a couple methods that belong in this trait, which in this commit I just implemented for GenericScript<T> for all T:
* in bitcoin/src/crypto/sighash.rs all the sighash methods * in primitives/src/script/mod.rs the ScriptHash constructors * in bitcoin/src/script/mod.rs for new_witness_program_unchecked * in bitcoin/src/script/borrowed.rs for all the p2sh methods * in bitcoin/src/script/owned.rs for the new_p2wpkh constructor
In the next commit we will tighten these so that they are only applicable to the two types RedeemScript and ScriptPubKey. (Really, we want to tighten them so that they're applicable only to RedeemScript and some more-specific SegwitV0ScriptPubKey type. But I think that would be a bridge too far: if we had multiple scriptpubkey types then what would we put in TxOut::script_pubkey?)
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Informational 19/100
This commit is a large internal refactoring in the rust-bitcoin library. It introduces a new dedicated type, ScriptPubKey, for the scripts that appear in transaction outputs, and updates many examples and internal functions to use it. The change is described by the author as a step toward preventing confusion between scriptPubKeys and redeemScripts. It is not a security patch for an exploitable bug; it is a type-system cleanup that may reduce future misuse but does not by itself fix any vulnerability.
Security candidateprimitives: split RedeemScript and RedeemScriptBuf from scriptby Andrew Poelstra · abf93a45 · Aug 22, 2025 · 18 filesMessage 83 · StrongLow 29Details
Commit message · Andrew Poelstra
primitives: split RedeemScript and RedeemScriptBuf from script
There were multiple places in bitcoin/src/blockdata/script/tests.rs where we were being sloppy and reinterpreting redeem scripts as witness scripts and vice-versa. I am happy to say these no longer compile :).
This completes the hard part of script tagging -- we still need to add WitnessScript and TapScript, but these are part of "modern" Bitcoin and therefore aren't randomly cast to/from other script types.
83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Low 29/100
This commit is a code-quality and type-safety refactor in the rust-bitcoin library. It introduces a dedicated RedeemScript type so that P2SH redeem scripts can no longer be accidentally confused with other script types (such as witness scripts). The change makes several previously-allowed unsafe conversions fail at compile time, which helps prevent future bugs rather than fixing an active vulnerability.
Security candidaterun cargo fmtby Andrew Poelstra · 65747aa0 · Aug 22, 2025 · 6 filesMessage 28 · OpaqueInformational 15Details
Commit message · Andrew Poelstra
run cargo fmt
28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Informational 15/100
This commit is purely a code-formatting cleanup. It runs the Rust formatter (cargo fmt) across six files, changing only whitespace, line breaks, and import order. No program logic, security behavior, or functionality was altered.
This commit fixes a programming bug where iterating over a serialized ECDSA signature would cause the program to call itself forever, eventually crashing with a stack overflow. The fix changes one line so the iterator uses the actual byte data instead of accidentally re-entering the same function. A new test was added to confirm iteration now works correctly.
Security candidatebuild(deps): bump actions/checkout from 4 to 5by dependabot[bot] · 5d3428d1 · Aug 21, 2025 · 14 filesMessage 88 · StrongInformational 15Details
Commit message · dependabot[bot]
build(deps): bump actions/checkout from 4 to 5
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/v4...v5)
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
boot or update pathdocumentation-only discountautomated dependency-update discount
AI analysis · Informational 15/100
This is a routine dependency update by Dependabot that changes the GitHub Actions 'checkout' action from version 4 to version 5 across all project workflow files. There is no indication of a security fix or vulnerability in the commit itself, and no source code affecting the Rust Bitcoin library was changed.
Security candidatefix: add all optional feature dependenciesby Nick Johnson · d39a8ac4 · Aug 19, 2025 · 1 fileMessage 90 · StrongInformational 15Details
Commit message · Nick Johnson
fix: add all optional feature dependencies
Ensure all optional feature dependencies are tested when creating the lock files. rust-bitcoin's dependency tree is so lean right now though, this is currently a no-op.
90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
boot or update path
AI analysis · Informational 15/100
This is a small change to an internal maintenance script used to generate dependency lock files for testing. It adds the '--all-features' flag so that optional features are included when checking the project against minimal and recent dependency versions. The commit message explicitly says this is currently a no-op because rust-bitcoin has very few optional dependencies. There is no indication this fixes a security vulnerability.
Security candidatefix: build Cargo-minimal.lock with min depsby Nick Johnson · 328937a5 · Aug 19, 2025 · 2 filesMessage 100 · StrongInformational 15Details
Commit message · Nick Johnson
fix: build Cargo-minimal.lock with min deps
Instead of letting minimal versions potentially drift upwards, reset the Cargo-minimal.lock file each time dependencies are updated. The new script uses a combination of the `direct-minimal-version` and `minimal-versions` flags to ensure the minimal version dependency tree is tested.
100/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
boot or update path
AI analysis · Informational 15/100
This commit is a routine build-maintenance change. It tightens how the project tests against the oldest allowed versions of its dependencies, and refreshes a checked-in lock file so those oldest versions are actually used in CI. There is no product bug fix, no change to the library code users run, and no security issue being patched.
Security candidatedocs: Add a bunch of project management docsby Tobin C. Harding · 9d118129 · Aug 19, 2025 · 6 filesMessage 100 · StrongInformational 15Details
Commit message · Tobin C. Harding
docs: Add a bunch of project management docs
Recently I hypothesised that `rust-bitcoin` needed a project manager - well here I am stepping up to the plate.
Created by going through #550, wip because I'm up to
Please review at any level, I'm open to doing anything differently as suggested.
100/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
This commit only adds and edits project planning documentation (markdown files about crate organization, roadmap, coding policy, keys/crypto, and Taproot). No source code, build scripts, tests, or dependencies were changed. There is no security-relevant behavior introduced or fixed.
Security candidateStandardize BIP notation to BIP-XXXXby jrakibi · 7664ff36 · Aug 17, 2025 · 44 filesMessage 68 · AdequateInformational 15Details
Commit message · jrakibi
Standardize BIP notation to BIP-XXXX
use consistent BIP-XXXX notation with 4-digit numbers and hyphen separators in all documentation, comments, and error messages
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Informational 15/100
This commit is a pure documentation and comment cleanup. It changes how Bitcoin Improvement Proposal (BIP) numbers are written throughout the codebase from inconsistent styles like 'BIP32', 'BIP 341', and 'BIP-32' to a uniform 'BIP-XXXX' format with four digits and a hyphen. No program logic, code behavior, or security properties were changed.
Security candidatebitcoin: remove `From<Message>` for `TapSighash`by jrakibi · 933f4c8e · Aug 17, 2025 · 4 filesMessage 68 · AdequateLow 34Details
Commit message · jrakibi
bitcoin: remove `From<Message>` for `TapSighash`
The `Message` type is specific to ECDSA and should not be used for Taproot sighashes. Taproot sighashes are just 32 bytes long. With these changes, `From<Message>` is only used for legacy and SegWit v0 sighashes, not for Taproot
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Low 34/100
This commit removes a convenience conversion that let developers accidentally treat a Taproot transaction digest as an ECDSA-style message. It is a defensive API cleanup: it makes the library's types more precise so users cannot pass a Taproot sighash through an ECDSA-specific wrapper. There is no direct bug being fixed, but the change prevents a class of future misuse where a Taproot signature could be computed over a wrongly-wrapped hash.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Informational 15/100
This commit is a routine automated code-formatting run using the nightly version of rustfmt. It only changes whitespace, line breaks, import order, and comment alignment across 19 files. No program logic, security behavior, or API semantics were altered.
Security candidateFix overflow bug in `Weight` constructorsby Shing Him Ng · aa086a0a · Aug 16, 2025 · 1 fileMessage 73 · AdequateLow 38Details
Commit message · Shing Him Ng
Fix overflow bug in `Weight` constructors
This fixes an overflow bug which occured when these constructors were used to construct a `Weight` of max value. Since `Weight` is a `u64` under the hood, the constructors panicked during the attempt to add to the max weight value
73/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
Why it was queued
memory safety
AI analysis · Low 38/100
This commit fixes a panic (crash) in two Bitcoin weight-unit conversion helpers when they are called on the maximum possible weight value. The functions now use saturating addition, so instead of overflowing and crashing they return a large but valid rounded-up result. This is a reliability fix that prevents denial-of-service-style crashes from untrusted inputs.
Add a bunch of imports and make usage more terse with no loss of clarity.
Internal change only, no logic change.
60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100
This commit is a cosmetic code cleanup in the rust-bitcoin library. It replaces fully written-out module paths (like `crate::Txid`) with shorter imported names (like `Txid`) in the PSBT error definitions. The commit message and diff show no functional changes—only style improvements.
Security candidateFix overflow during *_ceil FeeRate conversionsby Shing Him Ng · dc2de6ad · Aug 12, 2025 · 1 fileMessage 85 · StrongLow 38Details
Commit message · Shing Him Ng
Fix overflow during *_ceil FeeRate conversions
This fixes an overflow bug which occured when these ceil functions were called on `FeeRate::MAX`, which is u64::MAX under the hood. This resulted in the function panicking due to an overflow since part of the ceil operation involves adding to the FeeRate before dividing by the appropriate unit. By calling `saturating_add` instead of using `+`, this prevents the function from panicking while preserving the expected behavior when converting `FeeRate`s that would have previously overflowed
85/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Names security-relevant behavior explicitly
Why it was queued
memory safety
AI analysis · Low 38/100
This commit fixes a bug in the rust-bitcoin library where three fee-rate conversion functions would crash when given the maximum possible fee rate. The functions round fee rates up to different units, and internally they added a small number before dividing. When the input was the maximum value (the largest 64-bit unsigned integer), that addition overflowed and caused a panic. The fix uses saturating addition, which caps the value instead of overflowing, so the functions now return a sensible result rather than crashing.
Security candidatehashes: Remove code deprecated in 0.15.0by Tobin C. Harding · d1595876 · Aug 11, 2025 · 7 filesMessage 80 · StrongInformational 19Details
Commit message · Tobin C. Harding
hashes: Remove code deprecated in 0.15.0
Policy is to keep deprecated stuff for two releases. We have released 0.16.0 already so we can remove stuff deprecated in 0.15.0 (assuming 0.17.0 is out next).
Furthermore this assists with the `primitives` stable release because it removes `FromSliceError` from the API of crates that call public macros across crate boundaries from `hashes`.
80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
cryptography-sensitive path
AI analysis · Informational 19/100
This commit removes old, deprecated functions from the rust-bitcoin `hashes` crate that were marked for removal two releases ago. It is a routine cleanup change: it deletes functions like `from_slice`, `const_hash`, and `as_u64` that users were already warned not to use, and switches internal code to use the newer replacements. There is no bug fix or security patch here.
✓ Subject identifies a change! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
signing boundarysigning or wallet pathdocumentation-only discount
AI analysis · Informational 15/100
This commit fixes a single spelling mistake ('spilt' to 'split') in a project planning document. It does not change any code, configuration, or security behavior.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100
This commit is a routine automated code-formatting run by the rustfmt tool. It only changes whitespace, import order, line breaks, and brace placement. There are no functional changes, bug fixes, or security-related alterations.
When cargo-public-api releases a new version with a super new nightly requirement it breaks our CI for not a lot of added value. Lets pin the version and go right ahead and remember to update `cargo-public-api` at some stage.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
access controldocumentation-only discount
AI analysis · Informational 15/100
This commit pins the version of a CI tool (cargo-public-api) used to check whether the project's public programming interface has changed. It is a build-maintenance change to prevent unexpected CI failures when the tool releases new versions requiring newer Rust compilers. There is no security issue in the code change itself.
✓ Subject identifies a change! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100
This commit fixes a typo in a code comment, changing 'Porallel' to 'Parallel'. It does not change any executable code, logic, or behavior. There is no security impact.
Security candidaterustdoc: Do not use Createsby Tobin C. Harding · 3905871a · Aug 7, 2025 · 13 filesMessage 60 · AdequateInformational 15Details
Commit message · Tobin C. Harding
rustdoc: Do not use Creates
Policy here is to use 'Constructs' instead of 'Creates' - it doesn't matter but we chose one - lets stick to it.
60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Informational 15/100
This commit only changes documentation wording in source code comments, replacing the word 'Creates' with 'Constructs' across 13 files to match the project's style policy. No program logic, behavior, or security properties were modified.
