AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 15 Bitcoin

Merge rust-bitcoin/rust-bitcoin#7039: primitives: Fix daily Miri cron failures with measured test gating

Public commit record

What the developer wrote

Authored by Andrew Poelstra

91/100 · Strong
Merge rust-bitcoin/rust-bitcoin#7039: primitives: Fix daily Miri cron failures with measured test gating

2c096d0b41b8da11e4909186ecaa8282330cf06f primitives: Gate Miri tests by measured cost, not buffer size (bytescape30)

Pull request description:

Close #6982

This PR gates Miri tests by their measured cost under Miri instead of by buffer size:

#[cfg_attr(miri, ignore)] is already an established pattern in this crate for exactly this situation

<details><summary>Measurements</summary>

| Test | Wall time | Peak RSS | Gated |
|---|---|---|---|
| `decode_max_serialized_size` | ~51-54 min | ~1.66 GB | yes |
| `block_decoder_rejects_aggregate_weight_over_limit` | ~2.7 s | ~305 MB | **no** |
| `accept_transaction_at_maximum_block_weight` | ~57-62 s | ~760-822 MB | yes |
| `reject_transaction_exceeding_maximum_block_weight` | ~59-62 s | ~616-665 MB | yes |
| `decode_rejects_witness_over_limit_due_to_aggregate_data` | ~5.1-5.3 min | ~1.34-1.38 GB | yes |
| `decode_rejects_witness_over_limit_due_to_prefix_overhead` | >12 h (killed) | not measured | yes |
| `block_rejects_oversized_trailing_coinbase_witness_item` | ~54.8 min | ~1.56 GB | yes |
| `compute_wtxid_commits_to_oversized_witness_elements` | ~4.8 min | ~290 MB | **no** |

</details>


ACKs for top commit:
satsfy:
ACK 2c096d0b41b8da11e4909186ecaa8282330cf06f
tcharding:
ACK 2c096d0b41b8da11e4909186ecaa8282330cf06f
apoelstra:
ACK 2c096d0b41b8da11e4909186ecaa8282330cf06f; successfully ran local tests
Kixunil:
ACK 2c096d0b41b8da11e4909186ecaa8282330cf06f


Tree-SHA512: 6398d9004a0212ded0b4bd0d1ae067c5ebc0c07b41376adbcec37a316bc4202505ebfe27f018ab5a80a428030db930b3bf96bef983a46b3416a2dc592e78ac2c
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This change only adds `#[cfg_attr(miri, ignore)]` annotations to a handful of slow unit tests so they are skipped when run under Miri, a Rust interpreter used for detecting undefined behavior. It does not change any production code, consensus logic, or public APIs. The purpose is to stop daily automated Miri CI jobs from timing out or being killed due to extremely long-running tests. There is no security impact on users of the library.

Recommended action

No security action required. Treat as a normal test/CI maintenance change.

Security signals we found

No strong security signals were identified.

Risk score

Why this scored 15/100

Our methodology →
Potential impact 0/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 0/15
Confidence 10/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.