Public commit record
76/100 · Adequate
What the developer wrote
Authored by jrakibi
hashes: remove unused bench files
These `benches.rs` files were left behind when benchmarks were migrated
to Criterion in #5012. they are not run and duplicate the Criterion benchmarks in
`benches`
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
What changed, and why it matters
This commit simply deletes five old benchmark test files that were accidentally left behind after benchmarks were moved to a newer testing framework. It removes unused code and has no effect on the actual Bitcoin hashing library or its users.
Recommended action
No security action needed. This is a routine code-cleanup commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit removes legacy benches.rs files under hashes/src/{ripemd160,sha1,sha256,sha3_256,sha512}/. These files used the deprecated nightly-only test::Bencher framework and were superseded by Criterion benchmarks in PR #5012. The deletion is a cleanup change with no functional code modifications.
Changed components
Not specified
Inspect captured patch +0 / −165
diff --git a/hashes/src/ripemd160/benches.rs b/hashes/src/ripemd160/benches.rs
deleted file mode 100644
index cb023a93..00000000
--- a/hashes/src/ripemd160/benches.rs
+++ /dev/null
@@ -1,33 +0,0 @@
-use test::Bencher;
-
-use crate::{ripemd160, Hash, HashEngine};
-
-#[bench]
-pub fn ripemd160_10(bh: &mut Bencher) {
- let mut engine = ripemd160::Hash::engine();
- let bytes = [1u8; 10];
- bh.iter(|| {
- engine.input(&bytes);
- });
- bh.bytes = bytes.len() as u64;
-}
-
-#[bench]
-pub fn ripemd160_1k(bh: &mut Bencher) {
- let mut engine = ripemd160::Hash::engine();
- let bytes = [1u8; 1024];
- bh.iter(|| {
- engine.input(&bytes);
- });
- bh.bytes = bytes.len() as u64;
-}
-
-#[bench]
-pub fn ripemd160_64k(bh: &mut Bencher) {
- let mut engine = ripemd160::Hash::engine();
- let bytes = [1u8; 65536];
- bh.iter(|| {
- engine.input(&bytes);
- });
- bh.bytes = bytes.len() as u64;
-}
diff --git a/hashes/src/sha1/benches.rs b/hashes/src/sha1/benches.rs
deleted file mode 100644
index fcf2518d..00000000
--- a/hashes/src/sha1/benches.rs
+++ /dev/null
@@ -1,33 +0,0 @@
-use test::Bencher;
-
-use crate::{sha1, Hash, HashEngine};
-
-#[bench]
-pub fn sha1_10(bh: &mut Bencher) {
- let mut engine = sha1::Hash::engine();
- let bytes = [1u8; 10];
- bh.iter(|| {
- engine.input(&bytes);
- });
- bh.bytes = bytes.len() as u64;
-}
-
-#[bench]
-pub fn sha1_1k(bh: &mut Bencher) {
- let mut engine = sha1::Hash::engine();
- let bytes = [1u8; 1024];
- bh.iter(|| {
- engine.input(&bytes);
- });
- bh.bytes = bytes.len() as u64;
-}
-
-#[bench]
-pub fn sha1_64k(bh: &mut Bencher) {
- let mut engine = sha1::Hash::engine();
- let bytes = [1u8; 65536];
- bh.iter(|| {
- engine.input(&bytes);
- });
- bh.bytes = bytes.len() as u64;
-}
diff --git a/hashes/src/sha256/benches.rs b/hashes/src/sha256/benches.rs
deleted file mode 100644
index f6e270d9..00000000
--- a/hashes/src/sha256/benches.rs
+++ /dev/null
@@ -1,33 +0,0 @@
-use test::Bencher;
-
-use crate::{sha256, Hash, HashEngine};
-
-#[bench]
-pub fn sha256_10(bh: &mut Bencher) {
- let mut engine = sha256::Hash::engine();
- let bytes = [1u8; 10];
- bh.iter(|| {
- engine.input(&bytes);
- });
- bh.bytes = bytes.len() as u64;
-}
-
-#[bench]
-pub fn sha256_1k(bh: &mut Bencher) {
- let mut engine = sha256::Hash::engine();
- let bytes = [1u8; 1024];
- bh.iter(|| {
- engine.input(&bytes);
- });
- bh.bytes = bytes.len() as u64;
-}
-
-#[bench]
-pub fn sha256_64k(bh: &mut Bencher) {
- let mut engine = sha256::Hash::engine();
- let bytes = [1u8; 65536];
- bh.iter(|| {
- engine.input(&bytes);
- });
- bh.bytes = bytes.len() as u64;
-}
diff --git a/hashes/src/sha3_256/benches.rs b/hashes/src/sha3_256/benches.rs
deleted file mode 100644
index afefdcb7..00000000
--- a/hashes/src/sha3_256/benches.rs
+++ /dev/null
@@ -1,33 +0,0 @@
-use test::Bencher;
-
-use crate::{Hash, HashEngine};
-
-#[bench]
-pub fn sha3_256_10(bh: &mut Bencher) {
- let mut engine = crate::sha3_256::Hash::engine();
- let bytes = [1u8; 10];
- bh.iter(|| {
- engine.input(&bytes);
- });
- bh.bytes = bytes.len() as u64;
-}
-
-#[bench]
-pub fn sha3_256_1k(bh: &mut Bencher) {
- let mut engine = crate::sha3_256::Hash::engine();
- let bytes = [1u8; 1024];
- bh.iter(|| {
- engine.input(&bytes);
- });
- bh.bytes = bytes.len() as u64;
-}
-
-#[bench]
-pub fn sha3_256_64k(bh: &mut Bencher) {
- let mut engine = crate::sha3_256::Hash::engine();
- let bytes = [1u8; 65536];
- bh.iter(|| {
- engine.input(&bytes);
- });
- bh.bytes = bytes.len() as u64;
-}
diff --git a/hashes/src/sha512/benches.rs b/hashes/src/sha512/benches.rs
deleted file mode 100644
index 56b71800..00000000
--- a/hashes/src/sha512/benches.rs
+++ /dev/null
@@ -1,33 +0,0 @@
-use test::Bencher;
-
-use crate::{sha512, Hash, HashEngine};
-
-#[bench]
-pub fn sha512_10(bh: &mut Bencher) {
- let mut engine = sha512::Hash::engine();
- let bytes = [1u8; 10];
- bh.iter(|| {
- engine.input(&bytes);
- });
- bh.bytes = bytes.len() as u64;
-}
-
-#[bench]
-pub fn sha512_1k(bh: &mut Bencher) {
- let mut engine = sha512::Hash::engine();
- let bytes = [1u8; 1024];
- bh.iter(|| {
- engine.input(&bytes);
- });
- bh.bytes = bytes.len() as u64;
-}
-
-#[bench]
-pub fn sha512_64k(bh: &mut Bencher) {
- let mut engine = sha512::Hash::engine();
- let bytes = [1u8; 65536];
- bh.iter(|| {
- engine.input(&bytes);
- });
- bh.bytes = bytes.len() as u64;
-}
Risk score
Our methodology →Why this scored 15/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.