Merge rust-bitcoin/rust-bitcoin#7197: ci: bump rbmt to 0.5.5 and fail API job on private dep leak
What changed, and why it matters
This is a build-system improvement, not a code change. It updates a CI helper tool and makes the automated API-checking job fail if a private internal crate accidentally becomes part of the public API. That prevents future leaks of internal implementation details but does not fix any currently exploitable bug.
No immediate action required. Treat as a routine hardening change. Ensure the rbmt 0.5.5 upgrade does not break existing CI jobs before merging.
Security signals we found
CI guardrail added to prevent private dependency leaks into stable crate public APIs
Tool bump enables detection of re-exported private dependencies
No source-code vulnerability is patched
Evidence from the diff
The commit bumps the workspace’s cargo-rbmt version from 0.5.4 to 0.5.5 and adds a step in .github/workflows/rust.yml that fails the API job when cargo rbmt api exits with code 1 (tool error) or 3 (private dependency leak), while still allowing exit code 2 (API diff) to pass. The rbmt 0.5.5 release adds detection of re-exports of private dependencies. This is purely a CI/guardrail change; no Rust source code is modified.
Changed components
.github/workflows/rust.ymlCargo.toml workspace metadatacargo-rbmt CI toolingInspect captured patch +7 / −1
### .github/workflows/rust.yml
@@ -117,6 +117,12 @@ jobs:
with:
name: api-diff
path: api-diff
+ # `cargo rbmt api` exits with 0 on no API change, 1 on a tool error, 2 on an API diff and 3
+ # on a private dependency leak. 0 and 2 should pass the job, 1 (error) and 3 (private
+ # dependency leak) should fail.
+ - name: "Fail on private dependency leak"
+ if: steps.api_check.outputs.exit_code != '0' && steps.api_check.outputs.exit_code != '2'
+ run: exit 1
Bench:
runs-on: ubuntu-24.04
### Cargo.toml
@@ -4,7 +4,7 @@ exclude = ["benches"]
resolver = "2"
[workspace.metadata]
-rbmt.version = "0.5.4"
+rbmt.version = "0.5.5"
rbmt.lock.lockfiles = ["minimal", "recent"]
rbmt.toolchains.nightly = "nightly-2026-11-07"
rbmt.toolchains.stable = "1.99.1"Why this scored 18/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.