AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 18 Bitcoin

Merge rust-bitcoin/rust-bitcoin#7197: ci: bump rbmt to 0.5.5 and fail API job on private dep leak

Public commit record

What the developer wrote

Authored by Andrew Poelstra

91/100 · Strong
Merge rust-bitcoin/rust-bitcoin#7197: ci: bump rbmt to 0.5.5 and fail API job on private dep leak

40ac950acb35ca14e72f45afc3fd2746ed6f95c9 ci: fail API job on private dependency leak (satsfy (Renato Britto))
892bc18ca783fc084f22eb0dfeafb22e65fd2fd8 ci: bump cargo-rbmt to 0.5.5 (satsfy (Renato Britto))

Pull request description:

Closes #3849.

The issue asks for a CI job that greps the API text files to prove nothing from `internals` is in the public API of a stable crate. `cargo rbmt api` now does that check with no effort on our part, through `private = ["bitcoin_internals"]` in each stable crate, so the grep is not needed.

By bumping to rbmt to 0.5.5, we also catch re-exports (new feature). However, it has various exit codes: exit code 1 is a literal error with rbmt binary, 2 is API diff, and 3 is a private dependency leak. An exit code 2 is an API diff, so it should not fail the job, but 1 and 3 should cause the job to fail, which the rust.yml change does here.


ACKs for top commit:
tcharding:
ACK 40ac950acb35ca14e72f45afc3fd2746ed6f95c9
apoelstra:
ACK 40ac950acb35ca14e72f45afc3fd2746ed6f95c9; successfully ran local tests


Tree-SHA512: 8f28a32f1d3d11a65665cf0fbc0ee6ccd78c8aa9d43e41b436ab6c56a025c6c8783da4f0efa9e22fadb07ddf77d2c3662152c30c6174ef9a1cf7b0e937976371
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This is a build-system improvement, not a code change. It updates a CI helper tool and makes the automated API-checking job fail if a private internal crate accidentally becomes part of the public API. That prevents future leaks of internal implementation details but does not fix any currently exploitable bug.

Recommended action

No immediate action required. Treat as a routine hardening change. Ensure the rbmt 0.5.5 upgrade does not break existing CI jobs before merging.

Security signals we found

01

CI guardrail added to prevent private dependency leaks into stable crate public APIs

02

Tool bump enables detection of re-exported private dependencies

03

No source-code vulnerability is patched

Risk score

Why this scored 18/100

Our methodology →
Potential impact 2/30
Exploitability 0/25
Stealth signal 1/15
Affected reach 1/15
Confidence 9/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.