rust-bitcoin

This commit adds a safety check in the rust-bitcoin library so that when a Bitcoin transaction is being decoded, the total value of all its outputs is rejected if it exceeds the protocol's maximum allowed money supply (MAX_MONEY). This prevents a class of bugs similar to the historic Bitcoin Core overflow issue referenced as CVE-2010-5139, where an impossibly large total output value could cause incorrect accounting or consensus problems.

This change only touches an example program used for documentation and CI demos. It makes the seed argument optional by providing a documented default value. There is no security issue: the seed was already hard-coded in the comment above, and the example is not production code.

This commit only fixes compiler lint warnings. It adds missing feature gates so that test code compiles cleanly when certain optional features are enabled or disabled. There is no change to runtime behavior, no bug fix, and no security relevance.

This commit simply deletes five old benchmark test files that were accidentally left behind after benchmarks were moved to a newer testing framework. It removes unused code and has no effect on the actual Bitcoin hashing library or its users.

This commit is a documentation-only cleanup. It fixes spelling mistakes, grammar, and typos in code comments, README files, and rustdoc strings. No executable code, logic, or security behavior was changed.

This commit fixes a bug in a 256-bit unsigned integer multiplication routine used by the Rust Bitcoin library. The old code produced wrong multiplication results and failed to detect when the result exceeded 256 bits. Because this arithmetic is used in Bitcoin's difficulty retargeting calculations, incorrect results could theoretically lead to wrong difficulty estimates, though the practical attack path is limited.

This commit adds a faster way to calculate SHA-256 hashes on modern 64-bit ARM processors (like Apple's M chips, AWS Graviton, and recent smartphones) by using built-in CPU instructions called ARM SHA2 crypto extensions. It mirrors an earlier change that did the same thing for x86 processors. There is no indication in the commit that this fixes a security bug; it is a performance improvement.

This commit is a routine feature addition to the Rust Bitcoin library. It introduces a new ExactSizeEncoder trait that lets callers ask fixed-size encoders how many bytes they will produce, and adds an ExactSizeIterator implementation for the byte iterator. There is no security fix or vulnerability here; it is purely an API enhancement with tests.

This commit adds a safety check in the rust-bitcoin library so that when a Bitcoin transaction is being decoded, it is rejected if it tries to spend the same coin twice within the same transaction. This prevents a known bug class (CVE-2018-17144) where duplicate inputs could cause nodes to crash or accept invalid transactions. The change also updates existing tests that accidentally used duplicate inputs.

This commit adds a Rust compiler annotation called #[track_caller] to a single function. It does not change what the program does, how it validates inputs, or how it handles errors. It only improves the quality of panic messages so that if the function panics, the reported error location points to the caller's code rather than inside this library function. There is no security fix here.

This commit fixes example code and a test helper that builds Bitcoin Taproot script-path witness data. The old code placed digital signatures in the wrong order on the transaction witness stack, following the order of an internal sorted map instead of the reverse order required by the Bitcoin Taproot specification (BIP-0342). A transaction finalized with the old ordering would be rejected by the Bitcoin network, so no funds could be stolen, but users copying the example could produce invalid transactions. The fix reads public keys from the script in their actual script order, then pushes the matching signatures in reverse.

This commit only changes test code. It replaces the use of an external random number generator (from the `rand` crate) with a small, deterministic pseudo-random number generator inside the `MerkleBlock` unit tests. The goal is to make the tests reproducible and remove a test-only dependency on the `rand` feature. There is no change to production code and no security vulnerability is introduced or fixed.

This commit is a documentation and test fix, not a security patch. It adds a comment explaining that an 'empty coinbase' helper produces a 0-byte scriptSig that is technically invalid under Bitcoin consensus rules (which require 2-100 bytes), but is kept for backward compatibility in PSBT workflows where the scriptSig is filled in later. It also re-enables and updates a previously ignored unit test to use a valid 2-byte coinbase scriptSig.

This commit is a routine version bump for a small Rust library called bitcoin-io, from version 0.3.0 to 0.4.0-rc.0. It updates lockfiles, a changelog, and dependency references in other crates so they all use the new version. There is no code change and no security issue visible in the commit.

This commit is purely a code-formatting cleanup. It runs the project's formatter across 58 files, adjusting whitespace, line breaks, import order, and adding two missing semicolons the formatter exposed. There are no functional code changes, no bug fixes, and no security-relevant alterations.

This is a routine Rust API improvement that lets two small data types be copied implicitly instead of requiring an explicit clone. It does not fix a security bug and does not introduce an obvious vulnerability.

This commit simply renames a local variable from 'rinsed' to 'roundtrip' in several test files. It is a cosmetic code cleanup with no functional changes and no security relevance.

This commit only removes documentation sections from README files in multiple Rust packages. It deletes redundant mentions of the minimum Rust version and licensing information, which are already present in the package manifest files. There are no code changes, no functional changes, and no security implications.

This commit changes version constraints for several in-development (release candidate) internal dependencies so Cargo will use an exact version rather than automatically picking a newer release candidate. It is a build/maintenance change to prevent unexpected dependency resolution, not a fix for a security vulnerability.

This commit changes a single version requirement in a Rust package file so that a pre-release dependency is pinned to an exact version rather than allowing newer release-candidate versions. It is a build-stability fix, not a security patch. There is no code change that fixes a vulnerability or changes runtime behavior.

This commit is a code-quality cleanup, not a security fix. It adds a `let _ = w[15];` line in two SHA hashing implementation files solely to silence a new Rust clippy lint about an unused assignment inside a macro on the final round of SHA-256 and SHA-512. The generated machine code and behavior are unchanged.

This commit is a routine code reorganization. It moves a helper macro that generates standard methods for array-like types from the main `bitcoin` crate into the shared `internals` crate. The goal is to let other crates (specifically `p2p`) use the macro without depending directly on `bitcoin`. The generated behavior is essentially unchanged, though a couple of deprecated `to_bytes` methods are moved from the macro into individual type definitions.

This commit fixes two typos in documentation comments. One incorrectly called a private key type an 'extended public key,' and another incorrectly referenced a different struct name in a conversion function's doc comment. These are purely cosmetic comment corrections and do not change any executable code.

This commit is a large but purely cosmetic code cleanup in the Rust Bitcoin library. It removes wildcard imports of error types (like `use Error::*`) and replaces them with explicit `Self::Variant` or fully-qualified names. The behavior of the code does not change; it only makes the source code easier to read and maintain.

This commit only reformats source code using the Rust formatter (cargo fmt). It changes whitespace, line breaks, and import grouping but does not alter program logic, behavior, or any security checks. There is no security issue.