rust-bitcoin

This commit is a code-quality and linting cleanup for the `hashes` crate in rust-bitcoin. It moves the crate to use shared workspace lint rules, adds clippy allow attributes, fixes minor style issues (semicolons, doc formatting, import lists), and adds documentation comments. There are no functional changes to hash algorithms or public APIs, and no security bug is introduced or fixed.

This commit simply moves an existing internal Rust macro from one file to another shared location. The code itself is unchanged; it is a pure refactoring to prepare for splitting a crate. There is no security-relevant change.

This commit only changes the wording and formatting of documentation comments at the top of seven source files. It makes crate header titles uniform by adding '#' markers and adjusting capitalization. There are no code changes, no security fixes, and no behavior changes.

This commit only changes two words in code comments, replacing 'Creates' with 'Constructs' in documentation. There is no change to actual program logic, no security fix, and no behavior change.

This is a tiny documentation-style change to an example file. It swaps one way of saying 'use the Bitcoin main network' for another equivalent way, with no effect on actual code behavior or security.

This commit is a routine internal cleanup in the rust-bitcoin library. It swaps one hex-decoding helper for another equivalent one so the library no longer depends on an 'unstable' public API from a dependency. There is no indication this fixes a security bug or changes behavior visible to users in a dangerous way.

This commit swaps out an unstable, experimental hex-decoding helper for a stable, project-owned one. It is a cleanup/refactoring change to keep the public API from depending on a crate version that is not yet finalized. There is no direct security bug being fixed; the main risk is that if done incorrectly, error handling could change slightly for users parsing hex strings.

This commit only moves existing code around in the same file. It takes several implementation blocks for the Hmac type and places them directly below the Hmac struct definition instead of further down after another struct. No code behavior, logic, or public interface was changed.

This commit simply moves existing code around in two files. It relocates the implementation blocks for SHA256 and SipHash24 hash types to appear earlier in their respective files, right after the hash type is declared. No code behavior was changed, no bugs were fixed, and no security issues were introduced.

This is a routine API cleanup, not a security fix. The change removes the requirement for callers to supply their own random number generator when creating a new keypair. Instead, the function now creates the generator internally, matching how the related PrivateKey API already works. There is no vulnerability here; it is a convenience and consistency change.

This commit creates a brand-new, empty placeholder crate named 'bitcoin-key-expression' inside the rust-bitcoin workspace. It contains no code, no logic, and no changes to existing behavior. It is purely a structural preparation step for future development.

This commit is a routine API cleanup, not a security fix. It changes one function so it takes its input by value instead of by reference, matching normal Rust conventions for small copyable types. There is no bug being fixed and no security relevance stated.

This commit is a small API cleanup in a Rust Bitcoin library. It changes one constructor so callers must provide a 'parity' value directly instead of setting it afterward. Existing callers are updated to preserve the same behavior as before. There is no indication this fixes a security bug or changes any security-relevant behavior.

This commit only lowers the minimum required version of a small helper crate called `cpufeatures` in a lockfile used for testing the oldest supported dependency versions. It is a routine housekeeping change with no security relevance.

This commit is a performance optimization for the finalization step of several cryptographic hash functions (RIPEMD-160, SHA-1, SHA-256, SHA-512). It rewrites how padding bytes are added so the code writes directly into an internal buffer instead of calling the general input() function multiple times. The commit message and diff show only speed improvements; there is no indication of a security fix or behavior change in the hash output.

This commit simply removes unused `cmp` (comparison) imports from five hash algorithm files in the `hashes` crate. It is a cleanup change with no functional effect and no security relevance.

This commit is a routine automated code-formatting run by the rustfmt tool. It only changes whitespace, import order, line breaks, and other stylistic details across 23 files. No program logic, algorithms, or security-sensitive behavior was altered.

This commit only adds new test data and test code. It imports official NIST cryptographic test vectors for several hash algorithms and writes tests that compare the library's output against those known correct answers. There is no change to the actual hashing code, no bug fix, and no security-relevant behavior change.

This is a routine code cleanup in the project's hash functions. A single-block helper was renamed and adjusted so it can later accept multiple blocks at once. The actual hashing math and behavior are unchanged, and the commit message explicitly says it is only refactoring with no logic changes.

This is a routine internal code cleanup in the project's hash-function code. It changes how a low-level helper function is called so it takes the hash state and data block as explicit arguments, rather than reading them from a surrounding object. The commit message and diff show no change to the actual hashing math or results. There is no security issue here.

This commit only adds and improves documentation comments for error conditions in the cryptographic key module. No code behavior, logic, or security properties were changed. It is a documentation-only change.

This commit fixes a bug in how the library reads Bitcoin public keys from raw bytes. Previously, when a caller said the key was 'compressed', the code did not verify that the first byte was a valid compressed-key prefix (2 or 3). That meant invalid or even attacker-chosen prefix bytes could be accepted for compressed keys, while uncompressed keys were already checked. The fix now rejects any compressed key whose first byte is not 2 or 3, matching the Bitcoin protocol rules.

This commit fixes a documentation comment for a Rust function. The comment previously said the function returned one type of private key object, but it actually returns a different, lower-level secret key type. There is no code behavior change and no security risk.

This is a code cleanup commit in the rust-bitcoin library. It replaces old transaction-encoding helper functions with newer equivalent ones inside the signature-hash (sighash) code. There is no direct evidence in the commit message or diff that this fixes a security vulnerability; it reads as a refactoring to use a newer internal API. However, because the change touches the exact code that computes Bitcoin transaction signatures, any accidental change to the bytes produced could break compatibility with the Bitcoin protocol or wallets, so it is in a security-sensitive area.

This commit fixes a bug where the Rust Bitcoin library incorrectly accepted 65-byte Taproot signatures whose final byte was 0x00. Under Bitcoin's BIP-341 rules, such signatures are invalid. Accepting them could let invalid transactions or signatures slip through, and it could break the library's own round-trip serialization (reading a signature in and writing it back out).