rust-bitcoin

This commit only updates two generated API snapshot files (all-features.txt and alloc-only.txt) to reflect newly added public types and methods in the bitcoin_primitives crate. It contains no actual source code changes, no bug fixes, and no security-related modifications.

This commit only adds and moves automated tests for Bitcoin script building code. It does not change any production logic, fix bugs, or alter behavior. There is no security issue here.

This commit is a one-character documentation fix: it adds a missing period at the end of a comment describing the first witness version. There are no code, logic, or API changes.

This commit only updates generated API listing files (text snapshots that document what functions and types are publicly available). It adds entries for a newly exposed 'witness_version' module and some conversions to/from opcodes. There is no actual code change, no bug fix, and no security-relevant behavior change in this commit itself.

This is a tiny code-style cleanup in error message formatting code. It changes how a Rust error type inspects its own contents when producing text or finding the underlying cause. There is no security-relevant change: the behavior is functionally identical before and after.

This commit is a routine API cleanup, not a security fix. It removes two automatic error-conversion shortcuts (From impls) from a Bitcoin library's witness-version parsing error type and replaces them with explicit error mapping. The behavior of parsing errors remains the same.

This commit only adds unit tests for existing WitnessVersion and Opcode logic. It does not change any production behavior except making one internal opcode constant available during test builds. There is no security issue here.

This commit fixes compiler lint warnings in the rust-bitcoin library's script-building code. It adds #[must_use] annotations to builder methods and changes a numeric literal format for readability. There is no security-relevant behavior change.

This commit is a routine code reorganization. It moves the `Builder` type (used to construct Bitcoin scripts step by step) from the main `bitcoin` crate into the lower-level `primitives` crate, then re-exports it so existing users can still use it the same way. No behavior changes are visible in the diff.

This commit is a routine internal code reorganization. It moves the `WitnessVersion` type and its related error types from the main `bitcoin` crate into a lower-level `primitives` crate, then re-exports them so existing users still see the same public API. There is no functional change, no bug fix, and no security relevance.

This commit is a routine internal code reorganization. It moves some helper methods for building Bitcoin scripts from one internal module to another, without changing what the code actually does. There is no security-relevant change visible in the diff.

This commit is a routine internal code cleanup in the rust-bitcoin library. It changes how the Script Builder accesses its own data so that future code reorganization is easier. There is no indication this fixes a security bug or changes behavior visible to users.

This commit is a routine internal code reorganization. It moves a helper function for building Bitcoin scripts from a public-ish location on the Builder type into a private extension trait only visible inside one module. There is no security bug being fixed here; the change is about keeping an internal implementation detail from accidentally becoming part of the public API.

This commit is a routine internal code reorganization. It moves several helper methods off the `Builder` type into a new `BuilderExt` extension trait so that the core `Builder` can be kept clean and moved to a more basic crate. There is no bug fix, behavior change, or security patch here.

This commit is a straightforward internal code cleanup in the Rust Bitcoin library. It removes a redundant field from the script Builder struct and replaces it with an equivalent method call. There is no security-relevant change visible in the diff.

This commit only adds a new unit test that checks how a fee rate multiplied by a transaction weight rounds up. It does not change any production code, so it cannot introduce or fix a security vulnerability by itself. It may be related to a prior bug fix, but the commit alone is just a test.

This commit fixes a rounding bug in a Bitcoin fee calculation. The code previously rounded the fee rate down to the nearest whole number before multiplying by transaction weight, which could cause the calculated fee to be slightly too low. After the fix, it rounds up, ensuring the fee is always sufficient. A too-low fee could cause a transaction to be rejected by the Bitcoin network or get stuck unconfirmed.

This commit fixes a bug in a Rust Bitcoin library iterator that reports byte positions of script instructions. The custom `nth` method incorrectly returned the byte offset of the found instruction without updating the iterator's internal position, so later calls to advance the iterator would report wrong positions. Removing the custom `nth` lets the normal iterator machinery keep positions correct. The practical security impact is limited because it is a correctness bug in reporting indices, not a direct memory-safety or cryptographic flaw, but code relying on these indices could make wrong decisions.

This commit only adds a new test to the rust-bitcoin library. The test demonstrates that a method called `InstructionIndices::nth` can report incorrect byte positions when used in certain ways. The commit message explicitly says there is 'no real fix in the commit' and that the custom `nth` implementation should be removed because it returns a byte offset without properly advancing the iterator. So this is a test that exposes a bug, not a patch that fixes it.

This is a tiny, non-security change in test-only code. It swaps one standard-library import for an equivalent core-library import so that a verification tool (Kani) can run in environments without the full standard library. There is no change to actual wallet or transaction logic, and no user-facing behavior changes.

This commit only adds a new regression test. It does not change any production code. The test checks that a function called from_base64 correctly rejects base64 inputs that decode to fewer or more than 65 bytes. Because no actual fix is included in this commit, the commit itself does not introduce or remove a security vulnerability; it merely adds a test to help catch the bug in the future.

This commit fixes a bug in the rust-bitcoin library where a specific function used to verify Bitcoin signed messages could crash the program. The crash could be triggered by feeding it a carefully crafted 88-character base64 string that decoded to 66 bytes instead of the expected 65 bytes. The fix adds proper length checks so the function returns a clean error instead of panicking, and also rejects 64-byte results that were previously silently accepted.

This commit fixes a bug where a Bitcoin data decoder could silently ignore parts of incoming data. The decoder only processed each chunk of data once, but some decoders don't finish a chunk in one go. Leftover bytes were effectively dropped, which could cause malformed or incomplete data to be accepted as valid. The fix repeatedly feeds the remaining bytes until the chunk is fully consumed or an error occurs.

This commit only adds a regression test for a previously existing bug in a decoding helper. It does not change any production code, so by itself it cannot introduce a security vulnerability. The test documents a bug where a decoder could lose unconsumed bytes under specific conditions, but the actual fix must have happened in an earlier commit not shown here.

This commit only adds a new regression test for an already-fixed bug in a Rust Bitcoin IO decoding function. It does not change any production code, so by itself it cannot introduce or fix a security vulnerability. The test documents a subtle edge case where a decoder consumes input one byte at a time.