Replace encode_check with Base58CkString in tests and benchmarks
What the developer wrote
Authored by Mitchell Bagot
Replace encode_check with Base58CkString in tests and benchmarks
The encode_check function is used for base58check encoding under the
old function API. With the introduction of the Base58CkString type,
base58check encoding is now done through Base58CkString::encode or
encode_unbounded.
Replace encode_check uses in tests and benchmarks with
Base58CkString::encode_unbounded.
What changed, and why it matters
This commit only updates internal tests and benchmarks to use a newer API for base58check encoding. It does not change any production code or fix a security problem.
No security action needed. Treat as routine refactoring.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff replaces calls to the legacy encode_check function with Base58CkString::encode_unbounded inside test and benchmark code in base58/src/lib.rs. The behavior being tested (base58check roundtrip and known-address encoding) remains identical. No functional or security-relevant change is present.
Changed components
base58/src/lib.rs (tests and benchmarks only)Inspect captured patch +11 / −8
diff --git a/base58/src/lib.rs b/base58/src/lib.rs
index a74d54f8..f2d4ced1 100644
--- a/base58/src/lib.rs
+++ b/base58/src/lib.rs
@@ -435,7 +435,10 @@ mod tests {
// Addresses
let addr = hex!("00f8917303bfa8ef24f292e8fa1419b20460ba064d");
- assert_eq!(&encode_check(&addr[..]), "1PfJpZsjreyVrqeoAfabrRwwjQyoSQMmHH");
+ assert_eq!(
+ Base58CkString::encode_unbounded(&addr[..]).as_str(),
+ "1PfJpZsjreyVrqeoAfabrRwwjQyoSQMmHH"
+ );
}
#[test]
@@ -463,11 +466,11 @@ mod tests {
fn base58_roundtrip() {
let s = "xprv9wTYmMFdV23N2TdNG573QoEsfRrWKQgWeibmLntzniatZvR9BmLnvSxqu53Kw1UmYPxLgboyZQaXwTCg8MSY3H2EU4pWcQDnRnrVA1xe8fs";
let v: Vec<u8> = decode_check(s).unwrap();
- assert_eq!(encode_check(&v[..]), s);
- assert_eq!(decode_check(&encode_check(&v[..])).ok(), Some(v));
+ assert_eq!(Base58CkString::encode_unbounded(&v[..]).as_str(), s);
+ assert_eq!(decode_check(Base58CkString::encode_unbounded(&v[..]).as_str()).ok(), Some(v));
// Check that empty slice passes roundtrip.
- assert_eq!(decode_check(&encode_check(&[])), Ok(vec![]));
+ assert_eq!(decode_check(Base58CkString::encode_unbounded(&[]).as_str()), Ok(vec![]));
// Check that `len > 4` is enforced.
assert_eq!(decode_check(&encode(&[1, 2, 3])), Err(TooShortError { length: 3 }.into()));
}
@@ -482,8 +485,8 @@ mod benches {
let data: alloc::vec::Vec<_> = (0u8..50).collect();
bh.iter(|| {
- let r = super::encode_check(&data);
- black_box(&r);
+ let r = super::Base58CkString::encode_unbounded(&data);
+ black_box(r.as_str());
});
}
@@ -492,8 +495,8 @@ mod benches {
let data: alloc::vec::Vec<_> = (0u8..78).collect(); // length of xpub
bh.iter(|| {
- let r = super::encode_check(&data);
- black_box(&r);
+ let r = super::Base58CkString::encode_unbounded(&data);
+ black_box(r.as_str());
});
}
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.