RB
← All projectsRust Bitcoin

rust-bitcoin

Rust library for Bitcoin data structures, serialization, consensus encoding, and scripts.

BitcoinCryptographic librariesNormal
Repository coverage

2570 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

612security candidates555second-pass queue2330AI analyses
153commits · 30 days
279commits · 60 days
977commits · 180 days
2058commits · 365 days
Backfill bands
Aug 5 → Feb 6787 seen32 candidatesComplete
Feb 6 → Jun 6878 seen53 candidatesComplete
Jun 6 → Jul 6211 seen15 candidatesComplete
Jul 6 → Aug 5184 seen2 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

68/100 average clarity
702Strong · 80–100
1135Adequate · 60–79
582Thin · 40–59
151Opaque · 0–39
20security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Andrew Poelstra407139251391
Mitchell Bagot659200654068
Tobin C. Harding42167411063
jrakibi1015096069
satsfy (Renato Britto)652235065
Nick Johnson19621190060
Jamil Lambert, PhD12619117062
Fmt Bot351532045
Trevor Arjeski111111069
Shing Him Ng31731056
Martin Habovstiak31629069
Ismail Daif22622050
Analysis record

Published AI watches

Last scanned 2 minutes ago

Informational 19 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7220: refactor(bip32)!: replace KeySource with KeyOrigin

This is a routine code cleanup in a Bitcoin library. It renames a simple data container from KeySource to KeyOrigin and gives it named fields (fingerprint and path) instead of numbered tuple slots (.0 and .1). The serialized format is inte…

6bb507b2by Andrew Poelstra+84−33 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7204: key-expression: Get secp256k1 from the crypto dep

This change is a routine internal cleanup: the key_expression crate stops depending directly on the secp256k1 cryptography library and instead uses a re-export provided by another internal crate called crypto. No user-facing behavior, type…

d193efc5by Andrew Poelstra+7−107 files
No security note in commit
Informational 17 AI analysisMessage 68 · Adequate
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

key_expression: Forward serde feature to network

This is a small Cargo.toml fix in a Rust Bitcoin subcrate. When the optional 'serde' feature was enabled on the key_expression crate alone, it did not also enable serde on the network crate. That meant a type called NetworkKind could not b…

806f1e1fby bytescape30+1−11 file
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7223: build(deps): bump taiki-e/install-action from 2.87.9 to 2.87.13

This is a routine update to a GitHub Actions helper used in automated testing workflows. It bumps the version of taiki-e/install-action, which downloads and installs Rust developer tools during CI runs. There is no change to the actual Bit…

c8ee144aby Andrew Poelstra+2−22 files
No security note in commit
Informational 20 AI analysisMessage 100 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7224: build(deps): bump astral-sh/setup-uv from 10.0.1 to 10.1.0

This is a routine update to a GitHub Actions helper used only in automated security-scanning workflows. The new version adds minor improvements, including respecting proxy settings and verifying downloaded files with checksums. It does not…

Dependency bump of a third-party GitHub Action used in CI onlyUpstream release notes mention generic security improvements (checksum verification, npm install defaults, NO_PROXY)No CVE, advisory, or vendor security disclosure is present in the commit or supplied references
7bc9d696by Andrew Poelstra+2−22 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7105: Remove derived serde impls for types in stabilising crates

This commit removes automatic serde (serialization/deserialization) code generation from several Rust Bitcoin library crates and replaces it with hand-written implementations. The stated goal is to reduce dependencies and make the code eas…

Manual serde implementations replace derived ones, increasing the surface area for serialization-format bugsNo validation logic changes are visible in the diffNo mention of security fixes, CVEs, or vulnerability reports in commit message or PR description
9eeb7774by Andrew Poelstra+219−4110 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7205: Manual update to rustc stable (to 1.100.0)

This commit updates the project's automated Rust compiler version from 1.99.1 to 1.100.0 and adjusts a CI cache cleanup script to match a new directory layout used by Cargo 1.100. It is purely an infrastructure/maintenance change to keep a…

44e6f0caby Andrew Poelstra+8−22 files
No security note in commit
Informational 18 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7197: ci: bump rbmt to 0.5.5 and fail API job on private dep leak

This is a build-system improvement, not a code change. It updates a CI helper tool and makes the automated API-checking job fail if a private internal crate accidentally becomes part of the public API. That prevents future leaks of interna…

CI guardrail added to prevent private dependency leaks into stable crate public APIsTool bump enables detection of re-exported private dependenciesNo source-code vulnerability is patched
be14c72eby Andrew Poelstra+7−12 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7185: Refactor/bip32 flatten error constructors

This is a minor internal code cleanup in the Rust Bitcoin library. It changes how two functions (Xpriv::decode and Xpub::decode) build their error messages when an input is the wrong length. The behavior is the same before and after; only …

271f662aby Andrew Poelstra+8−61 file
No security note in commit
Informational 24 AI analysisMessage 93 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7167: units: remove `Denomination::MicroBitcoin`

This is a routine API cleanup, not a security fix. The change removes one way of naming a Bitcoin unit ('MicroBitcoin' / 'uBTC') and keeps the equivalent 'bits' form. Any code that previously used the old name will fail to compile or fail …

No security signal: public API deprecation and enum variant removalNo memory safety, cryptographic, or consensus code modifiedError message change is informational only
d0602195by Andrew Poelstra+53−403 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7127: key_expression: Reduce `alloc` gating to minimal types

This commit is a code cleanup and feature-gating refactor for the rust-bitcoin library's key_expression crate. It makes more BIP32 (Bitcoin wallet key derivation) types available when the 'alloc' memory allocator feature is disabled, and s…

Refactor of error types and parsing paths for Xpriv/Xpub base58 decodingSwitch from unbounded base58 decode to fixed-size array decode (78 bytes)Removal of explicit length-check error path in favor of decoder-reported length error
c3d27d5dby Andrew Poelstra+60−823 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7039: primitives: Fix daily Miri cron failures with measured test gating

This change only adds `#[cfg_attr(miri, ignore)]` annotations to a handful of slow unit tests so they are skipped when run under Miri, a Rust interpreter used for detecting undefined behavior. It does not change any production code, consen…

1dc09077by Andrew Poelstra+6−03 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7182: Update local dependencies

This commit only updates version numbers in package configuration files (Cargo.toml) for internal dependencies so that all crates in the project require the same minimum versions of shared libraries. There are no code changes, no bug fixes…

06f41225by Andrew Poelstra+7−75 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7179: build(deps): bump taiki-e/install-action from 2.87.4 to 2.87.9

This is a routine update to a GitHub Actions helper used in automated testing workflows. It changes which version of a third-party tool-installer action is used, but only for installing the cargo-mutants testing tool. There is no indicatio…

4fda66b5by Andrew Poelstra+2−22 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7180: build(deps): bump cargo-bins/cargo-binstall from 1.22.0 to 1.23.0

This commit updates the version of a helper tool called cargo-binstall used in two automated GitHub workflows. The change only affects internal build/CI tooling and does not alter the rust-bitcoin library code that users install or run. Th…

53eae24dby Andrew Poelstra+2−22 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7181: build(deps): bump github/codeql-action/upload-sarif from 4.37.9 to 4.38.0

This is a routine update by Dependabot to the GitHub CodeQL upload-sarif action used in a scheduled security scanning workflow. It changes one pinned commit hash to a newer version of the same action. There is no indication this introduces…

4bb555f0by Andrew Poelstra+1−11 file
No security note in commit
Informational 15 AI analysisMessage 81 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

key_expression: Flatten BIP32 decode error construction

This commit is a minor code cleanup in the Rust Bitcoin library. It changes how an error message is built when decoding BIP32 extended keys, switching from one nested construction style to two chained calls. The actual behavior and returne…

c31c11e0by Adewale Ijalana+8−61 file
No security note in commit
Low 36 AI analysisMessage 100 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7168: units: add `visit_units` in optional serde visitors

This commit fixes a bug in how optional Bitcoin amount and fee-rate values are read from JSON when those fields are inside a flattened struct and the value is null. Previously, the code would error out because it did not handle a special s…

Deserialization failure in optional numeric types under serde flattenMissing serde visitor method (visit_unit) causing runtime errorsRegression test added for null handling in flattened structs
47340d2fby Andrew Poelstra+79−03 files
No security note in commit
Informational 15 AI analysisMessage 93 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

build(deps): bump github/codeql-action/upload-sarif

This is a routine dependency update by Dependabot, bumping the version of a GitHub-provided action used to upload security scan results. There is no indication of a security vulnerability in the project itself or in this change.

fe755619by dependabot[bot]+1−11 file
No security note in commit
Informational 15 AI analysisMessage 93 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

build(deps): bump cargo-bins/cargo-binstall from 1.22.0 to 1.23.0

This is a routine automated update by Dependabot that changes the version of a GitHub Action used to install Rust tools in two CI workflows. There is no indication of a security issue in the commit itself, and no verified security referenc…

2ccb0029by dependabot[bot]+2−22 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityprimitives: Add reason to must_use on into_boxed_scriptby PeterXMR · a5756e68 · Oct 27, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · PeterXMR

primitives: Add reason to must_use on into_boxed_script

`ScriptBuf::into_boxed_script` reallocates when the capacity is larger
than the length. Calling it and ignoring the result does nothing useful.
Say so in the `must_use` message, focusing on the caller forgetting to
use the result. Wording suggested in review.

Fixes #3963

Assisted-by: Claude Opus 5.5
Assisted-by: Claude Fable 5.1

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Security candidateMerge rust-bitcoin/rust-bitcoin#7102: Flatten nested error constructorsby Andrew Poelstra · 965f7863 · Oct 27, 2026 · 5 filesMessage 81 · StrongInformational 19Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7102: Flatten nested error constructors

96dc7c3f70f053ce61b6f434c73553323aa43b3f key_expression: Flatten nested error constructors (Mitchell Bagot)
3ef33748bc9da500c39879990bc8b5d11e35f4dc base58: Flatten nested error constructors (Mitchell Bagot)
f09d1924a3da60e8ed16d1def9664328620ed094 primitives: Flatten nested error constructors (Mitchell Bagot)
18bde4fd1b38376ecf918cc924336bf952e54f7e units: Flatten nested error constructors (Mitchell Bagot)

Pull request description:

As has been an established pattern, error constructors should be flattened and use map_err to wrap successive error types. There remain places that need to follow this pattern.

Contributes to #6539


ACKs for top commit:
tcharding:
ACK 96dc7c3f70f053ce61b6f434c73553323aa43b3f
Abeeujah:
ACK 96dc7c3f70f053ce61b6f434c73553323aa43b3f


Tree-SHA512: 9a241830f4dd18517aeecb8123a706d6ba932c019954ae0af7fd5651e9fa16722be92088b1d9bf6673d5b796dc4fe987b6b3d9acb7f08f3778560c759ae234d5

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Informational 19/100

This commit is a code-style cleanup in the rust-bitcoin library. It rewrites how some internal error types are constructed so that nested error wrappers are created in a flatter, more consistent way using a common Rust pattern (map_err). There is no functional change to how the library behaves, no bug fix, and no security improvement or vulnerability introduced.

AI review queuedMerge rust-bitcoin/rust-bitcoin#7098: bitcoin: include hidden nodes in the `leaves` listby Andrew Poelstra · 8b5fdb1c · Oct 27, 2026 · 1 fileMessage 91 · StrongLow 27Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7098: bitcoin: include hidden nodes in the `leaves` list

74104e5a93846675c2e8171f2c0668a50e155a52 bitcoin: test NodeInfo round trip with hidden nodes (jrakibi)
1dbc3b7376b21190e5034cb2541a4a1751b0715e bitcoin: include hidden nodes in the `leaves` list (jrakibi)

Pull request description:

When constructing a `NodeInfo` with hidden nodes, we don’t save these hidden nodes in the `leaves` list. So serializing `NodeInfo` omits the hidden nodes and only keeps known script leaves, which breaks the round trip when deserializing.

Add the hidden node to the leaves list so it is included when serializing.

Related to #1327


ACKs for top commit:
Abeeujah:
ACK 74104e5a93846675c2e8171f2c0668a50e155a52
tcharding:
ACK 74104e5a93846675c2e8171f2c0668a50e155a52
apoelstra:
ACK 74104e5a93846675c2e8171f2c0668a50e155a52; successfully ran local tests


Tree-SHA512: e43d934edcceedf0d300a40c13841ae36f9046413463ec9524e74a2d00c5d2d929debaa72aa209201a1b71726436d0ebfab82ca38f3892ac227ccce542d38a36

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Low 27/100

This change fixes a bug in how Taproot tree data is saved to JSON or other serialized formats. Previously, deliberately hidden branches of a Taproot tree were left out of the 'leaves' list, so after saving and loading the tree back, the hidden part was missing. The fix adds a placeholder hidden leaf so round-trip serialization works correctly. It is a correctness/data-integrity bug, not a direct theft-of-funds vulnerability.

AI review queuedprimitives: Remove serde derives from all typesby Mitchell Bagot · 98d482b0 · Oct 27, 2026 · 4 filesMessage 68 · AdequateInformational 17Details
Commit message · Mitchell Bagot

primitives: Remove serde derives from all types

The serde derive feature introduces various additional dependencies to
the dependency graph. Since derives are harder to reason about, and
slow down the compilation with extra deps, it's better to simply provide
explicit serde impls for all types and drop the feature.

Remove serde derive feature from primitives.
Replace all serde derives with explicit impls for all remaining types.

Assisted by: Claude Opus 5.5

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Informational 17/100

This commit removes the automatic serde serialization/deserialization macros from the rust-bitcoin primitives crate and replaces them with hand-written implementations. It is a code-quality and dependency-reduction change, not a security fix. There is no evidence in the commit or supplied references that this addresses a vulnerability.

AI review queuedunits: Remove serde derives from all typesby Mitchell Bagot · 904eedc3 · Oct 27, 2026 · 5 filesMessage 68 · AdequateInformational 17Details
Commit message · Mitchell Bagot

units: Remove serde derives from all types

The serde derive feature introduces various additional dependencies to
the dependency graph. Since derives are harder to reason about, and
slow down the compilation with extra deps, it's better to simply provide
explicit serde impls for all types and drop the feature.

Remove serde derive feature from units.
Replace all serde derives with explicit impls for all remaining types.

Assisted by: Claude Opus 5.5

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 17/100

This commit removes the automatic serde (serialization/deserialization) derive feature from the `units` crate and replaces it with hand-written implementations. The stated goal is to reduce compile-time dependencies and make the code easier to reason about. There is no direct security fix here, but any change to serialization behavior carries a small risk of accidentally altering how data is encoded or decoded, which could affect downstream users relying on stable formats.

Security candidateconsensus_encoding: Remove derive feature outside testsby Mitchell Bagot · 16bffa0c · Oct 27, 2026 · 1 fileMessage 95 · StrongInformational 15Details
Commit message · Mitchell Bagot

consensus_encoding: Remove derive feature outside tests

In consensus_encoding, serde is only used for the serde_as_consensus.
In order to reduce compile time, the feature can be removed. When the
derives are removed from types in units and primitives, this also
ensures that the feature is not re-enabled.

Only enable derive feature in consensus_encoding for tests.

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
consensus or confidential-proof validation
AI analysis · Informational 15/100

This commit is a routine build optimization. It removes the automatic 'derive' feature from the serde dependency in the consensus_encoding crate, keeping it only for test builds. This reduces compile time and prevents unused derive machinery from being pulled in. There is no security-relevant change.

Security candidateMerge rust-bitcoin/rust-bitcoin#7096: Add x_only_serde module for `XOnlyPublicKey` serdeby Andrew Poelstra · 64780981 · Oct 26, 2026 · 6 filesMessage 91 · StrongLow 37Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7096: Add x_only_serde module for `XOnlyPublicKey` serde

50940cb20fad4839b00ba56e499df4ab75beb8f2 Remove default XOnlyPublicKey serde impl (Mitchell Bagot)
877faa8f4399a3e6fe20de29bd16f9470a1568a1 Remove uses of default XOnlyPublicKey serde (Mitchell Bagot)
65ea85ba008f8a2f1c3889f8e0bee0b35cb50066 Add x_only_serde module for XOnlyPublicKey serde encoding (Mitchell Bagot)

Pull request description:

Currently, the x-only public key serde encodes and decodes using the inner type, without any parity. Since the bitcoin-crypto type holds the parity, this makes the type unable to roundtrip odd parity keys. Instead, with or without parity encoding should be selectable by users.

Closes #5729


ACKs for top commit:
tcharding:
ACK 50940cb20fad4839b00ba56e499df4ab75beb8f2
apoelstra:
ACK 50940cb20fad4839b00ba56e499df4ab75beb8f2; successfully ran local tests


Tree-SHA512: 9de8f4794a8897c0956540b050e5d4a290516921cb7a2964739626652e2e09d8664c349714e188d9d24a053915422e9803228e3769a124df7618d1958a2884f4

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Low 37/100

This change fixes a data-integrity problem in how a special Bitcoin public key type (XOnlyPublicKey) was being saved and loaded through serde. Previously, the type silently dropped the 'parity' bit during serialization, so an odd-parity key could be serialized and then deserialized as a different, even-parity key. The patch removes the automatic serde implementation and instead offers two explicit modules: one that preserves parity by serializing the full public key, and one that intentionally drops parity. It also removes serde support from Taproot ControlBlock because that structure contained an XOnlyPublicKey and could no longer round-trip safely by default. This is a correctness and API-breaking change, not a remote code-execution vulnerability.

Lower-priorityMerge rust-bitcoin/rust-bitcoin#7094: TapTree tweaks to make it easier to implement an encoderby Andrew Poelstra · 2ac810d2 · Oct 26, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7094: TapTree tweaks to make it easier to implement an encoder

56d52c2696a815f1cc3fa10b24d2c4f83657f6a7 TapTree tweaks to make it easier to implement an encoder (Nick Johnson)

Pull request description:

Two tweaks are required to make writing a TapTree encoder way easier, using the existing IterEncoder primitive.

The first is to derive Clone on the TapTree's iterators. This is a requirement for IterEncoder to calculate and exact size to encode. This does expand the public API, but isn't a large chunk of logic since it is just exposing the Clone functipnallity of the inner types. The Debug trait is also added to be more inline with the policy of the repository.

The second tweak is to loosen the lifetime of the leaves by tying them to the tree itself. It overrides the lifetime to self (ScriptLeaf) and connects it to the tree's lifetime where the data lives. This makes it easy for the *tree* encoder to reference the data and avoid unnecessary clones. It is backwards compatible since it "loosening" the lifttime by tieing it to a longer one.

A cosmetic change is renaming the ScriptLeaf lifetime from 'leaf to 'tree. I think this generally makes more sense, the view is tied to the tree, even though it is possible to create a ScriptLeaf view on a single leaf.

I plan to backport some version of this to 0.32.xxx if cool with it.


ACKs for top commit:
tcharding:
ACK 56d52c2696a815f1cc3fa10b24d2c4f83657f6a7
Abeeujah:
ACK 56d52c2696a815f1cc3fa10b24d2c4f83657f6a7
apoelstra:
ACK 56d52c2696a815f1cc3fa10b24d2c4f83657f6a7; successfully ran local tests


Tree-SHA512: a236233b81d40b3b84a4413cb0176b1bc04894ec49d399a8ac5945cfa3860fe435d6234507a029bfcd79c4c7fd05cdba94aed3e1c4e259b7e4988357d95e942c

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge rust-bitcoin/rust-bitcoin#7067: Add annex and codeseparator position to taproot sighash methodsby Andrew Poelstra · 62c7c658 · Oct 26, 2026 · 2 filesMessage 96 · StrongModerate 60Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7067: Add annex and codeseparator position to taproot sighash methods

897a4e32f3cce741955f3ec906e9013f36ffb2ac bitcoin: add codeseparator test vectors from Core (anshumancanrock)
65b7d7dfa9b07c9208f1a1502b469d6681a60161 bitcoin: test taproot sighash methods (anshumancanrock)
f8e2f4eea0e43d3da53c217d9870f039080a1f78 bitcoin: add annex and codeseparator position to taproot sighash methods (anshumancanrock)

Pull request description:

Fixes #7019

`taproot_key_spend_signature_hash` and `taproot_script_spend_signature_hash` have no way to pass an annex, so they return the wrong sighash for any input that has one. The script spend one also hardcodes the codeseparator position to `0xFFFFFFFF`, which is wrong once an `OP_CODESEPARATOR` has executed.

I Added `annex: Option<Annex>` to both, and `code_separator_pos: Option<u32>` to the script spend one (`None` = no `OP_CODESEPARATOR` was executed). Arg order matches `taproot_signature_hash`.

The existing taproot sighash tests, including the annex ones, now also go through these methods. There's also a small test for the codeseparator position.

The mainnet example from the issue is tx `f859a4e6692c3f15a279449eac191ecb9d17d2d6c003bbae9a55e5da07147eab`, in block 896088 (not 896078). Its signature verifies with the annex and fails without it.


ACKs for top commit:
jrakibi:
ACK 897a4e32f3cce741955f3ec906e9013f36ffb2ac
apoelstra:
ACK 897a4e32f3cce741955f3ec906e9013f36ffb2ac; successfully ran local tests


Tree-SHA512: 9465eb838a7b3454e4307341b725a0f49ce44bd3ee2764108e85f79bd8d796bfb2d04ddcae49e6c47f669a2bd28c025ec4013befc04af8ea93bd2c86541d8179

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundaryfuzzing or regression evidencecryptography-sensitive pathsigning or wallet pathmerge-commit duplicate discount
AI analysis · Moderate 60/100

This commit fixes a bug in how Bitcoin transaction signatures are calculated for Taproot-style transactions. Previously, two helper methods could not accept an optional extra data chunk called an 'annex' and always assumed no special code-separator instruction had run. That meant any transaction using those features would compute an incorrect signature hash, causing a valid signature to be rejected. The change adds the missing parameters so the helpers match the more complete API. It is a correctness fix rather than a memory-safety or remote-exploitable vulnerability, but incorrect sighashes can break wallets, tests, or services that rely on these methods.

Lower-priorityMerge rust-bitcoin/rust-bitcoin#7088: primitives: Remove broken link from changelogby Andrew Poelstra · 3c4865a2 · Oct 26, 2026 · 1 fileMessage 100 · StrongTriage 0Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7088: primitives: Remove broken link from changelog

f31a35e3817bac7383218efcf6a5df84b1630a86 primitives: Remove broken link from changelog (Tobin C. Harding)

Pull request description:

The links don't work for point releases because we don't release them from master. Just remove the link markdown.


ACKs for top commit:
apoelstra:
ACK f31a35e3817bac7383218efcf6a5df84b1630a86; successfully ran local tests


Tree-SHA512: 05801ae915911fd1993cf9c45c74220eb8eff0a016c84c7af88fb3069520391cf1abdd671ba27cf8b123c7000cb6575b1bb293f652429ce77b600d1260d3ad29

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
documentation-only discountmerge-commit duplicate discount
Lower-priorityMerge rust-bitcoin/rust-bitcoin#7091: primitives: Group pub extern cratesby Andrew Poelstra · 2d027788 · Oct 26, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7091: primitives: Group pub extern crates

e9f2c16ad324533f198c2928b047d32514010ec5 primitives: Group pub extern crates (Tobin C. Harding)

Pull request description:

As we do in `units` group the extern crates and remove newlines just to be a bit more terse with no loss of clarity.


ACKs for top commit:
apoelstra:
ACK e9f2c16ad324533f198c2928b047d32514010ec5; successfully ran local tests


Tree-SHA512: ada4ec2b9af07ee0c2184b8cadd304273101052e94b5f015de76dc73b046d2188fb1247ac3c8379e8b6f0f04b631a34523623e339538ef2b1088f5593c8be884

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge rust-bitcoin/rust-bitcoin#7090: primitives: docs: Copy policy from unitsby Andrew Poelstra · cc4f98f0 · Oct 26, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7090: primitives: docs: Copy policy from units

ea33f09581722bf1b7a77c42059f483a90942a7d primitives: docs: Copy policy from units (Tobin C. Harding)

Pull request description:

Copy the top level rustdoc section on `Policy` from `units`.

No reason not to.


ACKs for top commit:
apoelstra:
ACK ea33f09581722bf1b7a77c42059f483a90942a7d; successfully ran local tests


Tree-SHA512: a5a2fc7784d1d6227f35aa0e2146789f8259ded06cb9187aa9486a2a3f2eca42d14d5ea0ee3cf42ef8470166eec75c3cd46b00ca93de0a6472d76add5770b833

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge rust-bitcoin/rust-bitcoin#7085: build(deps): bump github/codeql-action/upload-sarif from 4.37.7 to 4.37.9by Andrew Poelstra · 8b246155 · Oct 26, 2026 · 1 fileMessage 96 · StrongInformational 15Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7085: build(deps): bump github/codeql-action/upload-sarif from 4.37.7 to 4.37.9

2875f67ab04a88ec088f95a681dc9abd113794b5 build(deps): bump github/codeql-action/upload-sarif (dependabot[bot])

Pull request description:

Bumps [github/codeql-action/upload-sarif](https://github.com/github/codeql-action) from 4.37.7 to 4.37.9.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action/upload-sarif's releases</a>.</em></p>
<blockquote>
<h2>v4.37.9</h2>
<ul>
<li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.26.4">2.26.4</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4106">#4106</a></li>
</ul>
<h2>v4.37.8</h2>
<p>No user facing changes.</p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action/upload-sarif's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>4.39.1 - 21 Oct 2026</h2>
<ul>
<li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.3">2.27.3</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4256">#4256</a></li>
</ul>
<h2>4.39.0 - 15 Oct 2026</h2>
<ul>
<li><em>Breaking change</em>: Bump the minimum required CodeQL bundle version to 2.20.7. <a href="https://redirect.github.com/github/codeql-action/pull/4205">#4205</a></li>
<li>The <code>codeql-action/analyze</code> step now validates that a correct argument for the <code>checkout_path</code> input has been provided. The <code>checkout_path</code> input must be set to the path where the repository that is being analyzed is checked out at on the runner, if that path is something other than the workspace root. If the path does not point to a repository checkout or is different from the path that was used by <code>codeql-action/init</code>, then the CodeQL Action now produces a warning. <a href="https://redirect.github.com/github/codeql-action/pull/4148">#4148</a></li>
<li>Resolved an issue with third-party caching implementations that prevented caches from being restored correctly. <a href="https://redirect.github.com/github/codeql-action/pull/4206">#4206</a></li>
<li>The <code>codeql-action/start-proxy</code> step that is used in Code Scanning Default Setup now finds CodeQL releases using the same logic as <code>codeql-action/init</code>. This primarily benefits customers who are using GitHub instances other than <code>github.com</code> where the <code>codeql-action/start-proxy</code> step may previously have been unable to locate recent releases and ended up using outdated versions of the private registry authentication proxy as a result. <a href="https://redirect.github.com/github/codeql-action/pull/4198">#4198</a></li>
</ul>
<h2>4.38.3 - 08 Oct 2026</h2>
<ul>
<li><em>Upcoming breaking change</em>: CodeQL version 2.21.2 and earlier were discontinued on 24 September 2026 alongside GitHub Enterprise Server 3.17, and will be unsupported by the next minor release of the CodeQL Action. Added a deprecation warning for customers using these versions of CodeQL. <a href="https://redirect.github.com/github/codeql-action/pull/4188">#4188</a></li>
<li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.2">2.27.2</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4203">#4203</a></li>
<li>Fixed a bug where the decision of whether to use a per-language bundle did not account for custom configurations that reference queries outside of compiled CodeQL packs. This issue was caught during internal testing and did not affect any customer repositories. We will resume the roll out of per-language bundles in the coming weeks. <a href="https://redirect.github.com/github/codeql-action/pull/4184">#4184</a></li>
</ul>
<h2>4.38.2 - 24 Sept 2026</h2>
<ul>
<li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.1">2.27.1</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4160">#4160</a></li>
</ul>
<h2>4.38.1 - 18 Sept 2026</h2>
<ul>
<li>The CodeQL Action now has experimental support for CodeQL releases for which per-language bundles are available. Per-language bundles support analysis for a single language and are therefore smaller than the combined bundles that allow analysis for all supported languages. As a result, per-language bundles take up less space on disk and are faster to download. We expect to roll this change out to everyone in the coming weeks. <a href="https://redirect.github.com/github/codeql-action/pull/4146">#4146</a></li>
</ul>
<h2>4.38.0 - 09 Sept 2026</h2>
<ul>
<li>On GitHub-hosted runners, the CodeQL Action now deletes unused CodeQL bundles from the toolcache before downloading a different bundle, which frees up disk space for the analysis. We expect to roll this change out to everyone in September. <a href="https://redirect.github.com/github/codeql-action/pull/4124">#4124</a></li>
<li>The CodeQL Action now supports CodeQL releases that are compatible with Linux Arm64 and downloads the native <code>linux-arm64</code> CodeQL bundle when available. <a href="https://redirect.github.com/github/codeql-action/pull/4072">#4072</a></li>
<li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.0">2.27.0</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4129">#4129</a></li>
</ul>
<h2>4.37.9 - 26 Aug 2026</h2>
<ul>
<li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.26.4">2.26.4</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4106">#4106</a></li>
</ul>
<h2>4.37.8 - 21 Aug 2026</h2>
<p>No user facing changes.</p>
<h2>4.37.7 - 13 Aug 2026</h2>
<ul>
<li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.26.3">2.26.3</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4085">#4085</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/cdf488f595d80d6e07e03d4674febd5ab45fa938"><code>cdf488f</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4107">#4107</a> from github/update-v4.37.9-920ba7cd1</li>
<li><a href="https://github.com/github/codeql-action/commit/7243f38558d187dde99730d224bb47aa26a95306"><code>7243f38</code></a> Update changelog for v4.37.9</li>
<li><a href="https://github.com/github/codeql-action/commit/920ba7cd1596037e042122c00381eb16b397d68e"><code>920ba7c</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4106">#4106</a> from github/update-bundle/codeql-bundle-v2.26.4</li>
<li><a href="https://github.com/github/codeql-action/commit/ecfa6e16817b8f490bc9a59baa391baf4fa3e3c2"><code>ecfa6e1</code></a> Add changelog note</li>
<li><a href="https://github.com/github/codeql-action/commit/adcdf4a70d247343cf9c29e0f7a6658b51c3a2b1"><code>adcdf4a</code></a> Update default bundle to codeql-bundle-v2.26.4</li>
<li><a href="https://github.com/github/codeql-action/commit/486fec2a3ea2626afcd8c7e9208b4f515078dd7e"><code>486fec2</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4099">#4099</a> from github/update-supported-enterprise-server-versions</li>
<li><a href="https://github.com/github/codeql-action/commit/134624c67b20869c2aaa36dafa726375b78a5d76"><code>134624c</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4101">#4101</a> from github/dependabot/npm_and_yarn/npm-minor-457d82...</li>
<li><a href="https://github.com/github/codeql-action/commit/ff43db8f982a368288f117354fb8d046e937124c"><code>ff43db8</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4103">#4103</a> from github/mergeback/v4.37.8-to-main-db488dde</li>
<li><a href="https://github.com/github/codeql-action/commit/4605e03a74cf891614c4d76f82384a16c1c11816"><code>4605e03</code></a> Rebuild</li>
<li><a href="https://github.com/github/codeql-action/commit/099c869cad6bf3b88657154d4ae47ffed27e632d"><code>099c869</code></a> Update changelog and version after v4.37.8</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/ff2f1c621b7f889edc0d3c761ac2e6a3f8cdb0dd...cdf488f595d80d6e07e03d4674febd5ab45fa938">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action/upload-sarif&package-manager=github_actions&previous-version=4.37.7&new-version=4.37.9)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>


ACKs for top commit:
apoelstra:
ACK 2875f67ab04a88ec088f95a681dc9abd113794b5; successfully ran local tests


Tree-SHA512: d60a4aca92fb7a38f71d00431a3fe3327677fc580c73133aa7a4879ff93d00444cdfbbfa5d42e3052f90e8931963143fe1b4c1eda12358e106df66374a895780

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
access controldefensive validationdocumentation-only discountautomated dependency-update discountmerge-commit duplicate discount
AI analysis · Informational 15/100

This is a routine update by Dependabot to the GitHub CodeQL upload-sarif action used in a scheduled security-scanning workflow. It changes only the pinned commit hash of a third-party GitHub Action from version 4.37.7 to 4.37.9. There is no change to the project's Rust code, no disclosed security vulnerability, and no indication this update fixes an active security problem in rust-bitcoin itself.

Security candidateMerge rust-bitcoin/rust-bitcoin#7086: build(deps): bump taiki-e/install-action from 2.86.3 to 2.86.8by Andrew Poelstra · 1e886979 · Oct 26, 2026 · 2 filesMessage 96 · StrongInformational 15Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7086: build(deps): bump taiki-e/install-action from 2.86.3 to 2.86.8

2968f432865f6fa2cada9c8b7900438989ab5c91 build(deps): bump taiki-e/install-action from 2.86.3 to 2.86.8 (dependabot[bot])

Pull request description:

Bumps [taiki-e/install-action](https://github.com/taiki-e/install-action) from 2.86.3 to 2.86.8.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/taiki-e/install-action/releases">taiki-e/install-action's releases</a>.</em></p>
<blockquote>
<h2>2.86.8</h2>
<ul>
<li>
<p>Update <code>wasmtime@latest</code> to 48.0.1.</p>
</li>
<li>
<p>Update <code>wasm-tools@latest</code> to 1.258.0.</p>
</li>
<li>
<p>Update <code>oxfmt@latest</code> to 1.80.0.</p>
</li>
<li>
<p>Update <code>mise@latest</code> to 2026.8.12.</p>
</li>
<li>
<p>Update <code>kingfisher@latest</code> to 2.0.0.</p>
</li>
<li>
<p>Update <code>cargo-zigbuild@latest</code> to 0.23.2.</p>
</li>
</ul>
<h2>2.86.7</h2>
<ul>
<li>
<p>Update <code>tombi@latest</code> to 1.4.1.</p>
</li>
<li>
<p>Update <code>rafn@latest</code> to 0.1.5.</p>
</li>
<li>
<p>Update <code>cargo-binstall@latest</code> to 1.22.0.</p>
</li>
</ul>
<h2>2.86.6</h2>
<ul>
<li>
<p>Update <code>dprint@latest</code> to 0.56.1.</p>
</li>
<li>
<p>Update <code>cargo-lambda@latest</code> to 1.9.2.</p>
</li>
<li>
<p>Update <code>biome@latest</code> to 2.5.10.</p>
</li>
</ul>
<h2>2.86.5</h2>
<ul>
<li>
<p>Update <code>zola@latest</code> to 0.23.4.</p>
</li>
<li>
<p>Update <code>wasm-tools@latest</code> to 1.257.1.</p>
</li>
<li>
<p>Update <code>protoc@latest</code> to 3.36.0.</p>
</li>
<li>
<p>Update <code>mise@latest</code> to 2026.8.10.</p>
</li>
<li>
<p>Update <code>cargo-dinghy@latest</code> to 0.8.6.</p>
</li>
<li>
<p>Update <code>wasmtime@latest</code> to 48.0.0.</p>
</li>
</ul>
<h2>2.86.4</h2>
<ul>
<li>
<p>Update <code>oxfmt@latest</code> to 1.79.0.</p>
</li>
<li>
<p>Update <code>mise@latest</code> to 2026.8.8.</p>
</li>
<li>
<p>Update <code>martin@latest</code> to 1.14.0.</p>
</li>
<li>
<p>Update <code>dprint@latest</code> to 0.56.0.</p>
</li>
<li>
<p>Update <code>cargo-about@latest</code> to 0.9.2.</p>
</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/taiki-e/install-action/blob/main/CHANGELOG.md">taiki-e/install-action's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<p>All notable changes to this project will be documented in this file.</p>
<p>This project adheres to <a href="https://semver.org">Semantic Versioning</a>.</p>
<!-- raw HTML omitted -->
<h2>[Unreleased]</h2>
<h2>[2.87.31] - 2026-10-23</h2>
<ul>
<li>
<p>Downgrade <code>cargo-sort@latest</code> to 2.1.3.</p>
</li>
<li>
<p>Update <code>vacuum@latest</code> to 0.35.0.</p>
</li>
<li>
<p>Update <code>xh@latest</code> to 0.26.3.</p>
</li>
<li>
<p>Update <code>uv@latest</code> to 0.13.5.</p>
</li>
<li>
<p>Update <code>ubi@latest</code> to 0.13.0.</p>
</li>
<li>
<p>Update <code>trivy@latest</code> to 0.76.1.</p>
</li>
<li>
<p>Update <code>tombi@latest</code> to 1.9.0.</p>
</li>
<li>
<p>Update <code>release-plz@latest</code> to 0.3.174.</p>
</li>
<li>
<p>Update <code>prek@latest</code> to 0.5.7.</p>
</li>
<li>
<p>Update <code>mise@latest</code> to 2026.10.17.</p>
</li>
<li>
<p>Update <code>jaq@latest</code> to 3.1.2.</p>
</li>
<li>
<p>Update <code>espup@latest</code> to 0.17.1.</p>
</li>
<li>
<p>Update <code>cargo-zigbuild@latest</code> to 0.24.0.</p>
</li>
<li>
<p>Update <code>cargo-nextest@latest</code> to 0.9.149.</p>
</li>
<li>
<p>Update <code>biome@latest</code> to 2.6.2.</p>
</li>
</ul>
<h2>[2.87.30] - 2026-10-21</h2>
<ul>
<li>
<p>Update <code>zizmor@latest</code> to 1.31.1.</p>
</li>
<li>
<p>Update <code>wasmtime@latest</code> to 50.0.0.</p>
</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/taiki-e/install-action/commit/fcf5432d9f50d67e37ee6e29bdb7a224ff67b4a7"><code>fcf5432</code></a> Release 2.86.8</li>
<li><a href="https://github.com/taiki-e/install-action/commit/f62d9e4aee39b59d225de036323247d9aa3bcd5c"><code>f62d9e4</code></a> Update <code>wasmtime@latest</code> to 48.0.1</li>
<li><a href="https://github.com/taiki-e/install-action/commit/f8e3d097225a92555fe656cd8c5ce7aebf885b60"><code>f8e3d09</code></a> Update <code>wasm-tools@latest</code> to 1.258.0</li>
<li><a href="https://github.com/taiki-e/install-action/commit/484825a046ee4cf51ff46e4525d0af31412a277b"><code>484825a</code></a> Update vacuum manifest</li>
<li><a href="https://github.com/taiki-e/install-action/commit/6d0ad88d70ae4ea951105b5f44ac67d1b739df47"><code>6d0ad88</code></a> Update uv manifest</li>
<li><a href="https://github.com/taiki-e/install-action/commit/36fe62475978dfc558afa1765e51c6d9975236e9"><code>36fe624</code></a> Update <code>oxfmt@latest</code> to 1.80.0</li>
<li><a href="https://github.com/taiki-e/install-action/commit/fbcb11bef5d276954dce6be82dd36d31890620a1"><code>fbcb11b</code></a> Update <code>mise@latest</code> to 2026.8.12</li>
<li><a href="https://github.com/taiki-e/install-action/commit/6558a76193bdebc0fcf58fa1120f1c3976bb52b9"><code>6558a76</code></a> Update <code>kingfisher@latest</code> to 2.0.0</li>
<li><a href="https://github.com/taiki-e/install-action/commit/7d183c86d7fdea20b30442a1b39048f143f4dd65"><code>7d183c8</code></a> Update editorconfig-checker manifest</li>
<li><a href="https://github.com/taiki-e/install-action/commit/12f8c84b95b5c8de1be2833276eeae67714b14da"><code>12f8c84</code></a> Update <code>cargo-zigbuild@latest</code> to 0.23.2</li>
<li>Additional commits viewable in <a href="https://github.com/taiki-e/install-action/compare/5b4d68e2e660441203ab128a23676f1e4faf1532...fcf5432d9f50d67e37ee6e29bdb7a224ff67b4a7">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=taiki-e/install-action&package-manager=github_actions&previous-version=2.86.3&new-version=2.86.8)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>


ACKs for top commit:
apoelstra:
ACK 2968f432865f6fa2cada9c8b7900438989ab5c91; successfully ran local tests


Tree-SHA512: 3905b49f736e7577b70244dd1ebcb31a45c39af718544c311a48470d58b5c3d77b1a9b73acf1fb4313a9a3e4d5840e23d42da6eaab6f3e26f8559eb2528da225

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
update trustdocumentation-only discountautomated dependency-update discountmerge-commit duplicate discount
AI analysis · Informational 15/100

This is a routine Dependabot update that changes the version of a third-party GitHub Action used in automated testing workflows. The action installs developer tools like cargo-mutants. There is no indication this change fixes or introduces a security vulnerability in the rust-bitcoin library itself.

AI review queuedMerge rust-bitcoin/rust-bitcoin#7087: build(deps): bump cargo-bins/cargo-binstall from 1.21.1 to 1.22.0by Andrew Poelstra · 1129d94f · Oct 26, 2026 · 2 filesMessage 96 · StrongInformational 15Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7087: build(deps): bump cargo-bins/cargo-binstall from 1.21.1 to 1.22.0

c4e306537b8bb527cbf96239ef56083128dea599 build(deps): bump cargo-bins/cargo-binstall from 1.21.1 to 1.22.0 (dependabot[bot])

Pull request description:

Bumps [cargo-bins/cargo-binstall](https://github.com/cargo-bins/cargo-binstall) from 1.21.1 to 1.22.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/cargo-bins/cargo-binstall/releases">cargo-bins/cargo-binstall's releases</a>.</em></p>
<blockquote>
<h2>v1.22.0</h2>
<p><em>Binstall is a tool to fetch and install Rust-based executables as binaries. It aims to be a drop-in replacement for <code>cargo install</code> in most cases. Install it today with <code>cargo install cargo-binstall</code>, from the binaries below, or if you already have it, upgrade with <code>cargo binstall cargo-binstall</code>.</em></p>
<h4>In this release:</h4>
<ul>
<li>Add <code>--allow-insecure-http</code> to permit plaintext HTTP (<a href="https://redirect.github.com/cargo-bins/cargo-binstall/issues/2606">#2606</a> <a href="https://redirect.github.com/cargo-bins/cargo-binstall/issues/2635">#2635</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/cargo-bins/cargo-binstall/commit/75b4bfae1b2c753a6806bbce6e6cb89b602de33c"><code>75b4bfa</code></a> release: cargo-binstall v1.22.0 (<a href="https://redirect.github.com/cargo-bins/cargo-binstall/issues/2640">#2640</a>)</li>
<li><a href="https://github.com/cargo-bins/cargo-binstall/commit/64125a38d2458f094835ed0830c6c9c6e95e63fd"><code>64125a3</code></a> chore: release (<a href="https://redirect.github.com/cargo-bins/cargo-binstall/issues/2620">#2620</a>)</li>
<li><a href="https://github.com/cargo-bins/cargo-binstall/commit/e192da8de838bd9f11899b4078279e9a359f612e"><code>e192da8</code></a> build(deps): bump clap-cargo from 0.18.3 to 0.19.0 in the deps group (<a href="https://redirect.github.com/cargo-bins/cargo-binstall/issues/2639">#2639</a>)</li>
<li><a href="https://github.com/cargo-bins/cargo-binstall/commit/8f137732cada3c067cb574fe3537fedfe2a6451d"><code>8f13773</code></a> dep: Upgrade transitive dependencies (<a href="https://redirect.github.com/cargo-bins/cargo-binstall/issues/2638">#2638</a>)</li>
<li><a href="https://github.com/cargo-bins/cargo-binstall/commit/4779ab63141bb9636d2f13d77fa07acd4392e72d"><code>4779ab6</code></a> feat: add --allow-insecure-http to permit plaintext HTTP (<a href="https://redirect.github.com/cargo-bins/cargo-binstall/issues/2635">#2635</a>)</li>
<li><a href="https://github.com/cargo-bins/cargo-binstall/commit/b629f84e79e8fbc4f76616a8efd340f3ea605cab"><code>b629f84</code></a> build(deps): bump netdev from 0.45.0 to 0.46.0 in the deps group (<a href="https://redirect.github.com/cargo-bins/cargo-binstall/issues/2632">#2632</a>)</li>
<li><a href="https://github.com/cargo-bins/cargo-binstall/commit/86d826d1f6561da3c7e6328638ebaa2d531d6193"><code>86d826d</code></a> dep: Upgrade transitive dependencies (<a href="https://redirect.github.com/cargo-bins/cargo-binstall/issues/2630">#2630</a>)</li>
<li><a href="https://github.com/cargo-bins/cargo-binstall/commit/b5723a5790b379eeac6713950acef86189492996"><code>b5723a5</code></a> dep: Upgrade transitive dependencies (<a href="https://redirect.github.com/cargo-bins/cargo-binstall/issues/2627">#2627</a>)</li>
<li><a href="https://github.com/cargo-bins/cargo-binstall/commit/44679a2752be2ce0f32f56de19838377ea0e9cd2"><code>44679a2</code></a> build(deps): bump actions/attest from 4.2.1 to 4.2.2 (<a href="https://redirect.github.com/cargo-bins/cargo-binstall/issues/2626">#2626</a>)</li>
<li><a href="https://github.com/cargo-bins/cargo-binstall/commit/f21464c976f072485f2ab0743b3337b66911d97f"><code>f21464c</code></a> build(deps): bump actions/attest from 4.2.0 to 4.2.1 (<a href="https://redirect.github.com/cargo-bins/cargo-binstall/issues/2621">#2621</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/cargo-bins/cargo-binstall/compare/e00d2c94cc0067b77737821097a62d91c0301baa...75b4bfae1b2c753a6806bbce6e6cb89b602de33c">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=cargo-bins/cargo-binstall&package-manager=github_actions&previous-version=1.21.1&new-version=1.22.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>


ACKs for top commit:
apoelstra:
ACK c4e306537b8bb527cbf96239ef56083128dea599; successfully ran local tests


Tree-SHA512: 743c0e4f354f519c05b6193dc347de321987facd9a58641cb39c225f4e85a27fb7a9472546ce7562f71c56ed409cb2ae16225e0ba4708a47efeec1db1ac0e58b

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
documentation-only discountautomated dependency-update discountmerge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Informational 15/100

This is a routine automated update by Dependabot that changes which version of a helper tool (cargo-binstall) is used inside two GitHub Actions workflow files. The tool is only used during CI to install other Rust utilities. There is no indication this update fixes a security problem or introduces one.

Security candidateMerge rust-bitcoin/rust-bitcoin#7083: key_expression: Add Xpriv::from_byte_array and Xpub::from_byte_arrayby Andrew Poelstra · 1c363f4f · Oct 26, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7083: key_expression: Add Xpriv::from_byte_array and Xpub::from_byte_array

245733dab9ad8b4917ccc754361e291ceab9440a key_expression: Add Xpriv::from_byte_array and Xpub::from_byte_array (PeterXMR)

Pull request description:

An encoded extended key is always 78 bytes and `encode` already returns `[u8; 78]`, so add `Xpriv::from_byte_array` and `Xpub::from_byte_array` taking `&[u8; 78]`, and make the internal `Common::decode` take the array too.

`decode(&[u8])` is kept unchanged so callers holding a slice, `Vec` or boxed slice keep working via deref coercion without a conversion. It now checks the length, still returning `XkeyDecodeError::WrongExtendedKeyLength` on a mismatch, and delegates to `from_byte_array`. `FromStr` behaves as before.

This is purely additive, there is no API break.

Tests cover `decode` and `from_byte_array` agreeing on valid keys, `decode` rejecting 0, 77 and 79 byte inputs, and `FromStr` returning `InvalidBase58PayloadLength` for payloads of those lengths.

Closes #4196

This patch was written with the assistance of an LLM (Claude Opus 5.5) and reviewed by me.


ACKs for top commit:
apoelstra:
ACK 245733dab9ad8b4917ccc754361e291ceab9440a; successfully ran local tests
tcharding:
ACK 245733dab9ad8b4917ccc754361e291ceab9440a


Tree-SHA512: 2652c590d8e707a33d33cc0c70ccfe9f6dca24f56f7ce83b5bb757e7b4aa35392e8408919b78cd50e8a274d9e3f9aa8a7e398c51d298e8021b63e2c32a752705

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit adds two new helper functions, Xpriv::from_byte_array and Xpub::from_byte_array, for decoding Bitcoin extended keys from a fixed 78-byte array. It also moves the length check out of an internal helper so the new functions can rely on Rust's type system for length safety. The existing decode(slice) API is preserved and still validates length. There is no security bug or vulnerability here—this is a routine, purely additive API improvement with added tests.

Security candidateRemove default XOnlyPublicKey serde implby Mitchell Bagot · 50940cb2 · Oct 26, 2026 · 1 fileMessage 68 · AdequateInformational 20Details
Commit message · Mitchell Bagot

Remove default XOnlyPublicKey serde impl

With the new x_only_serde module, the default XOnlyPublicKey serde impl
can be entirely dropped.

Remove the default XOnlyPublicKey serde impl.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
cryptography-sensitive path
AI analysis · Informational 20/100

This commit removes the automatic serialization/deserialization support for the XOnlyPublicKey type in the rust-bitcoin library. Previously, serializing this type would silently drop the 'parity' bit (a small piece of metadata indicating whether the full public key was even or odd). Now users must explicitly choose a serialization format from a new module. This is a design cleanup that prevents accidental data loss when the type is serialized, but it is not a fix for an active security vulnerability.

Security candidateRemove uses of default XOnlyPublicKey serdeby Mitchell Bagot · 877faa8f · Oct 26, 2026 · 5 filesMessage 68 · AdequateInformational 18Details
Commit message · Mitchell Bagot

Remove uses of default XOnlyPublicKey serde

Before removing the current default XOnlyPublicKey serde impl, the
existing uses of it should be removed or replaced by the equivalent
format from the new x_only_serde module.

Replace all uses of the old XOnlyPublicKey serde with the new
x_only_serde.
Remove derived serde impl on ControlBlock and TweakedPublicKey.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
cryptography-sensitive path
AI analysis · Informational 18/100

This commit removes and replaces default serialization/deserialization handling for a special Bitcoin public key type (XOnlyPublicKey) in the rust-bitcoin library. It is a cleanup/refactoring change to prepare for a future removal of the old default serde implementation. It also removes derived serde support from two related types (ControlBlock and TweakedPublicKey). There is no direct security fix here; it is an internal API and test-data cleanup.

Security candidateAdd x_only_serde module for XOnlyPublicKey serde encodingby Mitchell Bagot · 65ea85ba · Oct 26, 2026 · 2 filesMessage 73 · AdequateInformational 12Details
Commit message · Mitchell Bagot

Add x_only_serde module for XOnlyPublicKey serde encoding

Currently, the x-only public key serde encodes and decodes using the
inner type, without any parity. Since the bitcoin-crypto type holds the
parity, this makes the type unable to roundtrip odd parity keys.
Instead, with or without parity encoding should be selectable by users.

Add x_only_serde module that provides with_parity and without_parity
serde encoding for the XOnlyPublicKey type.

Assisted by: Claude Opus 5.5

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
cryptography-sensitive path
AI analysis · Informational 12/100

This commit adds a new optional serde (serialization) helper module for x-only public keys. It does not change existing behavior or fix a vulnerability; it gives library users an explicit choice between round-tripping parity information or discarding it. There is no security bug visible in the diff.

Lower-priorityprimitives: Group pub extern cratesby Tobin C. Harding · e9f2c16a · Oct 25, 2026 · 1 fileMessage 60 · AdequateTriage 0Details
Commit message · Tobin C. Harding

primitives: Group pub extern crates

As we do in `units` group the extern crates and remove newlines just
to be a bit more terse with no loss of clarity.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Lower-priorityprimitives: docs: Copy policy from unitsby Tobin C. Harding · ea33f095 · Oct 25, 2026 · 1 fileMessage 60 · AdequateTriage 0Details
Commit message · Tobin C. Harding

primitives: docs: Copy policy from units

Copy the top level rustdoc section on `Policy` from `units`.

No reason not to.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Lower-priorityprimitives: Remove broken link from changelogby Tobin C. Harding · f31a35e3 · Oct 25, 2026 · 1 fileMessage 72 · AdequateTriage 0Details
Commit message · Tobin C. Harding

primitives: Remove broken link from changelog

The links don't work for point releases because we don't release them
from master. Just remove the link markdown.

72/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Explains rationale or failure mode
Why it was queued
documentation-only discount
Lower-priorityMerge rust-bitcoin/rust-bitcoin#7081: units: Finish using amount test helpersby Andrew Poelstra · 9317d3b6 · Oct 25, 2026 · 2 filesMessage 100 · StrongTriage 0Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7081: units: Finish using amount test helpers

782f83ce6f28fb7948ad045cebce79b418024eda units: Document amount test helpers (PeterXMR)
2226fdfc01bf555110ee2d9e03895fe09e96314b units: Finish using amount test helpers (PeterXMR)

Pull request description:

#6988 switched most of the amount tests over to the `sat`, `ssat`, `res` and `sres` helpers. This finishes the job across all amount test code:

- the `add` and `sub` tests built the expected `NumOpResult` with `sat(n).into()` / `ssat(n).into()`; they now use `res(n)` / `sres(n)`.
- the `check_res!` macro defined its own `from_sat(..).unwrap()` closure and wrapped amounts with `NumOpResult::from`; it now takes the helper names (`check_res!(sat, res, ..)`) instead of the amount type.
- a few remaining `NumOpResult::Valid(..)` / `NumOpResult::from(..)` wrappers in `tests.rs`, including around `Amount::ZERO` / `SignedAmount::ZERO`, now use `res` / `sres`.
- the tests in `amount/ops.rs` called `Amount::from_sat_u32` / `SignedAmount::from_sat_i32` directly because the helpers were private to `amount/tests.rs`. The helpers are now `pub(super)` and imported there. The `sat`, `ssat` and `res` locals in those tests are renamed so they don't shadow the helpers.

The second commit adds a short doc comment to each of `sat`, `ssat`, `res` and `sres`.

Tests outside the `amount` module (`fee.rs`, `fee_rate/mod.rs`, `result.rs`) are intentionally left as they are, since the helper names are too terse to use outside `amount`.

I went with `pub(super)` rather than moving the `ops` tests into `tests.rs` to keep the diff small; happy to move them instead if preferred.

After this, the only direct constructor calls left in amount test code are inside the helpers. `NumOpResult::from` is still used around `MAX_MONEY` constants, which the integer helpers don't cover.

Test refactor only.

Closes #4211

This patch was written with the assistance of an LLM (Claude Opus 5.5) and reviewed by me.


ACKs for top commit:
apoelstra:
ACK 782f83ce6f28fb7948ad045cebce79b418024eda; successfully ran local tests
tcharding:
ACK 782f83ce6f28fb7948ad045cebce79b418024eda
satsfy:
ACK 782f83ce6f28fb7948ad045cebce79b418024eda


Tree-SHA512: 3aa6273482abc573e9416d6bff4d775aec2f18da2224f3e6ba31c368eb5e93b168032868ae2b51f46d727ffb69852d339d26dc7443c4d84f385398d66a02c647

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityTapTree tweaks to make it easier to implement an encoderby Nick Johnson · 56d52c26 · Oct 25, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Nick Johnson

TapTree tweaks to make it easier to implement an encoder

Two tweaks are required to make writing a TapTree encoder way easier,
using the existing IterEncoder primitive.

The first is to derive Clone on the TapTree's iterators. This is a
requirement for IterEncoder to calculate and exact size to encode. This
does expand the public API, but isn't a large chunk of logic since it
is just exposing the Clone functipnallity of the inner types. The Debug
trait is also added to be more inline with the policy of the repository.

The second tweak is to loosen the lifetime of the leaves by tying them to
the tree itself. It overrides the lifetime to self (ScriptLeaf) and
connects it to the tree's lifetime where the data lives. This makes it
easy for the *tree* encoder to reference the data and avoid unnecessary
clones. It is backwards compatible since it "loosening" the lifttime by
tieing it to a longer one.

A cosmetic change is renaming the ScriptLeaf lifetime from 'leaf to
'tree. I think this generally makes more sense, the view is tied to the
tree, even though it is possible to create a ScriptLeaf view on a single
leaf.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityMerge rust-bitcoin/rust-bitcoin#7080: io, hashes: Override write_all for hash enginesby Andrew Poelstra · 07ff043b · Oct 25, 2026 · 2 filesMessage 91 · StrongTriage 0Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7080: io, hashes: Override write_all for hash engines

60a7bfce573a340538dd618725ea04948504c71a io: Override write_all for hash engines (PeterXMR)
a8a612d6188c6b819f0a05e82420414a15dbf4fc hashes: Override write_all for std::io::Write (PeterXMR)

Pull request description:

Hash engines consume the whole buffer on every `write`, so the default `write_all` loop, with its `Interrupted` and zero-length handling, only ever runs once. Override `write_all` in the `impl_write!` macros to feed the buffer to `HashEngine::input` directly, as suggested by Kixunil in https://github.com/rust-bitcoin/rust-bitcoin/pull/3961#discussion_r1948708494.

- Patch 1 does it for `std::io::Write` in `hashes`.
- Patch 2 does it for `bitcoin_io::Write` in `io`.

The existing `write_test!` cases in `io/src/hash.rs` already hash 0, 256 and 64000 bytes through `write_all` and check the digests.

Close #4034

This patch was written with the assistance of an LLM (Claude Opus 5.5) and reviewed by me.


ACKs for top commit:
apoelstra:
ACK 60a7bfce573a340538dd618725ea04948504c71a; successfully ran local tests


Tree-SHA512: 136bb4ca8269ff765a67b44f69012212279039e93bb6fd79272326236b2d2068f4c8065d49be8732629a4e152461e860d1f15e1b3e3a87c36e4079548c980e96

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount