rust-bitcoin

Add `impl Clone for Box<{custom DST}>`

`Script<T>` and `PushBytes` are unsized types wrapping `[u8]`. The standard
library only provides `Clone for Box<T>` where `T: Clone + Sized`, so
`Box<Script<T>>` and `Box<PushBytes>` were missing `Clone` implementations.

Add manual `impl<T> Clone for Box<Script<T>>` and `impl Clone for
Box<PushBytes>` that clone the underlying bytes and wrap them in new boxed
values via `from_boxed_bytes` / `from_boxed_slice_unchecked`.

Also add the corresponding `Box<{Script variant}>` and `Box<PushBytes>` fields
to the API test's `Clone` struct (guarded by `#[cfg(feature = "alloc")]`) so
that these impls are covered by the compile-time API surface tests.

primitives: Remove todo

Just remove it and document that state machine code is often verbose.

primitives: Bump version to 0.103.0

In preparation for release add a changelog entry, bump the version,
and update the lock files.

bitcoin: Depend on encoding 1.1.0

The `bitcoin` crate uses the `hex` feature of `encoding` which only
came out in `1.1.0` so we need to explicitly depend on that version.

Automated update to rustc stable-1.97.1

fuzz: update to target 0.32.102

test: V1NetworkMessage sendcmpct should be either 1 or 0

Add a test that if the mode bit of the sendcmpct should fail if not 1 or
0.

p2p: make SendCmpct encode/decode idempotent

Normalizing the mode bit makes serialization/deserealiztion _not_
idempotent. That's due to the checksum that's created before
normalization which if serialized again, no longer has the same
checksum. This cases a failure to serialize the same `SendCmpct` which
was received if the mode bit is anything other then 0 or 1.
Furthermore, the spec https://bips.dev/152/ defines only 0
(low-bandwidth mode) or 1 (high-bandwidth mode) so anything other than
0 or 1 is unspecified and should result in an error.

As quoted from spec https://bips.dev/152/:
The first integer SHALL be interpreted as a boolean (and MUST have a
value of either 1 or 0)

Update API files

Move error types to error submodules

In the crates, all error types should be defined within error submodules
and then re-exported no_inline in the main module. Currently, we have
two error types that do not follow this pattern in units and primitives.

Move error types to error submodules and re-export no_inline.

Update API files

Add Extend impl to Witness

Per the C-COLLECT API guideline, any collection type that implements
FromIterator should also implement Extend. Since the Witness type
already has the push method, and FromIterator impl, it is clearly
intended to be usable like a collection and should thus also have
Extend.

Add Extend impl to Witness.

Add Debug impl to witness::Iter

The C-DEBUG API guideline recommends that all public types implement
Debug. The witness::Iter type is the only public type in primitives
which does not implement Debug, and thus should have a Debug derive
added to it.

Add derive(Debug) impl to witness::Iter.

hashes: bump version to 1.1.0

Make Witness FromIterator infallible

The current Witness FromIterator impl uses the WitnessDecoder
internally. This was initially done as a means of reducing the
allocations needed to construct the type. However, for DoS protection,
the WitnessDecoder has various limitations that make it unsuitable for
infallible Witness construction. Instead, the old infallible solution
should be used, but tweaked to remove the previous per-item allocations
from the iterator collection.

Adjust the Witness FromIterator implementation to use a collect and
from_slice call to remove the incorrect function beyond the DoS
protection limits of the WitnessDecoder.

Use DebugTuple for Builder debug

The Builder Debug impl currently calls through to Display which
eventually calls down to Script's Display. For empty scripts, this can
render as a empty string. Per the C-DEBUG-NONEMPTY API guideline, all
Debug impls should always render something, even for conceptually empty
types.

Use DebugTuple in the Builder Debug to render the struct name around
the internal content.

fuzz: Fix stale script

As usual the `generate-files.sh` script is stale. Update it using the
contents of `fuzz/Cargo.toml` so that running script produces no changes.

io: Bump version to 0.6.0

In preparation for release add a changelog entry, bump the version
number, and update the lock files.

Refactor Encoder and ExactSizeIterator Option impls

Replace match statements with idiomatic Option combinator methods
to flatten code and improve readability.

consensus_encoding: flatten error constructors

Refactor deeply nested error type constructors with chained map_err
calls, This improves readability by making each error conversion step
explicit and avoids deeply nested error constructors.

Allow clippy unnecessary_map_on_constructor in place where readability
is preferred over clippy being right.

consensus_encoding: Deduplicate end() error path in decoders

Both ByteVecDecoder and VecDecoder had identical error handling
patterns in their end methods, structured to check prefix, compare
bytes, return Err with the missing amount. This patch reorders the
logic to compute the missing value first, and early returns when no
bytes are missing.

CompactSizeDecoder end method refactored via pattern matching to
error when either the decoded value is outside the given range
or above the decoded limit.

This reduces the error construction duplication and clarifies the
control flow.

Make ToU64 private

The ToU64 trait was moved from internals to bitcoin recently. When
moved, it was made public in bitcoin as it was used in the public API
of some of the old consensus code. With that consensus code removed,
the trait should be made private.

Make ToU64 pub(crate).

consensus-encoding: Bump version to 1.1.0

In preparation for release add a changelog entry, bump the version,
and update the lock files.

This is a post-1.0 release so we need to be careful here team. Please
spend some time reviewing the output of:

`git diff bitcoin-consensus-encoding-1.0.0 consensus_encoding`

With careful eye for API design choices, things that might make
maintenance harder etc.

Thanks

refactor(bip32): Xpub child tweak api

- Replace ckd_pub_tweak with derive_child_tweak returning XpubChildTweak.
- Remove Xpub::ckd_pub_tweak. Users must use Xpub::derive_child_tweak
and XpubChildTweak instead.

refactor(bip32): rename Xpub and Xpriv derivation methods

- Rename the xpriv and xpub derivation APIs to derive_child and derive_path
- Remove derive_priv, derive_xpriv, derive_pub, derive_xpub, and
ckd_pub. Callers should now use derive_child for single ChildNumber
derivation and derive_path for path derivation.