rust-bitcoin

crypto: Remove unused test from ecdsa

In ecdsa, the write_serialized_signature test was used to test the
serialize_to_writer method on the ecdsa::Signature. Since this was
removed as part of the bitcoin-io dep removal, the test should also
be removed.

Remove write_serialized_signature test case from ecdsa tests module.

Update the API text files

Re-name consensus_encoding main traits

When we did the first implementation of the `consensus_encoding` crate
we used the same names for the public traits as the old encoding code.

In hindsight we should have used the more Rusty terms `Encode` and
`Decode` instead of `Encodable` and `Decodable`.

Bonus points the new names are easier to spell.

Do trivial-ish rename. Leave the `EncodableBytesIter` as is because
the fix to it is non-trivial. Leave the old encoding traits as they
are because they are destined for the grave very soon anyways.

Enable multiple tests in single macro call

Instead of calling the macro to define each test in a single call add
support for multiple tests in one call. Makes the code more terse at
the cost of macro complexity. Also we want to exclude these from the
formatter so a single macro call is way better.

Requires splitting one macro into three and removing the flag at
the front (display, lower, upper).

crypto: Bump version to 0.2.0

Bump the `crypto` version. Update the dep in `bitcoin` and add an
explicit version number in `taproot-primitives`.

In preparation add a changelog entry, bump the version number, and
update the lock files.

Delete psbt module

In #6055 we deprecated the `psbt` module on the `0.32.x` branch. Now
we can delete it from master.

### Context

Development of the PSBT has moved to a separate crate. Hosted on the
new Forgejo instance at:

https://git.rust-bitcoin.org/rust-bitcoin/rust-psbt

Crate name is `psbt-v2` because it has initial support for PSBTv2. The
crate also includes all code from the `0.32.x` branch (as well as
miniscript code). In other words the crate is a drop in replacement
for the `Psbt` type and its functionality.

During release of `psbt-v2 v0.3.0` we attempted to ensure feature
parity with `0.32.x` since the actual migration was done a while back.

The road map for dev of `psbt-v2` is loosely:

- Improve PSBTv2 stuff
- Continue work on supporting Silent Payments
- Use crate as a test bed for the process of upgrade of `bitcoin 0.32.x`


Exact strategy of the last point is being worked on. We are
investigating creating a bunch of step-by-step releases to help the
process. To prove (and develop) the process we plan on using:

- miniscript
- psbt-v2
- corepc

fuzz: Migrate p2p fuzz targets to new encoding

p2p: remove deprecated encoders in V1NetworkMessage constructor

`payload.consensus_encode()` is deprecated. Replace with
newer sans/IO `hashes::encode_to_engine()`.

Also, updated the doc comment now that encode no longer has a panic
path.

p2p: return count of bytes hashed sha2_checksum()

When computing the message body from the header, its required to know
the number of bytes. In order to do so, keep track of the number of
bytes hashed.

Implement p2wsh Witness constructor

`p2wsh` constructs a witness inpust script required by a P2WSH output
script, the constructor appends all conditions that should be satisfied
by the output script to redeem the input witness script.

Implement P2WPKH & P2WSH output spend script

`p2sh_p2wpkh` implements the scriptSig required to spend a P2SH-P2WPKH
output, for the spend address, by appending witness version and the
witness program to the output script, for the P2SH input script to unlock.

`p2sh_p2wsh` implements the scriptSig required to spend P2SH-P2WSH
output, for the spend address, appending the witness version and the
32-byte SHA256 hash of the witness script, to be executed alongside
the P2SH input script.

Introduce check to re-exports CI for error types

With the move to error submodules, we should move towards a policy for
error access. Specifically, for any foo::error::FooError, there should
also exist a foo::FooError. This has already been implemented in units
and primitives, but should also be enforced by CI in the case of new
errors.

Add check error reexport script and add to check re-exports CI action.

Assisted by Claude Opus 4.6.

hashes: Add x86 AVX2 8-way dispatch

add dispatcher that handles 8-way

hashes: fold 8-way AVX2 SHA256d into round! macro

use a round! macro to cut ~1060 lines from the unrolled version.
each round becomes a single round!(...) call that almost matches
Core's Transform_8way line-by-line, so it's easy to compare and
review against sha256_avx2.cpp.

refactor, no behavior change.

hashes: Add 8-way AVX2 SHA256d for 64-byte input

add the three transforms for sha256(sha256(64_bytes)) using AVX2
SIMD.

AVX2 uses 256-bit registers, so we can pack eight 32-bit words into
each register and compute 8 independent hashes in parallel with a
single SIMD op.

- Transforms 1 & 2 compute the inner `sha256(64_bytes)`.
- Transform 3 computes sha256(output_of_T1_and_T2).

rounds are fully unrolled (we will use a round! macro to fold them
in the next patch).

test(p2p): Remove legacy encoding logic in `message`

Here we also remove tests for `CheckedData`, as the checksum will be
computed directly.

ref: https://github.com/rust-bitcoin/rust-bitcoin/pull/6076

test(p2p): Remove legacy encoding roundtrip tests in `address`

In the case of these unit tests, the new encoding logic has already been
added alongside the old encoding. This simply removes the old encoding
cases

p2p: Compute checksum when decoding v1 messages

The `sha2_checksum` function is updated to take a `T: Encodable`, which
is passed to `hashes::encode_to_engine`. Two calls to `sha2_checksum`
are unwound, as `Vec<u8>` is not `Encodable`, but both of these
callsites will be removed shortly when `CheckedData` is removed along
with the legacy encoding traits.

Implement `AsRef<PushBytes>` for generic hashes

Some hash types provided by the `bitcoin_hashes` crate are natively
supported by the Bitcoin script and it seems natural that the users
might want to compute the hash from a preimage and push it into the
script. This is already doable by simply calling
`.push_slice(hash.as_byte_array())` because of the impls on `&[u8; N]`
however, we do support these casts in case of other hash types to make
it more convenient to push them into script and signal that it is usual
to put these objects into script.

To close the gap, this commit adds implementations for the missing
hashes.

ext: Add extension trait re-exports

The ext module in bitcoin is supposed to hold re-exports of all
extension traits. During the recent crypto and taproot-primitives moves
some new extension traits were added but not re-exported from ext.

Add NetworkExt, TargetExt, WorkExt, TapLeafHashExt, TapNodeHashExt, and
PrivateKeyExt extension trait re-exports to ext module.

Run the formatter

Use drain instead of flush

The term 'flush' has meaning already in respect to a std writer thus
impiles that a function with 'flush' in the name would call
`writer.flush()` but we do not.

After debate we reached consensus on the verb 'drain' to replace
'flush'.

Rename all 'flush_to_writer' functions to be `drain_to_writer`
repository wide. To keep our API uniform also re-name `flush_to_vec`
to be `drain_to_vec`.

Update the API text files

Move import

There is an unrelated lint warning, no clue how it started showing up
but its a trivial fix. Move import from one feature gated scope to
another.

test(p2p): Replace encoding logic in `message_blockdata`