test(p2p): Replace encoding logic in `message_blockdata`
What the developer wrote
Authored by rustaceanrob
test(p2p): Replace encoding logic in `message_blockdata`
What changed, and why it matters
This is a small test-only change that swaps one set of encoding helper functions for another inside unit tests. It does not touch production code, network behavior, or any security-sensitive logic.
No action required. This is a routine test refactoring.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit updates tests in p2p/src/message_blockdata.rs to use the crate-local encoding::{decode_from_slice, encode_to_vec} helpers instead of the older bitcoin::consensus::encode::{deserialize, serialize} imports. The assertions and test data remain identical. No runtime code is modified.
Changed components
p2p/src/message_blockdata.rs (test module only)Inspect captured patch +6 / −7
diff --git a/p2p/src/message_blockdata.rs b/p2p/src/message_blockdata.rs
index 2e4fc7eb..453a79b4 100644
--- a/p2p/src/message_blockdata.rs
+++ b/p2p/src/message_blockdata.rs
@@ -597,7 +597,6 @@ impl<'a> Arbitrary<'a> for Inventory {
#[cfg(test)]
mod tests {
- use bitcoin::consensus::encode::{deserialize, serialize};
use hex_unstable::hex;
use super::*;
@@ -607,15 +606,15 @@ mod tests {
let from_sat = hex!("72110100014a5e1e4baab89f3a32518a88c31bc87f618f76673e2cc77ab2127b7afdeda33b0000000000000000000000000000000000000000000000000000000000000000");
let genhash = hex!("4a5e1e4baab89f3a32518a88c31bc87f618f76673e2cc77ab2127b7afdeda33b");
- let decode: Result<GetBlocksMessage, _> = deserialize(&from_sat);
+ let decode: Result<GetBlocksMessage, _> = encoding::decode_from_slice(&from_sat);
assert!(decode.is_ok());
let real_decode = decode.unwrap();
assert_eq!(real_decode.version.0, 70002);
assert_eq!(real_decode.locator_hashes.hashes().len(), 1);
- assert_eq!(serialize(&real_decode.locator_hashes.hashes()[0]), genhash);
+ assert_eq!(encoding::encode_to_vec(&real_decode.locator_hashes.hashes()[0]), genhash);
assert_eq!(real_decode.stop_hash, BlockHash::GENESIS_PREVIOUS_BLOCK_HASH);
- assert_eq!(serialize(&real_decode), from_sat);
+ assert_eq!(encoding::encode_to_vec(&real_decode), from_sat);
}
#[test]
@@ -623,14 +622,14 @@ mod tests {
let from_sat = hex!("72110100014a5e1e4baab89f3a32518a88c31bc87f618f76673e2cc77ab2127b7afdeda33b0000000000000000000000000000000000000000000000000000000000000000");
let genhash = hex!("4a5e1e4baab89f3a32518a88c31bc87f618f76673e2cc77ab2127b7afdeda33b");
- let decode: Result<GetHeadersMessage, _> = deserialize(&from_sat);
+ let decode: Result<GetHeadersMessage, _> = encoding::decode_from_slice(&from_sat);
assert!(decode.is_ok());
let real_decode = decode.unwrap();
assert_eq!(real_decode.version.0, 70002);
assert_eq!(real_decode.locator_hashes.hashes().len(), 1);
- assert_eq!(serialize(&real_decode.locator_hashes.hashes()[0]), genhash);
+ assert_eq!(encoding::encode_to_vec(&real_decode.locator_hashes.hashes()[0]), genhash);
assert_eq!(real_decode.stop_hash, BlockHash::GENESIS_PREVIOUS_BLOCK_HASH);
- assert_eq!(serialize(&real_decode), from_sat);
+ assert_eq!(encoding::encode_to_vec(&real_decode), from_sat);
}
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.