rust-bitcoin

Remove unused types and macros from internals::serde

The IntoDeError and serde_struct_human_string_impl macro in
internals::serde are both entirely unused. These two are neither used
privately within internals, nor publicly by other crates.

Drop IntoDeError and serde_struct_human_string_impl from
internals::serde.

Move SerializeBytesAsHex to primitives

The SerializeBytesAsHex type in internals is only ever used in Witness
in primitives. Rather than provide the type from internals, the type
can instead be pasted in-line in the primitives witness module (as a
private type) and used there.

Move SerializeBytesAsHex type as private type to primitives::witness.

Drop wrap_debug module from internals

The wrap_debug module in internals is only ever used in Witness in
primitives. Rather than provide the module from internals, the type
can instead be pasted in-line in the primitives witness module (as a
private type) and used there.

Copy WrapDebug type as private type to primitives::witness and drop
wrap_debug module from internals.

Move serde_round_trip macro to bip32

The serde_round_trip macro from internals is only used in the bip32
module for testing. Rather than pulling it in from internals, it should
instead be defined in-line in the tests module.

Move serde_round_trip macro to bip32. Add bincode dev dependency to
key_expression.

primitives: Re-order transaction code

Put the encoding stuff in the conventional order and put other trait
impls all together.

Do `transaction` separately because its a bit more involved.

primitives: Re-order encoding code

I thought we scrubbed this code but the code layout is not correct
here.

We are trying to make all the encoding code be **exactly** the same
because it is boilerplate and is going to live on various branches.

Re-order the code to match our convention.

Remove Verification re-exports

These re-exports exist from the days when secp required an explicit
context for cryptographic operations. With the introduction of the
global context in recent secp versions, they are no longer needed.

Remove Verification re-exports from key modules.

policy: update docs on ordering derives

`rust-ordering` is no longer recommended and was removed from the
workspace in #4065 (38c8c9).

There are types like `NetworkKind` which derive order and it is used
downstream in other workspace packages to also derive order (e.g. Xpub).
I believe this derive actually caused issues before in v0.32.4,
discussed in issue #4116. But it probably low risk going forward since
the enum is exhaustive and I don't think someone would change the
variant order just for fun.

This more general policy is discussed in #3865.

units: Add mention of wu to hex parsing functions

The `Weight` type has a bunch of constructors each of which mentions
the unit used. However the hex parsing constructors do not mention the
weight unit, add it.

units: Use uniform docs style for 1000

We have '1000' and also '1,000' - pick one and be uniform.

Favour using the comma because we already have other usages eg
1,000,000

units: Fix typo

Should be 'from amount' like the other constructors that take an
`Amount` type.

units: Use little t in docs

We use locktime 'n' (lowercase) but time 'T' (uppercase) in docs.
There does not seem to be a reason, I think lowercase reads better.
This may be subjective.

units: Use uniform whitespace in consts

In some places we have no newlines between associated consts and in
others we have newlines. Lets pick one and be uniform.

Elect to use whitespace.

\me ducks to avoid flaming.

units: Group private and public modules separately

As is customary group the private modules above the public ones.

units: no_inline error

As is customary here, use `no_inline` on error re-export.

units: Fix fee_rate docs

Users get unit using the `to_sat_per` family of functions not
`from_sat`.

units: Remove unnecessary unit tests

We have two unit tests that test that we call through from a
deprecated function to its replacement. Remove them.

units: Remove all deprecated code

In preparation for releasing `v1.0.0` remove all deprecated code.

Update the API text files

units: Remove usage of deprecated to_hex

This function is deprecated, no need to use it in test code.

Replace usage of secp256k1::Error with new errors in key

As part of the goal of providing more precise error types, the new
error types should be used for the from_bytes, from_secret_bytes and
verify functions on the key types. This also requires replacement of
the various Secp256k1 variants in enum error types.

Replace Secp256k1 error variants with specific error types and
replace error return types with specific types for from_bytes,
from_secret_bytes and verify functions.

Replace usage of secp256k1::Error with new error in ecdsa

The ecdsa::InvalidDerError can be used both in the key verify
functions but also to replace the Secp256k1 variant in DecodeError.

Replace DecodeError::Secp256k1 variant with InvalidDer.

crypto: Remove all From impls for error types

Aside from From<Infallible>, error types should not have any From
impls but should instead make use of map_err. This ensures greater
future flexibility for changes to the error types moving forward.

Remove From<InvalidSighashTypeError> for SigFromSliceError from
taproot.

Remove Secp256k1 variant from taproot SigFromSliceError

The Secp256k1 variant of the SigFromSliceError is no longer needed.
The secp parsing of the signature is now infallible, meaning there
cannot be a secp error during parsing of a signature from a slice.

Remove Secp256k1 error variant from taproot::SigFromSliceError.

Introduce errors for byte parsing and verification

At present, the from_bytes, from_secret_bytes and verify methods on
the key types all return secp256k1::Error. In all of these methods,
only a single variant of that error type is returned. To both hide
the secp type, and to provide the possibility for more meaningful
error values, new error types should be introduced.

Add FromSecretBytesError, InvalidPublicKeyError and VerifyError to
key errors.
Add InvalidDerError error type to ecdsa error submodule.