LD
← All projectsLedger

Ledger Bitcoin app

Open-source Bitcoin application running on Ledger devices; the device OS is outside this repository.

BitcoinHardware walletsNormal
Repository coverage

301 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

75security candidates126second-pass queue301AI analyses
51commits · 30 days
82commits · 60 days
231commits · 180 days
301commits · 365 days
Backfill bands
Aug 5 → Feb 670 seen8 candidatesComplete
Feb 6 → Jun 6149 seen21 candidatesComplete
Jun 6 → Jul 623 seen0 candidatesComplete
Jul 6 → Aug 555 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

51/100 average clarity
13Strong · 80–100
76Adequate · 60–79
157Thin · 40–59
55Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Salvatore Ingala16748167455
Ilya Artemov952695145
github-actions[bot]17117046
Mathias BROUSSET14014040
José Luis Landabaso Díaz404067
Cerberus Merlin101062
iartemov-ledger101043
Michael Evans101073
Charles-Edouard de la Vergne101045
Analysis record

Published AI watches

Last scanned 14 minutes ago

Moderate 59 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #542 from LedgerHQ/musig-fixes

This commit fixes missing error handling in the Ledger Bitcoin app's MuSig2 multi-signature code. Several cryptographic functions could fail silently or return incorrect results because their error codes were ignored. The patch now checks …

Missing error propagation in cryptographic point operationsUnchecked return value of crypto_tr_lift_x could lead to use of an unspecified pointUnchecked point_add return value in key aggregation, nonce aggregation, and tweaking
0fec192fby Salvatore Ingala+21−63 files
No security note in commit
Moderate 59 AI analysisMessage 65 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix missing return value checks for point_add calls

This commit fixes three places in the Ledger Bitcoin app's MuSig2 code where the result of an elliptic-curve point-addition operation was not checked for failure. If point_add fails (for example, because it produced the special 'point at i…

Unchecked cryptographic operation return value (point_add)Potential use of invalid/infinite elliptic-curve point in MuSig2 aggregationMuSig2 nonce aggregation failure path now returns correct cosigner index
b1132395by Salvatore Ingala+14−52 files
No security note in commit
Moderate 59 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Propagate crypto_tr_lift_x errors in cpoint

This commit fixes a small but meaningful bug in the Ledger Bitcoin app's code that handles advanced multi-signature (MuSig) operations. A function called crypto_tr_lift_x can fail when given an invalid x-coordinate that does not correspond…

Unchecked return value from cryptographic point-lifting functionPotential use of invalid/uninitialized curve point in MuSig signing flowMissing error propagation in compressed public-key parsing
18647877by Salvatore Ingala+7−12 files
No security note in commit
High 72 AI analysisMessage 58 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #539 from LedgerHQ/fix-stack-exhaustion

This update fixes a stack-exhaustion weakness in Ledger's Bitcoin app. A malicious or unusually crafted wallet policy (the text string that describes how coins can be spent) could make the app recurse so deeply that it runs out of call sta…

Stack exhaustion / unbounded recursion in policy parsing and validationMissing depth accounting for miniscript wrapper chainsLarge automatic arrays inside recursive functions (compute_thresh_ops / compute_thresh_stacksize)
1621b7faby Salvatore Ingala+371−1427 files
Vendor flagged security relevance
Low 41 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reduce the stack frame of key_orderings_count

This commit rewrites a function in the Ledger Bitcoin app to use less memory. The old code stored a large table of key-derivation pairs for every possible class of key expression, which grew quadratically with the maximum number of key exp…

Large stack allocation removed (quadratic memory reduced to linear)Integer types narrowed based on stated boundsNo explicit security claim in commit message or diff comments
2e39aa2aby Salvatore Ingala+29−361 file
No security note in commit
Low 27 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Move the wallet confirmation stage out of the handler's frame

This commit refactors the Ledger Bitcoin app's wallet registration code so that the user-confirmation step runs in a separate function that the compiler is told not to inline. The stated goal is to reduce peak stack memory use by freeing l…

Stack memory layout hardening via noinline separation of validation and UI phasesReduction of peak stack footprint for deeply recursive policy validationRefactor only: no change to validation rules, cryptographic checks, or UI logic
ff2a7c7aby Salvatore Ingala+107−861 file
No security note in commit
Moderate 59 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Limit the amount of nesting for `thresh` fragments to 4

This commit fixes a stack-overflow risk in Ledger's Bitcoin app when parsing wallet policies that deeply nest 'thresh' miniscript fragments. It limits nesting to four levels and prevents two helper functions from being inlined so their lar…

Stack-frame bloat from inlined functions with large local arraysRecursive policy-tree walker with unbounded nested thresh inputPotential stack exhaustion / overflow on crafted miniscript policy
d4e23574by Salvatore Ingala+68−73 files
No security note in commit
Low 36 AI analysisMessage 55 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Add functional tests for the policy depth limits

This commit adds automated tests to the Ledger Bitcoin app to check that very deep or heavily nested wallet policies are rejected safely. The tests confirm that an over-deep policy returns an error instead of freezing or crashing the devic…

Tests for policy recursion/depth limitsReference to app constants MAX_PARSE_SCRIPT_RECURSION_DEPTH and MAX_THRESH_NESTINGAssertion that over-deep policy does not crash the app
a81554f8by Salvatore Ingala+51−01 file
No security note in commit
Low 43 AI analysisMessage 70 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Lowers MAX_N_IN_THRESH to 24

This commit reduces a hard-coded limit in Ledger's Bitcoin app on how many branches a 'thresh' miniscript operator can have, from 128 down to 24. The change is framed as a memory-usage improvement, not a security fix. It also adds a test t…

Stack-memory pressure reduction in recursive miniscript analysisHard-coded threshold lowered to prevent large dynamic-programming tablesNew unit test checks rejection of oversized thresh fragments
97ad772aby Salvatore Ingala+38−33 files
No security note in commit
High 72 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Count miniscript wrappers in the parser's recursion depth limit

This commit fixes a bug in the Ledger Bitcoin app's wallet-policy parser. Miniscript 'wrappers' (short letters like 'n' that modify a policy) were not counted toward the parser's recursion-depth safety limit. A crafted wallet descriptor wi…

Stack-exhaustion / denial-of-service via crafted descriptor templateMissing recursion-depth accounting for parser-level wrapper expansionPatch adds explicit depth budget check and regression test
ed7cd029by Salvatore Ingala+75−63 files
Vendor flagged security relevance
Low 31 AI analysisMessage 50 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Delete MAX_POLICY_DEPTH; rather, align with MAX_PARSE_SCRIPT_RECURSION_DEPTH from the parsing stage

This commit changes how deeply nested Bitcoin wallet policies can be when processed by a Ledger hardware wallet app. It removes a separate, smaller limit (10 levels) and instead uses the same deeper limit already applied during an earlier …

Depth-limit constant unified across parsing and processing stagesRemoval of a stricter local limit that could create inconsistent policy acceptanceNo new input validation or memory safety bug introduced by the diff itself
bb5386b0by Salvatore Ingala+3−41 file
No security note in commit
Informational 15 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix wrong comment in policy_node_thresh_t

This commit only changes a code comment to accurately describe how child scripts are stored. It does not alter any actual program logic, data structures, or behavior, so it has no security impact.

fbbdca3fby Salvatore Ingala+1−11 file
No security note in commit
Low 42 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Disable musig in key expressions of musig_a/sortedmulti_a

This commit temporarily blocks a specific advanced Bitcoin wallet feature (MuSig inside multi_a/sortedmulti_a) because the code that reads those wallet descriptions doesn't handle it correctly yet. It's a defensive change to prevent malfor…

Parser hardening for unsupported nested MuSig expressionsAddition of negative unit tests for malformed/unsupported policiesCommentary in code explicitly notes incompatibility and temporary disablement
558854ebby Salvatore Ingala+24−132 files
No security note in commit
Moderate 62 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Additional integrity checks for Merkle proofs

This commit adds extra safety checks when the Ledger Bitcoin app verifies Merkle proofs, which are cryptographic evidence used to confirm that a piece of data belongs to a larger set. The changes ensure that the proof length matches the ex…

Merkle proof length validation against leaf depthEnforcement of Merkle leaf prefix byte 0x00Prevention of streaming invalid preimage data before callback invocation
c44c9b8bby Salvatore Ingala+32−44 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 55 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Add unit tests for get_merkle_preimage

This commit only adds new unit tests for existing code. It does not change any production behavior, fix a bug, or introduce new functionality. The tests verify that certain security checks (proof length and domain separator checks) already…

Test-only commit with no production code changesTests verify existing Merkle proof length validation rejects internal-node-as-leaf and overlong proofsTests verify existing leaf preimage domain-separator check rejects internal-node preimages and non-zero prefixes
05445baeby Salvatore Ingala+334−03 files
No security note in commit
Moderate 59 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Type consistency in psbt_parse_rawtx, and some other hardenings

This commit hardens a Bitcoin transaction parser in Ledger's app. It changes some numeric fields to safer types, adds bounds checks on transaction counts and sizes, rejects extra trailing bytes after a transaction, checks a previously-igno…

Integer type narrowing and sentinel change from -1 to SIZE_MAXBounds checks before uint64_t to unsigned int castsReturn value of parser_consolidate_buffers now checked
1af86279by Salvatore Ingala+66−173 files
No security note in commit
Informational 15 AI analysisMessage 50 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Sign consistency for parser steps; removed stale comment

This commit only changes the declared type of three array-length constants from signed int to unsigned size_t, and removes two stale comments about a 10,000-byte limit. There is no change to program logic, memory allocation, bounds checkin…

373f4a56by Salvatore Ingala+7−72 files
No security note in commit
Moderate 59 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Harden prevout tx parsing checks

This commit tightens how the Ledger Bitcoin app parses previous transaction data when signing Bitcoin transactions. It adds size limits and completion checks that prevent malformed or oversized previous transaction outputs from being proce…

Adds explicit bounds checks on prevout scriptPubKey lengthsSwitches signed integer length arithmetic to size_t to avoid negative-length edge casesAdds completion check for streamed raw previous transaction parsing
0df0add4by Salvatore Ingala+44−64 files
No security note in commit
Informational 18 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix taptree hash computation in test_utils

This commit fixes a copy-paste bug in test helper code used during automated testing of Ledger's Bitcoin app. The bug caused the right-hand branch of a Taproot script tree to be ignored and the left-hand branch to be hashed twice when comp…

Incorrect cryptographic hash construction in Taproot taptree root computationCopy-paste error causing left subtree to be hashed twice and right subtree omittedTest-only code path, not production firmware
7cba440aby Salvatore Ingala+6−52 files
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Do not truncate preset names

This commit removes manual shortening of preset names in a developer-only playground GUI and lets the UI toolkit handle truncation automatically. It is a cosmetic/usability fix with no apparent security relevance.

9f57d1a4by Salvatore Ingala+9−41 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityAdd build-essential and git to speculos-bitcoin imageby Salvatore Ingala · 32788c7e · Nov 17, 2025 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Salvatore Ingala

Add build-essential and git to speculos-bitcoin image

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only changes a CI/testing Docker image used for Ledger's automated test environment. It adds common development tools (build-essential, curl, git) and slightly reorganizes apt commands. There is no indication this affects the actual Bitcoin app that runs on Ledger devices or end-user security.

Lower-priorityUse 'getbalances' rpc to get balanceby Salvatore Ingala · 97c08c13 · Nov 17, 2025 · 4 filesMessage 60 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Use 'getbalances' rpc to get balance

The 'balance' field from 'getwalletinfo' has been removed.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100

This commit only updates automated test scripts to use a different Bitcoin Core RPC command for checking wallet balances. It does not change the Ledger app code that users interact with, and it has no security relevance.

Lower-priorityUse speculos-bitcoin container in CI e2e testsby Salvatore Ingala · 965666f9 · Nov 17, 2025 · 1 fileMessage 78 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Use speculos-bitcoin container in CI e2e tests

The speculos-bitcoin-musig2 custom container was used before
bitcoin-core merged support to MuSig2. It's now no longer useful.

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit simply swaps the name of a test container used in automated CI testing. It changes one line in a GitHub Actions workflow file, switching from a custom 'speculos-bitcoin-musig2' container to a standard 'speculos-bitcoin' container because Bitcoin Core now supports MuSig2 natively. There is no change to the actual app code, no user-facing behavior change, and no security-relevant content.

Lower-priorityDisable multiprocessing when building Bitcoin Coreby Salvatore Ingala · e5b8bbaa · Nov 17, 2025 · 1 fileMessage 65 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Disable multiprocessing when building Bitcoin Core

Some dependencies are missing for multiprocess, and it's anyway
not useful in CI.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit changes a CI Dockerfile used to build Bitcoin Core for testing. It adds a build flag that disables Bitcoin Core's optional multiprocessing (IPC) feature because the build environment lacks the required dependencies. This is a build-configuration convenience change, not a security fix for the Ledger app itself.

Security candidateAllowing for message signature the line feed (LF) character handled by NBGL (2 new tests)by Ilya Artemov · e928b752 · Nov 17, 2025 · 1 fileMessage 65 · AdequateInformational 15Details
Commit message · Ilya Artemov

Allowing for message signature the line feed (LF) character handled by NBGL (2 new tests)

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100

This commit only changes automated test code for the Bitcoin app's message-signing feature. It adds a new test for messages containing a line feed (LF) character and updates an existing test to use a carriage return (CR) instead of a line feed. There is no change to the actual app code that runs on the Ledger device, so this commit does not introduce or fix a security vulnerability by itself.

Security candidateAllowing for message signature the line feed (LF) character handled by NBGLby Ilya Artemov · f4e1a90b · Nov 17, 2025 · 1 fileMessage 55 · ThinInformational 20Details
Commit message · Ilya Artemov

Allowing for message signature the line feed (LF) character handled by NBGL

55/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 20/100

This commit changes how the Ledger Bitcoin app decides whether a message being signed is 'printable' on the device screen. It now allows the Line Feed (newline) character to pass through, because the newer NBGL screen library can display multi-line text. Previously, any character outside the normal visible ASCII range would make the message be shown as a hex dump instead of readable text. The change is a small UI/UX improvement for message signing and does not appear to alter the actual cryptographic signature.

AI review queuedRemoving the special handling and the warning for the suspicious derivation paths (snapshots)by Ilya Artemov · 635044fe · Nov 14, 2025 · 79 filesMessage 50 · ThinInformational 15Details
Commit message · Ilya Artemov

Removing the special handling and the warning for the suspicious derivation paths (snapshots)

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
second-pass: unusually broad change
AI analysis · Informational 15/100

This commit only updates test screenshot snapshots (expected device screen images used in automated testing). It does not change any application code, firmware logic, or user-facing behavior. The title refers to a prior change that removed warnings for unusual Bitcoin key derivation paths; this commit merely refreshes the test images to match that earlier change.

Lower-priorityRemoving the special handling and the warning for the suspicious derivation paths (test framework)by Ilya Artemov · 89bba825 · Nov 14, 2025 · 2 filesMessage 60 · AdequateInformational 12Details
Commit message · Ilya Artemov

Removing the special handling and the warning for the suspicious derivation paths (test framework)

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 12/100

This commit only changes test helper code, not the actual Ledger Bitcoin app that users run. It removes a special test-only shortcut for handling 'suspicious derivation path' warnings and replaces it with more explicit test button presses. There is no direct evidence in the commit that a real security vulnerability was fixed.

Lower-priorityRemoving the special handling and the warning for the suspicious derivation pathsby Ilya Artemov · 2b665f87 · Nov 14, 2025 · 4 filesMessage 50 · ThinLow 37Details
Commit message · Ilya Artemov

Removing the special handling and the warning for the suspicious derivation paths

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 37/100

This commit removes a warning screen that previously appeared when a Bitcoin public key was requested for an unusual or non-standard derivation path. Without the warning, users may be less likely to notice if malicious software asks their Ledger device to reveal keys for a suspicious path. The change itself is a deliberate feature removal, not a hidden bug, but it weakens a user-facing safety check.

Security candidateUsing classical NBGL API for message signing - snapshotsby Ilya Artemov · 0fb99583 · Nov 14, 2025 · 157 filesMessage 50 · ThinInformational 15Details
Commit message · Ilya Artemov

Using classical NBGL API for message signing - snapshots

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100

This commit only updates test screenshot images (snapshots) for the Ledger Bitcoin app's message-signing user-interface tests. It does not change any application source code, cryptographic logic, or device behavior. The snapshots reflect a switch to the 'classical NBGL API' for message signing, but this is a test-asset update, not a security-relevant code change.

Security candidateUsing classical NBGL API for message signing - test adaptationby Ilya Artemov · d30eb8f9 · Nov 14, 2025 · 2 filesMessage 60 · AdequateInformational 15Details
Commit message · Ilya Artemov

Using classical NBGL API for message signing - test adaptation

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing boundary
AI analysis · Informational 15/100

This commit only updates automated test scripts for Ledger's Bitcoin app. It changes how on-screen button presses are simulated during message-signing tests on newer touch-screen devices, switching from one generic test helper to more specific tap coordinates. There is no change to the actual wallet application code that users run, so this cannot directly affect user funds or security.

Security candidateUsing classical NBGL API for message signingby Ilya Artemov · ad031119 · Nov 13, 2025 · 4 filesMessage 45 · ThinLow 27Details
Commit message · Ilya Artemov

Using classical NBGL API for message signing

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 27/100

This commit refactors how the Ledger Bitcoin app displays messages before signing. It replaces a streaming, paginated message-review flow with a single-page review using the standard NBGL API. The change increases the maximum message that can be shown from about 128 bytes to roughly 640 bytes, and removes the intermediate 'loading' start page. There is no direct evidence in the commit that this fixes a security vulnerability; it appears to be a user-interface simplification. However, any change to the confirmation screen logic can affect whether users correctly see what they are signing, so it warrants careful review.

AI review queuedSnapshots update for transaction send: unstreaming, warning unification, status diversificationby Ilya Artemov · b25b44c7 · Nov 7, 2025 · 1991 filesMessage 50 · ThinInformational 15Details
Commit message · Ilya Artemov

Snapshots update for transaction send: unstreaming, warning unification, status diversification

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only updates test screenshot snapshots (PNG images) for the Ledger Bitcoin app. It does not change any application source code, so it cannot directly affect the security of the app or user funds. The images are used by automated tests to verify that the device's on-screen prompts look as expected when signing transactions.

AI review queuedTest framework update for transaction send: unstreaming, warning unification, status diversificationby Ilya Artemov · 73fe541f · Nov 7, 2025 · 4 filesMessage 60 · AdequateInformational 15Details
Commit message · Ilya Artemov

Test framework update for transaction send: unstreaming, warning unification, status diversification

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only updates the automated test framework for the Ledger Bitcoin app. It changes how tests simulate button presses on the device screen, renames some test helper functions, and adds new test cases for transactions with many outputs and for navigating back and forth during signing. There is no change to the actual app code that runs on the Ledger device, so this commit does not introduce or fix a security vulnerability in the product itself.

Security candidateSource code: transaction signature status diversificationby Ilya Artemov · ae9304ab · Nov 7, 2025 · 3 filesMessage 55 · ThinInformational 15Details
Commit message · Ilya Artemov

Source code: transaction signature status diversification

55/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100

This commit is a minor user-interface wording change. It replaces the generic spinner text 'Signing' with the more descriptive phrase 'Signing transaction' shown while the device is computing a Bitcoin transaction signature. There is no change to cryptographic logic, transaction validation, or security behavior.

AI review queuedSource code: unstreaming for transaction send + warning message unificationby Ilya Artemov · 5201e56c · Nov 7, 2025 · 8 filesMessage 50 · ThinLow 33Details
Commit message · Ilya Artemov

Source code: unstreaming for transaction send + warning message unification

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 33/100

This commit refactors how the Ledger Bitcoin app displays transaction details on newer devices (Stax/Flex/Apex). It replaces a streaming, one-output-at-a-time review flow with a non-streaming 'simplified' flow for transactions with up to 16 external outputs, unifies warning messages, and moves warning screens to appear before the main transaction review. The changes are primarily a user-interface restructuring rather than a clear security fix, but they do widen the simplified-review path from 0/1 external outputs to up to 16 and change the order/timing of user warnings.

Lower-priorityMoving the ticker to the end for the swap caseby Ilya Artemov · 20beef19 · Oct 28, 2025 · 1 fileMessage 45 · ThinInformational 17Details
Commit message · Ilya Artemov

Moving the ticker to the end for the swap case

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 17/100

This commit changes how a cryptocurrency amount is formatted on screen during a swap operation. Previously the coin ticker (like 'BTC') appeared before the amount; now it appears after. The change also replaces hard-coded number 8 with a named constant and uses a safer array initialization. There is no direct evidence this fixes a security vulnerability.

Lower-priorityFeezing speculos container version to the one before breaking changesby Ilya Artemov · 2c7956fe · Oct 7, 2025 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Ilya Artemov

Feezing speculos container version to the one before breaking changes

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only changes the version of a testing container used in the project's automated CI workflow. It freezes the Speculos emulator image from 'latest' to a specific older version (0.25.5) because the test suite still uses an old Nano S Bitcoin binary that newer Speculos versions no longer support. There is no change to the actual Bitcoin app code, no user-facing change, and no security fix or vulnerability introduced.

AI review queuedAdding automatic snapshots updateby Ilya Artemov · 77e22e3d · Oct 7, 2025 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · Ilya Artemov

Adding automatic snapshots update

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit only changes a GitHub Actions CI workflow file. It adds a manual option for developers to automatically update test snapshot images when running tests, rather than failing the build. There is no change to the actual Bitcoin app code, no user-facing behavior change, and no security relevance.

AI review queued[auto-update] Update Ragger snapshotsby github-actions[bot] · 07bfe6b4 · Oct 7, 2025 · 286 filesMessage 45 · ThinInformational 15Details
Commit message · github-actions[bot]

[auto-update] Update Ragger snapshots

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only updates test screenshot images (called 'Ragger snapshots') for the Ledger Bitcoin app. No actual application code, transaction logic, or security behavior was changed. It is a routine test-maintenance update and does not affect users' funds or security.

AI review queuedDelete obsolete commentby Salvatore Ingala · be4a94d4 · Sep 29, 2025 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Salvatore Ingala

Delete obsolete comment

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only removes an old developer comment (a 'TODO' note) about a possible future feature. No actual code behavior changes, so it has no security effect on its own.

Security candidateHarden crypto_derive_symmetric_keyby Salvatore Ingala · c63f73cb · Sep 29, 2025 · 3 filesMessage 53 · ThinLow 45Details
Commit message · Salvatore Ingala

Harden crypto_derive_symmetric_key

The function would cause a buffer overflow passed a buffer longer
than 32 bytes. This is not an issue today as it was only ever used
for a fixed short string (WALLET_SLIP0021_LABEL).

The workaround to copy into a local buffer is still needed, so we
defensively forbid longer strings.

53/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly! Too few words to establish purpose
Why it was queued
memory safetydefensive validationcryptography-sensitive pathsigning or wallet path
AI analysis · Low 45/100

This commit fixes a defensive coding issue in the Ledger Bitcoin app. A function that derives a secret key from a text label could overflow an internal 32-byte buffer if given a label longer than 32 bytes. In practice, the app only ever passed one fixed short label, so the overflow was not reachable from normal use. The patch now rejects oversized labels and also handles the rare failure case when generating a wallet security code (HMAC).

AI review queuedApp version bump: snapshotsby Ilya Artemov · 347ee89c · Sep 10, 2025 · 3 filesMessage 35 · OpaqueInformational 15Details
Commit message · Ilya Artemov

App version bump: snapshots

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only updates three test snapshot images for Ledger device screens. These are reference pictures used in automated testing to check that the app's user interface displays correctly. No application code, firmware logic, or security-sensitive files were changed.

AI review queuedAPEX_P snapshotsby Ilya Artemov · 95669f9f · Sep 10, 2025 · 390 filesMessage 18 · OpaqueInformational 15Details
Commit message · Ilya Artemov

APEX_P snapshots

18/100 · OpaqueMessage clarity
✓ Subject identifies a change! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds 390 PNG image files used for automated testing of the Ledger Bitcoin app on a new device variant called 'apex_p'. These are screenshot snapshots that the test suite compares against expected device screens. No application code, no firmware logic, and no user-facing behavior were changed. There is no security risk visible in this commit.

AI review queuedApp version bumpby Ilya Artemov · 2cb54d79 · Sep 10, 2025 · 2 filesMessage 28 · OpaqueInformational 15Details
Commit message · Ilya Artemov

App version bump

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only bumps the app's version number from 2.4.1 to 2.4.2 and updates the changelog to note 'Apex P porting'. There are no code changes, no security fixes, and no functional modifications visible in the diff.