← Watch feed
Merge pull request #558 from LedgerHQ/embit_private
Public commit record
73/100 · Adequate
What the developer wrote
Authored by Salvatore Ingala
Merge pull request #558 from LedgerHQ/embit_private
Mark vendored embit clone 'private' in python client
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
What changed, and why it matters
This commit simply renames an internal Python package from `embit` to `_embit` (a common convention indicating it is private/implementation detail) and updates all import statements accordingly. There is no functional code change and no security fix or vulnerability present in the diff.
Recommended action
No security action required. Treat as a routine refactoring / packaging hygiene change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit renames the vendored bitcoin_client/ledger_bitcoin/embit/ directory to bitcoin_client/ledger_bitcoin/_embit/ and updates imports in client.py, test_utils/musig2.py, test_utils/txmaker.py, and test_utils/wallet_policy.py to reference the new _embit package. The leading underscore is a Python convention marking the module as private. No logic changes, no cryptographic changes, and no bug fixes are visible.
Changed components
bitcoin_client/ledger_bitcoin/_embit/ (renamed vendored package)bitcoin_client/ledger_bitcoin/client.pytest_utils/musig2.pytest_utils/txmaker.pytest_utils/wallet_policy.pyInspect captured patch +7 / −7
### bitcoin_client/ledger_bitcoin/_embit/LICENSE
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/_embit/README.md
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/_embit/__init__.py
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/_embit/base.py
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/_embit/base58.py
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/_embit/bech32.py
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/_embit/bip32.py
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/_embit/compact.py
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/_embit/descriptor/__init__.py
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/_embit/descriptor/arguments.py
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/_embit/descriptor/base.py
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/_embit/descriptor/checksum.py
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/_embit/descriptor/descriptor.py
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/_embit/descriptor/errors.py
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/_embit/descriptor/miniscript.py
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/_embit/descriptor/taptree.py
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/_embit/ec.py
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/_embit/hashes.py
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/_embit/misc.py
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/_embit/networks.py
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/_embit/script.py
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/_embit/util/__init__.py
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/_embit/util/ctypes_secp256k1.py
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/_embit/util/key.py
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/_embit/util/py_ripemd160.py
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/_embit/util/py_secp256k1.py
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/_embit/util/secp256k1.py
[binary or diff unavailable]
### bitcoin_client/ledger_bitcoin/client.py
@@ -3,10 +3,10 @@
import base64
from io import BytesIO, BufferedReader
-from .embit import base58
-from .embit.base import EmbitError
-from .embit.descriptor import Descriptor
-from .embit.networks import NETWORKS
+from ._embit import base58
+from ._embit.base import EmbitError
+from ._embit.descriptor import Descriptor
+from ._embit.networks import NETWORKS
from .command_builder import BitcoinCommandBuilder, BitcoinInsType
from .common import Chain, read_uint, read_varint
### test_utils/musig2.py
@@ -46,7 +46,7 @@
extract_placeholders,
)
-from bitcoin_client.ledger_bitcoin.embit.descriptor.miniscript import Miniscript
+from bitcoin_client.ledger_bitcoin._embit.descriptor.miniscript import Miniscript
from bitcoin_client.ledger_bitcoin.psbt import PSBT, PartiallySignedInput
from bitcoin_client.ledger_bitcoin.key import G, ExtendedKey, bytes_to_point, point_add, point_mul, point_to_bytes
from bitcoin_client.ledger_bitcoin.wallet import WalletPolicy
### test_utils/txmaker.py
@@ -29,7 +29,7 @@
from embit.networks import NETWORKS
from embit.script import Script
-from bitcoin_client.ledger_bitcoin.embit.descriptor.miniscript import Miniscript
+from bitcoin_client.ledger_bitcoin._embit.descriptor.miniscript import Miniscript
from test_utils import bip0340, sha256, hash160
from test_utils.bip0327 import cbytes, key_agg
from test_utils.wallet_policy import DescriptorTemplate, KeyPlaceholder, MuSig2KeyPlaceholder, PlainKeyPlaceholder, ShDescriptorTemplate, ShWpkhDescriptorTemplate, ShWshDescriptorTemplate, TrDescriptorTemplate, WshDescriptorTemplate, WpkhDescriptorTemplate, PkhDescriptorTemplate, derive_plain_descriptor, tapleaf_hash
### test_utils/wallet_policy.py
@@ -15,7 +15,7 @@
if _REPO_ROOT not in sys.path:
sys.path.insert(0, _REPO_ROOT)
-from bitcoin_client.ledger_bitcoin.embit.descriptor.miniscript import Miniscript
+from bitcoin_client.ledger_bitcoin._embit.descriptor.miniscript import Miniscript
from bitcoin_client.ledger_bitcoin.key import ExtendedKey
from test_utils.taproot import ser_script, tagged_hash
Risk score
Our methodology →Why this scored 15/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.