KS
← All projectsKeystone

Keystone 3 firmware

Open-source device firmware for Keystone 3 hardware wallets.

BitcoinHardware walletsNormal
Repository coverage

562 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

125security candidates296second-pass queue559AI analyses
5commits · 30 days
9commits · 60 days
185commits · 180 days
402commits · 365 days
Backfill bands
Aug 5 → Feb 6260 seen14 candidatesComplete
Feb 6 → Jun 6117 seen7 candidatesComplete
Jun 6 → Jul 639 seen4 candidatesComplete
Jul 6 → Aug 5115 seen4 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

43/100 average clarity
39Strong · 80–100
75Adequate · 60–79
213Thin · 40–59
235Opaque · 0–39
39security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
soralit11634116248
Adam Tucker931193263
aaron30430248
Soralit11711154
ww351268717652176026
github-actions[bot]656074
willwang15215025
John Boyd626088
Aaron Chen222068
Qkin-Keystone26126036
qkin12112050
Greg Pfeil616074
Analysis record

Published AI watches

Last scanned 56 minutes ago

Moderate 56 AI analysisMessage 81 · Strong
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Stop the wallet-prep countdown when its label goes (#2324)

This commit fixes a firmware crash and a timer-doubling bug in a cryptocurrency hardware wallet. If a user scanned a transaction too quickly after unlocking, a countdown timer could keep running after its on-screen label was destroyed, cau…

Use-after-free/dangling reference in UI timer callbackOrphaned timer leak causing accelerated countdown behaviorFirmware crash triggered by user timing (quick unlock → scan)
7da0b941by Greg Pfeil+0−00 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

fix(zcash): Fix regression in 3.2.2, improve performance by 15-18%, reduce firmware size by 4.4% (#2330)

This commit updates a Zcash cryptography dependency and changes compiler hints to fix a firmware performance regression and reduce firmware size. There is no security-relevant change visible in the diff.

36859d27by Jack Grigg+4−22 files
No security note in commit
Low 28 AI analysisMessage 81 · Strong
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Send the whole `g_checkResult` to the UI task (#2323)

A firmware fix for a data-passing bug between internal tasks. The code was accidentally sending only the memory address size of a result structure, not the full result. Right now this only affects the rarely-used error_message field, but i…

Incorrect size passed in inter-task message (sizeof pointer instead of sizeof structure)Structure member truncation could leak partial or stale data to UI taskCrash observed by developer when accessing the omitted error_message field
6f0fb82bby Greg Pfeil+0−00 files
No security note in commit
Low 45 AI analysisMessage 61 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

release 3.2.2 (#2327)

This is a routine firmware release (version 3.2.2) for the Keystone 3 hardware wallet. The main user-visible change is adding support for the Zcash NU7 network upgrade. The code changes mostly update Zcash-related Rust libraries to newer v…

Zcash dependency major-version upgrades and API migration for NU7 compatibilityLock-screen countdown timer now initialized to NULL and explicitly stopped on label deletion, reducing dangling-timer riskTransaction-check-fail signal fixed to pass correct struct size instead of pointer size
08150faeby github-actions[bot]+1032−90129 files
No security note in commit
Informational 19 AI analysisMessage 65 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore(release): 3.2.0 (#2315)

This commit is a routine version-bump release (3.2.0) for the Keystone 3 firmware. The visible changes are almost entirely code formatting/indentation, removal of unused imports and dead code, adding 'deprecated' annotations to legacy Bitc…

No security-relevant signals detected in the diff.No mention of CVE, security fix, vulnerability, audit, or bug bounty in commit message or changelog.Changes are cosmetic, dead-code removal, feature gating, and version bump.
3690bf1fby Soralit+674−51576 files
No security note in commit
Moderate 61 AI analysisMessage 80 · Strong
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore: release 3.1.4 (#2311)

This is a large routine firmware release (version 3.1.4) for the Keystone 3 hardware wallet. The visible changes add support for signing Bitcoin Cash, Dash and Dogecoin PSBTs, improve Solana and Tron transaction parsing, add Zcash shielded…

FreeRTOS MPU peripheral region narrowed to PSRAM-only and unprivileged peripheral access now disallowed by compile-time errorNew PSBT signing paths for BCH/DASH/DOGE with custom validation and sighash rulesSolana parser changes and addition of an overflow test fixture (squads-overflow.hex)
d2987b99by github-actions[bot]+18413−6376240 files
No security note in commit
Informational 23 AI analysisMessage 76 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge release v3.1.2 (#2306)

This is a routine firmware release merge (version 3.1.2). The only functional code change visible in the diff adds one more allowed cryptocurrency derivation path prefix, 'm/44'/9000'', for Avalanche (AVAX) X/P-chain addresses when the dev…

Additive change to a path-prefix allowlistNo input validation, parsing, or memory-safety changes visibleNo vendor statement of security relevance in commit or references
f95101fbby github-actions[bot]+23−25 files
No security note in commit
Informational 15 AI analysisMessage 48 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore: update ci (#2302)

This commit only updates a Git submodule pointer (a reference to another repository) in a release-related file. There are no code changes visible in the diff, no description of any security issue, and no references provided. It appears to …

6ef9ddd3by Soralit+1−11 file
No security note in commit
Low 42 AI analysisMessage 58 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge pull request #2293 from KeystoneHQ/merge/v3.1.0

This is a large firmware release merge (v3.1.0) for the Keystone 3 hardware wallet. The visible changes are mostly a major FreeRTOS kernel upgrade (from v10.x to v11.3.0), build-system improvements, and user-facing feature tweaks such as b…

FreeRTOS kernel major version upgrade (10.x -> 11.3.0) with MPU hardeningSwitch from ARM_CM4F non-MPU port to ARM_CM4_MPU portNew MPU configuration flags: configTOTAL_MPU_REGIONS=8, configENFORCE_SYSTEM_CALLS_FROM_KERNEL_ONLY=1, configALLOW_UNPRIVILEGED_CRITICAL_SECTIONS=0
0c0ae467by stone+59616−26981300 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 48 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore: update ci (#2292)

This commit only updates a Git submodule pointer in a release-tracking file. The actual code change is a one-line pointer update from one commit hash to another in a file named 'keystone3-firmware-release'. There is no visible security-rel…

90d1c789by Soralit+1−11 file
No security note in commit
Informational 15 AI analysisMessage 40 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore: update ci

This commit only updates a Git submodule pointer (keystone3-firmware-release) from one commit hash to another. No source code, build scripts, CI configuration, or security-related files are changed in the visible diff. There is no evidence…

a7f6db29by Soralit+1−11 file
No security note in commit
Moderate 58 AI analysisMessage 28 · Opaque
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

release 3.1.0

This is a large firmware release commit (version 3.1.0) for the Keystone 3 hardware wallet. The most significant change visible in the diff is a major upgrade of the FreeRTOS real-time operating system kernel from version 10.x to 11.3.0, c…

FreeRTOS major version upgrade (10.x → 11.3.0) with MPU port enabledNew MPU sandbox task/runtime/validator files addedconfigENFORCE_SYSTEM_CALLS_FROM_KERNEL_ONLY=1 and configALLOW_UNPRIVILEGED_CRITICAL_SECTIONS=0 set
2b007a29by Soralit+59615−26980300 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 76 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge release v3.0.8 (#2291)

This commit is a routine version-bump merge for release v3.0.8. It only updates changelogs, a Git submodule pointer, and a build version number. There is no code change visible in the diff and nothing that suggests a security fix or vulner…

b5e8f9fcby github-actions[bot]+18−24 files
No security note in commit
Low 47 AI analysisMessage 76 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge release v3.0.6 (#2290)

This firmware update adds support for Solana's new V1 transaction format and changes how oversized or malformed transaction details are displayed. The code introduces a dedicated parser for V1 messages with strict size and structure checks…

New parser enforces hard limits on V1 message fields and rejects malformed 0x81-prefix payloads instead of falling back to message signingCompute-budget instructions in V1 are explicitly ignored to prevent fee-display spoofingUI pagination change for large transaction details reduces truncation risk
87b78ae1by github-actions[bot]+564−2812 files
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

pin to new release config (#2285)

This commit only updates a Git submodule pointer (keystone3-firmware-release) from one commit hash to another. There is no code change visible in the diff, no description of what the new release config contains, and no security-related inf…

bc01c889by Aaron Chen+1−11 file
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

update the release repo (#2282)

This commit simply updates a Git submodule pointer for the project's release repository. There is no visible code change, no description of any security issue, and no indication this is anything other than a routine release-tracking update.

3ac7e802by Aaron Chen+1−11 file
No security note in commit
Moderate 59 AI analysisMessage 76 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge release v3.0.4 (#2279)

This is a routine firmware release merge (v3.0.4) for the Keystone 3 hardware wallet. The bulk of the changes are UI tweaks, new feature support (Solana CLI, Lace Wallet), and hardening fixes found during an internal 'regular AI review'. T…

NUL-byte rejection in EIP-712 typed data parsingC-string conversion hardening against NUL bytesNull-pointer and UTF-8 validation added to UR parsing entry points
6ab436a2by github-actions[bot]+4960−548845 files
No security note in commit
Informational 13 AI analysisMessage 59 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Build fix (#2273)

This commit is a routine build-system and code-formatting fix. It resets cached CMake build options so each build starts from known defaults, makes cbindgen header-generation failures visible instead of silently ignored, runs Rust formatti…

8568a657by stone wang+8−145 files
No security note in commit
Low 44 AI analysisMessage 36 · Opaque
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

limit file count (#2272)

This commit adds a hard cap on how many files the device will list from its SD card when loading multi-signature Bitcoin wallet data. It also tightens up null-pointer and length checks while scanning directories. The likely goal is to prev…

Unbounded directory listing now bounded by FATFS_MAX_FILE_NUMBERNull-pointer guards added for fileName, number, and path parametersLength checks added before copying filenames into caller buffers
de6879c3by stone wang+31−146 files
No security note in commit
Low 46 AI analysisMessage 73 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge pull request #2268 from KeystoneHQ/regular-review-fix

This commit tightens which old-style Bitcoin-like transactions the Keystone hardware wallet will accept. It now rejects raw protobuf Bitcoin (BTC) and Dogecoin (DOGE) legacy UTXO transactions, allowing only Bitcoin Cash (BCH), Dash (DASH),…

Deprecation of raw-protobuf Bitcoin transaction handlingRejection of unsupported legacy UTXO variants at multiple entry pointsShift from coin_code string matching to protobuf variant matching for legacy path eligibility
1c70d3d4by Soralit+134−166 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queued update code formatby qkin · dc988b09 · Apr 14, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · qkin

update code format

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only reformats a single Rust test file by splitting a long assert_eq! line into multiple lines. It does not change any executable code, logic, or security behavior.

AI review queued fix:add memo for tron swap txby qkin · 468eff30 · Apr 14, 2026 · 1 fileMessage 45 · ThinInformational 11Details
Commit message · qkin

fix:add memo for tron swap tx

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 11/100

This commit adds a new test case for parsing TRON swap transactions that include a memo field. It does not change any production code; it only verifies that an existing parser can correctly extract a memo from a specific transaction payload. There is no indication of a security fix or vulnerability.

AI review queuedfeat: upgrade sui sdkby soralit · 8c9aba41 · Apr 13, 2026 · 33 filesMessage 40 · ThinLow 35Details
Commit message · soralit

feat: upgrade sui sdk

40/100 · ThinMessage clarity
✓ Subject identifies a change✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Low 35/100

This commit is titled 'upgrade sui sdk' and mostly swaps the Sui library dependency to a newer, slimmer package, updates the Rust compiler version used across build scripts, and adjusts code to match the new library's types. There is one notable code change in the Sui request-checking function: it now immediately returns a success result and skips all actual validation. That looks like a temporary debugging change left in the commit, but it could allow an unverified Sui transaction to be approved. The commit does not describe itself as a security fix, and there is no disclosed vulnerability or researcher attribution.

AI review queuedfeat(zcash): pass firmware version in ZcashAccounts pairing QRby Adam Tucker · 7c477f86 · Apr 12, 2026 · 3 filesMessage 85 · StrongInformational 18Details
Commit message · Adam Tucker

feat(zcash): pass firmware version in ZcashAccounts pairing QR

Pass GetSoftWareVersionNumber() through the Zcash connect wallet
flow so the ZcashAccounts UR includes the device firmware version.
This mirrors what other chains (MetaMask, OKX, etc.) already do
via MultiAccounts.deviceVersion.

Requires the updated ur-registry crate with the device_version
field on ZcashAccounts (valargroup/keystone-sdk-rust@adam/zcash-accounts-device-version).

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100

This commit adds the device's firmware version number to the QR code that a Keystone hardware wallet shows when pairing with Zcash wallet software. The change is informational only and matches what the wallet already does for other cryptocurrencies like MetaMask and OKX. There is no indication it fixes a security bug or introduces a security weakness.

AI review queuedfeat: add more info on bitcoin transaction parsingby soralit · 8611828f · Apr 10, 2026 · 6 filesMessage 62 · AdequateLow 35Details
Commit message · soralit

feat: add more info on bitcoin transaction parsing

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 35/100

This commit improves the Bitcoin transaction review screen on Keystone hardware wallets. It adds clearer warnings and labels when a transaction uses unusual signature modes (SIGHASH_SINGLE or SIGHASH_NONE) or when the fee cannot be calculated exactly (for example, with ANYONE_CAN_PAY inputs). It also fixes a small display issue where line breaks in help text were shown as raw '\r\n' characters. Overall, this is a defensive user-interface improvement rather than an attack.

AI review queuedfeat: add input ref qrby soralit · c977c08e · Apr 10, 2026 · 10 filesMessage 50 · ThinInformational 18Details
Commit message · soralit

feat: add input ref qr

50/100 · ThinMessage clarity
✓ Subject identifies a change✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathparser or protocol pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100

This commit adds a new user-interface feature for Bitcoin transactions on the Keystone 3 hardware wallet. When a transaction input only provides a 'witness UTXO' (a lightweight proof of the coin being spent), the device now shows a warning asking the user to verify the input value, and offers a QR code that links to the transaction on a public blockchain explorer (mempool.space). This is a defensive UX improvement, not an attack or vulnerability fix. It helps users spot potentially fraudulent input amounts but does not change the underlying signing logic.

AI review queuedfeat(zcash): stamp firmware version into signed PCZTsby Adam Tucker · d7106d69 · Apr 9, 2026 · 6 filesMessage 85 · StrongInformational 19Details
Commit message · Adam Tucker

feat(zcash): stamp firmware version into signed PCZTs

Every signed PCZT response now carries
global.proprietary["keystone:fw_version"] = [major, minor, build]
so wallets can detect the Keystone firmware version after scanning
the signed QR and gate features accordingly.

The firmware does not enforce any minimum version — it just reports
its own. The wallet is the authority on version policy.

- build.rs reads src/config/version.h at compile time to generate
the KEYSTONE_FW_VERSION const (no manual sync needed)
- sign_pczt stamps the version via the pczt Updater role before
the Redactor strips witness data
- Simulator-only: replace the synchronous AsyncExecute stub with a
proper FIFO queue so the cypherpunk simulator doesn't crash during
wallet onboarding
- Simulator-only: guard KbTextAreaHandler against freed objects
during LVGL group cleanup

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Informational 19/100

This commit adds a firmware version stamp to Zcash signed transaction QR codes so wallets can tell which Keystone firmware version produced the signature. It also fixes two simulator-only stability bugs: one in the async task queue and one in a keyboard text-area handler. There is no direct security vulnerability in the diff; the changes are defensive or feature additions.

AI review queuedadd sol icon in connect keystone nexusby Qkin-Keystone · 86490bcf · Apr 9, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Qkin-Keystone

add sol icon in connect keystone nexus

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit simply adds the Solana (SOL) coin icon to two lists of icons shown on the 'connect wallet' screen for the Keystone Nexus wallet. It is a cosmetic UI change with no security relevance.

AI review queuedadd sol nexus supportby Qkin-Keystone · a9d31cb9 · Apr 9, 2026 · 2 filesMessage 28 · OpaqueInformational 15Details
Commit message · Qkin-Keystone

add sol nexus support

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit adds support for two Solana (SOL) public key derivation paths when connecting the Keystone hardware wallet to compatible software wallets via the 'Keystone Connect' feature. It is a routine feature addition and does not contain any obvious security fix or vulnerability.

AI review queuedupdate rust code formatby Qkin-Keystone · a53b1778 · Apr 9, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Qkin-Keystone

update rust code format

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only reformats Rust source code. It moves a comment onto its own line and adjusts blank lines. No program logic, calculations, or security behavior changed.

AI review queuedupdate review bug and remove useless commentsby Qkin-Keystone · bed968ee · Apr 9, 2026 · 4 filesMessage 45 · ThinLow 44Details
Commit message · Qkin-Keystone

update review bug and remove useless comments

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 44/100

This commit fixes a logic bug in how Tron transactions are routed based on QR code type. Previously the firmware treated 'TronSignRequest' as if it were a Keystone-style request and vice versa, which could send the wrong data to the wrong parser/signer. It also fixes a floating-point precision bug in how token amounts are formatted for display, replacing an unsafe logarithm calculation with a loop-based decimal count. A test helper and some comments were removed, but no security disclosure or researcher credit is present.

AI review queuedremove useless dependencyby Qkin-Keystone · 5634d954 · Apr 9, 2026 · 3 filesMessage 35 · OpaqueLow 35Details
Commit message · Qkin-Keystone

remove useless dependency

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: broader security terminologysecond-pass: opaque commit message
AI analysis · Low 35/100

This commit removes unused serialization libraries from the Tron app and, more importantly, changes how a missing wallet derivation path is handled. Previously, a missing path was silently replaced with an empty default. Now the code returns an explicit error. This is a defensive hardening change that prevents the signing code from continuing with an invalid or unexpected path.

AI review queuedupdate reviewby Qkin-Keystone · 4fb3a5e8 · Apr 9, 2026 · 2 filesMessage 18 · OpaqueLow 36Details
Commit message · Qkin-Keystone

update review

18/100 · OpaqueMessage clarity
✓ Subject identifies a change! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Low 36/100

This commit updates Tron-related code in a hardware wallet firmware. It changes how decimal precision is calculated for token amounts, removes an 'unsupported transaction type' error fallback, and broadens the accepted derivation path prefixes. These are code-quality and review changes, but they could have subtle security implications if the new precision logic mishandles edge cases or if removing the catch-all error allows unexpected transaction types to be signed.

AI review queuedupdate image hashby Qkin-Keystone · 67c98a5b · Apr 9, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Qkin-Keystone

update image hash

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit simply updates a stored hash value in a text file used for tracking image assets. There is no code change, no bug fix, and no visible security relevance in the commit itself or the supplied materials.

AI review queuedfix review bugby Qkin-Keystone · 422ba32f · Apr 9, 2026 · 3 filesMessage 28 · OpaqueLow 38Details
Commit message · Qkin-Keystone

fix review bug

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Low 38/100

This commit fixes several bugs in the Tron (TRX) signing flow of a cryptocurrency hardware wallet firmware. The changes remove an unused import, eliminate a catch-all error branch that could hide unsupported transaction types, add a missing master-fingerprint lookup, replace a hardcoded seed buffer size with a named constant, and harden string-copy helpers against NULL pointers and buffer overruns. The most user-visible risk is that the old code could crash or leak memory when displaying Tron personal-message data, and the missing master-fingerprint call could have produced incomplete or incorrect signing responses.

AI review queuedupdate urTypeby Qkin-Keystone · 07b20298 · Apr 9, 2026 · 1 fileMessage 18 · OpaqueInformational 12Details
Commit message · Qkin-Keystone

update urType

18/100 · OpaqueMessage clarity
✓ Subject identifies a change! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 12/100

This commit is a small cleanup in the Tron (TRX) transaction handling code for the Keystone 3 hardware wallet. It replaces a hardcoded number (7) with a named constant (KeystoneSignRequest) and removes some debug print statements. There is no direct evidence in the commit that this fixes a security vulnerability.

AI review queuedadd test case for errorby qkin · 7ea18bf2 · Apr 9, 2026 · 2 filesMessage 48 · ThinInformational 15Details
Commit message · qkin

add test case for error

48/100 · ThinMessage clarity
✓ Subject identifies a change✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds and updates test code for error handling in the Tron app. It expands unit tests to check that various error types convert correctly and removes an unnecessary `mut` keyword from a test variable. There are no changes to production code or security-sensitive behavior.

AI review queuedfix fmtby Qkin-Keystone · a219cf37 · Apr 9, 2026 · 4 filesMessage 0 · OpaqueInformational 15Details
Commit message · Qkin-Keystone

fix fmt

0/100 · OpaqueMessage clarity
! Very short subject! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only reformats Rust source code in the Tron app. It removes blank lines, reorders imports, and adjusts line breaks to match the project's style guide. No program logic, calculations, or security behavior was changed.

AI review queuedupdate format and test caseby Qkin-Keystone · e4808e9b · Apr 9, 2026 · 3 filesMessage 55 · ThinInformational 14Details
Commit message · Qkin-Keystone

update format and test case

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 14/100

This commit only adds and updates unit tests for the Tron app in the Keystone 3 firmware. It does not change any production code logic. The tests cover signing, parsing, address generation, and edge cases for transaction formatting. There is no indication of a security fix or vulnerability being addressed.

AI review queuedadd memo for tron swapby qkin · 8fe4976f · Apr 9, 2026 · 1 fileMessage 38 · OpaqueInformational 18Details
Commit message · qkin

add memo for tron swap

38/100 · OpaqueMessage clarity
✓ Subject identifies a change✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 18/100

This commit adds support for including a text 'memo' field on Tron cryptocurrency swap transactions. The memo is read from an incoming transaction and later copied into the raw transaction data when building a new transaction. There is no obvious security bug in the diff itself, but the change touches how transaction data is parsed and reconstructed, which is a sensitive area in hardware wallet firmware.

AI review queuedfix rust code formatby Qkin-Keystone · d68dcd40 · Apr 9, 2026 · 3 filesMessage 28 · OpaqueInformational 15Details
Commit message · Qkin-Keystone

fix rust code format

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only reformats Rust source code and reorders import statements. There are no functional changes, no bug fixes, and no security-related modifications.

AI review queuedfix fmt errorby qkin · 5185c315 · Apr 9, 2026 · 4 filesMessage 28 · OpaqueInformational 15Details
Commit message · qkin

fix fmt error

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit is purely a code formatting cleanup. It reorders import statements alphabetically, removes extra blank lines, and fixes indentation and spacing. There are no functional changes to how the Keystone 3 firmware handles cryptocurrency transactions or private keys.

AI review queuedstyle: fix formatting via rustfmtby qkin · 425e2bf0 · Apr 9, 2026 · 5 filesMessage 45 · ThinInformational 15Details
Commit message · qkin

style: fix formatting via rustfmt

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is purely a code-formatting cleanup using rustfmt. It adjusts whitespace, line breaks, and removes blank lines in Tron-related Rust files. The only non-cosmetic-looking change is adding a `fragment_len` parameter to a C-exported signing function, but the diff shows it is simply passed through to an existing encoder call and does not alter security logic.

AI review queuedfeat(nufi-tron): add unit test caseby qkin · 8a7e4621 · Apr 9, 2026 · 3 filesMessage 67 · AdequateInformational 15Details
Commit message · qkin

feat(nufi-tron): add unit test case

67/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds new automated test cases for the Tron app and removes an unused helper function. It does not change any production behavior, fix a bug, or alter how the device handles real transactions. There is nothing here that would let an attacker steal funds or bypass security.

AI review queuedfeat(nufi-tron): fix support keystone-nexus txby qkin · 7c125dd6 · Apr 9, 2026 · 2 filesMessage 57 · ThinLow 26Details
Commit message · qkin

feat(nufi-tron): fix support keystone-nexus tx

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 26/100

This commit adds support for a new Tron transaction format used by the NuFi/Keystone Nexus wallet integration. It changes how the firmware parses, validates, and signs certain Tron QR-code transactions, and it adjusts how unknown TRC-20 token amounts are converted for display. There is no direct evidence in the commit that this fixes a security vulnerability; it reads as a feature/compatability update.