KS
← All projectsKeystone

Keystone 3 firmware

Open-source device firmware for Keystone 3 hardware wallets.

BitcoinHardware walletsNormal
Repository coverage

562 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

125security candidates296second-pass queue559AI analyses
5commits · 30 days
9commits · 60 days
185commits · 180 days
402commits · 365 days
Backfill bands
Aug 5 → Feb 6260 seen14 candidatesComplete
Feb 6 → Jun 6117 seen7 candidatesComplete
Jun 6 → Jul 639 seen4 candidatesComplete
Jul 6 → Aug 5115 seen4 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

43/100 average clarity
39Strong · 80–100
75Adequate · 60–79
213Thin · 40–59
235Opaque · 0–39
39security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
soralit11634116248
Adam Tucker931193263
aaron30430248
Soralit11711154
ww351268717652176026
github-actions[bot]656074
willwang15215025
John Boyd626088
Aaron Chen222068
Qkin-Keystone26126036
qkin12112050
Greg Pfeil616074
Analysis record

Published AI watches

Last scanned 27 minutes ago

Moderate 56 AI analysisMessage 81 · Strong
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Stop the wallet-prep countdown when its label goes (#2324)

This commit fixes a firmware crash and a timer-doubling bug in a cryptocurrency hardware wallet. If a user scanned a transaction too quickly after unlocking, a countdown timer could keep running after its on-screen label was destroyed, cau…

Use-after-free/dangling reference in UI timer callbackOrphaned timer leak causing accelerated countdown behaviorFirmware crash triggered by user timing (quick unlock → scan)
7da0b941by Greg Pfeil+0−00 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

fix(zcash): Fix regression in 3.2.2, improve performance by 15-18%, reduce firmware size by 4.4% (#2330)

This commit updates a Zcash cryptography dependency and changes compiler hints to fix a firmware performance regression and reduce firmware size. There is no security-relevant change visible in the diff.

36859d27by Jack Grigg+4−22 files
No security note in commit
Low 28 AI analysisMessage 81 · Strong
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Send the whole `g_checkResult` to the UI task (#2323)

A firmware fix for a data-passing bug between internal tasks. The code was accidentally sending only the memory address size of a result structure, not the full result. Right now this only affects the rarely-used error_message field, but i…

Incorrect size passed in inter-task message (sizeof pointer instead of sizeof structure)Structure member truncation could leak partial or stale data to UI taskCrash observed by developer when accessing the omitted error_message field
6f0fb82bby Greg Pfeil+0−00 files
No security note in commit
Low 45 AI analysisMessage 61 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

release 3.2.2 (#2327)

This is a routine firmware release (version 3.2.2) for the Keystone 3 hardware wallet. The main user-visible change is adding support for the Zcash NU7 network upgrade. The code changes mostly update Zcash-related Rust libraries to newer v…

Zcash dependency major-version upgrades and API migration for NU7 compatibilityLock-screen countdown timer now initialized to NULL and explicitly stopped on label deletion, reducing dangling-timer riskTransaction-check-fail signal fixed to pass correct struct size instead of pointer size
08150faeby github-actions[bot]+1032−90129 files
No security note in commit
Informational 19 AI analysisMessage 65 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore(release): 3.2.0 (#2315)

This commit is a routine version-bump release (3.2.0) for the Keystone 3 firmware. The visible changes are almost entirely code formatting/indentation, removal of unused imports and dead code, adding 'deprecated' annotations to legacy Bitc…

No security-relevant signals detected in the diff.No mention of CVE, security fix, vulnerability, audit, or bug bounty in commit message or changelog.Changes are cosmetic, dead-code removal, feature gating, and version bump.
3690bf1fby Soralit+674−51576 files
No security note in commit
Moderate 61 AI analysisMessage 80 · Strong
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore: release 3.1.4 (#2311)

This is a large routine firmware release (version 3.1.4) for the Keystone 3 hardware wallet. The visible changes add support for signing Bitcoin Cash, Dash and Dogecoin PSBTs, improve Solana and Tron transaction parsing, add Zcash shielded…

FreeRTOS MPU peripheral region narrowed to PSRAM-only and unprivileged peripheral access now disallowed by compile-time errorNew PSBT signing paths for BCH/DASH/DOGE with custom validation and sighash rulesSolana parser changes and addition of an overflow test fixture (squads-overflow.hex)
d2987b99by github-actions[bot]+18413−6376240 files
No security note in commit
Informational 23 AI analysisMessage 76 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge release v3.1.2 (#2306)

This is a routine firmware release merge (version 3.1.2). The only functional code change visible in the diff adds one more allowed cryptocurrency derivation path prefix, 'm/44'/9000'', for Avalanche (AVAX) X/P-chain addresses when the dev…

Additive change to a path-prefix allowlistNo input validation, parsing, or memory-safety changes visibleNo vendor statement of security relevance in commit or references
f95101fbby github-actions[bot]+23−25 files
No security note in commit
Informational 15 AI analysisMessage 48 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore: update ci (#2302)

This commit only updates a Git submodule pointer (a reference to another repository) in a release-related file. There are no code changes visible in the diff, no description of any security issue, and no references provided. It appears to …

6ef9ddd3by Soralit+1−11 file
No security note in commit
Low 42 AI analysisMessage 58 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge pull request #2293 from KeystoneHQ/merge/v3.1.0

This is a large firmware release merge (v3.1.0) for the Keystone 3 hardware wallet. The visible changes are mostly a major FreeRTOS kernel upgrade (from v10.x to v11.3.0), build-system improvements, and user-facing feature tweaks such as b…

FreeRTOS kernel major version upgrade (10.x -> 11.3.0) with MPU hardeningSwitch from ARM_CM4F non-MPU port to ARM_CM4_MPU portNew MPU configuration flags: configTOTAL_MPU_REGIONS=8, configENFORCE_SYSTEM_CALLS_FROM_KERNEL_ONLY=1, configALLOW_UNPRIVILEGED_CRITICAL_SECTIONS=0
0c0ae467by stone+59616−26981300 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 48 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore: update ci (#2292)

This commit only updates a Git submodule pointer in a release-tracking file. The actual code change is a one-line pointer update from one commit hash to another in a file named 'keystone3-firmware-release'. There is no visible security-rel…

90d1c789by Soralit+1−11 file
No security note in commit
Informational 15 AI analysisMessage 40 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore: update ci

This commit only updates a Git submodule pointer (keystone3-firmware-release) from one commit hash to another. No source code, build scripts, CI configuration, or security-related files are changed in the visible diff. There is no evidence…

a7f6db29by Soralit+1−11 file
No security note in commit
Moderate 58 AI analysisMessage 28 · Opaque
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

release 3.1.0

This is a large firmware release commit (version 3.1.0) for the Keystone 3 hardware wallet. The most significant change visible in the diff is a major upgrade of the FreeRTOS real-time operating system kernel from version 10.x to 11.3.0, c…

FreeRTOS major version upgrade (10.x → 11.3.0) with MPU port enabledNew MPU sandbox task/runtime/validator files addedconfigENFORCE_SYSTEM_CALLS_FROM_KERNEL_ONLY=1 and configALLOW_UNPRIVILEGED_CRITICAL_SECTIONS=0 set
2b007a29by Soralit+59615−26980300 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 76 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge release v3.0.8 (#2291)

This commit is a routine version-bump merge for release v3.0.8. It only updates changelogs, a Git submodule pointer, and a build version number. There is no code change visible in the diff and nothing that suggests a security fix or vulner…

b5e8f9fcby github-actions[bot]+18−24 files
No security note in commit
Low 47 AI analysisMessage 76 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge release v3.0.6 (#2290)

This firmware update adds support for Solana's new V1 transaction format and changes how oversized or malformed transaction details are displayed. The code introduces a dedicated parser for V1 messages with strict size and structure checks…

New parser enforces hard limits on V1 message fields and rejects malformed 0x81-prefix payloads instead of falling back to message signingCompute-budget instructions in V1 are explicitly ignored to prevent fee-display spoofingUI pagination change for large transaction details reduces truncation risk
87b78ae1by github-actions[bot]+564−2812 files
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

pin to new release config (#2285)

This commit only updates a Git submodule pointer (keystone3-firmware-release) from one commit hash to another. There is no code change visible in the diff, no description of what the new release config contains, and no security-related inf…

bc01c889by Aaron Chen+1−11 file
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

update the release repo (#2282)

This commit simply updates a Git submodule pointer for the project's release repository. There is no visible code change, no description of any security issue, and no indication this is anything other than a routine release-tracking update.

3ac7e802by Aaron Chen+1−11 file
No security note in commit
Moderate 59 AI analysisMessage 76 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge release v3.0.4 (#2279)

This is a routine firmware release merge (v3.0.4) for the Keystone 3 hardware wallet. The bulk of the changes are UI tweaks, new feature support (Solana CLI, Lace Wallet), and hardening fixes found during an internal 'regular AI review'. T…

NUL-byte rejection in EIP-712 typed data parsingC-string conversion hardening against NUL bytesNull-pointer and UTF-8 validation added to UR parsing entry points
6ab436a2by github-actions[bot]+4960−548845 files
No security note in commit
Informational 13 AI analysisMessage 59 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Build fix (#2273)

This commit is a routine build-system and code-formatting fix. It resets cached CMake build options so each build starts from known defaults, makes cbindgen header-generation failures visible instead of silently ignored, runs Rust formatti…

8568a657by stone wang+8−145 files
No security note in commit
Low 44 AI analysisMessage 36 · Opaque
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

limit file count (#2272)

This commit adds a hard cap on how many files the device will list from its SD card when loading multi-signature Bitcoin wallet data. It also tightens up null-pointer and length checks while scanning directories. The likely goal is to prev…

Unbounded directory listing now bounded by FATFS_MAX_FILE_NUMBERNull-pointer guards added for fileName, number, and path parametersLength checks added before copying filenames into caller buffers
de6879c3by stone wang+31−146 files
No security note in commit
Low 46 AI analysisMessage 73 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge pull request #2268 from KeystoneHQ/regular-review-fix

This commit tightens which old-style Bitcoin-like transactions the Keystone hardware wallet will accept. It now rejects raw protobuf Bitcoin (BTC) and Dogecoin (DOGE) legacy UTXO transactions, allowing only Bitcoin Cash (BCH), Dash (DASH),…

Deprecation of raw-protobuf Bitcoin transaction handlingRejection of unsupported legacy UTXO variants at multiple entry pointsShift from coin_code string matching to protobuf variant matching for legacy path eligibility
1c70d3d4by Soralit+134−166 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityfix: chain coin display errorby soralit · d908e40f · Sep 15, 2025 · 1 fileMessage 57 · ThinLow 32Details
Commit message · soralit

fix: chain coin display error

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Low 32/100

This commit fixes a UI bug in the Ethereum batch transaction screen where the wrong memory buffer was being used to store a network symbol name. Before the fix, the code allocated memory for the symbol but then wrote the symbol into a buffer sized by a different function argument, which could lead to a crash or corrupted display text when showing swap details. The fix makes the destination buffer the same one that was just allocated, matching its size.

Lower-priorityfeat: add bsc thorchain contractsby soralit · 92339df3 · Sep 15, 2025 · 2 filesMessage 57 · ThinInformational 16Details
Commit message · soralit

feat: add bsc thorchain contracts

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 16/100

This commit adds two new BNB Smart Chain (BSC) THORChain router contract definitions to the wallet's built-in list of known smart contracts, and makes a small, safe-looking code change so the swap screen can display the correct network symbol (e.g., BNB) instead of hard-coding 'ETH'. There is no obvious security vulnerability in the diff itself; it appears to be a routine feature addition to support more cross-chain swaps.

AI review queuedsupport iota walletby ww3512687 · 3806ad42 · Sep 15, 2025 · 7 filesMessage 28 · OpaqueInformational 15Details
Commit message · ww3512687

support iota wallet

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit adds support for the IOTA wallet in the Keystone 3 firmware. It is a routine feature addition: a new wallet icon is included, the wallet is added to the status bar and connect-wallet lists, and the firmware build number is bumped. There is no indication of a security fix or vulnerability.

AI review queuedUpdate version for beta_testby bianminyan · fe25cc1a · Sep 15, 2025 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · bianminyan

Update version for beta_test

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit simply bumps a build number in a version header from 9 to 13 for a beta test. It does not change any executable logic, fix any bug, or alter any security behavior. There is no security relevance visible in the change itself.

Lower-priorityfeat: add bsc thorchain contractsby soralit · 75a0c4fb · Sep 12, 2025 · 1 fileMessage 57 · ThinInformational 15Details
Commit message · soralit

feat: add bsc thorchain contracts

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100

This commit simply adds two known THORChain Router smart contract definitions for the BNB Smart Chain (BSC) network to a lookup table used by the wallet's user interface. It is a routine data update with no visible security defect.

AI review queuedfix ada crashby 0xApprentice · 8ce06467 · Sep 10, 2025 · 1 fileMessage 28 · OpaqueLow 35Details
Commit message · 0xApprentice

fix ada crash

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: broader security terminologysecond-pass: opaque commit message
AI analysis · Low 35/100

This commit increases the memory stack size for a task that handles sensitive data, with the stated goal of fixing a crash related to Cardano (ADA). A too-small stack can cause memory corruption or a device crash when handling certain operations. While the change itself is defensive, the crash occurs in a security-sensitive task, so it could theoretically affect availability or stability during sensitive operations. There is no direct evidence in the commit that this is exploitable for theft or key extraction.

AI review queuedfix: buildby soralit · 5965959d · Sep 10, 2025 · 2 filesMessage 2 · OpaqueInformational 15Details
Commit message · soralit

fix: build

2/100 · OpaqueMessage clarity
✓ Uses a recognizable type or scope! Very short subject! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit is a routine build fix. It updates a cached image hash file and adds a missing function declaration inside a conditional compile block for a Web3-specific version. There is no visible security relevance.

AI review queuedDisordered keyboardby willwang · 7f1be015 · Sep 5, 2025 · 5 filesMessage 18 · OpaqueModerate 50Details
Commit message · willwang

Disordered keyboard

18/100 · OpaqueMessage clarity
✓ Subject identifies a change! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Moderate 50/100

This commit adds a feature that shuffles the on-screen numeric keypad layout each time the device lock screen appears. The goal is to make it harder for someone watching or recording your screen to figure out your PIN based on where your fingers tap. The change itself is a security improvement, not a vulnerability fix, but the commit message is vague and gives no explanation.

AI review queuedupdate hardware version displayby willwang · 841e50ad · Sep 4, 2025 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · willwang

update hardware version display

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit simply changes two user-facing text labels from 'Version 3.0' and 'Version 3.1' to 'V3.0' and 'V3.1'. It is a cosmetic string formatting update with no security relevance.

AI review queuedadd 2.2.12 changelogby bianminyan · 695095a4 · Sep 4, 2025 · 2 filesMessage 38 · OpaqueInformational 15Details
Commit message · bianminyan

add 2.2.12 changelog

38/100 · OpaqueMessage clarity
✓ Subject identifies a change✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit only adds release notes for firmware version 2.2.12. It does not change any executable code, configuration, or security controls. The changelog mentions a bug fix for Cardano passphrase message signing, but the commit itself contains only documentation updates.

AI review queuedDisordered keyboardby willwang · 9b13b0cc · Sep 3, 2025 · 1 fileMessage 18 · OpaqueLow 42Details
Commit message · willwang

Disordered keyboard

18/100 · OpaqueMessage clarity
✓ Subject identifies a change! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Low 42/100

This commit adds a shuffled numeric keypad for PIN entry on a hardware wallet. Instead of always showing 0-9 in the same order, the digits now appear in a random order each time. This is a defensive measure to make it harder for someone watching or recording the screen to learn your PIN based on where you tap.

Security candidatefix buildby willwang · 947fb0f6 · Sep 3, 2025 · 2 filesMessage 0 · OpaqueInformational 11Details
Commit message · willwang

fix build

0/100 · OpaqueMessage clarity
! Very short subject! Too few words to establish purpose! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
cryptography-sensitive path
AI analysis · Informational 11/100

This commit is a build fix that restructures conditional compilation blocks for different firmware variants (Web3, Cypherpunk, BTC-only). It does not appear to change runtime behavior for any single firmware build; it mainly ensures the correct code paths compile under each build configuration. There is no clear security-relevant change.

AI review queuedUpdate versionby bianminyan · b93fbb3d · Sep 3, 2025 · 1 fileMessage 18 · OpaqueInformational 15Details
Commit message · bianminyan

Update version

18/100 · OpaqueMessage clarity
✓ Subject identifies a change! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only changes one number in a version header, bumping the build version from 10 to 12. There is no functional code change, no bug fix, and no security-related content visible in the diff.

AI review queuedfmtby willwang · 273f573c · Sep 3, 2025 · 1 fileMessage 0 · OpaqueInformational 15Details
Commit message · willwang

fmt

0/100 · OpaqueMessage clarity
! Very short subject! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only reformats a single Rust test file using a code formatter (rustfmt). It changes whitespace and line breaks in an existing test assertion but does not alter any executable logic, constants, or behavior. There is no security relevance.

Security candidateAdd support for SLIP39 in Cardano wallet functionalityby willwang · 0ba89f3b · Sep 3, 2025 · 18 filesMessage 83 · StrongLow 27Details
Commit message · willwang

Add support for SLIP39 in Cardano wallet functionality

- Introduced new `slip23.rs` module for SLIP39 seed handling.
- Updated `address.rs` to include SLIP39 address derivation tests.
- Enhanced error handling in `errors.rs` for invalid seeds.
- Modified `lib.rs` to expose the new SLIP39 module.
- Updated various wallet functions to accommodate SLIP39, including key generation and transaction signing.
- Adjusted UI components to reflect SLIP39 compatibility in wallet operations.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing boundarycryptography-sensitive pathsigning or wallet path
AI analysis · Low 27/100

This commit adds support for the SLIP39 standard (a way to split a wallet backup into multiple shares) to the Cardano wallet features of a Keystone hardware wallet. It is a feature addition, not a clear security fix. The code changes how Cardano master keys are derived when a SLIP39 wallet is used, and removes several UI blocks that previously disabled Cardano for SLIP39 users. There is no vendor statement or external report saying this commit fixes a vulnerability.

AI review queuedupdate bsc iconby willwang · 0c4ca3c4 · Sep 3, 2025 · 4 filesMessage 28 · OpaqueInformational 15Details
Commit message · willwang

update bsc icon

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit simply swaps the on-screen icon for the BSC (Binance Smart Chain) wallet connection in the Keystone hardware wallet firmware. It updates the PNG source image, its converted embedded C array, the image hash file, and a widget reference. There is no change to security logic, cryptography, transaction handling, or user confirmation flows.

AI review queuedUpdate version for beta_testby bianminyan · fb25f051 · Sep 2, 2025 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · bianminyan

Update version for beta_test

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit simply changes one number in a version file, lowering the build version from 10 to 9 for a beta test. It does not modify any security-related code, fix any bug, or introduce any vulnerability.

AI review queuedfix bugby willwang · 99eadbc3 · Aug 29, 2025 · 1 fileMessage 0 · OpaqueLow 35Details
Commit message · willwang

fix bug

0/100 · OpaqueMessage clarity
! Very short subject! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Low 35/100

This commit fixes a bug in the 'forget password' screen of a Keystone hardware wallet. It resets a global flag called g_isTonMnemonic to false when leaving that screen. Without this reset, the wallet might incorrectly remember that it was handling a TON (The Open Network) style recovery phrase even after the user navigates away. That leftover state could lead to wrong behavior, confusion, or possibly security-relevant mistakes if the flag later influences how secrets are parsed or stored.

Lower-priorityfix ton wallet check and forgetby willwang · 411b3b79 · Aug 26, 2025 · 6 filesMessage 45 · ThinModerate 57Details
Commit message · willwang

fix ton wallet check and forget

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Moderate 57/100

This commit fixes two related bugs in the Keystone 3 hardware wallet's handling of TON (The Open Network) mnemonic phrases. First, when a user tried to verify or recover a wallet in the settings screen, the device always ran a TON-specific check even if the wallet was a standard multi-coin (BIP39) wallet. Second, when a user forgot their password and tried to reset it with a recovery phrase, the device could misidentify a BIP39 phrase as a TON phrase and then erase the wrong wallet data. The patch adds logic to distinguish TON-only from BIP39/multi-coin wallets and to choose the correct recovery path and reset flow for each.

AI review queuedupdate rust panic displayby willwang · 6d62fec4 · Aug 25, 2025 · 1 fileMessage 35 · OpaqueInformational 16Details
Commit message · willwang

update rust panic display

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: broader security terminologysecond-pass: opaque commit message
AI analysis · Informational 16/100

This commit changes the on-screen message shown when the device's Rust code crashes ('panics'). It now first reassures the user that their assets are safe and blames a 'failed data request,' then prints the technical Rust panic details in gray text instead of showing only the raw panic message. There is no direct evidence this fixes a security vulnerability; it appears to be a user-experience improvement that may also reduce information leakage from panic messages.

AI review queuedfix key imagesby willwang · de4174eb · Aug 22, 2025 · 2 filesMessage 28 · OpaqueModerate 57Details
Commit message · willwang

fix key images

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Moderate 57/100

This commit fixes how the Keystone hardware wallet generates Monero 'key images' for transactions that use extra one-time public keys (subaddresses or additional transaction keys). Before the fix, the code always used the main transaction public key to derive key images, even when Monero rules say it should use an additional key. This mismatch could cause the wallet to generate the wrong key image, which in a hardware wallet context most likely means a transaction would fail to build or be rejected, rather than funds being stolen. The commit adds logic to pick the correct additional key based on subaddress major/minor indices and the output index.

Security candidatefix: buildby soralit · 00ddb4b8 · Aug 22, 2025 · 1 fileMessage 2 · OpaqueInformational 15Details
Commit message · soralit

fix: build

2/100 · OpaqueMessage clarity
✓ Uses a recognizable type or scope! Very short subject! Too few words to establish purpose! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100

This commit only adds two function declarations (a setter and a getter for an 'extendable' flag) to a header file. There is no executable code change, no bug fix, and no security-relevant behavior visible in the diff. It appears to be a straightforward build fix to satisfy a compiler or linker error caused by missing declarations.

AI review queuedfix monero unwrapby willwang · fadd5bc9 · Aug 22, 2025 · 1 fileMessage 28 · OpaqueModerate 57Details
Commit message · willwang

fix monero unwrap

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Moderate 57/100

This commit changes how the Monero signing code in the Keystone 3 firmware handles failures when computing cryptographic key images. Previously, the code used `.unwrap()`, which would cause the firmware to panic (crash) if key-image generation failed. The patch replaces those unwraps with proper error propagation (`Result<...>`), so failures are returned as errors instead of crashing. For a hardware wallet, a panic during transaction signing could potentially be triggered by a malformed transaction and might be used to deny service or, in the worst case, leak sensitive state through crash behavior. The patch is a defensive hardening fix.

AI review queuedUpdate versionby bianminyan · 8ed565ca · Aug 19, 2025 · 1 fileMessage 18 · OpaqueInformational 15Details
Commit message · bianminyan

Update version

18/100 · OpaqueMessage clarity
✓ Subject identifies a change! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit simply bumps a build number in a version header file from 8 to 10. There are no code changes, no bug fixes, and no security-related modifications visible in the diff.

AI review queuedfix uiby willwang · c4ca4617 · Aug 19, 2025 · 1 fileMessage 0 · OpaqueInformational 15Details
Commit message · willwang

fix ui

0/100 · OpaqueMessage clarity
! Very short subject! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit adjusts the vertical positioning of a divider line and a button on the device's 'About' info screen. It is purely a cosmetic user-interface fix with no security relevance.