CommitWatch RSS
EL
← All projectsElectrum

Electrum

Long-running lightweight Bitcoin wallet for desktop and mobile platforms.

BitcoinSoftware walletsNormal
Source repository ↗
Repository coverage

1149 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

90security candidates259second-pass queue1003AI analyses
132commits · 30 days
258commits · 60 days
541commits · 180 days
1001commits · 365 days
Backfill bands
Aug 5 → Feb 6470 seen11 candidatesComplete
Feb 6 → Jun 6346 seen10 candidatesComplete
Jun 6 → Jul 653 seen2 candidatesComplete
Jul 6 → Aug 554 seen3 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

66/100 average clarity
220Strong · 80–100
546Adequate · 60–79
339Thin · 40–59
44Opaque · 0–39
2security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
ThomasV137891162
SomberNight39330362063
f321x40124385070
Sander van Grieken10910101057
ghost4341516070
Felix2439072
user323062
ekzyis222053
accumulator613071
Roman Zeyde515053
Sasha Zykov515075
Aaron Fiore414068
Analysis record

Published AI watches

Last scanned 51 minutes ago

Informational 15 AI analysisMessage 78 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10988 from f321x/update_security_review_ci_model

This commit updates Electrum's internal CI (continuous integration) script that runs an automated security review using Anthropic's Claude Code tool. It changes the AI model version used for reviews from 'claude-opus-5' to 'claude-opus-5-5…

CI hardening: detects and reports AI model downgrades during automated security reviewNo changes to application code, cryptography, network protocol, or build artifactsNo privilege escalation, injection, or data-exfiltration vectors introduced by the diff
638fbba8by Felix+75−111 file
No security note in commit
Open full analysis →Source commit ↗
Informational 12 AI analysisMessage 90 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

ci: security review: warn if the model got downgraded

This commit updates Electrum's own CI security-review script. It adds detection and warnings when the automated code reviewer (Claude Code) silently falls back to a different AI model, for example after a content-policy refusal. It does no…

CI-only changeNo modification of wallet, crypto, networking, or build artifactsAdds detection for AI model fallback/downgrade in automated security review
ace2ca7aby f321x+74−101 file
No security note in commit
Open full analysis →Source commit ↗
Low 44 AI analysisMessage 68 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10987 from spesmilo/fix_10986

This commit fixes a bug where Electrum failed to recognize certain already-signed Bitcoin transactions as complete. Specifically, for native SegWit inputs, Bitcoin Core can produce a finalized PSBT with a valid witness but an empty scriptS…

Logic error in transaction completeness detectionNative SegWit witness handling edge casePSBT interoperability issue with Bitcoin Core
bef80421by ghost43+11−02 files
No security note in commit
Open full analysis →Source commit ↗
Low 35 AI analysisMessage 81 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

transaction: treat native segwit input with non-empty witness as complete

This commit fixes a bug where Electrum incorrectly treated finalized Bitcoin transactions as incomplete. Some wallet software (like Bitcoin Core and Sparrow) creates native SegWit transactions that omit an empty placeholder field Electrum …

Logic error in transaction completeness detectionPotential denial of service / user funds stuck due to refusal to broadcast valid finalized transactionInteroperability failure with Bitcoin Core and Sparrow PSBT output
e9bb42e6by ThomasV+11−02 files
No security note in commit
Open full analysis →Source commit ↗
Moderate 68 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10981 from spesmilo/do_not_sign_txin_with_witness

This change prevents Electrum from re-signing Bitcoin transaction inputs that already contain a witness (the data proving the input was authorized). The patch fixes a bug where Electrum could incorrectly sign a non-SegWit input as if it we…

Incorrect signature algorithm selection for non-SegWit inputs when witness data is presentPSBT handling edge case where pre-existing witness data influences signing pathPotential invalid signature production during transaction signing
9da4c342by ThomasV+10−21 file
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10974 from SomberNight/202609_nostr_psbt_xpub

This commit only adds a long code comment explaining a design choice in Electrum's PSBT-over-Nostr plugin. It does not change any program behavior. The comment documents that the plugin derives each cosigner's Nostr secret key from their B…

Documentation-only changeExplicit design tradeoff disclosure: cosigners can derive each other's Nostr secret keys from shared xpubsNo functional code change
46408a78by ThomasV+13−01 file
No security note in commit
Open full analysis →Source commit ↗
Low 42 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10980 from spesmilo/add_input_from_network_do_not_ignore_exceptions

This is a one-line bugfix in Electrum's transaction handling. Previously, the code accidentally swallowed (hid) almost all exceptions when fetching extra transaction data from the network, only re-raising errors that were both network-rela…

Exception swallowing bug fixedNetwork/transaction input enrichment logic changedSilent failure mode removed
bb9d3280by ghost43+1−11 file
No security note in commit
Open full analysis →Source commit ↗
Moderate 60 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10970 from f321x/fix_bolt11_bugs_2

This commit fixes several bugs in Electrum's handling of BOLT11 Lightning invoices. The most user-visible fixes are: stricter validation of invoice amounts (rejecting zero, negative, sub-millisatoshi, and leading-zero amounts), correct pad…

Stricter BOLT11 amount validation prevents acceptance of zero, negative, sub-millisatoshi, and leading-zero amountsFixed int_to_data5 padding bug that corrupted small timestamp values during invoice round-tripMalformed 'r' routing tags now raise exceptions instead of being silently skipped
4b92c0f2by ghost43+82−939 files
No security note in commit
Open full analysis →Source commit ↗
Moderate 61 AI analysisMessage 80 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

add_info_from_network: do not swallow exceptions

Electrum's transaction builder had a bug where it would ignore certain consistency errors when fetching extra transaction data from the network. A malicious or misbehaving server could supply a wrong input amount, and Electrum would silent…

Swallowed exception leading to use of attacker-controlled input valuePSBT input consistency check bypassedPotential malicious Electrum server influence on transaction signing
3f67b21bby ThomasV+1−11 file
Vendor flagged security relevance
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 60 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

bolt11: remove tag arg from get_routing_info

This is a small code cleanup change. A function that reads routing hints from Lightning invoices no longer takes a tag argument because only one type of routing hint ('r') is now supported. All callers are updated accordingly. There is no …

e78fba28by f321x+12−127 files
No security note in commit
Open full analysis →Source commit ↗
Moderate 62 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10940 from accumulator/fix_10937

This commit tightens how Electrum parses Bitcoin payment requests (BOLT11 lightning invoices and BIP21 URIs). It turns previously uncaught internal errors into proper validation failures, rejects malformed invoice fields that used to be si…

Stricter input validation for externally supplied BOLT11 invoices and BIP21 URIsPreviously uncaught exceptions (ValueError, UnicodeDecodeError, ecc errors) are now wrapped in domain-specific decode exceptionsMalformed fallback addresses are skipped rather than aborting or crashing
a57ef6e7by Felix+707−9610 files
No security note in commit
Open full analysis →Source commit ↗
Low 40 AI analysisMessage 36 · Opaque
EL ElectrumElectrum BitcoinSoftware wallets

bolt11: followup #10940

This commit tightens how Electrum parses BOLT11 Lightning invoices. It now rejects duplicate 'n' (node pubkey) tags instead of silently keeping only the first one, and it rejects invoice timestamps that are negative or too far in the futur…

Stricter validation of invoice timestamp boundsDuplicate 'n' tag now raises an exception instead of being silently droppedFollow-up to prior PR #10940, indicating a recent area of security-sensitive review
3026fbdbby f321x+14−232 files
No security note in commit
Open full analysis →Source commit ↗
Low 32 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10737 from sashazykov/hw-close-wallet-thread-leak

This commit fixes a shutdown bug in Electrum's hardware wallet support. Previously, if disconnecting from a hardware wallet failed, the cleanup thread could keep running, which could crash the application when closing. The fix stops the th…

Process abort/crash at shutdown due to leaked QThreadException during cleanup not handled, potentially causing abnormal terminationHardware wallet client close made best-effort with error logging
5b77ca46by Felix+9−22 files
No security note in commit
Open full analysis →Source commit ↗
Informational 23 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10958 from SomberNight/202609_deps

This commit is a routine dependency update for the Electrum Bitcoin wallet. It bumps versions of Python, OpenSSL, secp256k1, and various Python packages used in builds and runtime. The commit itself does not fix any known security bug in E…

Dependency version bumps for cryptographic libraries (OpenSSL, libsecp256k1, electrum-ecc)Routine maintenance commit with no explicit security claimHash-only changes in deterministic requirements files
8bd8c3fbby ghost43+57−5612 files
No security note in commit
Open full analysis →Source commit ↗
Informational 21 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10965 from SomberNight/202609_header_checkpoints

This commit only adds new Bitcoin block header checkpoints to Electrum's built-in chain data files. Checkpoints are hardcoded reference points that help the wallet verify it is following the real blockchain and not a fake one. Updating the…

Hardcoded blockchain checkpoints extended for all supported networksNo executable code or cryptographic logic changedNo bug fix, privilege change, or input validation change present
9e0b7e64by ghost43+276−04 files
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

update block header checkpoints

This commit simply refreshes Electrum's built-in list of Bitcoin blockchain checkpoints. Checkpoints are known-good block hashes that help the wallet verify it is following the real chain. The update adds newer checkpoints for mainnet, sig…

e11c579bby SomberNight+276−04 files
No security note in commit
Open full analysis →Source commit ↗
Low 46 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10945 from accumulator/stale_utxo_data_fixes

This commit fixes cases where Electrum's wallet cache could hold onto outdated information about coins and transactions after blockchain reorganizations or mempool changes. For example, if a transaction was previously thought to be mined b…

stale cached state after reorg/mempool evictionincorrect confirmation metadata displayed to userscache invalidation added at multiple state transitions
e20b24c0by Felix+132−239 files
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 60 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

transaction: add set_mined_info setter to TxInput

This commit is a simple code cleanup: it replaces two repeated lines that set a transaction input's block height and position with a single helper method called set_mined_info. There is no change in behavior, no bug fix, and no security re…

61f71acbby f321x+7−73 files
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 60 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qt/util: consolidate short_id check pattern

This is a small internal code cleanup in the Electrum Bitcoin wallet. It moves the logic that builds a compact transaction identifier (like '123x4') into one shared helper method, and removes a duplicate helper class. There is no user-faci…

2af9e26aby f321x+7−133 files
No security note in commit
Open full analysis →Source commit ↗
Informational 19 AI analysisMessage 85 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

contrib: build appimage: fetch ca-certificates from pinned sources

This commit changes how the Electrum AppImage build container first obtains trusted web certificates. Because the build's pinned Debian package sources use HTTPS, the container needs certificates before it can talk to them. The old method …

build pipeline changetemporary downgrade from HTTPS to HTTP for package bootstrappackage integrity still protected by apt GPG signatures
fd687940by f321x+11−41 file
No security note in commit
Open full analysis →Source commit ↗
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedqewallet: replace some threads with coroutinesby f321x · 0505ef59 · May 6, 2026 · 1 fileMessage 60 · AdequateInformational 12Details
Commit message · f321x

qewallet: replace some threads with coroutines

Allows to simplify a bit and has less overhead.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 12/100

This commit is a routine code cleanup in Electrum's mobile/QML user interface. It replaces two background threads with lightweight coroutines (async functions) for broadcasting Bitcoin transactions and paying Lightning invoices. There is no indication this change fixes or introduces a security vulnerability.

AI review queuedwallet: make_unsigned_transaction: nicer error msg for bad outputsby SomberNight · b9cb44db · May 5, 2026 · 1 fileMessage 65 · AdequateInformational 15Details
Commit message · SomberNight

wallet: make_unsigned_transaction: nicer error msg for bad outputs

traceback was hard to understand if outputs was a list of TxOutputs
(as opposed to PartialTxOutput)

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit adds a clearer error message inside Electrum's wallet code when a developer passes the wrong kind of transaction output object to a function that builds unsigned transactions. It is a defensive programming/debugging improvement, not a security fix. There is no indication it addresses a vulnerability or changes user-facing behavior beyond producing a more informative error.

AI review queuedtests: lnpeer: simplify anchors moreby SomberNight · e2ec6b3c · May 4, 2026 · 6 filesMessage 55 · ThinInformational 15Details
Commit message · SomberNight

tests: lnpeer: simplify anchors more

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes test code. It makes anchor channels the default setting for Electrum's Lightning test suite and removes the need to pass an explicit 'has_anchors' flag when creating mock wallets in tests. There is no change to the actual wallet or Lightning code that users run, so it does not affect real-world security.

AI review queuedtests: lnpeer: simplify anchorsby SomberNight · 02847771 · May 4, 2026 · 4 filesMessage 60 · AdequateInformational 15Details
Commit message · SomberNight

tests: lnpeer: simplify anchors

there were too many degrees of freedom - sometimes the fields were actually inconsistent

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a test-only cleanup commit. It removes a redundant 'anchor_outputs' parameter from helper functions used in Lightning Network tests and instead derives the channel type from a wallet configuration flag. It also re-enables an internal assertion that was previously commented out. There is no change to production wallet behavior or user-facing security.

AI review queuedLNWallet: set OPT_ANCHOR_REQ for peer, rm config.ENABLE_ANCHOR_CHANNELSby SomberNight · 193ea6da · May 4, 2026 · 6 filesMessage 95 · StrongLow 34Details
Commit message · SomberNight

LNWallet: set OPT_ANCHOR_REQ for peer, rm config.ENABLE_ANCHOR_CHANNELS

- require the OPTION_ANCHORS peer feature
- rm the config.ENABLE_ANCHOR_CHANNELS config var, which some users might have set (maybe even forgot they did)
- instead add a new config.TEST_LN_OPEN_SRK_CHANNELS, explicitly for testing

---

As @f321x said, the intention is:
> This will prevent opening new outgoing and incoming SRK channels.
> It will also prevent connecting to peers that don't signal anchor support at all (INIT features), so existing channels to them would need to get force closed or the peer needs to be bullied into updating their node software.
> Existing SRK channels with peers that signal anchor support (e.g. SRK channel opened to Electrum Trampoline) remain usable.

However the part re preventing new incoming SRK channels is not correct AFAICT. I am fixing that in a later commit in the branch.
This is because, AFAIU BOLT-02, just because we negotiated OPTION_ANCHORS as a peer feature, setting channel_type to an SRK channel in open_channel is still technically valid.

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 34/100

This commit changes Electrum's Lightning wallet so it now requires anchor-style channels by default and removes the old user-facing setting that let people opt out. It replaces the opt-out with a hidden testing-only flag for older channel types. The change is a deliberate protocol hardening step, not a fix for an active exploit, though the commit message notes a follow-up is needed to fully block incoming old-style channels.

AI review queuedcommands: export_lightning_preimage: add comment about wallet passwordby SomberNight · 3399c20a · Apr 28, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · SomberNight

commands: export_lightning_preimage: add comment about wallet password

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100

This commit only adds a documentation comment to the export_lightning_preimage command explaining that exporting a Lightning payment preimage does not require the wallet password. It changes no code behavior, no access controls, and no security logic. There is no vulnerability in this patch.

AI review queuedbolt11: follow-up renamesby SomberNight · b0a5e201 · Apr 27, 2026 · 2 filesMessage 35 · OpaqueInformational 15Details
Commit message · SomberNight

bolt11: follow-up renames

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit is a simple code cleanup that renames leftover references from 'LnAddr' to 'BOLT11Addr' and 'lndecode' to 'decode_bolt11_invoice' in comments and docstrings. It makes no functional changes to the code and has no security relevance.

AI review queuedqml: BalanceDetails: fix typoby SomberNight · d2700dfb · Apr 27, 2026 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · SomberNight

qml: BalanceDetails: fix typo

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This is a one-character typo fix in a user-interface file for Electrum's QML (mobile-style) GUI. The button that starts a Lightning swap was checking the wrong property name, which likely meant the button stayed disabled even when a Lightning receive balance existed. There is no security issue here—just a UI bug that may have prevented users from clicking a swap button.

AI review queuedqt, watchtower: cleanup importsby f321x · 560d90e8 · Apr 27, 2026 · 2 filesMessage 35 · OpaqueInformational 15Details
Commit message · f321x

qt, watchtower: cleanup imports

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit removes unused Python imports from two files: a Qt channel details dialog and a watchtower server plugin. It is a routine code cleanup with no functional changes and no security relevance.

AI review queuedlnaddr: rename LnAddr -> bolt11by f321x · 306cac19 · Apr 27, 2026 · 15 filesMessage 58 · ThinInformational 15Details
Commit message · f321x

lnaddr: rename LnAddr -> bolt11

The LnAddr, lndecode and lnencode naming didn't imply that it is
bolt 11 specific, making it confusing to work with, now that there are
also bolt 12 "lnaddr".
Renaming it to *bolt11* creates a clear separation to bolt 12 things and
reduces mental load.

This commit is pure renaming (using the PyCharm IDE refactor function),
except for the removal of the `object` inheritance of LnAddr/BOLT11Addr,
this is Python 2 legacy.

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a large but purely cosmetic rename in the Electrum Bitcoin wallet. It renames the internal module `lnaddr.py` to `bolt11.py` and renames classes/functions from names like `LnAddr` and `lndecode` to `BOLT11Addr` and `decode_bolt11_invoice`. The goal is to avoid confusion with the newer BOLT 12 Lightning invoice format. The actual code logic is unchanged, apart from removing the obsolete `object` base class from one class. There is no security fix or vulnerability introduced here.

AI review queuedcrash_reporter: detect more altcoin-forks, don't send reportsby SomberNight · 3534f62b · Apr 27, 2026 · 1 fileMessage 91 · StrongInformational 23Details
Commit message · SomberNight

crash_reporter: detect more altcoin-forks, don't send reports

A new crash report [0] looks to be from a fork where the altcoin has the same genesis block [1] as Bitcoin.
But ofc "branding" is important, so they updated the URLs to point to their fork -- so we could also test against that.

[0]: https://github.com/spesmilo/electrum/issues/10610
[1]: https://github.com/palladium-coin/pallectrum/blob/0df81c6af8d36f3549739576681d3df9969e32fd/electrum/constants.py#L194

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 23/100

This commit tightens a check in Electrum's crash reporter so it refuses to send crash reports to Electrum's servers when the software is an altcoin fork. Previously, forks that kept Bitcoin's genesis block but changed the project's source-code URL could still spam Electrum with crash reports. The change adds a URL check to catch more forks. It is a defensive hardening patch, not a fix for a vulnerability in Electrum itself.

AI review queuedqt: send start_new_window exc to reporterby f321x · c8c44e35 · Apr 24, 2026 · 1 fileMessage 68 · AdequateInformational 19Details
Commit message · f321x

qt: send start_new_window exc to reporter

Send more types of exceptions happening during daemon.load_wallet
in `ElectrumGui.start_new_window()` to the crash reporter to catch
e.g. assertion failures instead of showing them to the user as a warning
dialog.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 19/100

This is a small user-experience improvement in the Electrum Bitcoin wallet's Qt desktop interface. It changes how certain wallet-loading errors are handled: instead of showing some unexpected errors to the user as a warning dialog, they are now sent to Electrum's crash reporter. It does not change how funds are stored, signed, or transmitted, and there is no indication it fixes a security vulnerability.

AI review queuedqml: deduplicate wallet name validationby f321x · d34129ef · Apr 23, 2026 · 4 filesMessage 60 · AdequateLow 29Details
Commit message · f321x

qml: deduplicate wallet name validation

Deduplicates the wallet name validation between wizard and daemon.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 29/100

This commit cleans up duplicate wallet-name checking code in Electrum's mobile-style QML interface and moves the validation into one shared place. It also slightly changes when the 'rename' button is enabled. The changes look like a defensive hardening/refactoring rather than a fix for a known active attack, but they do strengthen checks against path-traversal-style wallet names.

AI review queuedappimage: update Dockerfile dependenciesby Roman Zeyde · 8e49eb80 · Apr 22, 2026 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · Roman Zeyde

appimage: update Dockerfile dependencies

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit updates version numbers for build dependencies inside a patch file used to create reproducible AppImage builds. It is a routine maintenance change with no visible security bug or vulnerability fix.

AI review queuedp4a ref 1098be6964cfc2156959e435e81c2c50f8398586by Sander van Grieken · 29b5e167 · Apr 22, 2026 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · Sander van Grieken

p4a ref 1098be6964cfc2156959e435e81c2c50f8398586

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit simply updates a reference to a specific version (commit hash) of the python-for-android build tool used to create Electrum's Android app. There is no indication in the commit itself that this is a security fix, vulnerability, or malicious change. It is a routine dependency/build-tool pointer update.

AI review queuedqml: FlatButton: show indicator for press-and-hold functionalityby Sander van Grieken · 31b19740 · Apr 22, 2026 · 2 filesMessage 50 · ThinInformational 15Details
Commit message · Sander van Grieken

qml: FlatButton: show indicator for press-and-hold functionality

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit adds a small visual progress bar to buttons in Electrum's mobile-style QML interface that have a hidden 'press and hold' action. It is purely a user-experience change to help users discover that long-pressing certain buttons does something extra. There is no security-relevant change in the code.

AI review queuedqml: don't add navigationbar padding when on-screen keyboard is visible, also allow stackview pages to override navigationbar background color to allow correct color runoff below buttonsby Sander van Grieken · 738992ac · Apr 22, 2026 · 12 filesMessage 73 · AdequateInformational 15Details
Commit message · Sander van Grieken

qml: don't add navigationbar padding when on-screen keyboard is visible,
also allow stackview pages to override navigationbar background color to
allow correct color runoff below buttons

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a user-interface polish change for Electrum's mobile/QML layout. It stops adding extra bottom padding when the on-screen keyboard is visible, and lets individual pages set the background color of the navigation-bar area so the screen looks consistent. There is no security issue visible in the changes.

AI review queuedqml: remove unused componentsby Sander van Grieken · 8e78d747 · Apr 22, 2026 · 2 filesMessage 35 · OpaqueInformational 15Details
Commit message · Sander van Grieken

qml: remove unused components

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit simply deletes two unused user-interface files from Electrum's mobile/QML GUI. There is no indication of a security fix, vulnerability, or behavior change that affects users. It appears to be routine code cleanup.

AI review queuedstyling OpenChannelDialogby Sander van Grieken · 1c0851c6 · Apr 22, 2026 · 1 fileMessage 25 · OpaqueInformational 15Details
Commit message · Sander van Grieken

styling OpenChannelDialog

25/100 · OpaqueMessage clarity
✓ Descriptive subject! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit is a purely cosmetic restyling of a user-interface dialog in Electrum's mobile/QML app. It rearranges the text box, buttons, and labels used when opening a Lightning payment channel, but does not change any security logic, validation, or data handling.

AI review queuedqml: various styling updatesby Sander van Grieken · 3c5dc660 · Apr 22, 2026 · 3 filesMessage 35 · OpaqueInformational 15Details
Commit message · Sander van Grieken

qml: various styling updates

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit makes small visual styling changes to three QML user-interface files in Electrum's mobile-style GUI. It adds a navigation bar background color property and sets background colors on two info text areas, plus adjusts spacing in a dialog. There is no indication these changes affect security, data handling, cryptography, or network behavior.

AI review queuedandroid: openssl 3.0.18by Sander van Grieken · 854f95b7 · Apr 22, 2026 · 1 fileMessage 38 · OpaqueLow 27Details
Commit message · Sander van Grieken

android: openssl 3.0.18

38/100 · OpaqueMessage clarity
✓ Subject identifies a change✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Low 27/100

This commit changes the version of OpenSSL used in Electrum's Android build from 3.3.1 to 3.0.18. It also removes a safety check that ensured the expected version was being used. The change appears to be a downgrade to an older OpenSSL version, which could reintroduce known security vulnerabilities that were fixed in newer releases. However, the commit message gives no explanation, and no security advisory or vendor statement is supplied.

AI review queuedbitcoin.py: add helper func: neuter_bitcoin_addressby SomberNight · 68e6995a · Apr 20, 2026 · 3 filesMessage 50 · ThinInformational 22Details
Commit message · SomberNight

bitcoin.py: add helper func: neuter_bitcoin_address

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 22/100

This commit is a privacy improvement, not a security fix for an attack. It adds a small helper that truncates Bitcoin addresses before putting them into error messages. The goal is to protect users if those error messages are sent to a crash reporter or shown in logs, so that full addresses (which could identify transactions or balances) are not leaked. No vulnerability is being patched.

AI review queuedwallet_db: put 'genesis_blockhash' in DB, detect mainnet/testnet mixupby SomberNight · 45458c2f · Apr 20, 2026 · 3 filesMessage 98 · StrongLow 27Details
Commit message · SomberNight

wallet_db: put 'genesis_blockhash' in DB, detect mainnet/testnet mixup

If the user tries to open a wallet for a different chain (mainnet vs testnet), try to show a reasonable error message.

See previous attempt at this: https://github.com/spesmilo/electrum/commit/c13e05770150c5210783c3d42d3d2b1a683f18b4, which added `wallet.test_addresses_sanity()`. However there are many codepaths where "random" exceptions might get raised before the Wallet object is even instantiated.
See [discussion there](https://github.com/spesmilo/electrum/commit/c13e05770150c5210783c3d42d3d2b1a683f18b4#commitcomment-28017341):
> should we actually fix that?
> if yes, it would be better to write the network type in storage

Indeed now I think we should do that. At the time I was concerned it would not help against altcoin forks if we put "mainnet" or "testnet" in the DB. Now I realise we should just put the genesis block hash in the DB instead.

Many of the reports in https://github.com/spesmilo/electrum/issues/6526 are likely due to users trying to open a mainnet wallet in testnet mode or vice-versa.

fixes https://github.com/spesmilo/electrum/issues/9134
same issue in wizard 2fa two-step wallet-creation flow

98/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 27/100

This commit improves Electrum so that when a user accidentally opens a wallet created for one Bitcoin network (mainnet) while running Electrum configured for another (testnet), they get a clear error message instead of confusing crashes. It stores the network's genesis block hash inside the wallet file and checks it on load. It is a defensive hardening change, not a fix for an active security vulnerability or exploit.

AI review queuedwallet: make_unsigned_tx: fix base_tx for GUI simple-send batchingby SomberNight · febe95e6 · Apr 19, 2026 · 4 filesMessage 91 · StrongLow 34Details
Commit message · SomberNight

wallet: make_unsigned_tx: fix base_tx for GUI simple-send batching

fixes regression from https://github.com/spesmilo/electrum/commit/a9f20e4d3de9848247a9079b5b164d8006cf80db :
For the GUI / manual new tx constructions usecase, the flow relies on `base_tx.add_info_from_wallet(self)` being called before `base_tx_fee = base_tx.get_fee()`.

fixes https://github.com/spesmilo/electrum/issues/10587
maybe fixes https://github.com/spesmilo/electrum/issues/8876
probably not a full fix: base_tx could have inputs for which add_info_from_wallet is not sufficient

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 34/100

This commit fixes a bug in Electrum's Bitcoin wallet where combining a new payment with an existing unconfirmed transaction (a feature called RBF batching) could fail or compute fees incorrectly. The root cause was that the code tried to read the existing transaction's fee before it had loaded all the necessary wallet information about that transaction's inputs. The fix reorders the code so the wallet enriches the transaction first, then reads its fee. It also adds a safety check to skip transactions whose confirmation status is unknown when looking for batching candidates.

AI review queuedqml: allow renaming walletsby f321x · 8a12874c · Apr 8, 2026 · 3 filesMessage 66 · AdequateLow 30Details
Commit message · f321x

qml: allow renaming wallets

Allows to rename a wallet file from the QML Wallet Details view.
This seems like a feature we should support as the use-case of a wallet can
change or maybe the user didn't think about a proper name when setting
up the wallet. Especially with lightning channels it is not possible to
restore from seed to change the name.

Fixes #4377

66/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 30/100

This commit adds a feature that lets users rename their wallet file from the mobile-style QML user interface. It is a normal feature addition, not a security fix. The code does include some safety checks, but there are small gaps that could theoretically allow a misnamed or clashing wallet file. There is no evidence this was released as a security patch or credited to a security researcher.