Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This is a small bug-fix patch for Electrum's QML (mobile-style) graphical interface. The crash reporter was not correctly handling exceptions that come from Python's threading system, which could cause the crash reporter itself to misbehav…
Fixes incorrect exception argument handling in crash reporterPrevents potential secondary failure in error-reporting pathNo security boundary crossed; no input from untrusted source is processed
This commit fixes a bug in Electrum's mobile-style QML crash reporter. When an uncaught exception occurred inside a background thread, the crash reporter itself would break because it expected three pieces of information but received one b…
Crash reporter failure could hide or obscure real runtime errors in background threadsNo input validation, privilege boundary, or cryptographic issue presentFix improves diagnostic fidelity but does not close an attack vector
This commit changes how Electrum creates unsigned Bitcoin transactions when an existing 'base transaction' is provided. Previously, the wallet wrongly demanded spendable coins even when the caller supplied a base transaction that already c…
Relaxation of input-source preconditionAddition of consensus-level invariant assertion (at least one input)Addition of empty-input guard before PartialTransaction construction
This commit fixes a crash in Electrum's transaction builder. If a user had only one on-chain coin (UTXO) that was just enough to meet a reserve requirement, clicking 'Max' in the send tab would hit an internal assertion and fail instead of…
Denial-of-service-like crash path triggered by user action in normal wallet stateAssertion failure reachable through GUI send flowFix converts assertion crash into handled NotEnoughFunds exception
This is a routine maintenance commit that updates many of Electrum's software building blocks (dependencies) and raises the minimum required Python version from 3.10 to 3.11. It also refreshes the Linux distribution snapshots used to build…
Dependency version bumps for security-sensitive libraries (cryptography, cffi, libffi, sqlite)Removal of an embedded PGP public key and switch to hash verification for Windows Python installer downloadsBase image refresh from EOL/near-EOL Debian bullseye to bookworm for AppImage builds
This commit is a straightforward internal cleanup: it moves repeated checks like 'are we running on Windows?', 'are we on Android?', and 'are we inside an AppImage?' into a single new helper module called platform.py. The actual behavior o…
This commit is a straightforward internal cleanup: it moves repeated operating-system checks (Windows, macOS, Linux, Android, AppImage) into a single new helper module called platform.py and updates the rest of the code to use those helper…
This commit only changes the software version number from 4.8.3 to 4.8.4 in a single file. It contains no security-related changes, no bug fixes, and no functional code modifications.
This commit relaxes a wallet check when creating a new Bitcoin transaction. Previously, Electrum refused to create a transaction if the user had no spendable coins and no explicit inputs. The change allows creation to continue if a 'base t…
Relaxation of input/coin availability guardAddition of post-construction input count assertionPotential workflow: Replace-By-Fee (RBF) or transaction bumping using base_tx inputs
This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an older thread-based background scan for BIP39 seed accounts with a newer asyncio-based task approach, and makes the recovery dialog destroy itself wh…
Refactor of async task lifecycle and cancellation handlingDialog lifecycle cleanup with onClosed: destroy()Use of ignore_if_destroyed to avoid callbacks on destroyed QML objects
This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an extra background thread with a simpler asyncio-based callback for scanning BIP39 seed accounts. There is no indication this fixes a security bug; it…
This commit fixes a bug in Electrum's Qt 'Send' tab where selecting a contact from the autocomplete dropdown could briefly leave the wrong recipient active. Previously, the payment field was set to a display name like 'Alice <alice@example…
UI state desynchronization between displayed recipient and active PaymentIdentifierStale PaymentIdentifier usable for ~1 second after recipient text changesPay/Save/Max buttons enabled while recipient is being edited
This commit fixes a UI bug in Electrum's QML (mobile-style) interface where transaction and address labels could become stale or fail to update after editing. It replaces a fragile manual callback system with a proper event listener so the…
No security-relevant signals in diff: no privilege escalation, injection, cryptographic, or authentication changes.Fixes a UI consistency bug (stale labels) that could mislead users but does not enable direct exploitation.Adds event-listener lifecycle management (register/unregister on destroy) to prevent dangling callbacks and potential use-after-free patterns.
This commit fixes a bug in Electrum's mobile-style QML password dialog. If a user tapped the OK/confirm button while the dialog was already closing, the app could emit an extra 'password entered' signal. That extra signal triggered a crash…
Crash in authentication-related code path (AuthMixin)Duplicate signal emission during UI state transitionUser-interaction race condition (tap while dialog closing)
This commit is a performance fix for a wallet function that traces where a transaction's funds came from. It replaces a slow, repeatedly-recursive approach with a more efficient loop and removes an old cache. The change also fixes how the …
Performance fix for wallet history traversalAddress-reuse uncle detection logic changedCache removed in favor of iterative computation
This commit fixes a bug where Electrum wallets created with unusual, hand-crafted 'old-style' seed phrases could not be opened or used. These seeds decode to an odd number of hex characters, which the program previously rejected. The chang…
Input validation relaxed for legacy data (odd-length hex strings)New user-facing error path prevents seed display when mnemonic encoding is impossibleGUI exception handling narrowed: UserFacingException shown as str, other Exception as repr
This commit is a small follow-up cleanup. It translates several user-facing error messages into different languages and makes the Qt GUI handle one specific file-read/write error (StorageReadWriteError) more gracefully, showing a warning d…
Exception-handling path changed in GUIUser-facing error messages internationalizedNo changes to encryption, wallet parsing semantics, or permissions
This commit improves Electrum's error handling when a user tries to open a file that is not a valid Electrum wallet. Previously, if the file contained bytes that were not valid UTF-8 text, the program would crash with a confusing technical…
Error-handling hardeningUser-facing exception message improvedNo cryptographic or parsing logic changed
This is a small user-interface fix in Electrum's Qt desktop app. Previously, if the wallet file was on a read-only folder or an unplugged drive, the app treated the resulting StorageReadWriteError as an unexpected crash and sent a crash re…
No memory safety, cryptographic, or authorization changesException handling change only; no new attack surface introducedCrash-reporting no longer triggered for expected I/O failure scenarios
This commit is a small follow-up cleanup in Electrum's keystore code. It renames an internal helper function, makes the code accept certain unusual 'old' seed phrases that some users created by hand, improves an error message shown to user…
Refactoring of seed validation helperUser-facing error handling improvement in seed displayGrandfathering of non-standard old seed phrases
This is a small bug-fix patch for Electrum's QML (mobile-style) user interface. It prevents the app from crashing when a wallet is closed while a fee-slider screen is still active. The code now checks whether a wallet still exists before trying to read its settings or compare transactions. There is no indication this can be used to steal funds or attack users remotely.
AI review queuedMerge pull request #10994 from spesmilo/ln_config_symmetryby ThomasV · 304e22ec · Oct 9, 2026 · 9 filesMessage 58 · ThinLow 27Details
Commit message · ThomasV
Merge pull request #10994 from spesmilo/ln_config_symmetry
Ln config symmetry
58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 27/100
This is a large internal refactoring of how Electrum stores Lightning channel secrets. It removes private keys from the channel configuration objects saved in the wallet file, keeping only public data there, and puts the actual secrets (channel seed and multisig private key) directly in the channel storage. It also makes the local and remote channel configurations symmetric. The change includes a wallet database upgrade that converts old wallets to the new format and verifies that derived public keys match the stored ones. There is no direct evidence in the commit of an exploitable vulnerability; it looks like a hardening/cleanup change, but it touches sensitive key-handling code and the upgrade routine could in theory lock users out if key derivation does not match stored data.
AI review queuedMerge pull request #10991 from f321x/qml_history_calendar_sectionsby accumulator · beaa8291 · Oct 9, 2026 · 3 filesMessage 73 · AdequateInformational 15Details
Commit message · accumulator
Merge pull request #10991 from f321x/qml_history_calendar_sections
qml: use calendar based history sections
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit is a user-interface improvement for the Electrum mobile/QML wallet's transaction history screen. It changes how transactions are grouped by date, adding sections like 'Earlier this week' and 'Earlier this month' and making the week start follow the user's locale. There is no security issue here.
AI review queuedandroid: fix avoiding loading QtMultimedia on android. (#11018)by accumulator · 89dda292 · Oct 8, 2026 · 3 filesMessage 81 · StrongInformational 24Details
Commit message · accumulator
android: fix avoiding loading QtMultimedia on android. (#11018)
* android: fix avoiding loading QtMultimedia on android.
followup on fd5b867689f6f2b29d4681e0edd51238be7ac415, which did not properly avoid SendDialog compilation after wallet load.
This moves the SendDialog component signal handlers declared in WalletMainView to the SendDialog component itself, and dynamically loads the component at runtime, only if running on desktop.
fixes #10784
* qml: quit the app in case of send/scan component load error
main.qml: dedup app quit logic into quitApp() function
Co-authored-by: Felix <51097237+f321x@users.noreply.github.com>
---------
Co-authored-by: Felix <51097237+f321x@users.noreply.github.com>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 24/100
This commit fixes a bug in Electrum's Android app where a desktop-only camera component (QtMultimedia) was accidentally being loaded on Android, which could cause crashes. The fix moves the send/scan dialog code so it is only loaded on desktop, and adds a clean app-exit path if loading fails. There is no direct evidence this is a security vulnerability; it appears to be a stability/crash fix.
AI review queuedMerge pull request #11017 from f321x/fix_10998by accumulator · 6b78158d · Oct 7, 2026 · 6 filesMessage 68 · AdequateModerate 59Details
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 59/100
This commit fixes a bug where Electrum would save private keys for unsupported Bitcoin address types (such as multi-signature 'p2wsh' keys) to the wallet file when a user tried to import them. The fix makes the wallet reject and not store these unsupported keys. Before the fix, an imported unsupported key could silently persist in the wallet even though Electrum could not actually use it, which could mislead users and potentially cause loss of funds or confusion.
AI review queuedMerge pull request #10993 from spesmilo/remove_attrby ghost43 · 4cb03ef4 · Oct 1, 2026 · 8 filesMessage 58 · ThinInformational 12Details
Commit message · ghost43
Merge pull request #10993 from spesmilo/remove_attr
replace attrs with dataclasses
58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 12/100
This commit replaces the third-party 'attrs' library with Python's built-in 'dataclasses' across several Electrum source files. It is a routine refactoring change: the same data classes are defined in a different syntax, and equivalent validation/conversion logic is preserved using Python's standard mechanisms. There is no indication this fixes or introduces a security vulnerability.
Merge pull request #11003 from SomberNight/202609_tx_any_segwit
transaction: rename `is_segwit`->`is_any_segwit`, and add `is_all_segwit`
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 44/100
This commit renames Electrum's transaction 'is_segwit' check to 'is_any_segwit' and adds a new 'is_all_segwit' check. It then uses the stricter 'all inputs are segwit' rule when validating Lightning channel funding transactions and timelock-recovery transactions. The change is defensive: a transaction that mixes segwit and non-segwit inputs still has a malleable transaction ID, which can cause problems for protocols that rely on a stable txid. The commit does not claim to fix an active exploit, and one new code comment explicitly flags that a related zeroconf check is still incomplete and unsafe.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 44/100
This commit adds a helper method to check whether every input of a Bitcoin transaction uses SegWit, and starts using it in place of a weaker 'any input is SegWit' check when validating Lightning funding transactions. SegWit fixes 'transaction malleability,' where the transaction ID (txid) can be changed by someone else after signing. For Lightning, the funding txid must be stable because both parties rely on it to set up the channel. The old check only required at least one SegWit input, which could still allow non-SegWit inputs to be re-signed or malleated, changing the txid. The commit also adds a TODO noting that a zero-confirmation code path still doesn't perform this check at all, which the authors already flag as unsafe.
transaction: rename tx.is_segwit() to tx.is_any_segwit()
Some callers might want the "any" usage, some might want "all".
65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 27/100
This commit is a code cleanup that renames a method from is_segwit() to is_any_segwit() and adds a clarifying comment. It does not change the actual behavior of the code. The rename makes it clearer that the method returns true if any input is SegWit, not necessarily all inputs. A developer left a note in the Lightning channel funding code saying the current check should eventually use an 'all inputs are SegWit' check instead. On its own, this commit is not a security fix, but it highlights a place where the code's understanding of SegWit malleability could be imprecise.
Merge pull request #10984 from f321x/fix_onchain_backup_discovery
lnwallet: fix discovery of onchain backups
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 59/100
This commit fixes how Electrum's Lightning wallet discovers and watches 'on-chain channel backups'—recovery records embedded in funding transactions. Previously, backups could be missed if the wallet learned about a transaction in stages, or if two channels reused the same on-chain funding address. The fix makes the wallet re-check transactions when more of their inputs are identified as belonging to the wallet, and switches watcher callbacks from being keyed by address to being keyed by the unique funding outpoint. A malicious or buggy remote peer could reuse a funding public key, causing two channels to share the same address; the old code might then overwrite the watcher callback for one channel with the other, leaving a backup unwatched and funds unrecoverable if the channel closed.
Merge pull request #10992 from f321x/dedup_is_seed_wizard
qt: wizard: dedup seed validation rules
58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 29/100
This commit simplifies the seed-validation logic in Electrum's Qt wallet wizard by replacing a local copy of the rules with a call to an existing shared validation method. The change appears to be a code-cleanup refactor that removes duplicated logic rather than fixing a security bug. There is no direct evidence in the commit or supplied references that this change addresses a vulnerability.
`WCHaveSeed.is_seed()` carried the same rules as `KeystoreWizard.validate_seed()`, so instead use this method to have the rules in a single place and prevent them from drifting apart.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI analysis · Informational 12/100
This commit is a small code cleanup in Electrum's wallet setup wizard. It removes a duplicate copy of the rules used to check whether a recovery seed is valid and instead reuses an existing method. There is no indication this fixes a security bug; it is a maintenance change to keep the two copies of the rules from diverging in the future.
transaction: treat native segwit input with non-empty witness as complete
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 44/100
This commit fixes a bug where Electrum failed to recognize certain already-signed Bitcoin transactions as complete. Specifically, for native SegWit inputs, Bitcoin Core can produce a finalized PSBT with a valid witness but an empty scriptSig. Electrum's 'is this transaction complete?' check previously required a non-empty scriptSig for such inputs, so it wrongly treated these valid, signed transactions as incomplete. The fix adds a rule: if a native SegWit input has a non-empty witness, treat it as complete. This could have led users to try re-signing or re-broadcasting, or to confusion about whether a transaction was ready.
AI review queuedtransaction: treat native segwit input with non-empty witness as completeby ThomasV · e9bb42e6 · Sep 22, 2026 · 2 filesMessage 81 · StrongLow 35Details
Commit message · ThomasV
transaction: treat native segwit input with non-empty witness as complete
Bitcoin Core, Sparrow omit the final scriptSig is empty, for native segwit inputs, and only write the witness. PartialTxInput.is_complete() should not require both fields to be present. fixes #10986
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 35/100
This commit fixes a bug where Electrum incorrectly treated finalized Bitcoin transactions as incomplete. Some wallet software (like Bitcoin Core and Sparrow) creates native SegWit transactions that omit an empty placeholder field Electrum expected. As a result, Electrum could wrongly refuse to broadcast or mishandle valid, already-signed transactions. The fix makes Electrum recognize these transactions as complete when the witness data is present.
Merge pull request #10981 from spesmilo/do_not_sign_txin_with_witness
transaction: do not sign txin if if already has a witness
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 68/100
This change prevents Electrum from re-signing Bitcoin transaction inputs that already contain a witness (the data proving the input was authorized). The patch fixes a bug where Electrum could incorrectly sign a non-SegWit input as if it were SegWit when a PSBT already included a witness for that input. This could lead to producing invalid or unintended signatures during transaction signing, especially when handling partially-signed transactions from external signers.
AI review queuedlightning: derive local channel keys instead of storing them (see #4909)by ThomasV · 461238aa · Sep 19, 2026 · 9 filesMessage 81 · StrongLow 31Details
Commit message · ThomasV
lightning: derive local channel keys instead of storing them (see #4909)
Keep only pubkeys in LocalConfig. Privkeys and per_commitment_secret_seed are removed; they are re-derived from channel_seed on startup, and checked against the pubkeys. Secrets (channel_seed, multisig privkey) and funding_locked_received are moved to channel storage.
WalletDB conversion 73->74.
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 31/100
This commit refactors how Electrum stores Lightning channel keys. Instead of keeping private keys inside the channel configuration object that gets saved to disk, it now keeps only public keys there and re-derives the private keys from a channel seed when the wallet starts up. The goal is to reduce the amount of secret material sitting in persisted channel data. It also adds a wallet database upgrade that strips old private keys from existing wallets and moves the remaining secrets into the channel storage. This is a defensive hardening change, not a fix for an active exploit.
Merge pull request #10980 from spesmilo/add_input_from_network_do_not_ignore_exceptions
add_info_from_network: do not swallow exceptions
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 42/100
This is a one-line bugfix in Electrum's transaction handling. Previously, the code accidentally swallowed (hid) almost all exceptions when fetching extra transaction data from the network, only re-raising errors that were both network-related and not set to be ignored. After the fix, any unexpected error is re-raised so it can be handled or reported properly. The change improves reliability and error visibility, but the diff alone does not show an active security vulnerability being exploited.
Merge pull request #10970 from f321x/fix_bolt11_bugs_2
bolt11: bugfixes and cleanup
58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 60/100
This commit fixes several bugs in Electrum's handling of BOLT11 Lightning invoices. The most user-visible fixes are: stricter validation of invoice amounts (rejecting zero, negative, sub-millisatoshi, and leading-zero amounts), correct padding of the timestamp field so small dates don't get corrupted, preserving the 'n' (public key) tag when decoding so re-encoding doesn't silently drop it, and removing support for the non-standard 't' routing tag that could previously hide malformed data. There is also a fix to how description fields are truncated so they don't produce invalid UTF-8. These are correctness and robustness fixes rather than a single critical vulnerability, but they could have allowed malformed or ambiguous invoices to be accepted or re-encoded incorrectly.
AI review queuedbolt11: remove tag arg from get_routing_infoby f321x · e78fba28 · Sep 18, 2026 · 7 filesMessage 60 · AdequateInformational 15Details
Commit message · f321x
bolt11: remove tag arg from get_routing_info
Through the removal of t-type routing info tags this argument isn't neccessary anymore.
60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This is a small code cleanup change. A function that reads routing hints from Lightning invoices no longer takes a tag argument because only one type of routing hint ('r') is now supported. All callers are updated accordingly. There is no security issue visible in the change.
AI review queuedMerge pull request #10940 from accumulator/fix_10937by Felix · a57ef6e7 · Sep 14, 2026 · 10 filesMessage 73 · AdequateModerate 62Details
Commit message · Felix
Merge pull request #10940 from accumulator/fix_10937
Add BOLT11DecodeException and InvalidBitcoinURI wraps for missing uncaught exceptions.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 62/100
This commit tightens how Electrum parses Bitcoin payment requests (BOLT11 lightning invoices and BIP21 URIs). It turns previously uncaught internal errors into proper validation failures, rejects malformed invoice fields that used to be silently skipped, and adds a wallet database upgrade that deletes stored invoices which no longer pass the stricter checks so old wallets can still open. The main user-visible risk is that a malicious or malformed invoice/URI could previously crash the parser or be accepted when it should have been rejected.
✓ Subject identifies a change✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Low 40/100
This commit tightens how Electrum parses BOLT11 Lightning invoices. It now rejects duplicate 'n' (node pubkey) tags instead of silently keeping only the first one, and it rejects invoice timestamps that are negative or too far in the future. These are defensive correctness fixes that reduce the chance a malformed or malicious invoice could confuse the wallet, but they are follow-up cleanups rather than a fix for a known active attack.
AI review queuedMerge pull request #10737 from sashazykov/hw-close-wallet-thread-leakby Felix · 5b77ca46 · Sep 11, 2026 · 2 filesMessage 73 · AdequateLow 32Details
Commit message · Felix
Merge pull request #10737 from sashazykov/hw-close-wallet-thread-leak
hw_wallet: fix crash on exit if device unpairing fails
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
This commit fixes a shutdown bug in Electrum's hardware wallet support. Previously, if disconnecting from a hardware wallet failed, the cleanup thread could keep running, which could crash the application when closing. The fix stops the thread before attempting disconnect, and makes the disconnect step tolerate errors instead of crashing.
Merge pull request #10965 from SomberNight/202609_header_checkpoints
update block header checkpoints
58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 21/100
This commit only adds new Bitcoin block header checkpoints to Electrum's built-in chain data files. Checkpoints are hardcoded reference points that help the wallet verify it is following the real blockchain and not a fake one. Updating them is a routine maintenance change; it does not fix a software bug and does not introduce new code behavior. It slightly strengthens protection against certain long-range attacks by extending the known-good chain history.
``` >>> network.export_checkpoints(f"/home/user/wspace/electrum/electrum/chains/{electrum.constants.net.NET_NAME}/checkpoints.json") ``` (with the last 1-3 retarget periods manually removed, depending on how much we trust a chain not to do deep reorgs)
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit simply refreshes Electrum's built-in list of Bitcoin blockchain checkpoints. Checkpoints are known-good block hashes that help the wallet verify it is following the real chain. The update adds newer checkpoints for mainnet, signet, testnet, and testnet4. There is no code change and no security vulnerability introduced or fixed here.
AI review queuedMerge pull request #10945 from accumulator/stale_utxo_data_fixesby Felix · e20b24c0 · Sep 10, 2026 · 9 filesMessage 58 · ThinLow 46Details
Commit message · Felix
Merge pull request #10945 from accumulator/stale_utxo_data_fixes
Stale utxo data fixes
58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 46/100
This commit fixes cases where Electrum's wallet cache could hold onto outdated information about coins and transactions after blockchain reorganizations or mempool changes. For example, if a transaction was previously thought to be mined but later returned to the mempool, the wallet might still treat it as confirmed and display an incorrect 'short ID' for it. The patch adds cache invalidation calls and makes the code consistently check whether a transaction is actually mined before showing a compact short ID. It is a correctness/bug-fix change rather than a direct remote-exploitable vulnerability, but stale cached state could mislead users or downstream logic about confirmation status.