EL
← All projectsElectrum

Electrum

Long-running lightweight Bitcoin wallet for desktop and mobile platforms.

BitcoinSoftware walletsActive incident
Repository coverage

1361 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

108security candidates322second-pass queue1084AI analyses
90commits · 30 days
200commits · 60 days
570commits · 180 days
1124commits · 365 days
Backfill bands
Aug 5 → Feb 6470 seen11 candidatesComplete
Feb 6 → Jun 6346 seen10 candidatesComplete
Jun 6 → Jul 653 seen2 candidatesComplete
Jul 6 → Aug 554 seen3 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

66/100 average clarity
252Strong · 80–100
675Adequate · 60–79
388Thin · 40–59
46Opaque · 0–39
2security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
SomberNight42533373163
ThomasV16511104163
ghost4376626170
f321x44128400070
Sander van Grieken12412112057
Felix54720070
user323062
ekzyis222053
accumulator28111072
Roman Zeyde515053
Sasha Zykov515075
Aaron Fiore414068
Analysis record

Published AI watches

Last scanned 38 minutes ago

Informational 19 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11172 from accumulator/qml_crash_reporter_threading

This is a small bug-fix patch for Electrum's QML (mobile-style) graphical interface. The crash reporter was not correctly handling exceptions that come from Python's threading system, which could cause the crash reporter itself to misbehav…

Fixes incorrect exception argument handling in crash reporterPrevents potential secondary failure in error-reporting pathNo security boundary crossed; no input from untrusted source is processed
45ad42f7by Felix+4−11 file
No security note in commit
Informational 19 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qml: crash reporter: handle threading.excepthook arguments

This commit fixes a bug in Electrum's mobile-style QML crash reporter. When an uncaught exception occurred inside a background thread, the crash reporter itself would break because it expected three pieces of information but received one b…

Crash reporter failure could hide or obscure real runtime errors in background threadsNo input validation, privilege boundary, or cryptographic issue presentFix improves diagnostic fidelity but does not close an attack vector
2e7fe460by Sander van Grieken+4−11 file
No security note in commit
Low 40 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11154 from spesmilo/make_unsigned_tx_with_base_tx

This commit changes how Electrum creates unsigned Bitcoin transactions when an existing 'base transaction' is provided. Previously, the wallet wrongly demanded spendable coins even when the caller supplied a base transaction that already c…

Relaxation of input-source preconditionAddition of consensus-level invariant assertion (at least one input)Addition of empty-input guard before PartialTransaction construction
ff273162by ThomasV+4−11 file
No security note in commit
Low 29 AI analysisMessage 68 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

wallet: make_unsigned_tx: follow-up prev

This commit fixes a crash in Electrum's transaction builder. If a user had only one on-chain coin (UTXO) that was just enough to meet a reserve requirement, clicking 'Max' in the send tab would hit an internal assertion and fail instead of…

Denial-of-service-like crash path triggered by user action in normal wallet stateAssertion failure reachable through GUI send flowFix converts assertion crash into handled NotEnoughFunds exception
462f631dby SomberNight+2−01 file
No security note in commit
Low 28 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11097 from SomberNight/202610_bump_deps

This is a routine maintenance commit that updates many of Electrum's software building blocks (dependencies) and raises the minimum required Python version from 3.10 to 3.11. It also refreshes the Linux distribution snapshots used to build…

Dependency version bumps for security-sensitive libraries (cryptography, cffi, libffi, sqlite)Removal of an embedded PGP public key and switch to hash verification for Windows Python installer downloadsBase image refresh from EOL/near-EOL Debian bullseye to bookworm for AppImage builds
84345fdcby ghost43+934−103048 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11139 from accumulator/consolidate_platform_checks

This commit is a straightforward internal cleanup: it moves repeated checks like 'are we running on Windows?', 'are we on Android?', and 'are we inside an AppImage?' into a single new helper module called platform.py. The actual behavior o…

22e24580by ghost43+87−7619 files
No security note in commit
Informational 15 AI analysisMessage 45 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

consolidate platform checks into platform.py

This commit is a straightforward internal cleanup: it moves repeated operating-system checks (Windows, macOS, Linux, Android, AppImage) into a single new helper module called platform.py and updates the rest of the code to use those helper…

9715f882by Sander van Grieken+87−7619 files
No security note in commit
Informational 15 AI analysisMessage 38 · Opaque
EL ElectrumElectrum BitcoinSoftware wallets

version: bump to 4.8.4

This commit only changes the software version number from 4.8.3 to 4.8.4 in a single file. It contains no security-related changes, no bug fixes, and no functional code modifications.

0c661eb8by f321x+1−11 file
No security note in commit
Low 29 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

make_unsigned_transaction: do not require coins if there is a base_tx

This commit relaxes a wallet check when creating a new Bitcoin transaction. Previously, Electrum refused to create a transaction if the user had no spendable coins and no explicit inputs. The change allows creation to continue if a 'base t…

Relaxation of input/coin availability guardAddition of post-construction input count assertionPotential workflow: Replace-By-Fee (RBF) or transaction bumping using base_tx inputs
876360deby ThomasV+2−11 file
No security note in commit
Informational 17 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11111 from accumulator/qml_bip39recovery_task_refactor

This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an older thread-based background scan for BIP39 seed accounts with a newer asyncio-based task approach, and makes the recovery dialog destroy itself wh…

Refactor of async task lifecycle and cancellation handlingDialog lifecycle cleanup with onClosed: destroy()Use of ignore_if_destroyed to avoid callbacks on destroyed QML objects
896a68d7by Felix+44−332 files
No security note in commit
Informational 12 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qml: refactor BIP39 account scan to asyncio tasks.

This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an extra background thread with a simpler asyncio-based callback for scanning BIP39 seed accounts. There is no indication this fixes a security bug; it…

00ed883aby Sander van Grieken+44−332 files
No security note in commit
Moderate 59 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qt: paytoedit: complete contacts to their key, not 'name <key>'

This commit fixes a bug in Electrum's Qt 'Send' tab where selecting a contact from the autocomplete dropdown could briefly leave the wrong recipient active. Previously, the payment field was set to a display name like 'Alice <alice@example…

UI state desynchronization between displayed recipient and active PaymentIdentifierStale PaymentIdentifier usable for ~1 second after recipient text changesPay/Save/Max buttons enabled while recipient is being edited
dd1b50fbby f321x+47−132 files
No security note in commit
Informational 18 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11092 from f321x/qml_address_history_labels

This commit fixes a UI bug in Electrum's QML (mobile-style) interface where transaction and address labels could become stale or fail to update after editing. It replaces a fragile manual callback system with a proper event listener so the…

No security-relevant signals in diff: no privilege escalation, injection, cryptographic, or authentication changes.Fixes a UI consistency bug (stale labels) that could mislead users but does not enable direct exploitation.Adds event-listener lifecycle management (register/unregister on destroy) to prevent dangling callbacks and potential use-after-free patterns.
9242c505by Felix+334−8412 files
No security note in commit
Low 34 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qml: avoid potential Ok signal by tapping while dialog is closing,

This commit fixes a bug in Electrum's mobile-style QML password dialog. If a user tapped the OK/confirm button while the dialog was already closing, the app could emit an extra 'password entered' signal. That extra signal triggered a crash…

Crash in authentication-related code path (AuthMixin)Duplicate signal emission during UI state transitionUser-interaction race condition (tap while dialog closing)
00f981edby Sander van Grieken+8−01 file
No security note in commit
Informational 21 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11091 from f321x/fix_num_parents_perf_simple

This commit is a performance fix for a wallet function that traces where a transaction's funds came from. It replaces a slow, repeatedly-recursive approach with a more efficient loop and removes an old cache. The change also fixes how the …

Performance fix for wallet history traversalAddress-reuse uncle detection logic changedCache removed in favor of iterative computation
4ec70746by ThomasV+82−463 files
No security note in commit
Informational 24 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11047 from fametrano/old-seed-odd-length

This commit fixes a bug where Electrum wallets created with unusual, hand-crafted 'old-style' seed phrases could not be opened or used. These seeds decode to an odd number of hex characters, which the program previously rejected. The chang…

Input validation relaxed for legacy data (odd-length hex strings)New user-facing error path prevents seed display when mnemonic encoding is impossibleGUI exception handling narrowed: UserFacingException shown as str, other Exception as repr
fc31115eby ghost43+93−157 files
No security note in commit
Informational 19 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11096 from f321x/followup_11094

This commit is a small follow-up cleanup. It translates several user-facing error messages into different languages and makes the Qt GUI handle one specific file-read/write error (StorageReadWriteError) more gracefully, showing a warning d…

Exception-handling path changed in GUIUser-facing error messages internationalizedNo changes to encryption, wallet parsing semantics, or permissions
54c355feby Felix+9−75 files
No security note in commit
Informational 23 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11094 from devdavidejesus/fix-10760-storage-not-utf8

This commit improves Electrum's error handling when a user tries to open a file that is not a valid Electrum wallet. Previously, if the file contained bytes that were not valid UTF-8 text, the program would crash with a confusing technical…

Error-handling hardeningUser-facing exception message improvedNo cryptographic or parsing logic changed
2a20256fby Felix+10−12 files
No security note in commit
Informational 20 AI analysisMessage 65 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qt: show StorageReadWriteError to user instead of crash reporting it

This is a small user-interface fix in Electrum's Qt desktop app. Previously, if the wallet file was on a read-only folder or an unplugged drive, the app treated the resulting StorageReadWriteError as an unexpected crash and sent a crash re…

No memory safety, cryptographic, or authorization changesException handling change only; no new attack surface introducedCrash-reporting no longer triggered for expected I/O failure scenarios
5a971b11by f321x+2−11 file
No security note in commit
Low 26 AI analysisMessage 45 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

keystore: follow-up prev: small clean-up

This commit is a small follow-up cleanup in Electrum's keystore code. It renames an internal helper function, makes the code accept certain unusual 'old' seed phrases that some users created by hand, improves an error message shown to user…

Refactoring of seed validation helperUser-facing error handling improvement in seed displayGrandfathering of non-standard old seed phrases
ead42d09by SomberNight+35−154 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Security candidatewallet.check_sighash: don't assume tx.add_info_from_wallet alrdy ranby SomberNight · b57327fb · Jul 1, 2026 · 2 filesMessage 85 · StrongLow 42Details
Commit message · SomberNight

wallet.check_sighash: don't assume tx.add_info_from_wallet alrdy ran

Sighash warnings/errors might in theory not be triggered for
inputs owned by the wallet but which are beyond the gap limit.
tx.add_info_from_wallet(wallet) side-effects the wallet state
so that wallet.is_mine() learns derivation paths for beyond-gap-limit addresses.

In practice both GUIs currently call tx.add_info_from_wallet before
check_sighash runs, so this was not exploitable.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
explicit security languagesigning or wallet path
AI analysis · Low 42/100

This commit fixes a defensive check in the Electrum Bitcoin wallet. Before signing a transaction, Electrum checks whether the transaction uses unusual 'sighash' flags that could allow someone else to move coins unexpectedly. The bug was that this safety check could be skipped for wallet addresses that were beyond the user's configured gap limit, because the wallet had not yet learned those addresses belonged to it. The fix makes the check self-contained by first asking the transaction to teach the wallet about any relevant addresses, using a copy so the original transaction is not changed. The commit message says the current graphical interfaces already performed this step, so the bug was not exploitable in practice through normal use.

AI review queuedupdate block header checkpointsby SomberNight · 9ebabef3 · Jul 1, 2026 · 4 filesMessage 58 · ThinInformational 15Details
Commit message · SomberNight

update block header checkpoints

```
>>> network.export_checkpoints(f"/home/user/wspace/electrum/electrum/chains/{electrum.constants.net.NET_NAME}/checkpoints.json")
```

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit simply adds newer Bitcoin block checkpoints to Electrum's built-in chain data files. Checkpoints are pre-recorded block hashes that help the wallet verify it is following the correct blockchain. There is no code change and no indication of a security vulnerability.

Lower-prioritybuild: rerun freeze_packagesby SomberNight · 5972fc7d · Jul 1, 2026 · 9 filesMessage 90 · StrongLow 36Details
Commit message · SomberNight

build: rerun freeze_packages

somewhat conservative and paranoid...

generated with patch:
```
user@debian:~/wspace/electrum$ git diff
diff --git a/contrib/requirements/requirements-binaries-mac.txt b/contrib/requirements/requirements-binaries-mac.txt
index ab8bd5f33..dfbd55c2b 100644
--- a/contrib/requirements/requirements-binaries-mac.txt
+++ b/contrib/requirements/requirements-binaries-mac.txt
@@ -5,3 +5,11 @@ PyQt6<6.7
PyQt6-Qt6<6.7,!=6.6.3

cryptography>=2.6
+
+
+pip==25.1.1
+setuptools==80.9.0
+wheel==0.45.1
+
+cryptography==46.0.7
+pycparser==2.23
diff --git a/contrib/requirements/requirements-binaries.txt b/contrib/requirements/requirements-binaries.txt
index b41089680..5771aef24 100644
--- a/contrib/requirements/requirements-binaries.txt
+++ b/contrib/requirements/requirements-binaries.txt
@@ -3,3 +3,12 @@ PyQt6
# we need at least cryptography>=2.1 for electrum.crypto,
# and at least cryptography>=2.6 for dnspython[DNSSEC]
cryptography>=2.6
+
+
+pip==25.1.1
+setuptools==80.9.0
+wheel==0.45.1
+
+cryptography==46.0.7
+pycparser==2.23
+PyQt6==6.9.1
diff --git a/contrib/requirements/requirements-build-android.txt b/contrib/requirements/requirements-build-android.txt
index e9d272837..4bf6cc1fc 100644
--- a/contrib/requirements/requirements-build-android.txt
+++ b/contrib/requirements/requirements-build-android.txt
@@ -20,3 +20,10 @@ toml
# needed for the Qt/QML Android GUI:
# TODO double-check this
typing-extensions
+
+
+pip==25.1.1
+setuptools==80.9.0
+wheel==0.45.1
+
+sh==2.2.2
diff --git a/contrib/requirements/requirements-build-appimage.txt b/contrib/requirements/requirements-build-appimage.txt
index ee8b4aa89..d79cd93b6 100644
--- a/contrib/requirements/requirements-build-appimage.txt
+++ b/contrib/requirements/requirements-build-appimage.txt
@@ -7,4 +7,11 @@ wheel
# The pinned Cython must be installed before hidapi is built;
# otherwise when installing hidapi, pip just downloads the latest Cython.
# see https://github.com/spesmilo/electrum/issues/5859
-Cython>=0.27
\ No newline at end of file
+Cython>=0.27
+
+
+pip==25.1.1
+setuptools==80.9.0
+wheel==0.45.1
+
+Cython<3.2
diff --git a/contrib/requirements/requirements-build-base.txt b/contrib/requirements/requirements-build-base.txt
index 5bfea96fe..6cc7d303c 100644
--- a/contrib/requirements/requirements-build-base.txt
+++ b/contrib/requirements/requirements-build-base.txt
@@ -28,3 +28,12 @@ flit_core>=3.4,<4
# aio-libs/frozenlist and aio-libs/propcache needs:
# https://github.com/aio-libs/frozenlist/blob/c28f32d6816ca0fa56a5876e84831c46084bb85d/pyproject.toml#L6
expandvars
+
+
+pip==25.1.1
+setuptools==80.9.0
+wheel==0.45.1
+setuptools-scm<9
+
+expandvars==1.0.0
+poetry-core==2.1.3
diff --git a/contrib/requirements/requirements-build-mac.txt b/contrib/requirements/requirements-build-mac.txt
index 5504223d3..583c91170 100644
--- a/contrib/requirements/requirements-build-mac.txt
+++ b/contrib/requirements/requirements-build-mac.txt
@@ -15,3 +15,12 @@ packaging>=22.0
# otherwise when installing hidapi, pip just downloads the latest Cython.
# see https://github.com/spesmilo/electrum/issues/5859
Cython>=0.27
+
+
+
+pip==25.1.1
+setuptools==80.9.0
+wheel==0.45.1
+
+Cython<3.2
+pyinstaller-hooks-contrib==2025.4
diff --git a/contrib/requirements/requirements-build-wine.txt b/contrib/requirements/requirements-build-wine.txt
index 80cccba33..647a90acb 100644
--- a/contrib/requirements/requirements-build-wine.txt
+++ b/contrib/requirements/requirements-build-wine.txt
@@ -9,3 +9,10 @@ altgraph
pywin32-ctypes>=0.2.1
pyinstaller-hooks-contrib>=2025.2
packaging>=22.0
+
+
+pip==25.1.1
+setuptools==80.9.0
+wheel==0.45.1
+
+pyinstaller-hooks-contrib==2025.4
diff --git a/contrib/requirements/requirements-hw.txt b/contrib/requirements/requirements-hw.txt
index 5dfb0290e..3c4955eb6 100644
--- a/contrib/requirements/requirements-hw.txt
+++ b/contrib/requirements/requirements-hw.txt
@@ -30,3 +30,13 @@ pyserial>=3.5.0,<4.0.0
# prefer older urllib3 to avoid needing hatchling
# (pulled in via trezor -> requests -> urllib3)
urllib3<2
+
+
+pip==25.1.1
+setuptools==80.9.0
+wheel==0.45.1
+
+cryptography==46.0.7
+pycparser==2.23
+libusb1<3.4
+protobuf==3.20.3
diff --git a/contrib/requirements/requirements.txt b/contrib/requirements/requirements.txt
index e9963c12c..da9ab8cde 100644
--- a/contrib/requirements/requirements.txt
+++ b/contrib/requirements/requirements.txt
@@ -18,3 +18,15 @@ attrs>=20.1.0,<23
# - upper limit to avoid needing hatchling at build-time :/
# (however newer versions should work at runtime)
dnspython>=2.2,<2.5
+
+
+pip==25.1.1
+setuptools==80.9.0
+wheel==0.45.1
+
+aiohappyeyeballs<2.7
+jsonpatch==1.33
+jsonpointer==3.0.0
+propcache==0.3.1
+protobuf==3.20.3
+python-socks==2.8.1
```

90/100 · StrongMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
documentation-only discount
AI analysis · Low 36/100

This commit updates Electrum's frozen dependency lists to newer versions of many Python packages used to build and run the wallet. The author describes it as 'somewhat conservative and paranoid.' It is a routine dependency refresh, not a code fix for a known vulnerability. Updating pinned dependencies can improve security by moving to newer, patched versions, but the commit itself does not describe any specific security issue, and a large dependency bump always carries some risk of introducing new bugs or build problems.

Lower-priorityandroid build: bump openssl (3.0.18 -> 3.0.21)by SomberNight · 4af8b7f1 · Jul 1, 2026 · 1 fileMessage 45 · ThinLow 47Details
Commit message · SomberNight

android build: bump openssl (3.0.18 -> 3.0.21)

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 47/100

This commit updates the version of OpenSSL used when building the Electrum Android app from 3.0.18 to 3.0.21, along with the matching cryptographic fingerprint (SHA-512 hash). OpenSSL is a widely used library that provides encrypted connections. Newer patch releases typically fix security bugs in the older version, so this is likely a routine dependency update to address known vulnerabilities in OpenSSL 3.0.18. However, the commit message does not say which specific bugs are being fixed, and no separate security advisory was supplied.

Lower-prioritybuild: bump python versions in binariesby SomberNight · 991c79ff · Jul 1, 2026 · 3 filesMessage 85 · StrongInformational 19Details
Commit message · SomberNight

build: bump python versions in binaries

note: 3.12 is in security-only status,
so can't bump win/mac binaries without switching to 3.13
(as we don't compile our own cpython for those)
we should bump those to at least 3.13...

85/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
AI analysis · Informational 19/100

This commit updates the Python versions used to build Electrum's Android, Linux AppImage, and host Python components. It moves Android and host Python from 3.11.14 to 3.11.15, and the Linux AppImage from 3.12.11 to 3.12.13. It also switches Android builds to download Python from the official python.org source instead of GitHub auto-generated archives. The commit message notes that Python 3.12 is now in 'security-only' status and Windows/Mac binaries should ideally move to 3.13. This is a routine maintenance/security-hardening build change, not a fix for an active exploit.

AI review queuedqt: fix crash through stale pi resolveby f321x · 299be410 · Jul 1, 2026 · 1 fileMessage 76 · AdequateInformational 24Details
Commit message · f321x

qt: fix crash through stale pi resolve

When multiple PIs get resolved consecutively through
repeated editing of the PI field, and the `on_resolve_done`
callback tries to access a PI that has been cleared by
a previous, failed callback an exception is raised.

I was able to reproduce this somehow by adding a sleep to
`PaymentIdentifier._do_resolve()` and entering lightning addresses.

Fixes https://github.com/spesmilo/electrum/issues/10724

76/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 24/100

This commit fixes a bug in Electrum's Qt send tab where the app could crash if a user edited the payment recipient field quickly while previous lookups were still finishing. The fix ignores results from outdated lookups instead of letting them trigger an error.

Lower-priorityqml/2fa: partially reverse #10543by f321x · b5a0af27 · Jul 1, 2026 · 1 fileMessage 76 · AdequateInformational 19Details
Commit message · f321x

qml/2fa: partially reverse #10543

When opening the 2fa app on an android phone the Electrum app
gets killed, causing the user to lose the wizard state.
This is quite annoying, so we should prevent this until
there is a proper mechanism to keep the app alive.

76/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 19/100

This commit changes the Android two-factor authentication setup flow in Electrum's mobile app. Previously, tapping the QR code would open an external authenticator app directly, but on Android this caused Electrum to be killed by the system, losing the user's progress in the setup wizard. The fix simply copies the secret code to the clipboard instead and tells the user to enter or scan it manually. This is a usability/reliability fix, not a security vulnerability patch.

AI review queued(trivial) wallet: fix stale comment on on_event_invoice_statusby Sasha Zykov · 95317f4b · Jun 30, 2026 · 1 fileMessage 73 · AdequateInformational 15Details
Commit message · Sasha Zykov

(trivial) wallet: fix stale comment on on_event_invoice_status

The followup rename (_paid_invoice_keys -> _paid_invoice_keys_cache) and
the de-sloppify left this comment referring to the old name and claiming
the listener only tracks LN-driven changes; it is now the population path
for onchain invoices too.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only updates a stale code comment to match a recent variable rename and to correctly describe what the function now does. No actual code behavior was changed, so there is no security impact.

AI review queuedwallet: de-sloppify d2d4251c8 (paid invoice cache)by SomberNight · 63ee2f3a · Jun 30, 2026 · 2 filesMessage 50 · ThinLow 35Details
Commit message · SomberNight

wallet: de-sloppify d2d4251c8 (paid invoice cache)

arghhhhhh

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 35/100

This commit is a cleanup of a previous change that added a cache for paid invoices. The developer admits the earlier code was sloppy ('arghhhhhh'). The patch removes redundant logic that tried to update the paid-invoice cache in multiple places and instead lets a single method, get_invoice_status, decide whether an invoice is paid. The risk is that if the cache is not updated correctly, Electrum might wrongly report an invoice as paid or unpaid, which could mislead users or merchants about whether money was actually received. There is no direct evidence this is exploitable by an attacker, but it is a correctness fix in payment handling.

Lower-priorityregtest: make extract_preimage less flakyby f321x · 2a321f08 · Jun 30, 2026 · 1 fileMessage 90 · StrongInformational 15Details
Commit message · f321x

regtest: make extract_preimage less flaky

Wait until the lnpay screen commands in the `extract_preimage`
regtest return before checking their log output to prevent a race
where the preimage becomes available but the log doesn't yet contain
the success string.

```
***** test_extract_preimage ******
initializing alice
funding alice
a6f8f660a3bab3c4af636849dae55f4c7d5d483289a5812c7efce19f4c701753
initializing bob
funding bob
b51eae095f875c7a796e74d87d6e4c21d42348272159ee30bd81ce7d9f18defe
mining 1 blocks
starting daemon (PID 5040)
/tmp/alice/regtest/wallets/default_wallet
true
starting daemon (PID 5060)
/tmp/bob/regtest/wallets/default_wallet
true

alice opens channel
7cde6dcba2a0d033ecd40c1c7cb8eec4c554acb1a09099eb1206ba39a93728ae:1
mining 3 blocks
wait until alice sees channel open.
wait until alice sees channel open..
wait until alice sees channel open...
0caecfe64e319771d60f6f1e488f28d64667783432a15fccab534dfffb2096a4
mining 1 blocks
wait until alice has preimage for c217931809c870a8032d536e59ccf2399a5d96b937818c64ae60c7e7d5363728.
wait until alice has preimage for c217931809c870a8032d536e59ccf2399a5d96b937818c64ae60c7e7d5363728..
wait until alice has preimage for c217931809c870a8032d536e59ccf2399a5d96b937818c64ae60c7e7d5363728...
wait until bob has preimage for c53556db6fcffcb2dd7c6b215e94d1af9c96e42c7170ae11e47b03a929917f28.
bob payment failed
Daemon stopped
Daemon stopped
......F
======================================================================
FAIL: test_extract_preimage (tests.regtest.TestLightningAB)
```

90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit fixes a flaky automated test, not a security bug in the Electrum wallet. It adds a wait step so the test script doesn't check log files before background payment commands have finished writing to them. There is no change to production code or user-facing behavior.

Lower-prioritytest_storage_upgrade: add upgrade from client_4_6_0_with_unfulfilled_htlcsby ThomasV · eff48a2d · Jun 30, 2026 · 3 filesMessage 50 · ThinInformational 15Details
Commit message · ThomasV

test_storage_upgrade: add upgrade from client_4_6_0_with_unfulfilled_htlcs

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only adds a new test case and a test helper. It does not change any production wallet code. The test checks that Electrum can correctly upgrade an old wallet database that contains unfinished Lightning payment data ('unfulfilled HTLCs') from version 4.6.0 to the current format. There is no security fix or vulnerability being patched here.

Security candidateexchange rate: remove CoinDesk providerby f321x · 6571e479 · Jun 30, 2026 · 2 filesMessage 65 · AdequateInformational 15Details
Commit message · f321x

exchange rate: remove CoinDesk provider

The API is non-functional and their new api requires an authorization
token, so we cannot keep using it.

65/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Names security-relevant behavior explicitly
Why it was queued
access control
AI analysis · Informational 15/100

This commit simply removes the CoinDesk exchange-rate provider from Electrum because CoinDesk's old API no longer works and its new API requires a paid authorization token. It is a routine cleanup, not a security fix.

Security candidatehw_wallet/qt: reuse device message dialog across button requestsby Sasha Zykov · 898a4c27 · Jun 30, 2026 · 1 fileMessage 73 · AdequateInformational 15Details
Commit message · Sasha Zykov

hw_wallet/qt: reuse device message dialog across button requests

QtHandlerBase.message_dialog() used to tear down the current dialog
(clear_dialog -> QDialog.accept) and build a brand-new WindowModalDialog
on every device button request. A device emits one button request per
output, so signing a tx with many outputs rebuilt the dialog once per
output. On macOS a window-modal QDialog is shown as an animated "sheet",
so the popup visibly slid closed and reopened for each output, and the
GUI churn also competed with the single hardware-comms thread for the
GIL, adding latency between device prompts.

Reuse the open dialog and just update its label text when one is already
showing (title and on_cancel are stable within a signing flow). This
also smooths Ledger's repeated progress messages, which update the text
on each call.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100

This commit is a user-interface performance and polish fix for Electrum's hardware wallet integration. It stops the app from destroying and recreating the same on-screen prompt every time a hardware wallet asks the user to confirm a transaction output. Instead, it keeps the existing dialog open and just updates its text. This removes visible flicker/animation on macOS and reduces delays caused by repeatedly creating windows. There is no security vulnerability being fixed here.

Lower-prioritypayment_identifier: expand FIXME that openalias resolution DNS-leaksby SomberNight · bb1aaf60 · Jun 29, 2026 · 2 filesMessage 65 · AdequateLow 35Details
Commit message · SomberNight

payment_identifier: expand FIXME that openalias resolution DNS-leaks

and even for lightning-address, we also do the openalias resolution!

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Low 35/100

This commit only adds comments to the code. It does not fix anything. The comments warn that when Electrum resolves OpenAlias or Lightning Address payment identifiers, it sends DNS queries directly to Google's DNS server (8.8.8.8) instead of routing them through the user's configured network proxy (such as Tor). This could leak the user's real IP address and the fact that they are looking up a particular payment recipient. The commit itself is a documentation of a known privacy weakness, not a security patch.

Lower-priorityutil: CallbackManager: add comment how unregister_callback could raceby SomberNight · cc525082 · Jun 29, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · SomberNight

util: CallbackManager: add comment how unregister_callback could race

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only adds a comment explaining that a race condition is theoretically possible in the callback manager. It does not change any code behavior, fix a bug, or introduce a vulnerability. No action is needed beyond normal awareness.

Lower-priorityqml: disallow wallet names starting with '.'by f321x · 04eb5a19 · Jun 29, 2026 · 1 fileMessage 76 · AdequateLow 28Details
Commit message · f321x

qml: disallow wallet names starting with '.'

Prevent users from creating or renaming wallet files starting with
a `.` as those files are not listed in the wallet list, making it
impossible to access the wallet.
Later we could allow this again and implement opening such a "hidden"
wallet file e.g. through the wizard.

Related https://github.com/spesmilo/electrum/issues/10688

76/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
AI analysis · Low 28/100

This commit stops users of Electrum's mobile-style QML interface from giving a wallet a name that begins with a dot (like '.secret'). Such 'hidden' files are normally invisible in the wallet list, so a user could create a wallet and then be unable to see or open it again. The change is a simple guard that rejects these names when creating or renaming wallets.

Lower-priorityfixup! trezor: support Safe 7by Roman Zeyde · 154d79eb · Jun 29, 2026 · 1 fileMessage 45 · ThinInformational 18Details
Commit message · Roman Zeyde

fixup! trezor: support Safe 7

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 18/100

This is a tiny follow-up patch that changes how error messages from Trezor hardware wallets are displayed in Electrum's setup wizard. It switches from showing a programmer-style representation (repr) to a more readable plain-text message (str). There is no indication this fixes a security vulnerability; it is a user-experience cleanup.

AI review queuedwallet: followup d2d4251c8 (paid invoice cache)by f321x · 4f897200 · Jun 29, 2026 · 2 filesMessage 68 · AdequateInformational 13Details
Commit message · f321x

wallet: followup d2d4251c8 (paid invoice cache)

Followup to d2d4251c8 (paid invoice caching) in wallet.py.
* rename cache attribute to indicate it is a in-memory cache
* some minor reordering/simplifications
* also update on adb_removed_tx

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 13/100

This is a small internal cleanup commit for the Electrum Bitcoin wallet. It renames an in-memory cache used to remember which outgoing invoices have been paid, moves where the cache is initialized, simplifies some related logic, and makes sure the cache is also updated when a transaction is removed. There is no indication this fixes a security vulnerability or introduces a new security risk.

Lower-prioritylnurl: fail lnurl-pay on successAction fieldby f321x · 2223cc02 · Jun 26, 2026 · 1 fileMessage 76 · AdequateLow 43Details
Commit message · f321x

lnurl: fail lnurl-pay on successAction field

Fail the lnurl flow if a `successAction` field is present in the
lnurl callback response.
This prevents users from losing their payment until we properly
implement showing LUD-09 responses in the GUI.
See https://github.com/lnurl/luds/blob/luds/09.md.

Related: https://github.com/spesmilo/electrum/issues/10269

76/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
AI analysis · Low 43/100

This commit makes Electrum refuse LNURL-pay payments when the payment service includes a 'successAction' response. The change is a temporary safety measure: Electrum does not yet know how to display these follow-up actions to the user, so it blocks the payment rather than silently ignore the action. This prevents a scenario where a user might believe a payment completed successfully but miss an important post-payment message or instruction.

Lower-priorityqt: prevent setting locktime on channel funding txby f321x · 535609dd · Jun 26, 2026 · 1 fileMessage 73 · AdequateLow 27Details
Commit message · f321x

qt: prevent setting locktime on channel funding tx

Prevents the user from manually modifying the locktime of a
lightning channel funding transaction.
This seems like a potential footgun without much practical use.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 27/100

This commit removes the ability for users to manually set a transaction locktime when creating a Lightning channel funding transaction in Electrum's Qt desktop GUI. A locktime can delay when a transaction becomes valid or spendable. For channel funding transactions, allowing users to tweak this setting could lead to funds being stuck or channel setup failing, so the developers are treating it as a 'footgun'—a feature that is more likely to harm the user than help them. It is a UI restriction, not a fix for an active exploit.

Lower-prioritytrezor: support Safe 7by Roman Zeyde · 1547c5b4 · Jun 25, 2026 · 3 filesMessage 59 · ThinInformational 19Details
Commit message · Roman Zeyde

trezor: support Safe 7

Trezor Safe 7 is using Trezor-Host Protocol, for encrypted and authenticated communication:
https://docs.trezor.io/trezor-firmware/common/thp/specification.html

Since it requires a pairing process before device features are available,
an additional `WCTrezorPair` wizard step is introduced, allowing the user
to enter 6-digit pairing code (as shown on the device).

59/100 · ThinMessage clarity
✓ Subject identifies a change✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 19/100

This commit adds support for the new Trezor Safe 7 hardware wallet to Electrum. It introduces a pairing step where the user enters a 6-digit code shown on their device to establish an encrypted, authenticated connection. The change is a feature addition for compatibility, not a fix for a known security flaw.

Lower-priorityqml: QEInvoice: check if channels are still reestablishingby f321x · 00549808 · Jun 25, 2026 · 2 filesMessage 73 · AdequateInformational 19Details
Commit message · f321x

qml: QEInvoice: check if channels are still reestablishing

When opening an InvoiceDialog quickly after starting Electrum, e.g.
when it is being launched through an URI, the UI will say insufficient
balance if the lightning channels are still in the process of being
reestablished. While technically correct this is confusing to the user.
Instead if there is are channels that are funded and still disconnected
this will now change it to tell the user that the channels are still
in the connection phase.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 19/100

This commit is a user-experience fix, not a security fix. It changes the mobile/QML wallet's invoice screen so that, if Lightning channels are still reconnecting right after the app starts, the user sees a 'Connecting to Lightning peers...' message instead of a misleading 'insufficient balance' error. There is no indication this resolves an exploitable vulnerability.

Lower-priorityqml: InvoiceDialog: fix onCompleted operator precendence bugby f321x · 9d42454b · Jun 25, 2026 · 1 fileMessage 50 · ThinInformational 18Details
Commit message · f321x

qml: InvoiceDialog: fix onCompleted operator precendence bug

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 18/100

This is a tiny UI bug fix in Electrum's mobile/QML wallet interface. The original code accidentally checked the wrong condition when opening an invoice dialog, due to operator precedence: `!invoice.status == Invoice.Expired` was interpreted as `(!invoice.status) == Invoice.Expired` rather than `!(invoice.status == Invoice.Expired)`. The fix rewrites it to the intended meaning. The effect is at most a minor user-interface glitch when viewing certain invoices, not a security vulnerability.

Lower-priorityqml: InvoiceDialog: update fiat label onQuotesUpdatedby f321x · 5ff31dfa · Jun 25, 2026 · 1 fileMessage 73 · AdequateInformational 19Details
Commit message · f321x

qml: InvoiceDialog: update fiat label onQuotesUpdated

When opening the InvoiceDialog quickly after starting the app
the fx quotes might not be available yet. Once they become available
the InvoiceDialog wouldn't update and keep showing quotes unavailable.
This e.g. always happens when launching Electrum through an URI on Android.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 19/100

This is a user-interface bug fix for Electrum's mobile/QML app. When opening a payment invoice quickly after starting the app, the fiat (local currency) value label could stay stuck showing 'quotes unavailable' even after exchange-rate quotes arrived. The patch makes the label refresh automatically once quotes are updated. There is no security issue here.

Lower-prioritytest_storage_upgrade: add test wallet with invoice and requestby ThomasV · 4774f7ad · Jun 24, 2026 · 2 filesMessage 60 · AdequateInformational 15Details
Commit message · ThomasV

test_storage_upgrade: add test wallet with invoice and request

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only adds a new test case and a test wallet file to Electrum's test suite. It does not change any production code, so it cannot introduce a security vulnerability or fix one. The test wallet contains a publicly exposed seed phrase, but it appears to be a deliberately created test wallet with no real funds, used to verify that old wallet files upgrade correctly.