Electrum

lnutil: add blinded path feature flag

lnutil: rename LNFC.INVOICE -> BOLT11_INVOICE, add b12 LNFC

Renames the "INVOICE" lightning feature context to "BOLT11_INVOICE"
as there is now a bolt 12 invoice feature context as well that differs.

Also adds 4 new bolt 12 context to the Enum.

build: fix trezor: new trezorlib 0.20 now requires *.dist-info metadata

```
8.16 | W | gui.qt.wizard.wallet.WCChooseHWDevice | error getting device infos for trezor: Library version for 'trezor' is incompatible. // Installed: unknown, Needed: 0.20.0 <= x < 0.21 // Make sure you install it with python3
```

```
>>> trezorlib.__version__
Traceback (most recent call last):
File "<string>", line 1, in <module>
NameError: name 'trezorlib' is not defined
>>> import trezorlib
>>> trezorlib.__version__
Traceback (most recent call last):
File "/tmp/.mount_electrcmMljC/usr/lib/python3.12/importlib/metadata/__init__.py", line 397, in from_name
return next(cls.discover(name=name))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
StopIteration

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/tmp/.mount_electrcmMljC/usr/lib/python3.12/site-packages/trezorlib/__init__.py", line 27, in __getattr__
return importlib.metadata.version("trezor")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/.mount_electrcmMljC/usr/lib/python3.12/importlib/metadata/__init__.py", line 889, in version
return distribution(distribution_name).version
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/.mount_electrcmMljC/usr/lib/python3.12/importlib/metadata/__init__.py", line 862, in distribution
return Distribution.from_name(distribution_name)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/.mount_electrcmMljC/usr/lib/python3.12/importlib/metadata/__init__.py", line 399, in from_name
raise PackageNotFoundError(name)
importlib.metadata.PackageNotFoundError: No package metadata was found for trezor

```

We generally don't bundle the *.dist-info importlib metadata stuff as for many packages, these files are not reproducible.

ref
https://github.com/spesmilo/electrum/commit/aecc22dc081339fb570a7a3b09f3e47bf9ea5021
https://github.com/spesmilo/electrum/commit/c52a29fc221f8fdbe55872084f215478c957010d

(cherry picked from commit f8226f9384369ca30a2c4811cd631eb77719f97e)

build: support blacklisting dependencies for deterministic builds

The method works as follows:
1. for every blacklisted dependency, as listed in ghost.txt,
create and install an empty ghost package which will satisfy
the dependency resolver
2. before hash resolution step, remove those ghosts to make hashin happy

This required converting find_restricted_dependencies to use locally
installed package metadata instead of looking it up online on pypi. But
that seems to be a good idea anyway.

Upgrade `trezorlib` to 0.20.1

Trezor plugin is updated for `trezorlib` 0.20.1 release.

Tested the following scenarios with Trezor 1 (with FW 1.14.0), T, Safe 3 and Safe 5 (with FW 2.10.0):
- create a new wallet:
- generate new seed
- recover from backup
- verify an address
- send & RBF flows
- set a PIN & a passphrase
- open an existing wallet file
- locking the device on exit
- flow cancellation

Safe 7 support will be added in a subsequent PR.

Move StoredDict class into new 'stored_dict' module

This commit is only moving code, no functional change

ci: code review: extend prompt to verify commit message intent

Extends the code review CI prompt to verify commit messages are
actually doing what they claim to do. E.g. that a commit specifying
it is only moving code actually does not modify any logic.

ci: code review: pass commit messages into prompt context

Pass the git commit messages of the reviewed PR into the prompt.
This way claude doesn't have to fetch them manually but has them
in its context right from the beginning.

qml: InvoiceDialog: rename "Remote Pubkey" -> "Recipient Pubkey"

"Remote Pubkey" is somewhat misleading in the context of paying a
lightning invoice.
The german translation ("Entfernter öffentlicher Schlüssel") feels
even more out of context.

regtests: make wait_until_spent more robust

if `$1` was some garbage value (e.g. the 4-character "null" string coming from jq), the exit code of bitcoin_cli was not tested (it was masked by being part of the while's test condition). Instead now wait_until_spent correctly propagates bitcoin_cli's exit code. (due to `set -e` being set at the top level)

regtests: swaps: add test for forward-swap success case

Previously only the reverse-swaps were tested.
Note that what is reverse for the client, is forward for the server, hence testing different scenarios for reverse-swaps (success case, different failrue cases) already exercises some of the logic of forward-swaps.

However the swap-protocol request construction and validation is specific to swap direction, and that was not exercised for forward-swaps at all prior to this.

(but duplicating the other testcases probably is not worth)

util: ESocksProxy: add fixme for is_proxy_tor race

lnpeer: send channel_update on channel_reestablish

If we have forwarding enabled, send a channel_update message to the
peer after a channel_reestablish.
The peer needs to know our channel constraints to receive a payment
(for r_tags or blinded path) and sending it just once on mark_open
might not be enough as the peer could miss it, lose it or it might
get out of date if we'd change our forwarding fees.
See https://github.com/spesmilo/electrum/pull/10630#issuecomment-4390045965.

wallet: encrypt the keystore before adding it to db

adding keystore to db may result in a disk write, and we should
never write unencrypted keys to disk (except lightning_xprv)

lnworker: fix _get_next_peers_to_try regression

`LNPeerManager._get_next_peers_to_try` would skip all recent peers
if no proxy is enabled due to incorrect operator precedence.
Fixes regression introduced by 79ef429b3.

contrib/android/Readme.md: mention build cache

lnonion: factor out next_blinding_from_shared_secret

Factor out the derivation of the next path key/blinding in a
shared function.

Co-Authored-By: f321x <f@f321x.com>

qewallet: replace some threads with coroutines

Allows to simplify a bit and has less overhead.

qml: fix userinfo race in Invoice view

When paying a lightning invoice there was a race between the
`on_event_payment_succeeded` and `on_event_invoice_status` callbacks.
Depending on which was called last the string at the top
of the invoice view would either say "Paid!" (correct) or
"This invoice was already paid" (technically correct but confusing).
By keeping state if the invoice payment attempt was initiated in this
session the subsequent calls to `update_userinfo` can correctly
determine which string to show.

lnpeer: send channel update also for private channels, if we are forwarding

create_channel_backup: handle case where peer_addresses list is empty

build: fix regression: support local dev builds also using UID!=1000

- both "ELECBUILD_COMMIT fresh_clone builds" and "local dev builds"
should work even when the unix user has a different UID than 1000
on the host machine
- though I guess running as root does not work but that's prob ok

issue was:
```
$ echo $UID
1111
$ ./contrib/build-linux/appimage/build.sh
🗯 ERROR: Building outside a git clone is not supported.
```

contrib: build-{linux,wine}: continue fixing build user env

A continuation of 99b0df0f9fdf1d1feb50338091e233d53f9fabc3, as requested
in https://github.com/spesmilo/electrum/pull/10486.

contrib: android: make_apk.sh: add/update testnet comments

build: appimage: fix build: bump alpine apk deps

note: magic incantation to clear relevant docker build cache:
```
$ docker builder prune --all
```

build log:
```
$ ./contrib/build-linux/appimage/build.sh
[...]
=> ERROR [2/6] RUN apk add --no-cache bash=5.2.37-r0 alpine-sdk=1.1-r0 util-linux=2.40.4-r1 strace=6.12-r0 file=5.46-r2 autoconf=2.72-r0 automake=1.17-r0 libtool=2.4.7-r3 xz=5.6.3-r1 eudev-dev=3.2.14-r5 gettext- 0.6s
------
> [2/6] RUN apk add --no-cache bash=5.2.37-r0 alpine-sdk=1.1-r0 util-linux=2.40.4-r1 strace=6.12-r0 file=5.46-r2 autoconf=2.72-r0 automake=1.17-r0 libtool=2.4.7-r3 xz=5.6.3-r1 eudev-dev=3.2.14-r5 gettext-dev=0.22.5-r0 linux-headers=6.6-r1 meson=1.6.1-r0 zstd-dev=1.5.6-r2 zstd-static=1.5.6-r2 zlib-dev=1.3.2-r0 zlib-static=1.3.2-r0 clang19=19.1.4-r0 musl-dev=1.2.5-r11 mimalloc2-dev=2.1.7-r0:
0.224 fetch https://dl-cdn.alpinelinux.org/alpine/v3.21/main/x86_64/APKINDEX.tar.gz
0.309 fetch https://dl-cdn.alpinelinux.org/alpine/v3.21/community/x86_64/APKINDEX.tar.gz
0.475 ERROR: unable to select packages:
0.476 xz-5.8.3-r0:
0.476 breaks: world[xz=5.6.3-r1]
0.476 satisfies: gettext-dev-0.22.5-r0[xz]
------
Dockerfile:4
--------------------
3 | # includes dependencies from https://git.alpinelinux.org/aports/tree/main/fuse3/APKBUILD
4 | >>> RUN apk add --no-cache \
5 | >>> bash=5.2.37-r0 \
6 | >>> alpine-sdk=1.1-r0 \
7 | >>> util-linux=2.40.4-r1 \
8 | >>> strace=6.12-r0 \
9 | >>> file=5.46-r2 \
10 | >>> autoconf=2.72-r0 \
11 | >>> automake=1.17-r0 \
12 | >>> libtool=2.4.7-r3 \
13 | >>> xz=5.6.3-r1 \
14 | >>> eudev-dev=3.2.14-r5 \
15 | >>> gettext-dev=0.22.5-r0 \
16 | >>> linux-headers=6.6-r1 \
17 | >>> meson=1.6.1-r0 \
18 | >>> zstd-dev=1.5.6-r2 \
19 | >>> zstd-static=1.5.6-r2 \
20 | >>> zlib-dev=1.3.2-r0 \
21 | >>> zlib-static=1.3.2-r0 \
22 | >>> clang19=19.1.4-r0 \
23 | >>> musl-dev=1.2.5-r11 \
24 | >>> mimalloc2-dev=2.1.7-r0
25 |
--------------------
ERROR: failed to solve: process "/bin/sh -c apk add --no-cache bash=5.2.37-r0 alpine-sdk=1.1-r0 util-linux=2.40.4-r1 strace=6.12-r0 file=5.46-r2 autoconf=2.72-r0 automake=1.17-r0 libtool=2.4.7-r3 xz=5.6.3-r1 eudev-dev=3.2.14-r5 gettext-dev=0.22.5-r0 linux-headers=6.6-r1 meson=1.6.1-r0 zstd-dev=1.5.6-r2 zstd-static=1.5.6-r2 zlib-dev=1.3.2-r0 zlib-static=1.3.2-r0 clang19=19.1.4-r0 musl-dev=1.2.5-r11 mimalloc2-dev=2.1.7-r0" did not complete successfully: exit code: 2
🗯 ERROR: Error building type2-runtime.
```