EL
← All projectsElectrum

Electrum

Long-running lightweight Bitcoin wallet for desktop and mobile platforms.

BitcoinSoftware walletsActive incident
Repository coverage

1361 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

108security candidates322second-pass queue1084AI analyses
90commits · 30 days
200commits · 60 days
570commits · 180 days
1124commits · 365 days
Backfill bands
Aug 5 → Feb 6470 seen11 candidatesComplete
Feb 6 → Jun 6346 seen10 candidatesComplete
Jun 6 → Jul 653 seen2 candidatesComplete
Jul 6 → Aug 554 seen3 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

66/100 average clarity
252Strong · 80–100
675Adequate · 60–79
388Thin · 40–59
46Opaque · 0–39
2security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
SomberNight42533373163
ThomasV16511104163
ghost4376626170
f321x44128400070
Sander van Grieken12412112057
Felix54720070
user323062
ekzyis222053
accumulator28111072
Roman Zeyde515053
Sasha Zykov515075
Aaron Fiore414068
Analysis record

Published AI watches

Last scanned 18 minutes ago

Informational 19 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11172 from accumulator/qml_crash_reporter_threading

This is a small bug-fix patch for Electrum's QML (mobile-style) graphical interface. The crash reporter was not correctly handling exceptions that come from Python's threading system, which could cause the crash reporter itself to misbehav…

Fixes incorrect exception argument handling in crash reporterPrevents potential secondary failure in error-reporting pathNo security boundary crossed; no input from untrusted source is processed
45ad42f7by Felix+4−11 file
No security note in commit
Informational 19 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qml: crash reporter: handle threading.excepthook arguments

This commit fixes a bug in Electrum's mobile-style QML crash reporter. When an uncaught exception occurred inside a background thread, the crash reporter itself would break because it expected three pieces of information but received one b…

Crash reporter failure could hide or obscure real runtime errors in background threadsNo input validation, privilege boundary, or cryptographic issue presentFix improves diagnostic fidelity but does not close an attack vector
2e7fe460by Sander van Grieken+4−11 file
No security note in commit
Low 40 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11154 from spesmilo/make_unsigned_tx_with_base_tx

This commit changes how Electrum creates unsigned Bitcoin transactions when an existing 'base transaction' is provided. Previously, the wallet wrongly demanded spendable coins even when the caller supplied a base transaction that already c…

Relaxation of input-source preconditionAddition of consensus-level invariant assertion (at least one input)Addition of empty-input guard before PartialTransaction construction
ff273162by ThomasV+4−11 file
No security note in commit
Low 29 AI analysisMessage 68 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

wallet: make_unsigned_tx: follow-up prev

This commit fixes a crash in Electrum's transaction builder. If a user had only one on-chain coin (UTXO) that was just enough to meet a reserve requirement, clicking 'Max' in the send tab would hit an internal assertion and fail instead of…

Denial-of-service-like crash path triggered by user action in normal wallet stateAssertion failure reachable through GUI send flowFix converts assertion crash into handled NotEnoughFunds exception
462f631dby SomberNight+2−01 file
No security note in commit
Low 28 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11097 from SomberNight/202610_bump_deps

This is a routine maintenance commit that updates many of Electrum's software building blocks (dependencies) and raises the minimum required Python version from 3.10 to 3.11. It also refreshes the Linux distribution snapshots used to build…

Dependency version bumps for security-sensitive libraries (cryptography, cffi, libffi, sqlite)Removal of an embedded PGP public key and switch to hash verification for Windows Python installer downloadsBase image refresh from EOL/near-EOL Debian bullseye to bookworm for AppImage builds
84345fdcby ghost43+934−103048 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11139 from accumulator/consolidate_platform_checks

This commit is a straightforward internal cleanup: it moves repeated checks like 'are we running on Windows?', 'are we on Android?', and 'are we inside an AppImage?' into a single new helper module called platform.py. The actual behavior o…

22e24580by ghost43+87−7619 files
No security note in commit
Informational 15 AI analysisMessage 45 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

consolidate platform checks into platform.py

This commit is a straightforward internal cleanup: it moves repeated operating-system checks (Windows, macOS, Linux, Android, AppImage) into a single new helper module called platform.py and updates the rest of the code to use those helper…

9715f882by Sander van Grieken+87−7619 files
No security note in commit
Informational 15 AI analysisMessage 38 · Opaque
EL ElectrumElectrum BitcoinSoftware wallets

version: bump to 4.8.4

This commit only changes the software version number from 4.8.3 to 4.8.4 in a single file. It contains no security-related changes, no bug fixes, and no functional code modifications.

0c661eb8by f321x+1−11 file
No security note in commit
Low 29 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

make_unsigned_transaction: do not require coins if there is a base_tx

This commit relaxes a wallet check when creating a new Bitcoin transaction. Previously, Electrum refused to create a transaction if the user had no spendable coins and no explicit inputs. The change allows creation to continue if a 'base t…

Relaxation of input/coin availability guardAddition of post-construction input count assertionPotential workflow: Replace-By-Fee (RBF) or transaction bumping using base_tx inputs
876360deby ThomasV+2−11 file
No security note in commit
Informational 17 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11111 from accumulator/qml_bip39recovery_task_refactor

This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an older thread-based background scan for BIP39 seed accounts with a newer asyncio-based task approach, and makes the recovery dialog destroy itself wh…

Refactor of async task lifecycle and cancellation handlingDialog lifecycle cleanup with onClosed: destroy()Use of ignore_if_destroyed to avoid callbacks on destroyed QML objects
896a68d7by Felix+44−332 files
No security note in commit
Informational 12 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qml: refactor BIP39 account scan to asyncio tasks.

This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an extra background thread with a simpler asyncio-based callback for scanning BIP39 seed accounts. There is no indication this fixes a security bug; it…

00ed883aby Sander van Grieken+44−332 files
No security note in commit
Moderate 59 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qt: paytoedit: complete contacts to their key, not 'name <key>'

This commit fixes a bug in Electrum's Qt 'Send' tab where selecting a contact from the autocomplete dropdown could briefly leave the wrong recipient active. Previously, the payment field was set to a display name like 'Alice <alice@example…

UI state desynchronization between displayed recipient and active PaymentIdentifierStale PaymentIdentifier usable for ~1 second after recipient text changesPay/Save/Max buttons enabled while recipient is being edited
dd1b50fbby f321x+47−132 files
No security note in commit
Informational 18 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11092 from f321x/qml_address_history_labels

This commit fixes a UI bug in Electrum's QML (mobile-style) interface where transaction and address labels could become stale or fail to update after editing. It replaces a fragile manual callback system with a proper event listener so the…

No security-relevant signals in diff: no privilege escalation, injection, cryptographic, or authentication changes.Fixes a UI consistency bug (stale labels) that could mislead users but does not enable direct exploitation.Adds event-listener lifecycle management (register/unregister on destroy) to prevent dangling callbacks and potential use-after-free patterns.
9242c505by Felix+334−8412 files
No security note in commit
Low 34 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qml: avoid potential Ok signal by tapping while dialog is closing,

This commit fixes a bug in Electrum's mobile-style QML password dialog. If a user tapped the OK/confirm button while the dialog was already closing, the app could emit an extra 'password entered' signal. That extra signal triggered a crash…

Crash in authentication-related code path (AuthMixin)Duplicate signal emission during UI state transitionUser-interaction race condition (tap while dialog closing)
00f981edby Sander van Grieken+8−01 file
No security note in commit
Informational 21 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11091 from f321x/fix_num_parents_perf_simple

This commit is a performance fix for a wallet function that traces where a transaction's funds came from. It replaces a slow, repeatedly-recursive approach with a more efficient loop and removes an old cache. The change also fixes how the …

Performance fix for wallet history traversalAddress-reuse uncle detection logic changedCache removed in favor of iterative computation
4ec70746by ThomasV+82−463 files
No security note in commit
Informational 24 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11047 from fametrano/old-seed-odd-length

This commit fixes a bug where Electrum wallets created with unusual, hand-crafted 'old-style' seed phrases could not be opened or used. These seeds decode to an odd number of hex characters, which the program previously rejected. The chang…

Input validation relaxed for legacy data (odd-length hex strings)New user-facing error path prevents seed display when mnemonic encoding is impossibleGUI exception handling narrowed: UserFacingException shown as str, other Exception as repr
fc31115eby ghost43+93−157 files
No security note in commit
Informational 19 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11096 from f321x/followup_11094

This commit is a small follow-up cleanup. It translates several user-facing error messages into different languages and makes the Qt GUI handle one specific file-read/write error (StorageReadWriteError) more gracefully, showing a warning d…

Exception-handling path changed in GUIUser-facing error messages internationalizedNo changes to encryption, wallet parsing semantics, or permissions
54c355feby Felix+9−75 files
No security note in commit
Informational 23 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11094 from devdavidejesus/fix-10760-storage-not-utf8

This commit improves Electrum's error handling when a user tries to open a file that is not a valid Electrum wallet. Previously, if the file contained bytes that were not valid UTF-8 text, the program would crash with a confusing technical…

Error-handling hardeningUser-facing exception message improvedNo cryptographic or parsing logic changed
2a20256fby Felix+10−12 files
No security note in commit
Informational 20 AI analysisMessage 65 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qt: show StorageReadWriteError to user instead of crash reporting it

This is a small user-interface fix in Electrum's Qt desktop app. Previously, if the wallet file was on a read-only folder or an unplugged drive, the app treated the resulting StorageReadWriteError as an unexpected crash and sent a crash re…

No memory safety, cryptographic, or authorization changesException handling change only; no new attack surface introducedCrash-reporting no longer triggered for expected I/O failure scenarios
5a971b11by f321x+2−11 file
No security note in commit
Low 26 AI analysisMessage 45 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

keystore: follow-up prev: small clean-up

This commit is a small follow-up cleanup in Electrum's keystore code. It renames an internal helper function, makes the code accept certain unusual 'old' seed phrases that some users created by hand, improves an error message shown to user…

Refactoring of seed validation helperUser-facing error handling improvement in seed displayGrandfathering of non-standard old seed phrases
ead42d09by SomberNight+35−154 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityqml: ImportAddressesKeysDialog: separate scanned entries with newlineby f321x · 8a6aa253 · Oct 5, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · f321x

qml: ImportAddressesKeysDialog: separate scanned entries with newline

Scanning a second address/key appended ',\n', leaving a trailing comma
on the previous entry. is_address_list/is_private_key_list then reject
the text and the Import button stays disabled.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI review queuedMerge pull request #10993 from spesmilo/remove_attrby ghost43 · 4cb03ef4 · Oct 1, 2026 · 8 filesMessage 58 · ThinInformational 12Details
Commit message · ghost43

Merge pull request #10993 from spesmilo/remove_attr

replace attrs with dataclasses

58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 12/100

This commit replaces the third-party 'attrs' library with Python's built-in 'dataclasses' across several Electrum source files. It is a routine refactoring change: the same data classes are defined in a different syntax, and equivalent validation/conversion logic is preserved using Python's standard mechanisms. There is no indication this fixes or introduces a security vulnerability.

Lower-priorityfollow-up 1f78bb606ef7f9306815eb5ed5c8e3009f5a35d6by ThomasV · a03a6328 · Sep 30, 2026 · 1 fileMessage 40 · ThinTriage 0Details
Commit message · ThomasV

follow-up 1f78bb606ef7f9306815eb5ed5c8e3009f5a35d6

40/100 · ThinMessage clarity
✓ Specific, descriptive subject! No meaningful explanatory body
Security candidateMerge pull request #10874 from spesmilo/plugin_zipfileby Felix · aa630dd6 · Sep 30, 2026 · 5 filesMessage 78 · AdequateModerate 60Details
Commit message · Felix

Merge pull request #10874 from spesmilo/plugin_zipfile

plugins: load zip plugins from the bytes whose signature was verified

78/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarymerge-commit duplicate discount
AI analysis · Moderate 60/100

This commit hardens how Electrum loads third-party plugins. Previously, the app could authorize a plugin zip file, then later re-read that same file from disk to run it. An attacker who could replace the file in the brief gap (a 'time-of-check/time-of-use' or TOCTOU race) might get malicious code executed despite the signature check. The fix keeps the verified plugin bytes in memory and loads all code and icons from those bytes, so the file on disk can no longer be swapped in after approval. It also adds a plugin upgrade flow and new safety checks.

AI review queuedMerge pull request #11003 from SomberNight/202609_tx_any_segwitby ThomasV · ede66c89 · Sep 29, 2026 · 4 filesMessage 73 · AdequateLow 44Details
Commit message · ThomasV

Merge pull request #11003 from SomberNight/202609_tx_any_segwit

transaction: rename `is_segwit`->`is_any_segwit`, and add `is_all_segwit`

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 44/100

This commit renames Electrum's transaction 'is_segwit' check to 'is_any_segwit' and adds a new 'is_all_segwit' check. It then uses the stricter 'all inputs are segwit' rule when validating Lightning channel funding transactions and timelock-recovery transactions. The change is defensive: a transaction that mixes segwit and non-segwit inputs still has a malleable transaction ID, which can cause problems for protocols that rely on a stable txid. The commit does not claim to fix an active exploit, and one new code comment explicitly flags that a related zeroconf check is still incomplete and unsafe.

Lower-prioritycommands: add dscancel command, analog to bumpfeeby devdavidejesus · 0520119c · Sep 28, 2026 · 2 filesMessage 53 · ThinTriage 0Details
Commit message · devdavidejesus

commands: add dscancel command, analog to bumpfee

fixes #8268

53/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
AI review queuedtransaction: add method tx.is_all_segwit()by SomberNight · 43bb00d4 · Sep 28, 2026 · 3 filesMessage 45 · ThinLow 44Details
Commit message · SomberNight

transaction: add method tx.is_all_segwit()

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 44/100

This commit adds a helper method to check whether every input of a Bitcoin transaction uses SegWit, and starts using it in place of a weaker 'any input is SegWit' check when validating Lightning funding transactions. SegWit fixes 'transaction malleability,' where the transaction ID (txid) can be changed by someone else after signing. For Lightning, the funding txid must be stable because both parties rely on it to set up the channel. The old check only required at least one SegWit input, which could still allow non-SegWit inputs to be re-signed or malleated, changing the txid. The commit also adds a TODO noting that a zero-confirmation code path still doesn't perform this check at all, which the authors already flag as unsafe.

AI review queuedtransaction: rename tx.is_segwit() to tx.is_any_segwit()by SomberNight · 94a400fa · Sep 28, 2026 · 3 filesMessage 65 · AdequateLow 27Details
Commit message · SomberNight

transaction: rename tx.is_segwit() to tx.is_any_segwit()

Some callers might want the "any" usage, some might want "all".

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 27/100

This commit is a code cleanup that renames a method from is_segwit() to is_any_segwit() and adds a clarifying comment. It does not change the actual behavior of the code. The rename makes it clearer that the method returns true if any input is SegWit, not necessarily all inputs. A developer left a note in the Lightning channel funding code saying the current check should eventually use an 'all inputs are SegWit' check instead. On its own, this commit is not a security fix, but it highlights a place where the code's understanding of SegWit malleability could be imprecise.

AI review queuedMerge pull request #10984 from f321x/fix_onchain_backup_discoveryby ghost43 · 670b16a7 · Sep 28, 2026 · 9 filesMessage 73 · AdequateModerate 59Details
Commit message · ghost43

Merge pull request #10984 from f321x/fix_onchain_backup_discovery

lnwallet: fix discovery of onchain backups

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 59/100

This commit fixes how Electrum's Lightning wallet discovers and watches 'on-chain channel backups'—recovery records embedded in funding transactions. Previously, backups could be missed if the wallet learned about a transaction in stages, or if two channels reused the same on-chain funding address. The fix makes the wallet re-check transactions when more of their inputs are identified as belonging to the wallet, and switches watcher callbacks from being keyed by address to being keyed by the unique funding outpoint. A malicious or buggy remote peer could reuse a funding public key, causing two channels to share the same address; the old code might then overwrite the watcher callback for one channel with the other, leaving a backup unwatched and funds unrecoverable if the channel closed.

Security candidateMerge pull request #11000 from f321x/bip32_index_with_whitespaceby ghost43 · 3462e02b · Sep 28, 2026 · 2 filesMessage 73 · AdequateLow 39Details
Commit message · ghost43

Merge pull request #11000 from f321x/bip32_index_with_whitespace

bip32: followup #10999: require child index to be ascii digits

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
secret or key materialcryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Low 39/100

This commit tightens how Electrum parses BIP32 wallet derivation paths. Previously, the code used Python's built-in int() conversion, which accepts a wide variety of number-like strings, including whitespace, plus signs, underscores, and non-ASCII digits. The change now requires each path index to be plain ASCII digits only, optionally preceded by a minus sign for hardened derivation. This prevents subtle parsing surprises where a user or attacker could supply a path that looks valid but is interpreted differently than expected.

Lower-priorityMerge pull request #10996 from MrKalipo/fix/dnssec-ksk-2024by Felix · 22b97e50 · Sep 28, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Felix

Merge pull request #10996 from MrKalipo/fix/dnssec-ksk-2024

dnssec: add root KSK-2024 trust anchor (root KSK rollover on 2026-10-11)

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge pull request #10999 from MrKalipo/fix/bip32-strpath-index-rangeby Felix · 8b3879e8 · Sep 28, 2026 · 2 filesMessage 73 · AdequateLow 49Details
Commit message · Felix

Merge pull request #10999 from MrKalipo/fix/bip32-strpath-index-range

bip32: reject str path child index >= 2**31

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
secret or key materialcryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Low 49/100

This commit fixes a bug in how Electrum converts text-based Bitcoin wallet key paths (like "m/44'/0'/0'") into numeric form. Previously, typing an index of 2^31 or higher could silently be treated as a hardened key or could make the hardening marker (the apostrophe) meaningless. The fix now rejects such out-of-range indexes with a clear error. This is a correctness and safety improvement for a function that handles sensitive wallet derivation paths, but the commit itself does not describe a specific exploit or security incident.

Lower-priorityMerge pull request #10997 from MrKalipo/fix/coinchooser-notimplementederrorby Felix · e2f0ee6e · Sep 28, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Felix

Merge pull request #10997 from MrKalipo/fix/coinchooser-notimplementederror

coinchooser: raise NotImplementedError instead of NotImplemented

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidatebip32: reject str path child index >= 2**31by MrKalipo · 624fd5b8 · Sep 27, 2026 · 2 filesMessage 68 · AdequateLow 49Details
Commit message · MrKalipo

bip32: reject str path child index >= 2**31

convert_bip32_strpath_to_intpath only checked the *combined* value
(index | hardened flag) against UINT32_MAX. As the hardened flag is the
top bit, a literal index in [2**31, 2**32) passed the check and was
silently interpreted as hardened: "m/2147483648" parsed to the same path
as "m/0'", and for "m/2147483649'" the hardened marker was a no-op.

Reject any literal index >= 2**31 instead, and tell the user to use the
hardened suffix. This matches other implementations (rust-bitcoin,
bitcoinjs, BIP380 descriptor key paths) and makes the str->int->str
round trip unambiguous.

Co-authored-by: f321x <f@f321x.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
secret or key materialdefensive validationcryptography-sensitive path
AI analysis · Low 49/100

This commit fixes a bug in how Electrum parsed Bitcoin wallet derivation paths typed by users. A path like "m/2147483648" was silently treated the same as "m/0'" (a hardened key), and "m/2147483649'" lost its hardening marker. The patch now rejects any index of 2^31 or larger and tells the user to use the standard hardened suffix instead. This prevents confusion and makes path conversion unambiguous, but it is a correctness/hardening fix rather than a demonstrated remote exploit.

Lower-prioritycoinchooser: raise NotImplementedError instead of NotImplementedby MrKalipo · f8240039 · Sep 27, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · MrKalipo

coinchooser: raise NotImplementedError instead of NotImplemented

`NotImplemented` is a singleton, not an exception type; calling it raises
`TypeError: 'NotImplementedType' object is not callable` instead of the
intended NotImplementedError.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Security candidateMerge pull request #10972 from SomberNight/202609_qt_label_plaintext_by_defaultby ThomasV · 76dbf2b3 · Sep 26, 2026 · 30 filesMessage 73 · AdequateModerate 63Details
Commit message · ThomasV

Merge pull request #10972 from SomberNight/202609_qt_label_plaintext_by_default

qt/qml: labels to require opt-in to rich text

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
seed or entropy pathsigning or wallet pathboot or update pathmerge-commit duplicate discount
AI analysis · Moderate 63/100

This commit changes Electrum's user interface so that text labels default to plain text instead of rich text. Rich text (HTML-like formatting) can be abused if untrusted data is displayed, because it may allow attackers to inject clickable links, fake UI elements, or trigger bugs in the text-rendering engine. The patch makes rich text an opt-in choice for developers and explicitly marks trusted labels that need formatting. It also adds a runtime sanity check on Android and patches the Qt framework used in Android builds to make plain text the default at a lower level. This is a defensive hardening change rather than a fix for a specific known exploit.

Lower-priorityMerge pull request #10990 from SomberNight/202609_fxrate_cleanupby Felix · a4c770cd · Sep 25, 2026 · 3 filesMessage 58 · ThinTriage 0Details
Commit message · Felix

Merge pull request #10990 from SomberNight/202609_fxrate_cleanup

exchange_rate: some clean-up

58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
merge-commit duplicate discount
Lower-priorityutil: to_decimal: also accept None, convert it to "NaN"by SomberNight · 3d76613e · Sep 25, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · SomberNight

util: to_decimal: also accept None, convert it to "NaN"

- mainly for the exchange_rate usage, where we use to_decimal to parse
"number-like" data received from any exchange's HTTP API.
- change seems harmless for other existing callers of to_decimal

---

f321x said:

> We had the issue before that a `null` value would render a provider broken, maybe we could make `to_decimal` convert `null` to `Decimal(NaN)` so they are handled without discarding the remaining rates?
> See https://github.com/spesmilo/electrum/pull/10572

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Lower-priorityqml: android build: patch Qt to default Label.textFormat to PlainTextby SomberNight · 065ea702 · Sep 25, 2026 · 3 filesMessage 88 · StrongTriage 0Details
Commit message · SomberNight

qml: android build: patch Qt to default Label.textFormat to PlainText

Security-by-default, instead of convenience: require programmer to opt-in to RichText.

This patches Qt only for the Android build, and adds a runtime regression check.
We mainly use the QML GUI for Android. However this leaves the Linux desktop
dev environment and potential Linux phone users uncovered :/

88/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Names security-relevant behavior explicitly
Lower-priorityqt: standalone_exception_dialog: force plaintextby SomberNight · 5f4a054d · Sep 25, 2026 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · SomberNight

qt: standalone_exception_dialog: force plaintext

this special-case QApplication is not covered by InjectNoRichTextEventFilter

50/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body
Lower-priorityqt: util.custom_message_box: force plain text before setText()by SomberNight · ba24f1e2 · Sep 25, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · SomberNight

qt: util.custom_message_box: force plain text before setText()

llm output:

> Linux with a screen reader running. Here the accessibility bridge queries the label’s text from inside
> setText(), and Qt parses the HTML at that moment. This also affects custom_message_box(rich_text=False),
> which passes the text to the QMessageBox constructor before switching it to PlainText.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI review queuedMerge pull request #10992 from f321x/dedup_is_seed_wizardby ghost43 · 554daca6 · Sep 24, 2026 · 1 fileMessage 58 · ThinLow 29Details
Commit message · ghost43

Merge pull request #10992 from f321x/dedup_is_seed_wizard

qt: wizard: dedup seed validation rules

58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 29/100

This commit simplifies the seed-validation logic in Electrum's Qt wallet wizard by replacing a local copy of the rules with a call to an existing shared validation method. The change appears to be a code-cleanup refactor that removes duplicated logic rather than fixing a security bug. There is no direct evidence in the commit or supplied references that this change addresses a vulnerability.

Security candidateMerge pull request #10982 from spesmilo/wizard_2fa_seed_redirectby Felix · 310c9dd0 · Sep 24, 2026 · 3 filesMessage 73 · AdequateLow 29Details
Commit message · Felix

Merge pull request #10982 from spesmilo/wizard_2fa_seed_redirect

wizard: redirect flow if a 2fa seed is entered for a standard wallet.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlsigning or wallet pathmerge-commit duplicate discount
AI analysis · Low 29/100

This commit changes Electrum's wallet creation wizard so that if a user tries to restore a normal 'standard' wallet but pastes a seed phrase that actually belongs to a two-factor authentication (2FA) wallet, the wizard automatically redirects them into the correct 2FA wallet setup flow instead of rejecting the seed or creating a mismatched wallet. Previously, the wizard would treat 2FA seeds as invalid for standard wallets. The change also ensures the Qt GUI seed validator matches this new behavior. It is a usability fix that prevents user confusion and potential loss of access to funds, not a remote-exploitable vulnerability.

AI review queuedqt: wizard: dedup seed validation rulesby f321x · 89d0de06 · Sep 24, 2026 · 1 fileMessage 68 · AdequateInformational 12Details
Commit message · f321x

qt: wizard: dedup seed validation rules

`WCHaveSeed.is_seed()` carried the same rules as
`KeystoreWizard.validate_seed()`, so instead use this method
to have the rules in a single place and prevent them from
drifting apart.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI analysis · Informational 12/100

This commit is a small code cleanup in Electrum's wallet setup wizard. It removes a duplicate copy of the rules used to check whether a recovery seed is valid and instead reuses an existing method. There is no indication this fixes a security bug; it is a maintenance change to keep the two copies of the rules from diverging in the future.

Security candidatetests: wizard: cover standard -> 2fa redirectionby f321x · 70b4d27c · Sep 24, 2026 · 1 fileMessage 70 · AdequateInformational 15Details
Commit message · f321x

tests: wizard: cover standard -> 2fa redirection

Add tests to cover the newly added standard restore to 2fa
redirection.

70/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
access control
AI analysis · Informational 15/100

This commit only adds and reorganizes automated test code for Electrum's wallet creation wizard. It does not change any production wallet logic, cryptography, or network handling. The tests verify that when a user tries to restore a 'standard' wallet but enters a seed phrase that actually belongs to a two-factor authentication (2FA) wallet, the wizard correctly redirects them to the 2FA setup flow. There is no security-relevant code change here.