Merge pull request #10845 from f321x/hide_passphrase_entry
What the developer wrote
Authored by accumulator
Merge pull request #10845 from f321x/hide_passphrase_entry
qml: wizard: hide passphrase input if disabled
What changed, and why it matters
This change tweaks a mobile-style setup wizard so that the optional passphrase text box is hidden when its checkbox is not selected, instead of merely grayed out. The commit message says this was done because users were confusing the passphrase field with the seed re-entry field. It is a usability fix, not a security bug fix.
No security action required; treat as a routine UI/usability improvement.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In electrum/gui/qml/components/wizard/WCEnterExt.qml, the custom passphrase TextField’s property was changed from enabled: extendcb.checked to visible: extendcb.checked. This controls UI visibility/availability based on the state of an adjacent checkbox. There is no cryptographic, validation, or secret-handling change in the diff.
Changed components
electrum/gui/qml/components/wizard/WCEnterExt.qmlInspect captured patch +1 / −1
### electrum/gui/qml/components/wizard/WCEnterExt.qml
@@ -88,7 +88,7 @@ WizardComponent {
TextField {
id: customwordstext
- enabled: extendcb.checked
+ visible: extendcb.checked // users confuse this with the seed re-entry if shown
Layout.fillWidth: true
Layout.columnSpan: 2
placeholderText: qsTr('Enter your custom word(s)')Why this scored 20/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.