Electrum

This is a code-cleanup change inside Electrum's Lightning channel handling. It removes the special case where a channel object could exist without a linked Lightning wallet worker (lnworker). Previously, unit tests and some code paths allowed lnworker to be None, which forced many methods to check 'if self.lnworker:' before doing anything. The patch makes lnworker mandatory, simplifies those checks, and adds a developer note that one related cleanup call is currently broken. There is no direct security fix for end users here; it is mostly defensive maintenance that reduces the chance of future bugs in test or edge-case code.

This commit is a test-code refactor that rewrites how fake Lightning channels are created for unit tests so they go through the real wallet code path. It also re-enables a safety assertion in production code that checks a channel's remote payout address belongs to the wallet. There is no direct security fix for end users; it is infrastructure work to make tests more realistic and catch configuration mistakes during development.

This commit is a test-only refactor in the Electrum Bitcoin wallet. It fixes how mock Lightning Network wallets are created in unit tests so that the test objects match the real structure (wallet.lnworker.wallet == wallet and lnworker.wallet.lnworker == lnworker). It does not change production wallet behavior or fix a security vulnerability in shipped code.

This commit is a test-code cleanup and a small defensive guard in non-production code. It removes an unused mock helper class, simplifies a test wallet constructor, and adds a null check before cancelling an onion-message task group. There is no user-facing security fix here.

This commit is a test-only cleanup. It removes a temporary workaround in Electrum's Lightning test suite where test channel objects had their node IDs manually overwritten after creation. The change makes the test helper create channels with the correct wallet/node keys from the start, instead of patching them afterward. There is no change to the actual wallet or Lightning code that users run.

This commit only changes test code. It refactors how Lightning Network peer tests set up their simulated channels and peers, merging two similar helper functions into one. There is no change to the actual Electrum wallet or Lightning code that users run, so it cannot directly affect security of real funds or operations.

This commit simply moves a helper method used only in tests from one test class to another. No real user-facing code was changed, and there is no security impact.

This commit only changes internal test code for the Electrum Bitcoin wallet. It simplifies how mock transaction queues are created and passed around in Lightning Network peer tests. There is no change to the actual wallet or network code that real users run, so it has no security impact on end users.

This commit simply moves a helper method that builds settings for new Lightning channels from one internal file to another. The commit message says 'no functional changes' and the diff confirms that: the same code, same values, and same checks are preserved. There is no user-visible change and no security fix or vulnerability introduced.

This commit is a large internal refactoring of Electrum's Lightning code. It changes the relationship between a wallet and its Lightning worker so that the wallet 'has' a separate peer manager instead of 'being' one. The main goal is to make unit tests easier and more realistic. There is no obvious security vulnerability introduced, but one safety assertion about wallet ownership of a channel's remote output address was commented out with a 'FIXME' note, which is a small red flag.

This is a small bug fix in Electrum's Qt transaction editor. The dialog was listening for the wrong event when watching Lightning channels come online, so it could fail to refresh its submarine-swap tab promptly. The fix changes the callback to the correct event. There is no direct evidence this is a security vulnerability; it appears to be a UI responsiveness bug.

This commit only adds two explanatory comments to the code. It does not change any behavior, fix any bug, or alter any security mechanism. One comment clarifies that child classes of CosignerWallet must inherit from EventListener and register callbacks; the other notes that callbacks are registered in child classes. It is a documentation-only change.

This is a bug-fix patch for a crash in Electrum's optional PSBT-over-Nostr plugin. The plugin helps co-signers exchange partially-signed Bitcoin transactions. The crash happened because a background thread tried to update an asyncio synchronization object on the wrong event loop, triggering a RuntimeError. The fix routes that update to the correct asyncio loop. It is a reliability fix, not a security vulnerability, and there is no evidence it can be exploited by an attacker.

This commit simply updates the version of Python used to build the Electrum Android app from 3.10.18 to 3.11.14. It changes version numbers and cryptographic checksums in build files, and switches to a newer version of the python-for-android build tool. There is no indication of a security vulnerability being fixed or introduced.

This commit lets Electrum recognize email-style payment identifiers (like user@domain.com) even when they have a 'lightning:' prefix in front. Previously, 'lightning:user@domain.com' would not be treated as a resolvable Lightning address. The change simply strips the prefix before checking if the rest looks like an email address. It is a small usability improvement, not a fix for a known security flaw.

This commit fixes a bug in Electrum where certain email-like or domain-like payment identifiers that happened to start with the letters 'ln' (such as 'lnbcuser@some.domain') were wrongly treated as Lightning Network invoices. The fix makes the parser check whether the string is actually valid bech32 format before classifying it as a Lightning payment. This could have caused users to send payments to the wrong destination or prevented them from resolving legitimate email/domain payment identifiers.

This commit adds a 'tap to focus' feature to Electrum's Android QR code scanner. It is a usability improvement for users whose phones lack automatic focus, not a security fix or vulnerability. There are no security signals in the code or commit message.

This commit updates the versions of two open-source barcode scanning libraries used in Electrum's Android app and removes a local workaround patch. The removed patch forced the compiled barcode scanner library to use a specific memory page size (16 KB) so it would work on newer Android devices. The upstream library now handles this automatically, so the patch is no longer needed. There is no direct evidence in the commit that this fixes a security vulnerability; it appears to be a routine dependency maintenance change.

This is a small user-interface fix for the Electrum Bitcoin wallet's Qt desktop app. It makes the 'Submarine Payments' tab refresh itself once the user's Lightning channels finish loading, so an outdated liquidity warning doesn't stay on screen. There is no security vulnerability here.

This commit only adds a help button with explanatory text to a user interface screen about 'submarine payments' in the Electrum wallet. It is a documentation/user-experience change, not a security fix or vulnerability.

This commit is a purely cosmetic user-interface change. It adds the word 'Tools' next to the preferences icon in a transaction confirmation dialog so the button matches the main window's appearance. There is no security relevance.

This commit is a user-interface improvement, not a security fix. It simply grays out two Lightning-related options in the transaction confirmation dialog when the wallet does not support Lightning, and shows a tooltip explaining why. There is no vulnerability being patched.

This commit is a small hardening change in Electrum's Qt wallet interface. It hides the 'Submarine Payment' tab when the wallet does not have Lightning support (swap_manager is missing). Without this guard, the tab could be shown in a state where the underlying swap service is unavailable, which might lead to a confusing or broken user experience rather than a direct theft-of-funds bug.

This commit only adds helpful hover text (tooltips) to the 'New Channel' button in Electrum's user interface. It explains why the button is disabled when Lightning isn't available and what the button does when it is enabled. There is no security change.

This commit changes only a Python type hint in the Lightning Network peer code. It replaces 'Awaitable' with 'Coroutine' in a function signature annotation to better match what asyncio.create_task expects. Type hints do not affect runtime behavior, so this cannot by itself introduce or fix a security vulnerability. It is a code-quality/correctness improvement for static analysis tools and developers.