Electrum

android: build pyqt_builder and sip ourselves, hash pin all hostpython_prerequisites

qml: don't import QtMultimedia when running on android (android 8 compat)

qml: add missing button containers

qml: styling updates qt6.10

qml: styling History, ProxyConfig and NostrConfigDialog

qml: add workarounds for issue assigning custom types to QObject properties

- on the python side, for pyqtProperty's with a setter, the pyqtProperty should be declared as QVariant type
- on the qml side, properties should be declared 'var', not the custom type.

qml: use standard Button for buttons outside of buttoncontainer

qml: additional styling InfoTextArea in dialogs

android: update Qt6 to 6.10.2, PyQt6 to 6.10.2

qml: add type hints for QVariant pyqtProperty workarounds

ci: bump code review ci claude version 4.6 -> 4.7

An improved Claude Opus version got released, this bumps the code review
CI to use it.

bitcoin.py: add helper func: neuter_bitcoin_address

wallet_db: put 'genesis_blockhash' in DB, detect mainnet/testnet mixup

If the user tries to open a wallet for a different chain (mainnet vs testnet), try to show a reasonable error message.

See previous attempt at this: https://github.com/spesmilo/electrum/commit/c13e05770150c5210783c3d42d3d2b1a683f18b4, which added `wallet.test_addresses_sanity()`. However there are many codepaths where "random" exceptions might get raised before the Wallet object is even instantiated.
See [discussion there](https://github.com/spesmilo/electrum/commit/c13e05770150c5210783c3d42d3d2b1a683f18b4#commitcomment-28017341):
> should we actually fix that?
> if yes, it would be better to write the network type in storage

Indeed now I think we should do that. At the time I was concerned it would not help against altcoin forks if we put "mainnet" or "testnet" in the DB. Now I realise we should just put the genesis block hash in the DB instead.

Many of the reports in https://github.com/spesmilo/electrum/issues/6526 are likely due to users trying to open a mainnet wallet in testnet mode or vice-versa.

fixes https://github.com/spesmilo/electrum/issues/9134
same issue in wizard 2fa two-step wallet-creation flow

wallet: make_unsigned_tx: fix base_tx for GUI simple-send batching

fixes regression from https://github.com/spesmilo/electrum/commit/a9f20e4d3de9848247a9079b5b164d8006cf80db :
For the GUI / manual new tx constructions usecase, the flow relies on `base_tx.add_info_from_wallet(self)` being called before `base_tx_fee = base_tx.get_fee()`.

fixes https://github.com/spesmilo/electrum/issues/10587
maybe fixes https://github.com/spesmilo/electrum/issues/8876
probably not a full fix: base_tx could have inputs for which add_info_from_wallet is not sufficient

tests: lnpeer: fix flaky test "hold_invoice_set_doesnt_get_expired"

This test was flaky: the mpp_set resolution gets set to SETTLING several asyncio event loop iterations before the hold invoice callback "cb" gets called.
If the 0.1 sec polling triggers just in the middle of that interval, `assert cb_got_called` fails.

```
async def check_mpp_state():
async def wait_for_resolution():
while True:
await asyncio.sleep(0.1)
if payment_key not in bob_w.received_mpp_htlcs:
continue
if not bob_w.received_mpp_htlcs[payment_key].resolution == RecvMPPResolution.SETTLING:
continue
return
await util.wait_for2(wait_for_resolution(), timeout=2)
> assert cb_got_called
E assert False

tests/test_lnpeer.py:1898: AssertionError
```

see https://github.com/spesmilo/electrum/blob/16c8cb50e38c274cce8f9f66f28d8dd453f9f074/electrum/lnpeer.py#L3136-L3137

fixes https://github.com/spesmilo/electrum/issues/10589

-----

diff to reproduce the failure without present patch:
```
diff --git a/tests/test_lnpeer.py b/tests/test_lnpeer.py
index 8669931c24..e15973d68f 100644
--- a/tests/test_lnpeer.py
+++ b/tests/test_lnpeer.py
@@ -1885,6 +1885,7 @@ class TestPeerDirect(TestPeer):
cb_got_called = False
async def cb(_payment_hash):
self.logger.debug(f"hold invoice callback called. {bob_w.network.get_local_height()=}")
+ await asyncio.sleep(1)
nonlocal cb_got_called
cb_got_called = True
```

lnpeer: channel_reestablish: split "they_are_ahead" into ctn vs revnum

lnchannel: (trivial) fix type hint of receive_fail_reasons

Using GET_MASTER_FINGERPRINT for Legacy Client to get the root public key fingerprint

lnpeer: chan_reest: clarify my_current_per_commitment_point is ignored

`my_current_per_commitment_point` was only used prior to option_static_remotekey

qml: add top padding to nostr relay url list

The first relay url was close to the top of the ElTextArea and looked a
bit sliced. Adding some padding makes it look better.

windows: delete lightning URI hooks on uninstall

On install we register the URIs for bitcoin, lightning, lnurlp and lnurlw
in the registry but on uninstall we would only remove bitcoin again.

pi: don't match literal | char in regexes

The RE_EMAIL and RE_DOMAIN regexes matched the '|' character
which is probably not what they should do.

pi: handle lud-17 URI payment identifier

LNURL-W/P can also be encoded in lud-17 form instead of bech32.
https://github.com/lnurl/luds/blob/luds/17.md
e.g.
lnurlw://example.com/api/test123
lnurlp://example.com/api/test123

bip21: add comment listing URI scheme handler registrations

It is sufficiently rare that we have to touch this stuff that I always have to re-discover where/how it is done. And it is impractical to grep for "bitcoin:" or "lightning:".

Putting this "master list" comment very close to the BITCOIN_BIP21_URI_SCHEME variable seems like a good spot - at least this is where I would look for it first.

qml: allow renaming wallets

Allows to rename a wallet file from the QML Wallet Details view.
This seems like a feature we should support as the use-case of a wallet can
change or maybe the user didn't think about a proper name when setting
up the wallet. Especially with lightning channels it is not possible to
restore from seed to change the name.

Fixes #4377