Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This commit only updates documentation. It adds new version entries to the manual page for the lightning-downgrade tool and mentions the tool in the upgrade guide. No code, database logic, or security behavior is changed.
This is a packaging/build fix, not a security vulnerability. The `lightning-downgrade` utility was being compiled but accidentally left out of the list of programs installed by `make install`. As a result, official release archives contain…
This commit fixes a database upgrade bug in Core Lightning. Wallets created with version v26.06.10 were missing two new tables (our_outputs and our_txs) because they skipped the migrations that create them. When users later upgraded, a fol…
Database migration failure could prevent node startup after upgradeFixes missing table creation before data backfillAdds regression test for upgrade path from v26.06.10
This commit is a routine version bump from v26.06.10 to v26.12rc1 for Core Lightning. It only updates version strings in packaging files, a changelog, and a lockfile. There are no code changes that introduce, fix, or modify any security-se…
This commit fixes a database bug in Core Lightning where failure details for a payment attempt were being overwritten by later retry attempts that shared the same payment identifier fragment. The fix makes the failure record match on an ad…
Data integrity bug causing incorrect error reporting across payment retry groupsNo memory safety, authentication, authorization, or cryptographic issues presentNo external input is trusted or validated differently
This commit fixes a bug in Core Lightning's Rust plugin library where a plugin could crash with a panic if it tried to log a message after the internal log-writing task had already stopped, such as during shutdown. The fix makes the plugin…
panic on send failure replaced with stderr fallbacklog message no longer silently dropped on writer task exitunit test added for dropped-receiver scenario
This commit only adds documentation to the manual page for an existing command-line tool (hsmtool). It explains how to recover funds from old Lightning payment commitments (HTLCs) after losing channel state. There are no code changes, no n…
This commit only changes a test file to make a flaky test more reliable. It does not modify any production code, so it has no security impact on real users.
This commit only updates documentation to explain that the `listtransactions` command reports a block height and transaction index of 0 when a transaction is not currently in a block (for example, because it hasn't been mined yet or was re…
This is a small bug fix in a Python helper library used by Core Lightning. The Millisatoshi.to_approx_str() method previously crashed with a math error when converting a zero amount to a human-readable string. The patch makes zero return "…
No security-relevant signals presentFix is a routine correctness/robustness improvement
This commit is a trivial formatting cleanup (removing an extra blank line and adding one) in a test file. It does not change any code behavior, fix any bug, or alter any security-relevant logic.
This update fixes a crash in two wallet commands, addpsbtoutput and addpsbtinput. These commands let users add extra transaction outputs or inputs to a PSBT (a Bitcoin transaction planning file). If a user supplied a PSBT whose version 2 '…
Daemon crash (assertion failure) on crafted/strict PSBT inputMissing validation of PSBT v2 modifiable flags before mutationUser-controlled input directly passed to libwally without precondition check
This commit only adds a new test case that demonstrates two Core Lightning commands, addpsbtoutput and addpsbtinput, crash with an internal assertion when given a v2 PSBT that does not allow adding inputs or outputs. The test is marked as …
Daemon abort due to failed assertion in PSBT helper functionsRPC commands addpsbtoutput and addpsbtinput lack validation of PSBT modifiability flags before calling libwallyPotential denial-of-service vector: any caller able to submit a crafted v2 PSBT can crash lightningd
This commit fixes a minor bug in Core Lightning's Python client library where calling a pretty-printing method on a zero-amount payment would crash with a ValueError. It is a routine correctness fix, not a security vulnerability. There is …
This commit adds missing safety checks in Core Lightning when a peer sends signatures for opening or splicing a dual-funded Lightning channel. Before the patch, the software accepted peer-provided transaction witnesses without verifying th…
Missing input validation on peer-provided witness dataBOLT-2 compliance fix for tx_signaturesRejection of empty witness stacks
This fix prevents a user-issued 'abort channels' command from incorrectly failing a Lightning channel when a splice transaction has already been signed. Previously, the code would pass the latest in-flight splice to a routine that aborts i…
Denial-of-service/availability impact: user-initiated abort could inadvertently fail a funded channelProtocol compliance fix: avoids sending tx_abort after tx_signatures, which BOLT 2 forbidsState-handling bug in splice negotiation lifecycle
This update fixes a bug where a specific type of Lightning channel close could crash the node. It only happens when both parties cooperatively close a dual-funded channel that has not yet been confirmed and has gone through a funding bump …
NULL pointer dereference leading to daemon crash (denial of service)Crash occurs in cooperative-close path for unconfirmed dual-funded/RBF channelsFix uses canonical channel funding key instead of splice-only field
This commit fixes a security bug in Core Lightning's gRPC plugin (cln-grpc). Previously, a malformed request from a gRPC client could crash the plugin: bad public keys, hashes, secrets, channel IDs, or enum values triggered Rust 'unwrap()'…
Denial-of-service via malformed gRPC request causing tonic worker task panicDenial-of-service via std::process::exit(1) in ProofField conversion on missing oneofSilent integer truncation of u16/u8 fields via 'as' casts
This commit removes the protobuf package from the Nix build environment because it is no longer needed. A previous change made the cln-grpc component use its own bundled protoc compiler instead of relying on the system one. The Python bind…
This commit adds a new automated check to the project's build process that compares gRPC protocol definitions against the last release to catch accidental breaking changes early. It does not change any runtime code, fix a bug, or introduce…
wallet: route transaction reads/writes through our_txs
Now that the bwatch wallet path records every relevant transaction in our_txs, point the wallet's transaction readers at that table.
Since our_txs.blockheight is NOT NULL with 0 = unconfirmed, the legacy NULL handling disappears: wallet_transactions_by_height no longer needs its "IS NULL vs = ?" query split, and wallet_transaction_height reads the column unconditionally.
wallet_transaction_add keeps dual-writing the legacy transactions table: the close path still inserts into channeltxs, whose transaction_id foreign key points at transactions(id), and wallet_get_funding_spend joins it. That legacy write can only go away with channeltxs itself.
Co-authored-by: Cursor <cursoragent@cursor.com>
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 32/100
This commit changes how Core Lightning stores and reads wallet-related transactions. It moves most reads to a new table called our_txs while still keeping the old transactions table updated for compatibility. The main concern is that the code now prevents a confirmed transaction from being downgraded back to unconfirmed, which is good, but the change is part of a larger migration and could introduce subtle bugs if the two tables get out of sync. There is no direct evidence this fixes or introduces a security vulnerability.
Populate our_outputs/our_txs from the legacy outputs/transactions tables so the bwatch wallet path starts with the same state as the existing wallet.
Use outputs rather than utxoset because it already contains only wallet-owned rows and carries wallet metadata like reservations and channel-close info.
Downgrade only drops the new tables: later commits keep mirroring writes into the legacy tables, so no copy-back migration is needed.
This commit adds a database migration that copies existing wallet data into new tables used by an upcoming 'bwatch' wallet component. It is a data backfill, not a code fix for an active vulnerability. The main risk is that if the migration copies data incorrectly, a future version of Core Lightning could misread the wallet state—potentially showing wrong balances, missing transactions, or in rare cases making unsafe spending decisions. The commit includes tests that check the copy logic for several common cases.
Make each existing chaintopology writer update both representations of its UTXO state:
- wallet_add_utxo and wallet_add_onchaind_utxo insert into both tables; - db_set_utxo updates reservations in both tables; - wallet_confirm_tx updates confirmation heights in both tables; and - wallet_outpoint_spend marks outputs spent in both tables.
Keeping each pair of writes in the existing helper makes the downgrade mirror explicit without duplicating SQL at its callers. Reads remain on legacy `outputs` until the following commit switches them to our_outputs.
Co-authored-by: Cursor <cursoragent@cursor.com>
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
update trustsigning or wallet path
AI analysis · Low 29/100
This is a database refactoring commit in Core Lightning. It makes the wallet write UTXO (unspent transaction output) state to a new table called our_outputs in addition to the legacy outputs table, while reads still use the old table. The goal is to prepare for a future migration, not to fix an active security bug. There is no direct evidence in the commit that this change itself creates or fixes a vulnerability.
Upgrade a pre-bwatch snapshot db and check the migration mirrored outputs/transactions into our_outputs/our_txs, listfunds still reports the old UTXOs, and the wallet can receive and withdraw new funds.
Co-authored-by: Cursor <cursoragent@cursor.com>
78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100
This commit only adds a new automated test. It checks that an older Core Lightning database snapshot upgrades correctly: legacy wallet tables are copied into newer tables, existing funds remain visible, and the wallet can still receive and send money after the upgrade. There is no code change to the actual wallet or database migration logic.
AI review queuedwallet: make datastore helpers self-wrap a wallet transactionby Sangbida Chaudhuri · ae1a3347 · Jul 27, 2026 · 1 fileMessage 85 · StrongLow 31Details
Commit message · Sangbida Chaudhuri
wallet: make datastore helpers self-wrap a wallet transaction
The four wallet_datastore_{get,create,update,remove} helpers used to require the caller to be inside a wallet transaction; otherwise the underlying db_prepare_v2 fatals at db/utils.c:103 with "Attempting to prepare a db_stmt outside of a transaction".
watchman persists its pending bwatch ops through these helpers from plugin callbacks that run outside any transaction, so wrap one on demand.
Co-authored-by: Cursor <cursoragent@cursor.com>
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 31/100
This change fixes a crash bug in Core Lightning's wallet datastore helpers. Previously, four datastore functions required the caller to already be inside a database transaction, and would fatally crash if called outside one. The patch makes these helpers automatically start and commit a transaction when needed. The commit message says this specifically fixes crashes in the watchman plugin, which saves pending operations through these helpers from plugin callbacks that run outside any transaction.
Register the wallet/spk owner prefix with watchman so scriptpubkey matches and reverts reach the wallet handlers introduced in the previous commit. Document the owner suffix format alongside the dispatch entry.
Co-authored-by: Cursor <cursoragent@cursor.com>
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 27/100
This commit wires up the Core Lightning wallet to a new internal watcher service (bwatch) so that incoming payments to wallet addresses are detected and processed. It is a follow-up plumbing change that registers a dispatch handler for wallet scriptpubkey watches. There is no direct evidence in the commit that it fixes a security bug, but it is part of a larger change that could affect how funds are tracked and credited.
AI review queuedwallet: handle reorgs for our_outputs/our_txs by handby Sangbida Chaudhuri · bcdea215 · Jul 27, 2026 · 1 fileMessage 73 · AdequateModerate 54Details
Commit message · Sangbida Chaudhuri
wallet: handle reorgs for our_outputs/our_txs by hand
The legacy tables rely on their blocks(height) ON DELETE SET NULL foreign keys to mark rows unconfirmed/unspent when a block is reorged out. our_outputs/our_txs deliberately carry no blocks FK (bwatch does not maintain a blocks table), so block disconnect and rollback must demote their blockheight/spendheight fields explicitly.
Demote, never delete: a row also carries state the chain cannot re-deliver (reserved_til, onchaind close metadata), and this path runs not just on real reorgs but on every startup, when chaintopology invalidates its rescan window. Rediscovery re-promotes the row via wallet_add_our_output / wallet_transaction_add; a tx that never re-confirms just stays unconfirmed and unspendable.
Co-authored-by: Cursor <cursoragent@cursor.com>
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI analysis · Moderate 54/100
This commit fixes how Core Lightning's wallet records handle blockchain reorganizations (reorgs) for two newer database tables, our_outputs and our_txs. Previously, these tables were not properly updated when blocks were removed or rolled back, meaning the wallet could incorrectly believe funds were confirmed or spent when they no longer were. The fix explicitly resets those records to an unconfirmed state during reorgs and startup rescan windows, matching the behavior of older tables. This prevents internal accounting errors and potential loss or misreporting of funds after a reorg.
Add the wallet helpers and watch handlers that turn a bwatch scriptpubkey match into our_txs and our_outputs rows. They validate the matching output, notify invoice accounting, record confirmed deposits, and install watches for later spends.
The watch_revert handler demotes the rows back to unconfirmed (the 0 sentinel) rather than deleting them: a row also carries state a rediscovery cannot restore (reserved_til, onchaind close metadata), and the still-armed watches re-promote it if the tx confirms again. This matches the legacy tables, whose blocks(height) foreign keys demote rows to NULL when the block row is removed.
Unlike got_utxo(), this path does not write transaction_annotations: nothing reads per-transaction annotations anymore, so only the legacy scanner keeps populating them (for downgrade, like the other legacy tables).
The watchman dispatch entry is wired in the following commit. Keep this path alongside got_utxo() and wallet_transaction_add(): the legacy scanner must continue populating outputs and transactions for one release so downgrades do not require a rescan.
Co-authored-by: Cursor <cursoragent@cursor.com>
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
update trustdefensive validationsigning or wallet path
AI analysis · Low 32/100
This commit adds new wallet bookkeeping code for Core Lightning. It records Bitcoin deposits found by a new chain-watcher ('bwatch') into database tables and handles blockchain reorganizations by demoting transactions back to unconfirmed rather than deleting them. It is a feature/refactoring commit, not a fix for a known vulnerability, and the commit message does not describe any security issue.
The next commits move wallet UTXO and tx tracking off chaintopology and onto bwatch. bwatch doesn't maintain a blocks table, but the legacy utxoset, transactions and channeltxs tables all have FOREIGN KEY references into blocks(height) (CASCADE / SET NULL), so we can't just retarget the existing tables.
Instead, introduce parallel tables (our_outputs, our_txs) without the blocks(height) FK. The new bwatch-driven code writes only to these, the legacy tables stay populated by the existing code path during this release so downgrade still works, and a future release can drop them once we're past the downgrade window.
Losing the FK also changes what NULL means. In the legacy tables a NULL blockheight was never written by hand: the ON DELETE SET NULL trigger produced it when a reorg deleted the block row. These tables have no such trigger, so unconfirmed is stored as blockheight 0 (NOT NULL) instead, for three reasons:
- everything feeding these tables already speaks u32-with-0: watchman notifications carry blockheight as a required JSON number, and wallet_transaction_height() has always returned 0 for unconfirmed, so values bind straight through without a NULL/non-NULL branch at every read and write site;
- integer comparisons keep working: the unconfirmed->confirmed promotion is a single "WHERE blockheight < ?" (0 sorts below any real height) and reorg rollback is "SET blockheight = 0 WHERE blockheight >= ?", where a NULL row would match neither;
- it removes the footgun the legacy code warned about ("Note: blockheight=NULL is not the same as is NULL!"), where lookups had to branch between "= ?" and "IS NULL".
The same logic gives txindex 0 = unconfirmed/unknown (a *confirmed* txindex of 0 means coinbase, which blockheight disambiguates) and reserved_til 0 = not reserved. NULL survives only where 0 is a real value or genuinely ambiguous: spendheight (NULL = unspent), channel_dbid, commitment_point.
Schema only here — wallet handlers that write into these tables and the backfill from outputs/transactions land in subsequent commits.
Co-authored-by: Cursor <cursoragent@cursor.com>
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
update trustsigning or wallet path
AI analysis · Informational 18/100
This commit only adds two new empty database tables (our_outputs and our_txs) to Core Lightning's wallet. It is a preparatory schema change for a future feature; no code reads from or writes to these tables yet, and no existing behavior is changed. There is no direct security vulnerability here, though any new table design could later affect how safely wallet data is tracked.
wallet: mirror bwatch writes into legacy outputs table
The bwatch path writes wallet UTXOs to our_outputs while the legacy `outputs` table is what a downgraded binary reads. Mirror every our_outputs write (insert, spend, unspend-on-spend-revert, reservation) into `outputs` so a downgrade for one release needs no copy-back or rescan. Reorg demotion needs no mirror: the legacy rows are demoted by their blocks(height) foreign keys when chaintopology removes the block. The mirroring stops in the release that removes chaintopology, freezing all the legacy tables at the same height.
The spend mirror guards its spend_height the same way the insert guards confirmation_height: outputs.spend_height has a foreign key on blocks(height), which only chaintopology populates, and bwatch can deliver the spend before chaintopology has processed that block. Record NULL in that case (status already marks the row spent) and let chaintopology's own spend pass fill in the height.
The wallet still reads from `outputs`; switching reads over to our_outputs comes next.
Co-authored-by: Cursor <cursoragent@cursor.com>
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
update trustsigning or wallet path
AI analysis · Low 27/100
This change is a behind-the-scenes bookkeeping patch for Core Lightning's wallet database. The project is moving to a new table (`our_outputs`) for tracking spendable coins, but older versions of the software still read from the old table (`outputs`). The patch copies every new-table write back into the old table so that if a user downgrades to the previous release, their wallet still sees the correct coins and balances. It is not a fix for an externally exploitable bug; it is a compatibility/migration safeguard.
Lower-prioritypyln-testing: wait for listen port release before starting a nodeby Ken Sedgwick · 1136b217 · Jul 27, 2026 · 1 fileMessage 91 · StrongInformational 17Details
Commit message · Ken Sedgwick
pyln-testing: wait for listen port release before starting a node
A node's connectd is a separate process holding the listen socket, and on shutdown it exits on its own schedule after lightningd itself is gone -- under valgrind, its teardown can lag by tens of seconds. If a test restarts the node in that window, the new connectd fails with 'Address already in use', lightningd exits, and the test times out waiting for 'Server started with public key'. Seen in CI in test_emergencyrecoverpenaltytxn, where the port was still held 37 seconds after the old connectd began shutting down.
The filesystem port locks don't cover this: they keep other workers from reserving the port, but the restarting node owns its reservation both times; nothing waits for the old connectd to actually release the socket.
Before launching lightningd, bind-probe the node's port (with SO_REUSEADDR, matching connectd, so TIME_WAIT sockets don't count as in use) and only proceed once the bind succeeds.
Fixes: #9354 Changelog-None
91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 17/100
This is a testing-framework fix, not a fix in the Core Lightning node software itself. It stops automated tests from failing when a background process (connectd) is slow to release a network port after a node restart. There is no direct security vulnerability being patched; it improves test reliability.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 28/100
This commit removes a 180-second startup delay before the 'spender' plugin checks for Lightning channels that were stuck waiting for a signature after a crash. The change makes recovery happen immediately at startup instead of waiting three minutes. The commit message says this is intentional and safe, because the previous delay was only a workaround to avoid slowing down other plugins during startup. There is no direct evidence in the commit that this fixes a security vulnerability; it appears to be a reliability/startup-order change.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 31/100
This change moves a startup recovery task in the 'spenderp' plugin so it runs 180 seconds after startup instead of immediately during plugin initialization. The recovery task signs unsigned PSBTs for channels that are waiting to lock in. The patch is meant to prevent slow wallet signing from blocking other built-in plugins during startup. It is a performance and reliability fix, not a direct security patch, but the original behavior could have caused startup delays or related availability issues.
AI review queuedwallet: Read the max_index for addresses from the in-memory cacheby Christian Decker · 5b9ff9ff · Jul 23, 2026 · 1 fileMessage 50 · ThinInformational 16Details
Commit message · Christian Decker
wallet: Read the max_index for addresses from the in-memory cache
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 16/100
This small change makes the wallet's address-listing command read a cached value from memory instead of querying the database each time. It appears to be a performance or consistency cleanup rather than a security fix. There is no direct evidence in the commit that it repairs a vulnerability.
Security candidatewallet: Update the max_index cache when issuing new addressesby Christian Decker · d05815f5 · Jul 23, 2026 · 2 filesMessage 73 · AdequateModerate 51Details
Commit message · Christian Decker
wallet: Update the max_index cache when issuing new addresses
The write-through cache added for the address max_index was only kept in sync in wallet_can_spend(). wallet_get_newindex() still read and wrote the bip32_max_index/bip86_max_index db vars directly, leaving the in-memory cache stale after every newaddr. Since listaddresses and the rescan window now read from that cache, freshly issued addresses were invisible until the next restart (and wallet_can_spend could even write a stale, lower value back to the db).
Route all reads and writes through wallet_max_addr_index() and wallet_set_max_addr_index() so the cache and the db never diverge.
Changelog-None Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
secret or key materialsigning or wallet path
AI analysis · Moderate 51/100
This commit fixes a bug where Core Lightning's in-memory record of the highest address index could fall out of step with the database. When a user generated a new on-chain address, the code updated the database directly but left the cached value unchanged. That meant newly created addresses would not show up in address lists or rescan windows until the node was restarted, and in some cases the stale cache could overwrite the newer database value with an older one. The patch routes all reads and writes through helper functions so the cache and database stay synchronized.
Security candidatewallet: Cache the max_index for bip32 and bip86 address indicesby Christian Decker · 565da833 · Jul 23, 2026 · 2 filesMessage 83 · StrongInformational 15Details
Commit message · Christian Decker
wallet: Cache the max_index for bip32 and bip86 address indices
We were looking up the index for the addresses to scan, twice, for every single output, for every single TX for every block. No wonder that was being slow.
Changelog-Fixed: wallet: Addressed a performance regression during blockchain scans
83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
secret or key materialsigning or wallet path
AI analysis · Informational 15/100
This commit is a straightforward performance optimization. It caches two address-index values in memory instead of reading them from the database twice for every transaction output in every scanned block. The change fixes a slowdown during blockchain scans and does not alter security behavior.
AI review queueddocs: Fixing Ubuntu installation docs - updated release tag references - removed protobuf-compiler dependency - removed rustup default installation, changed it to only for Ubuntu <25.10 (rust <1.85) - added note about tzdata config halting executionby ScuttoZ · 947ed0f3 · Jul 22, 2026 · 1 fileMessage 85 · StrongInformational 15Details
Commit message · ScuttoZ
docs: Fixing Ubuntu installation docs - updated release tag references - removed protobuf-compiler dependency - removed rustup default installation, changed it to only for Ubuntu <25.10 (rust <1.85) - added note about tzdata config halting execution
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
This commit only updates the project's documentation for installing Core Lightning on Ubuntu. It refreshes supported Ubuntu versions, dependency package lists, release tag examples, and Rust setup instructions. There are no code changes and no security fix or vulnerability introduced.
Lower-priorityCI: set readme branch name to stableby daywalker90 · 6a243ef5 · Jul 22, 2026 · 1 fileMessage 57 · ThinInformational 15Details
Commit message · daywalker90
CI: set readme branch name to stable
Changelog-None
57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100
This commit only changes the branch name used by an automated documentation-publishing workflow from '1' to 'stable'. It affects how Core Lightning's public guides are synced to a documentation hosting service (ReadMe). There is no change to the actual Lightning node software, no handling of funds, no network behavior, and no security-sensitive code.
Security candidatelightningd: store raw failure message so waitsendpay always has raw_messageby Ken Sedgwick · 4eb80237 · Jul 21, 2026 · 5 filesMessage 91 · StrongLow 26Details
Commit message · Ken Sedgwick
lightningd: store raw failure message so waitsendpay always has raw_message
If a payment's HTLC failure completes before waitsendpay is called, wait_payment() rebuilds the error from the database, which did not persist the raw BOLT4 failure message: a 2019 FIXME in that path set fail->msg = NULL, silently dropping raw_message from the error data. This is the cause of the test_error_returns_blockheight CI flake - the test loses the race occasionally, calls waitsendpay after the failure has landed, and KeyErrors on the missing raw_message.
Add a failmsg column to the payments table (with a downgrade drop), persist fail->msg when recording the failure, and read it back in wait_payment. Local and self-payment failures store NULL as before, since no onion failure message exists for them; failed payments recorded before this migration also return NULL, matching the old behavior.
The flaky test now also calls waitsendpay a second time, which deterministically takes the database-replay path, so the regression is covered without any timing dependence.
Changelog-Fixed: JSON-RPC: `waitsendpay` error data now includes `raw_message` even when the payment already failed before the command was called. Fixes: #9341
91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
update trustsigning or wallet path
AI analysis · Low 26/100
This commit fixes a bug in Core Lightning where the `waitsendpay` command could omit a `raw_message` field from error responses if the payment failure was recorded in the database before the command was called. The fix adds a new database column to store the raw failure message and reads it back when reconstructing the error. It is a data-integrity/API-correctness fix, not a vulnerability that allows attacks or unauthorized access.
nix: fix `nix build` and simplify NixOS install docs
CLN's ./configure detects Python through `uv` (see default_python in configure), which the cln derivation does not provide, so PYTHON ends up empty and the build fails when a Makefile step runs `$(PYTHON) devtools/blockreplace.py`. Set PYTHON=python3 in preConfigure (the derivation already ships a python3 with mako/grpcio-tools) and add blockreplace.py to patchShebangs.
With `nix build` working again, replace the stale poetry-based NixOS section of the install guide with the flake commands (nix build / nix run / nix profile install / nix develop). Verified in a nixos/nix container: nix build ".?submodules=1" produces lightningd/lightning-cli v26.06.1.
Changelog-Fixed: nix: the flake build (`nix build`) no longer fails because ./configure cannot detect Python.
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Informational 16/100
This commit fixes the Nix package build for Core Lightning so that `nix build` works again. It is a build-system/documentation fix, not a security patch. There is no vulnerability being fixed here.
tests: fix broken race handler in test_funding_external_wallet_corners
d09d0112f ("pytest: handle v fast disconnect during test_funding_external_wallet_corners()") wrapped the reconnect in try/except to tolerate the "disconnected during connection" race, but the assert checks the substring against err.error, which is the whole error dict ({'code': 402, 'message': ...}). `in` on a dict tests its keys, so the assert fails exactly when the race it is meant to tolerate occurs.
Seen in CI, where connect raised code 402 and the handler itself then asserted:
E assert 'disconnected during connection' in {'code': 402, 'message': 'disconnected during connection'}
Match against err.error['message'] instead, as the equivalent handlers in test_plugin.py and test_misc.py already do.
Changelog-None
83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100
This is a one-line fix to a flaky automated test. The test was supposed to tolerate a harmless race condition where a peer disconnects during connection, but the assertion was checking the wrong part of the error object, so the test failed when the race actually happened. The change makes the test check the error message text instead of the dictionary keys. It does not change any production code or affect real users' funds or node security.
Lower-priorityrelease: CHANGELOG and version bumps for v26.06.6by daywalker90 · d6bce325 · Jul 21, 2026 · 10 filesMessage 45 · ThinInformational 15Details
Commit message · daywalker90
release: CHANGELOG and version bumps for v26.06.6
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100
This commit is purely a release housekeeping change: it updates version strings from v26.06.2 to v26.06.6 and adds a CHANGELOG entry for the new release. The CHANGELOG mentions two fixes that were already made in earlier commits (a Python build fix and rejecting reused channel funding outpoints), but this commit itself does not contain any code changes that fix a security issue. It is not a security patch.
The test snapshots getrawmempool() and then calls getrawtransaction() on each txid. In simple close both peers broadcast conflicting closer txs: here l2's tx pays only 400sat fee (its entire 400sat balance goes to fees since its own output is dust) while l1's pays 3375sat, so l1's tx can RBF-replace l2's between the snapshot and the fetch. The getrawtransaction() call on the replaced txid then fails with error -5 (No such mempool or blockchain transaction). A CI failure showed exactly this ordering: l2 broadcast its closer tx, l1's higher-fee tx replaced it 14ms later, and the test's per-txid fetch raced the replacement.
Retry the whole snapshot-and-check loop when a txid vanishes mid-iteration, keeping the single-output assertion hard. This is the same class of mempool race fixed for test_simple_close_delay_broadcast in 5ae0705f2 ("tests: fix flaky test_simple_close_delay_broadcast mempool race").
Changelog-None
83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100
This commit fixes a flaky automated test, not a security bug in the actual Core Lightning software. The test sometimes failed because it took a snapshot of Bitcoin's memory pool and then tried to fetch each transaction, but one transaction could be replaced by a higher-fee version in the tiny gap between those two steps. The fix simply retries the snapshot-and-check loop if a transaction disappears mid-check. No user funds, network behavior, or real-world security is affected.
Lower-prioritytests: compare medians in test_no_delay instead of meansby Ken Sedgwick · 365428bb · Jul 21, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · Ken Sedgwick
tests: compare medians in test_no_delay instead of means
test_no_delay compares mean round-trip times with a 3-standard-error margin. On loaded CI runners the trip-time distribution is heavy-tailed enough that the margin can exceed the entire effect being measured: in the #9329 failure the margin came to 45.3ms while the true Linux effect is one delayed-ACK quantum (40ms - the docstring's ~200ms figure is other platforms), so the assertion failed with the effect cleanly present (saving 44.6ms).
The stall shifts the whole distribution by the quantum, so the median difference detects it regardless of the noise tail. Compare medians, requiring half the quantum on Linux; on platforms without a measurable stall keep the not-slower sanity check with the same slack.
Fixes: #9329 Changelog-None
91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 15/100
This commit only changes a single test file. It swaps a flaky statistical comparison (mean with standard-error margin) for a more stable one (median with a fixed 20 ms margin) in a timing test about TCP Nagle delays. There is no change to production code, no security fix, and no vulnerability.
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100
This commit only fixes a typo and an incorrect sentence in documentation files describing the 'spliceout' command. It changes 'move funds into a channel' to 'move funds out of a channel' and adds the word 'to' in a usage sentence. No code behavior is changed, and there is no security impact.