CI: install CLN on macos and run selected pytest tests
What the developer wrote
Authored by daywalker90
CI: install CLN on macos and run selected pytest tests
remove the manual node start as it is covered by running pytests
Changelog-None
What changed, and why it matters
This commit only changes the project's macOS CI workflow. It replaces a manual setup that started Bitcoin and Core Lightning manually with an automated pytest-based test run after installing the software. There is no change to the actual Core Lightning code, user-facing behavior, or security-sensitive logic.
No security action needed. This is a routine CI improvement.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies .github/workflows/macos.yaml. It adds sudo gmake install, removes manual bitcoind/lightningd startup steps, and instead runs a small set of pytest tests with SLOW_MACHINE=1 and a 30-minute timeout. This is purely a CI/testing infrastructure change.
Changed components
.github/workflows/macos.yamlInspect captured patch +10 / −18
diff --git a/.github/workflows/macos.yaml b/.github/workflows/macos.yaml
index fd92c0d7..7e31bd9c 100644
--- a/.github/workflows/macos.yaml
+++ b/.github/workflows/macos.yaml
@@ -52,23 +52,15 @@ jobs:
uv run ./configure --disable-valgrind --disable-compat
uv run gmake
uv run gmake check-gen-updated
+ sudo gmake install
- - name: Start bitcoind in regtest mode
+ - name: Run pytest
+ env:
+ SLOW_MACHINE: 1
+ PYTEST_OPTS: "-vvv --timeout=1800 --durations=10"
+ PYTEST_TESTS: |
+ tests/test_misc.py::test_ipv4_and_ipv6
+ tests/test_connection.py::test_websocket
+ tests/test_connection.py::test_wss_proxy
run: |
- bitcoind -regtest -daemon
- sleep 5
-
- - name: Generate initial block
- run: |
- bitcoin-cli -regtest createwallet default_wallet
- bitcoin-cli -regtest generatetoaddress 1 $(bitcoin-cli -regtest getnewaddress)
- sleep 2
-
- - name: Start CLN in regtest mode
- run: |
- lightningd/lightningd --network=regtest --log-file=/tmp/l1.log --daemon
- sleep 5
-
- - name: Verify CLN is running
- run: |
- cli/lightning-cli --regtest getinfo
+ VALGRIND=0 uv run pytest $PYTEST_TESTS -n $(sysctl -n hw.ncpu) ${PYTEST_OPTS}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.