Core Lightning

This is a small code cleanup that switches to a helper function which unescapes JSON strings without making an extra copy. The only behavior change is that invalid escape sequences in command usage strings are now rejected instead of silently accepted unchanged. There is no obvious security vulnerability being fixed, and no evidence of an exploit or disclosure.

This commit is a small cleanup in Core Lightning's plugin handling. It changes how log messages received from plugins are unescaped, switching to a dedicated function that handles lengths directly. The commit message explicitly says this is just 'neatening' and that the actual unescape handling was already done in an earlier commit. There is no direct evidence in the diff or commit message that this fixes a security vulnerability.

This commit adds a missing piece of information—the channel type—to two plugin hooks used when opening Lightning channels. It is a straightforward feature addition that lets plugins see what kind of channel is being offered. There is no indication it fixes a security bug or introduces a vulnerability.

This commit fixes three trivial typos in documentation and a code comment: 'do it it' becomes 'do if it', 'in in' becomes 'in', and 'the the' becomes 'the'. There are no code behavior changes and no security relevance.

This commit fixes a subtle programming bug in how Core Lightning converts text strings to numbers. Functions like strtoull only set an error flag (errno) when a value is too large, but they leave it unchanged on success. If some earlier code had already set that flag to 'overflow,' a later successful conversion of the largest possible number could be wrongly rejected as an overflow. The patch clears the error flag before each conversion so the check afterward is reliable. The practical security impact is limited because the bug only triggers when a prior operation happens to leave that specific error flag set, and the affected conversions are mostly for amounts, route hints, and JSON parsing rather than cryptographic checks.

This commit only adds test data files (compressed SQLite snapshots) and a new pytest test case for the bookkeeper module. It is a testing-only change with no modifications to production code, so it has no security impact on running Core Lightning nodes.

This commit is a small code cleanup: it introduces a helper function that converts internal 'tags' into strings, and uses that helper in two places where notifications are formatted as JSON. There is no visible change in behavior and no security issue is apparent.

This commit is a straightforward internal code cleanup: it moves the logic for converting a text tag into an internal coin-movement tag out of the JSON parser and into a dedicated helper function. There is no visible security fix, behavior change, or vulnerability being addressed.

This commit is a simple code cleanup: it renames a set of internal bookkeeping labels (called enum mvt_tag values) so they all start with 'MVT_'. For example, CHANNEL_OPEN becomes MVT_CHANNEL_OPEN. The change touches many files but only renames symbols; it does not alter program logic, data formats, network behavior, or security checks.

This commit only adds the C keyword 'const' to function parameters and test stubs. It does not change any program logic, data flow, or behavior. It is a code-quality/cleanup change with no security relevance.

This commit is a straightforward internal refactoring: it replaces a variable-length list of text labels (called a 'tal_arr') with a compact 64-bit bitmap (a 'struct mvt_tags') for tracking coin-movement tags. The change touches many call sites but does not alter what the tags mean, how money moves, or any security boundary. It is not a security fix and introduces no obvious vulnerability.

This commit is a straightforward code cleanup: it moves the literal strings 'external' and 'wallet', plus small helper functions that test account names, into a single shared header file. Previously these strings and functions were duplicated across many files. There is no change to program behavior, no bug fix, and no security-related change.

This commit changes several database helper functions so they receive monetary amounts by copy (passing the value directly) instead of by pointer (passing a memory address). The commit message says this is just to match how the rest of the codebase now handles these types. There is no direct evidence in the diff or message that this fixes a security bug; it appears to be a code-consistency cleanup. Passing by copy can sometimes prevent certain classes of mistakes (for example, accidentally passing a NULL pointer or a pointer to uninitialized memory), but the diff does not show any such bug being fixed.

This is a routine internal code cleanup in Core Lightning. It changes how the node reports coin movements (on-chain and channel transactions) to plugins, switching from a single generic data structure to two more specific ones. There is no indication this fixes a security bug or introduces a vulnerability.

This commit is a code-quality refactor in Core Lightning's internal accounting system. It replaces formatted channel ID strings with direct pointers to channel objects, and introduces a small helper structure that can hold either a channel pointer or an alternative account name. The change removes unnecessary string formatting and lookups, and updates the wire serialization format for on-chain coin movement records. There is no indication of a security vulnerability being fixed or introduced.

This is a small code cleanup in the bookkeeper plugin. It removes an unused 'account_exists' flag from a helper function that looks up account balances. The flag was only used in tests, so the change simplifies the code without altering real behavior.

This commit changes an error message when a database query fails. Previously the program reported where the query came from and the SQL text; now it reports the actual database error message. There is no security fix here—only improved diagnostic logging for developers and operators.

This commit adds internal safety checks to ensure that financial movement records in Core Lightning always start with a main category tag, with any extra tags treated as secondary. It does not change user-facing behavior in production builds, but it helps prevent bookkeeping mistakes that could misclassify transactions.

This change only affects internal test helper code. It makes test comparisons of tag lists ignore the order of tags by sorting them first. There is no security issue; it is a test robustness fix.

This commit removes the bookkeeper plugin's ability to track multiple currencies. From now on, every transaction is reported in the node's own currency (for example, Bitcoin on mainnet). The change simplifies the code and database schema but does not fix a security bug. It could affect accounting accuracy for anyone who had manually configured different currencies.

This is a routine code cleanup in Core Lightning's internal accounting structures. It reorders struct fields for consistency and marks two pointer fields as 'const' (read-only after creation). There is no functional change visible in the diff, and no security issue is indicated.

This commit is a straightforward code cleanup: it replaces a true/false flag with a named enum (COIN_CREDIT/COIN_DEBIT) to make the code easier to read. It does not change any behavior, fix a bug, or address a security issue. The author deliberately reordered function arguments so any missed callers would fail to compile, ensuring the change is complete.

This is a small internal code cleanup in Core Lightning's plugin helper library. It changes a helper function so callers pass the data length explicitly, rather than the helper measuring it itself. The commit message frames this as a convenience change, not a security fix. There is no direct evidence in the commit of an exploitable vulnerability, but the change removes a class of potential bugs where a non-tal pointer could be mis-measured.

This change fixes accounting data that Core Lightning sends to plugins. For multi-part payments, the existing 'part_id' alone was not unique; the same part number could appear in different payment groups. The commit adds a 'group_id' field so plugins can reliably match each coin movement to the correct payment. It is a correctness/audit fix rather than a direct funds-loss bug, but inaccurate accounting could mislead downstream tools.

This commit removes an unused internal data structure (`struct coin_mvt`) and the helper functions that converted two other structures into it. It is a code cleanup change with no visible effect on users and no security relevance.