tests: drop obsolete x-prefix in compacter-slow.sh
What the developer wrote
Authored by Sangbida Chaudhuri
tests: drop obsolete x-prefix in compacter-slow.sh
Shellcheck 0.11 (SC2268) rejects the old x"$1" comparison idiom.
Prevents: "tests/plugins/compacter-slow.sh:5:6: note: Avoid x-prefix in comparisons as it no longer serves a purpose. [SC2268]"
What changed, and why it matters
This commit is a trivial shell script cleanup. It removes an old-fashioned 'x' prefix from a string comparison in a test helper script so that a newer version of the Shellcheck linter stops warning about it. The change does not alter program behavior and has no security relevance.
No security action needed. Treat as normal code hygiene.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff changes one line in tests/plugins/compacter-slow.sh from ‘[ x”$1” != x”–version” ]’ to ‘[ “$1” != “–version” ]’. This is purely a style/linting fix for Shellcheck rule SC2268. The comparison semantics are identical in modern shells, and the file is only used in tests.
Changed components
tests/plugins/compacter-slow.shInspect captured patch +1 / −1
diff --git a/tests/plugins/compacter-slow.sh b/tests/plugins/compacter-slow.sh
index 0812c62e..dd52fd8c 100755
--- a/tests/plugins/compacter-slow.sh
+++ b/tests/plugins/compacter-slow.sh
@@ -2,7 +2,7 @@
# This pretends to be lightning_gossip_compactd, but waits until the file "compactd-continue"
# exists. This lets us test race conditions.
-if [ x"$1" != x"--version" ]; then
+if [ "$1" != "--version" ]; then
while [ ! -f "compactd-continue" ]; do
sleep 1
done
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.