Core Lightning

This commit only adds a test case. It marks an existing emergency recovery test as expected to fail (xfail) and adds a single bookkeeping balance-listing call after recovery. There is no code fix or security change in the diff itself.

This commit fixes a crash in Core Lightning's bookkeeper plugin. After a user loses their main database and runs emergency recovery, then closes a channel, the bookkeeper plugin would hit an internal assertion and crash the whole node. The fix makes the plugin log a warning and continue running instead of crashing.

This commit adds a developer-only command to manually compact the gossip store file used by Core Lightning. It is a testing and diagnostic feature, not a normal user function. The command is gated behind the 'developer' build mode and does not change how regular users run the software. There is no indication in the commit that this fixes a security bug or introduces a security vulnerability.

This change updates how Core Lightning reloads its saved network map (the 'gossip store') after the file is compacted or reopened. It now reads a special 'UUID' marker at the start of the file to decide whether the file was rewritten from scratch or simply trimmed. If the UUID changed, it rebuilds the in-memory map from scratch; if it matches, it still rebuilds but can trust the equivalent offset. The patch is a robustness improvement, not an obvious security fix, and the commit message does not describe any security relevance.

This is a small bug-fix in a downgrade helper tool. Previously, the tool only deleted an incompatible gossip data file when the database actually needed changes. Now it deletes that file even if the database is already compatible, preventing a scenario where downgrading leaves behind a gossip file that the older version cannot read. It is a correctness fix, not an exploitable security vulnerability.

This commit improves a developer-only diagnostic tool (dump-gossipstore) so it prints the channel or node identifier alongside raw gossip messages. It is not a security fix and does not change any network-facing or wallet code. The only functional change is richer debug output.

This commit adds new internal plumbing for a future 'gossip store compaction' feature in Core Lightning. It introduces a helper sub-daemon called lightning_gossip_compactd and functions to reopen the gossip store, but the commit message explicitly says this code is 'not called anywhere yet.' There is no immediate security issue visible in the diff, but it is a partial foundation for a feature that will later rewrite a persistent data file and spawn an external helper process.

This change stops Core Lightning's gossip daemon from automatically 'compacting' (cleaning up and rewriting) its gossip store file every time the node starts. Instead, it only rewrites the file when an actual version upgrade is needed. The main benefit is faster startup. The patch also tightens error handling when creating a fresh store file. There is no direct evidence in the commit that this fixes a known security vulnerability; it reads primarily as a performance and robustness improvement.

This commit removes dead code in the Lightning node's gossip subsystem. During startup compaction of the gossip database, the code used to collect a list of 'dying channels' but never actually used that list. The change simply stops collecting that unused list. There is no obvious security problem being fixed here; it appears to be a minor cleanup that may also avoid a small memory waste or confusion during startup.

This commit changes how Core Lightning stores and tracks its internal gossip data file. It adds a unique identifier (UUID) to the front of the gossip store and includes that UUID in a 'store ended' marker so the node can tell when the file has been rewritten. The change is a normal data-format update, not a fix for an active security bug. There is one placeholder note in the code saying 'FIXME: real uuid!' which means the UUID is currently all zeros, but that is a completeness issue rather than an exploitable flaw.

This commit simply moves a file that defines internal message formats from one directory to another and updates all the references. It is a code reorganization (refactoring) with no functional change to the program's behavior and no security relevance.

This commit adds a test that reproduces a crash in Core Lightning's gossip daemon. The crash happens when the network's gossip store is compacted while a channel is in a 'dying' state (closing but not yet fully removed). The bug caused internal record offsets to become wrong, leading to a fatal read error and daemon crash. The commit message says the underlying handling was already fixed; this change only adds the regression test.

This is a small internal refactoring change in Core Lightning's gossip subsystem. It changes how 'dying' channel entries are loaded from the gossip store, switching from one temporary array to a callback that populates a persistent list. There is no indication this fixes a security bug or introduces a vulnerability; it appears to be code cleanup.

This patch fixes a bug in Core Lightning's gossip daemon where, after compacting the network graph store, the list of 'dying' channels was not reset and the code that repopulates it was not hooked up. This could cause the node to lose track of channels that are being closed, potentially leading to incorrect routing decisions or stale channel state. The fix clears the old list and provides a callback so dying channels are reloaded from the newly compacted store.

This commit changes a developer-only test tool so the fake channel IDs it creates are less predictable. The goal is to speed up test startup and prevent CI timeouts, not to fix a security bug. No production code is affected.

This commit is a small internal code cleanup. It moves a private data structure for reading gossip message headers from a source file into a shared header file so other parts of the program can reuse it. It also updates an outdated comment. There is no security-relevant change.

This is a small internal code cleanup in the part of Core Lightning that saves network gossip messages to disk. It moves a bookkeeping array (used to recover from rare filesystem sync problems) from one internal structure into another, so the module that actually writes to disk also owns the recovery data. There is no user-facing change, no new feature, and no obvious security vulnerability introduced or fixed by this patch.

This commit speeds up how Core Lightning loads its network map by replacing a strong hash function with a cheaper, simpler one. The change is framed as a performance optimization. The new hash for node IDs is weaker and uses a random byte offset, which could in theory allow a specially crafted node ID to collide with another in the hash table. However, the commit message argues that creating such collisions is expensive because it requires opening real Lightning channels. There is no direct evidence in the commit or supplied references that this is exploitable as a security bug.

This commit adds internal bookkeeping counters that track how many gossip records are currently active versus how many have been deleted in Core Lightning's network map. It does not change any security behavior, fix a bug, or alter how data is validated. It simply provides statistics so that a future compaction routine can decide when to clean up the map.

This change makes the Lightning node's gossip database automatically shrink itself when it becomes bloated with old, deleted records. It also fixes a small bug where the wrong file descriptor was being closed during that cleanup process. There is no direct evidence this is a security fix, but uncontrolled file growth and incorrect descriptor handling can contribute to reliability or minor resource problems.

This commit adds a new unique identifier (UUID) record to the gossip store file when the lightning node starts up or compacts its gossip database. The UUID is random and is intended to help identify different versions of the gossip store. The change is internal bookkeeping and does not fix or introduce any known security issue.

This commit adds a new internal callback mechanism so the gossipd component can be notified when the network graph sees a 'dying channel' message. It is a code cleanup/refactoring change: previously gossipd had to scan the entire gossip store at startup to find these messages, now it can receive them through a callback. There is no indication this fixes a security bug or introduces a vulnerability.

This commit fixes a bug in Core Lightning's gossip store compaction code. The bug caused the program to crash with a 'bad version' assertion when starting up with an empty or freshly-created gossip store file. The fix changes an internal length variable from 0 to 1 so the version header is written correctly. The commit also updates related tests, including one that now checks the program handles a corrupted gossip store gracefully rather than crashing.

This is a developer tool change that updates an internal file-format version number and adds a required header record so compressed gossip files match the format Core Lightning expects. It avoids a startup-time conversion step and has no apparent security relevance.

This commit adds a new helper program that compacts the Lightning node's gossip store file by copying it without deleted records. It is a normal maintenance/performance feature. There is no clear security bug in the code shown, but the program reads and writes binary gossip files and trusts command-line arguments, so it follows a path that could be sensitive to malformed input.