Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
36/100 average clarity
10Strong · 80–100
45Adequate · 60–79
195Thin · 40–59
218Opaque · 0–39
42security candidates with opaque commit messaging
This commit tightens how COLDCARD reads PSBTv2 (Partially Signed Bitcoin Transaction version 2) files. It now rejects several malformed or ambiguous encodings that could previously be accepted: extra key data attached to fields that should…
PSBT parser hardeningrejection of non-canonical compact-size encodingsenforcement of singleton key-data emptiness
This commit adds support in the COLDCARD firmware for a newer Bitcoin transaction format feature (PSBTv2) that lets each input specify its own required lock time. Before this change, the device did not correctly compute the final transacti…
PSBTv2 per-input locktime parsing and validation addedBIP-370 required locktime computation implementedIncompatible height/time locktime requirements rejected with assertion
This commit only adds a new automated test to the COLDCARD firmware test suite. The test checks that when a user tries to sign a text file containing valid JSON that is not a JSON object (for example, a plain number, string, null, or list)…
Regression test for input validation of JSON message-signingTest comment explicitly references avoiding a device crash on malformed JSON inputTest requested during review of pull request #808, suggesting prior related code change
This commit is a defensive hygiene fix in the COLDCARD hardware wallet's 'trick PIN' duress-wallet feature. It moves a memory-wipe routine so that it runs before the device looks up the duress wallet slot. The change reduces the window in …
This firmware update fixes a cleanup issue in the COLDCARD wallet's transaction signing code. Before finalizing a new Bitcoin transaction, the device now clears out leftover 'change output' records that may have been captured during a prev…
State not reset between signing attemptsStale change-output metadata reused in transaction finalizationOVC (Output Value Check) validation may be affected by leftover data
This commit removes a human-readable error message from a ValueError exception to reduce the amount of flash storage used by the firmware. It is a minor code cleanup and does not change the security behavior of the code. The function still…
This commit only adds a changelog note saying a previous fix stopped the COLDCARD hardware wallet from crashing when a message-signing request was valid JSON but not a JSON object (for example, a number or string instead of a dictionary). …
Device crash on malformed message-signing inputInput vector includes NFC, QR, and SD card JSON filesValid JSON but wrong type (non-object) bypasses simple format checks
This commit fixes a bug where the COLDCARD firmware's message-signing feature would crash with an uncaught error if a user supplied valid JSON that wasn't a structured object (for example, a plain number, string, list, or null). The fix ch…
uncaught exception in message parsing pathinput validation gap on JSON typepotential denial-of-service via malformed request
This commit only updates the release signature file (signatures.txt) for the COLDCARD firmware. It adds two new file hashes for a v5.6.2-mk release and refreshes the PGP signature covering the file. There are no code changes, no bug fixes,…
This commit only updates a release signature file. It refreshes SHA-256 hashes for changelog files and adds hashes for two new firmware release files, then re-signs the file with a PGP signature. There are no code changes, no bug fixes, an…
This commit simply updates a stored Bitcoin blockchain height number from 965,337 to 965,338. It is a routine, automatically generated data refresh with no code logic changes and no apparent security relevance.
This commit only edits the project's internal release notes file. It replaces a detailed list of upcoming changes with placeholder 'tbd' entries and adds a note asking contributors to leave blank lines between additions. There are no code …
This commit is a release-notes-only update for the COLDCARD hardware wallet firmware. It moves many security-relevant bug fixes and hardening items from the current changelog into the historical release notes for versions 5.6.1 and 1.5.1Q,…
USB protocol encryption upgrade (ncry v3) with direction-separated keys and replay protectionPSBT tampering detection: re-verify staged bytes before signing after Virtual Disk overwriteFirmware update integrity: abort if staged image overwritten, reject images extending past world-checksum region
This commit simply updates a stored Bitcoin blockchain height number from 963,314 to 965,337, along with its timestamp. It is an automatic, routine data refresh with no code logic changes and no apparent security relevance.
This commit fixes a bug in the COLDCARD firmware upgrade process. Previously, if someone tampered with the staged firmware after the user saw the approval prompt but before they confirmed, the device would crash with a bare internal error …
Tamper-detection failure path hardened: assert replaced with user-facing failure storyDefense-in-depth assertion added to PIN-changing flowTest coverage added for tamper-abort message
This commit only updates a linked external code library (a Git submodule called ckcc-protocol) to a newer version. The actual code changes inside that library are not shown in the commit diff, and no security-related information was provid…
This commit only edits the draft release changelog file. It rewords two upcoming feature descriptions and fixes line wrapping for another entry. No source code, firmware logic, or security behavior was changed.
This update fixes a bug where COLDCARD wallets would accept BIP-39 passphrases containing non-ASCII characters (like accented letters or emojis) or non-printable characters. Because different wallet software normalizes such characters diff…
Behavioral fix that prevents silent derivation of incompatible wallet seedsInput validation added for BIP-39 passphrase across USB, UI, saved-passphrase restore, and note/password lanesRejection of non-printable ASCII and non-ASCII Unicode characters
This commit fixes two related security bugs in the COLDCARD hardware wallet's protection against a known 'BIP-143 amount swap' attack. First, the wallet was recording the claimed amount of a segwit input to its secure cache as soon as a tr…
Fixes deferred persistence of UTXO amount cache until after successful signingFixes missing capture of single-sig segwit change outputs (p2wpkh and p2sh-p2wpkh)Prevents cache poisoning by cancelled/malicious PSBT previews
This update fixes a bug in how the COLDCARD wallet reads PSBT files (the standard format for passing Bitcoin transactions between devices). Previously, if a PSBT contained the same special 'singleton' key twice in the same section, the dev…
PSBT parser now rejects duplicate singleton keysNew test cases for duplicate keys in global/input/output mapsChangelog labels the change as a bugfix
✓ Subject identifies a change! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
signing boundarydefensive validationsigning or wallet path
AI analysis · Moderate 59/100
This commit tightens how COLDCARD reads PSBTv2 (Partially Signed Bitcoin Transaction version 2) files. It now rejects several malformed or ambiguous encodings that could previously be accepted: extra key data attached to fields that should have none, badly encoded input/output counts, and PSBTv2 files that are missing the required global version field. These are defensive hardening fixes rather than a single obvious exploit, but they close paths where a malicious or malformed PSBT could confuse the wallet's transaction parser.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 34/100
This commit adds support in the COLDCARD firmware for a newer Bitcoin transaction format feature (PSBTv2) that lets each input specify its own required lock time. Before this change, the device did not correctly compute the final transaction lock time from these per-input requirements, which could cause it to sign transactions with the wrong lock time or reject valid ones. The patch implements the BIP-370 rule: if any input requires a lock time, the transaction's final lock time must be the most restrictive (maximum) of those requirements, overriding any fallback. This is a correctness/feature fix rather than a remote exploit, but incorrect lock-time handling could in theory let a malicious co-signer or wallet software trick a user into signing a transaction that becomes spendable earlier or later than expected.
AI review queuedAdd regression test for non-object JSON message-sign inputby copilot-swe-agent[bot] · adb7baa8 · Sep 5, 2026 · 1 fileMessage 91 · StrongLow 46Details
Commit message · copilot-swe-agent[bot]
Add regression test for non-object JSON message-sign input
Test requested in review on Coldcard/firmware#808: valid JSON that is not an object (or lacks the "msg" key) must produce a clean failure story, never a device crash.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencesecond-pass: broader security terminology
AI analysis · Low 46/100
This commit only adds a new automated test to the COLDCARD firmware test suite. The test checks that when a user tries to sign a text file containing valid JSON that is not a JSON object (for example, a plain number, string, null, or list), or a JSON object missing the required 'msg' key, the device shows a clean error message instead of crashing. The commit itself does not change any firmware code, so it does not fix or introduce a vulnerability directly. It is a regression test requested during review of an earlier change, likely to make sure a previous fix stays effective.
hygiene: duress wallet activate - wipe before getting slot data
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
access controlauthentication path
AI analysis · Moderate 56/100
This commit is a defensive hygiene fix in the COLDCARD hardware wallet's 'trick PIN' duress-wallet feature. It moves a memory-wipe routine so that it runs before the device looks up the duress wallet slot. The change reduces the window in which sensitive wallet data could remain in memory if the device is in Delta Mode (a limited, coerced-access mode). There is no direct evidence in the commit that an actual leak was exploited; it reads as a precautionary hardening change.
AI review queuedOVC clear stale outputs from new_outputsby scgbckbone · 62163ccd · Sep 4, 2026 · 1 fileMessage 45 · ThinLow 41Details
Commit message · scgbckbone
OVC clear stale outputs from new_outputs
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 41/100
This firmware update fixes a cleanup issue in the COLDCARD wallet's transaction signing code. Before finalizing a new Bitcoin transaction, the device now clears out leftover 'change output' records that may have been captured during a previous signing attempt that failed or was aborted. If stale records remained, they could potentially confuse the wallet's checks about where money is going, which in rare cases might affect user-facing warnings or transaction validation.
AI review queuedDrop ValueError message string to save flash spaceby copilot-swe-agent[bot] · dc89513c · Sep 3, 2026 · 1 fileMessage 65 · AdequateInformational 15Details
Commit message · copilot-swe-agent[bot]
Drop ValueError message string to save flash space
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit removes a human-readable error message from a ValueError exception to reduce the amount of flash storage used by the firmware. It is a minor code cleanup and does not change the security behavior of the code. The function still raises an exception when invalid JSON input is provided; only the descriptive text is dropped.
This commit only adds a changelog note saying a previous fix stopped the COLDCARD hardware wallet from crashing when a message-signing request was valid JSON but not a JSON object (for example, a number or string instead of a dictionary). The actual code fix is not shown here, so we can only judge the issue from the changelog description. It appears to be a denial-of-service-style crash affecting message signing over NFC, QR, or SD card JSON files.
AI review queuedFix uncaught AttributeError on non-object JSON in parse_msg_sign_requestby copilot-swe-agent[bot] · d55ddbce · Sep 3, 2026 · 1 fileMessage 65 · AdequateInformational 23Details
Commit message · copilot-swe-agent[bot]
Fix uncaught AttributeError on non-object JSON in parse_msg_sign_request
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 23/100
This commit fixes a bug where the COLDCARD firmware's message-signing feature would crash with an uncaught error if a user supplied valid JSON that wasn't a structured object (for example, a plain number, string, list, or null). The fix checks the parsed JSON type and raises a proper, handled error instead of letting an AttributeError propagate. There is no direct evidence in the commit that this is exploitable for security harm, but unhandled exceptions can sometimes cause unexpected device behavior or denial of service.
AI review queuedSigned for mk release.by Peter D. Gray · e6d01c36 · Sep 3, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Peter D. Gray
Signed for mk release.
28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
signing or wallet pathdocumentation-only discountsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only updates the release signature file (signatures.txt) for the COLDCARD firmware. It adds two new file hashes for a v5.6.2-mk release and refreshes the PGP signature covering the file. There are no code changes, no bug fixes, and no security-relevant modifications visible in the diff.
AI review queuedSigned for q1 release.by Peter D. Gray · a310e1dd · Sep 3, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Peter D. Gray
Signed for q1 release.
28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
signing or wallet pathdocumentation-only discountsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only updates a release signature file. It refreshes SHA-256 hashes for changelog files and adds hashes for two new firmware release files, then re-signs the file with a PGP signature. There are no code changes, no bug fixes, and no security-relevant content in the diff itself.
AI review queuedupdate block heightby Peter D. Gray · 3caf599e · Sep 3, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Peter D. Gray
update block height
28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100
This commit simply updates a stored Bitcoin blockchain height number from 965,337 to 965,338. It is a routine, automatically generated data refresh with no code logic changes and no apparent security relevance.
AI review queuednew policy w blank linesby Peter D. Gray · 3d8f90f1 · Sep 3, 2026 · 1 fileMessage 38 · OpaqueInformational 15Details
Commit message · Peter D. Gray
new policy w blank lines
38/100 · OpaqueMessage clarity
✓ Subject identifies a change✓ Names a concrete action or component! No meaningful explanatory body
This commit only edits the project's internal release notes file. It replaces a detailed list of upcoming changes with placeholder 'tbd' entries and adds a note asking contributors to leave blank lines between additions. There are no code changes and no security relevance in the commit itself.
AI review queuedupdate for new releaseby Peter D. Gray · ea2b89bf · Sep 3, 2026 · 4 filesMessage 28 · OpaqueModerate 58Details
Commit message · Peter D. Gray
update for new release
28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
This commit is a release-notes-only update for the COLDCARD hardware wallet firmware. It moves many security-relevant bug fixes and hardening items from the current changelog into the historical release notes for versions 5.6.1 and 1.5.1Q, and adds a new set of notes for versions 5.6.2 and 1.5.2Q. The actual code changes are not present in the diff, only descriptions of them. The described issues include USB data leaks, PSBT tampering, firmware-update bypasses, virtual-disk file parsing flaws, and duress-wallet exposure in Delta Mode. Because we cannot see the patches themselves, we can only assess the claimed severity, not verify the fixes.
AI review queuedupdate block heightby Peter D. Gray · 15deb2f6 · Sep 3, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Peter D. Gray
update block height
28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100
This commit simply updates a stored Bitcoin blockchain height number from 963,314 to 965,337, along with its timestamp. It is an automatic, routine data refresh with no code logic changes and no apparent security relevance.
bugfix: report staged firmware modification at upgrade approval
- FirmwareUpgradeRequest: fail with "Firmware modified" story instead of bare assert when PSRAM write counter moved after staging - main_pin_changer: assert no temporary wallet is active (menu already hides the item; defense in depth) - test_upgrades: assert tamper abort shows the failure message - test_ccc: drop stale CCCFeature.last_fail_reason resets
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
authentication path
AI analysis · Moderate 59/100
This commit fixes a bug in the COLDCARD firmware upgrade process. Previously, if someone tampered with the staged firmware after the user saw the approval prompt but before they confirmed, the device would crash with a bare internal error (assert). Now it cleanly aborts and tells the user 'Firmware modified'. The commit also adds a small extra safety check in the main PIN change flow to ensure no temporary wallet is active, and updates tests accordingly.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
parser or protocol pathsecond-pass: security-sensitive path
AI analysis · Informational 2/100
This commit only updates a linked external code library (a Git submodule called ckcc-protocol) to a newer version. The actual code changes inside that library are not shown in the commit diff, and no security-related information was provided by the project or any verified source. On its own, this single-line submodule bump tells us nothing about whether a security issue was fixed or introduced.
AI review queuedtweaksby Peter D. Gray · e166ffdd · Sep 2, 2026 · 1 fileMessage 0 · OpaqueInformational 15Details
Commit message · Peter D. Gray
tweaks
0/100 · OpaqueMessage clarity
! Very short subject! Too few words to establish purpose! No meaningful explanatory body
This commit only edits the draft release changelog file. It rewords two upcoming feature descriptions and fixes line wrapping for another entry. No source code, firmware logic, or security behavior was changed.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
access controlcryptography-sensitive pathseed or entropy path
AI analysis · Moderate 62/100
This update fixes a bug where COLDCARD wallets would accept BIP-39 passphrases containing non-ASCII characters (like accented letters or emojis) or non-printable characters. Because different wallet software normalizes such characters differently, the same passphrase could silently produce a different wallet address on COLDCARD than on another app. The fix now rejects those passphrases outright, preventing users from accidentally creating funds they later cannot access or reconcile with other wallets.
bugfix: capture single-sig segwit change bugfix: defer OVC persistence until signing enhancement: improve OVC implementation and size 30 -> 128
60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing boundarycryptography-sensitive pathsigning or wallet pathauthentication path
AI analysis · High 74/100
This commit fixes two related security bugs in the COLDCARD hardware wallet's protection against a known 'BIP-143 amount swap' attack. First, the wallet was recording the claimed amount of a segwit input to its secure cache as soon as a transaction was previewed, even if the user later cancelled without signing. A malicious co-signer could therefore 'poison' the cache with a wrong amount and later prevent the owner from spending that coin. Second, single-signature segwit change outputs created by transactions the user signed were not being added to the cache, so an attacker could later trick the wallet into signing a spend that understated the change amount. The patch defers cache writes until after a signature is actually produced, and captures single-sig segwit change amounts at finalize time. It also expands the cache size from 30 to 128 entries.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Moderate 66/100
This update fixes a bug in how the COLDCARD wallet reads PSBT files (the standard format for passing Bitcoin transactions between devices). Previously, if a PSBT contained the same special 'singleton' key twice in the same section, the device might silently use the second value. Now it immediately rejects the file. Duplicate singleton keys could let a malicious transaction tool trick the wallet into using one value while a human reviewer sees another, potentially causing the wrong amount or destination to be signed.
AI review queuedadd commentby Peter D. Gray · b2a47fc9 · Sep 1, 2026 · 1 fileMessage 0 · OpaqueInformational 15Details
Commit message · Peter D. Gray
add comment
0/100 · OpaqueMessage clarity
! Very short subject! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only adds a plain-language comment ('# 10 years') next to an existing constant that sets how far in the future a transaction's locktime can be. No code behavior changed.
In Delta Mode, the Trick PINs menu allowed a coercer to (a) press (6) to read a duress wallet's full seed words / XPRV off screen, and (b) Activate Wallet to load the duress secret as the active temporary seed -- all without a wipe. Every other secret-revealing flow calls wipe_if_deltamode(); these two paths were missed. The master seed itself is safe (hardened derivation), but the duress wallet's funds and the user's deniability were exposed.
Keep menu browsing working (Delta Mode should look like normal operation), but call wipe_if_deltamode() before the (6) viewer reads the slot and before Activate Wallet applies the secret.
Add test_deltamode_duress_secret_view_wipes: browsing the menu works in delta mode, but viewing the duress secret and activating the wallet each trigger a wipe. Verified to fail pre-patch (no wipe) and pass with the fix.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
This commit fixes a security bug in the COLDCARD hardware wallet's 'Delta Mode' duress feature. Delta Mode is designed to make the device look normal while silently protecting secrets. Previously, a coercer could force someone to open the Trick PINs menu and either view the full seed words of a duress wallet, or activate that wallet, without triggering a wipe. This exposed the duress wallet's funds and weakened the user's deniability. The fix makes both actions trigger a secure wipe when in Delta Mode, matching how other secret-revealing flows already behaved. Browsing the menu still works so Delta Mode remains plausible.
The `bad txn version` check (`txn_version in {0,1,2,3}`) lives in parse_txn(), which only runs for PSBTv0. On the PSBTv2 path read_psbt() skips parse_txn(), so PSBT_GLOBAL_TX_VERSION was used unvalidated: a v2 PSBT with nVersion 4 (or a negative value) could be approved and signed, producing a transaction the network will not relay.
validate() already enforces PoR-specific versions (0 only for BIP-322, {0,2} for PoR txns) but had no upper bound for ordinary transactions. Add the matching non-PoR bound (txn_version in {1,2,3}) so both v0 and v2 reject out-of-range versions while the BIP-322 PoR path is unchanged.
Add test_psbt_v2_bad_txn_version (versions 4, -1, 100 rejected on v2). Verified to fail pre-patch (v2 reaches 'OK TO SEND?') and pass with the fix; full test_bip322.py suite still passes.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
secret or key materialsigning boundarydefensive validationsigning or wallet path
AI analysis · Moderate 64/100
This fix closes a gap where COLDCARD would approve and sign a Bitcoin transaction with an invalid version number if the transaction was packaged in the newer PSBTv2 format. For PSBTv0, such bad versions were already rejected, but the PSBTv2 code path skipped that check. The result could be a signed transaction that the Bitcoin network refuses to relay, potentially trapping funds or breaking wallet workflows. The patch adds the same version-number sanity check to the shared validation routine so both PSBT versions are protected.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 29/100
This change adds a warning when a Bitcoin transaction's locktime is set to a block height more than 10 years in the future. It does not block the transaction but alerts the user, helping catch potential tricks where a transaction is made unspendable for a very long time without the user noticing.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathauthentication path
AI analysis · Moderate 58/100
This commit simplifies how the COLDCARD firmware tracks writes to its external PSRAM memory chip. Previously, the firmware kept two separate counters: one for transaction (TXN) data and one for firmware upgrade images. The change merges them into a single counter that increments on any PSRAM write. The goal is to make it harder for an attacker to silently modify data after the user has reviewed it, by detecting any later write to PSRAM. It is a defensive hardening change rather than a fix for a known active attack, and the commit message does not describe a specific vulnerability.