AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
High 74 Bitcoin

Fix PSBT input classification and finalization

Public commit record

What the developer wrote

Authored by scgbckbone

45/100 · Thin
Fix PSBT input classification and finalization
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
The short version

What changed, and why it matters

This commit fixes bugs in how the COLDCARD hardware wallet classifies and finalizes Bitcoin transaction inputs from PSBT files. Before the fix, the device could incorrectly treat foreign or already-signed inputs as complete, producing an invalid ready-to-broadcast transaction instead of returning a still-partial PSBT. The patch separates input analysis from key selection, validates scripts against known wallets before finalizing, and refuses to finalize inputs whose signatures or scripts cannot be verified. The changelog explicitly calls these security-relevant bugfixes and credits an external reporter.

Recommended action

Treat this as a security fix and ensure affected firmware versions are upgraded. Wallets or services that build PSBTs for COLDCARD should verify that partially signed PSBTs are returned when any input cannot be safely finalized, and should not rely on previous firmware behavior that could emit invalid finalized transactions.

Security signals we found

01

Changelog labels the changes as 'Bugfix' and credits 'Nabeel-javed' for one of them

02

Separation of input classification from signing-key selection reduces risk of misclassifying foreign/presigned inputs

03

New script_validated flag prevents finalization of inputs whose scripts/signatures were not verified

04

Multisig finalization now checks signature membership against the validated script's pubkey order and threshold

05

Presigned inputs from another wallet are no longer finalized using the active wallet

06

Foreign single-sig inputs must have a signature that matches the committed pubkey/hash

07

Tests assert that malformed or unverifiable inputs cause 'PSBT output failed' instead of producing a broadcastable transaction

Risk score

Why this scored 74/100

Our methodology →
Potential impact 24/30
Exploitability 16/25
Stealth signal 10/15
Affected reach 12/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.